- gerrit-log - lists.osmocom.org

[S] Change in osmo-ccid-firmware[master]: ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error
by pespin 20 Feb '26

20 Feb '26

Attention is currently required from: Hoernchen. pespin has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email ) Change subject: ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I67d5cb876d20b29f4759d5b194606f34b8b966c4 Gerrit-Change-Number: 42157 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Feb 2026 10:29:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: 5gc: Split f_start_handler_with_pars() into multiple helpers
by pespin 20 Feb '26

20 Feb '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42153?usp=email to look at the new patch set (#2). Change subject: 5gc: Split f_start_handler_with_pars() into multiple helpers ...................................................................... 5gc: Split f_start_handler_with_pars() into multiple helpers This allows initializing multiple ConnHldr and then connecting them and starting them later. This is similar to what is is done eg. in MSC_Tests. Change-Id: Ic60009c5f7fcdc43f6e13f9ea469bfaddc639c33 --- M 5gc/C5G_Tests.ttcn 1 file changed, 20 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/53/42153/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42153?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic60009c5f7fcdc43f6e13f9ea469bfaddc639c33 Gerrit-Change-Number: 42153 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[S] Change in osmo-ccid-firmware[master]: ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error
by Hoernchen 20 Feb '26

20 Feb '26

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email ) Change subject: ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error ...................................................................... ccid: fix rdr_to_pc_parameters and rdr_to_pc_hardware_error Change-Id: I67d5cb876d20b29f4759d5b194606f34b8b966c4 --- M ccid_common/ccid_device.c M ccid_common/ccid_proto.h 2 files changed, 11 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/57/42157/1 diff --git a/ccid_common/ccid_device.c b/ccid_common/ccid_device.c index acee696..b136cd0 100644 --- a/ccid_common/ccid_device.c +++ b/ccid_common/ccid_device.c @@ -264,11 +264,12 @@ const struct ccid_pars_decoded *dec_par) { struct msgb *msg = ccid_msgb_alloc(); - struct ccid_rdr_to_pc_parameters *par = - (struct ccid_rdr_to_pc_parameters *) msgb_put(msg, sizeof(par->hdr)+sizeof(par->abProtocolData.t0)); + struct ccid_rdr_to_pc_parameters *par = (struct ccid_rdr_to_pc_parameters *)msgb_put( + msg, sizeof(par->hdr) + sizeof(par->bProtocolNum) + sizeof(par->abProtocolData.t0)); uint8_t sts = (cmd_sts & CCID_CMD_STATUS_MASK) | icc_status; SET_HDR_IN(par, RDR_to_PC_Parameters, slot_nr, seq, sts, err); + par->bProtocolNum = CCID_PROTOCOL_NUM_T0; if (dec_par) { osmo_store32le(sizeof(par->abProtocolData.t0), &par->hdr.hdr.dwLength); encode_ccid_pars_t0(&par->abProtocolData.t0, dec_par); @@ -286,11 +287,12 @@ const struct ccid_pars_decoded *dec_par) { struct msgb *msg = ccid_msgb_alloc(); - struct ccid_rdr_to_pc_parameters *par = - (struct ccid_rdr_to_pc_parameters *) msgb_put(msg, sizeof(par->hdr)+sizeof(par->abProtocolData.t1)); + struct ccid_rdr_to_pc_parameters *par = (struct ccid_rdr_to_pc_parameters *)msgb_put( + msg, sizeof(par->hdr) + sizeof(par->bProtocolNum) + sizeof(par->abProtocolData.t1)); uint8_t sts = (cmd_sts & CCID_CMD_STATUS_MASK) | icc_status; SET_HDR_IN(par, RDR_to_PC_Parameters, slot_nr, seq, sts, err); + par->bProtocolNum = CCID_PROTOCOL_NUM_T1; if (dec_par) { osmo_store32le(sizeof(par->abProtocolData.t1), &par->hdr.hdr.dwLength); encode_ccid_pars_t1(&par->abProtocolData.t1, dec_par); diff --git a/ccid_common/ccid_proto.h b/ccid_common/ccid_proto.h index e26a051..19f1333 100644 --- a/ccid_common/ccid_proto.h +++ b/ccid_common/ccid_proto.h @@ -333,6 +333,7 @@ /* Section 6.2.3 RDR_to_PC_Parameters */ struct ccid_rdr_to_pc_parameters { struct ccid_header_in hdr; + uint8_t bProtocolNum; union { struct ccid_proto_data_t0 t0; struct ccid_proto_data_t1 t1; @@ -401,9 +402,11 @@ uint8_t bmSlotCCState[0]; /* as long as bNumSlots/4 padded to next byte */ } __attribute__ ((packed)); -/* Section 6.3.1 */ +/* Section 6.3.2 - Interrupt IN message (4 bytes, NOT bulk header format) */ struct ccid_rdr_to_pc_hardware_error { - struct ccid_header hdr; + uint8_t bMessageType; /* 0x51 */ + uint8_t bSlot; + uint8_t bSeq; uint8_t bHardwareErrorCode; } __attribute__ ((packed)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I67d5cb876d20b29f4759d5b194606f34b8b966c4 Gerrit-Change-Number: 42157 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: tcap: vty: Fix writing tcap-routing command
by pespin 20 Feb '26

20 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42156?usp=email ) Change subject: tcap: vty: Fix writing tcap-routing command ...................................................................... tcap: vty: Fix writing tcap-routing command Change-Id: I36d23c0e330c224b69094fb861520c4a4a32b3d8 --- M src/ss7_as_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/ss7_as_vty.c b/src/ss7_as_vty.c index 2f59c3d..d9fd58d 100644 --- a/src/ss7_as_vty.c +++ b/src/ss7_as_vty.c @@ -506,7 +506,7 @@ } #ifdef WITH_TCAP_LOADSHARING if (as->cfg.loadshare.tcap.enabled) - vty_out(vty, "tcap-routing"); + vty_out(vty, " tcap-routing%s", VTY_NEWLINE); #endif /* WITH_TCAP_LOADSHARING */ if (as->cfg.recovery_timeout_msec != 2000) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I36d23c0e330c224b69094fb861520c4a4a32b3d8 Gerrit-Change-Number: 42156 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: tcap: vty: Fix writing tcap-routing command
by pespin 20 Feb '26

20 Feb '26

Attention is currently required from: daniel, fixeria, lynxis lazus, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42156?usp=email ) Change subject: tcap: vty: Fix writing tcap-routing command ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Merging since the problem and fix is obvious. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I36d23c0e330c224b69094fb861520c4a4a32b3d8 Gerrit-Change-Number: 42156 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 20 Feb 2026 10:02:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: tcap: vty: Fix writing tcap-routing command
by pespin 20 Feb '26

20 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42156?usp=email ) Change subject: tcap: vty: Fix writing tcap-routing command ...................................................................... tcap: vty: Fix writing tcap-routing command Change-Id: I36d23c0e330c224b69094fb861520c4a4a32b3d8 --- M src/ss7_as_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/56/42156/1 diff --git a/src/ss7_as_vty.c b/src/ss7_as_vty.c index 2f59c3d..d9fd58d 100644 --- a/src/ss7_as_vty.c +++ b/src/ss7_as_vty.c @@ -506,7 +506,7 @@ } #ifdef WITH_TCAP_LOADSHARING if (as->cfg.loadshare.tcap.enabled) - vty_out(vty, "tcap-routing"); + vty_out(vty, " tcap-routing%s", VTY_NEWLINE); #endif /* WITH_TCAP_LOADSHARING */ if (as->cfg.recovery_timeout_msec != 2000) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I36d23c0e330c224b69094fb861520c4a4a32b3d8 Gerrit-Change-Number: 42156 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-remsim[master]: rspro_server: fix releasing timed out clients
by pespin 20 Feb '26

20 Feb '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42133?usp=email ) Change subject: rspro_server: fix releasing timed out clients ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42133?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I1f7faf5ffdd909362c492ab434b63fa7e79ada95 Gerrit-Change-Number: 42133 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 20 Feb 2026 09:53:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: remsim: server: add a client timeout test
by pespin 20 Feb '26

20 Feb '26

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154?usp=email ) Change subject: remsim: server: add a client timeout test ...................................................................... Patch Set 2: (7 comments) File remsim/RemsimServer_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/9e4b9cfa_a714… : PS2, Line 183: testcase TC_connect_client_timeout_reconnect() runs on test_CT { TC_connect_client_ipa_ping_timeout_reconnect https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/da43f402_51d5… : PS2, Line 189: g_T_guard.start(180.0); These timings are way to high. Can't the IUT be changed to lower values over VTY? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/43a32437_36c9… : PS2, Line 197: mtc.stop; Misc_Helpers.f_shutdown() here and below. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/8eae6eea_a2a5… : PS2, Line 216: } these are usually indented one more level. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/f79d395f_854a… : PS2, Line 219: setverdict(fail, "Timed out. Server did not closed the connection."); did not close https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/c409b7a8_61fa… : PS2, Line 232: if (not match(js.clients[0], tr_JsClient(CONNECTED_CLIENT, rspro[1].rspro_id))) { Shouldn't this be rspro[0].rspro_id? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154/comment/aeefcd8c_a955… : PS2, Line 661: execute( TC_connect_client_timeout_reconnect() ); if it crashes, add a comment saying it crashes on version "<= N" and put it at the end. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42154?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iec52d3ce229c2ab84ab0ff9d8dbbff59b7f3fbd9 Gerrit-Change-Number: 42154 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 20 Feb 2026 09:45:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in pysim[master]: esim/http_json_api.py: support text/plain response Content-Type
by neels 20 Feb '26

20 Feb '26

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42155?usp=email ) Change subject: esim/http_json_api.py: support text/plain response Content-Type ...................................................................... esim/http_json_api.py: support text/plain response Content-Type Allow returning text/plain Content-Types as 'data' output argument. So far, all the esim/http_json_api functions require a JSON response. However, a specific vendor has a list function where the request is JSON but the response is text/plain CSV data. Allow and return in a dict. Change-Id: Iba6e4cef1048b376050a435a900c0f395655a790 --- M pySim/esim/http_json_api.py 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/55/42155/1 diff --git a/pySim/esim/http_json_api.py b/pySim/esim/http_json_api.py index cd95e0d..c268ce6 100644 --- a/pySim/esim/http_json_api.py +++ b/pySim/esim/http_json_api.py @@ -383,14 +383,18 @@ # SGP.22, section 6.5.1) if response.status_code != self.api_func.expected_http_status: raise HttpStatusError(response) - if response.content and not response.headers.get('Content-Type').startswith(req_headers['Content-Type']): - raise HttpHeaderError(response) if not response.headers.get('X-Admin-Protocol', 'gsma/rsp/v2.unknown').startswith('gsma/rsp/v2.'): raise HttpHeaderError(response) # Decode response and return the result back to the caller if response.content: - output = self.api_func.decode_client(response.json()) + if response.headers.get('Content-Type').startswith('application/json'): + output = self.api_func.decode_client(response.json()) + elif response.headers.get('Content-Type').startswith('text/plain;charset=UTF-8'): + output = { 'data': response.content.decode('utf-8') } + else: + raise HttpHeaderError(f'unimplemented response Content-Type: {response.headers=!r}') + # In case the response contains a header, check it to make sure that the API call was executed successfully # (the presence of the header field is checked by the decode_client method) if 'header' in output: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42155?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iba6e4cef1048b376050a435a900c0f395655a790 Gerrit-Change-Number: 42155 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[S] Change in osmo-remsim[master]: rspro_server: fix releasing timed out clients
by lynxis lazus 19 Feb '26

19 Feb '26

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/42133?usp=email ) Change subject: rspro_server: fix releasing timed out clients ...................................................................... Patch Set 2: (5 comments) Patchset: PS2: I've reworked the patch. File src/server/rspro_server.c: https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/ae4b2179_fb657093?… : PS1, Line 773: if (conn->peer) { > Hence why you must keep "conn->peer = NULL;" before in line 926. Done https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/5fb9be8a_7bca197e?… : PS1, Line 923: /* this will internally call closed_cb() which will dispatch a TCP_DOWN event */ > With your proposal you'll end up with a double free of the osmo_stream_srv afaict, from the parent t […] Done https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/28841391_c911cd26?… : PS1, Line 926: osmo_stream_srv_destroy(peer); > osmo_stream_srv_destroy(conn->peer) calls talloc_free(conn->peer), so it totally makes sense to do c […] Done https://gerrit.osmocom.org/c/osmo-remsim/+/42133/comment/70f5cfc9_f9ed5e41?… : PS1, Line 938: > if (conn->fi) { […] Re-ordered it. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/42133?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I1f7faf5ffdd909362c492ab434b63fa7e79ada95 Gerrit-Change-Number: 42133 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 19 Feb 2026 17:37:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

2026

2025

2024

2023

2022

gerrit-log