Attention is currently required from: dexter, fixeria, laforge.
Hello Jenkins Builder, dexter, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/40236?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Verified+1 by Jenkins Builder
Change subject: docs: Better python doc-strings for better pySim.esim manual
......................................................................
docs: Better python doc-strings for better pySim.esim manual
Change-Id: I7be6264c665a2a25105681bb5e72d0f6715bbef8
---
M pySim/esim/__init__.py
M pySim/esim/bsp.py
M pySim/esim/es8p.py
M pySim/esim/rsp.py
M pySim/esim/saip/__init__.py
M pySim/esim/saip/oid.py
M pySim/esim/saip/personalization.py
M pySim/esim/saip/templates.py
M pySim/esim/saip/validation.py
M pySim/esim/x509_cert.py
10 files changed, 87 insertions(+), 50 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/36/40236/2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40236?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7be6264c665a2a25105681bb5e72d0f6715bbef8
Gerrit-Change-Number: 40236
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40227?usp=email )
Change subject: contrib/jenkins: iterate over list of targets
......................................................................
contrib/jenkins: iterate over list of targets
Prepare to add code to upload each target's binary in the next patch.
Remove "set -x" to make the output more readable (the shell code is
simple, no need to be that verbose about it here).
Related: OS#6784
Change-Id: Ic106e298a1e6a4aa01e2c1d87b1d806f90f27b73
---
M CMakeLists.txt
M contrib/jenkins.sh
2 files changed, 14 insertions(+), 2 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/CMakeLists.txt b/CMakeLists.txt
index cb0f06f..94a9b6c 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -17,5 +17,6 @@
-Wno-maybe-uninitialized
)
+# When adding new subdirs, make sure to adjust TARGETS in contrib/jenkins.sh!
add_subdirectory(iso7816)
add_subdirectory(osmo-gtm900)
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index e24d71a..7f72e1b 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -1,7 +1,18 @@
-#!/bin/sh -ex
+#!/bin/sh -e
+TARGETS="
+ iso7816_cardem
+ osmo-gtm900
+"
rm -rf build
mkdir build
cd build
cmake ..
-make -j$(nproc)
+
+for i in $TARGETS; do
+ echo
+ echo "=== make $i ==="
+ echo
+
+ make -j$(nproc) "$i"
+done
--
To view, visit https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40227?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-rp2040-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ic106e298a1e6a4aa01e2c1d87b1d806f90f27b73
Gerrit-Change-Number: 40227
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: osmith.
fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40227?usp=email )
Change subject: contrib/jenkins: iterate over list of targets
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-rp2040-firmware/+/40227?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-rp2040-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ic106e298a1e6a4aa01e2c1d87b1d806f90f27b73
Gerrit-Change-Number: 40227
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 07 May 2025 08:42:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40229?usp=email )
Change subject: jobs/master: pass osmo-ci to docker
......................................................................
jobs/master: pass osmo-ci to docker
Let jobs such as the upcoming one for osmo-rp2040-firmware use the
known_hosts file from osmo-ci when uploading binaries. In other jobs
we've copied the known_hosts into the contrib/jenkins.sh file, but let's
try to have it in a central place at least for new jobs.
Related: OS#6784
Change-Id: If5257e7f5e3e2f9e09c52fa558a63e34c276b9a6
---
M jobs/master-builds.yml
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml
index 720c159..71ad3ac 100644
--- a/jobs/master-builds.yml
+++ b/jobs/master-builds.yml
@@ -42,6 +42,7 @@
-i \
-u build \
-v $(readlink -f $SSH_AUTH_SOCK):/ssh-agent \
+ -v "$HOME/osmo-ci:/osmo-ci:ro" \
-v "$PWD:/build" \
-v "$HOME/.ssh:/home/build/.ssh:ro" \
docker_run_ccache: |
@@ -68,6 +69,7 @@
-i \
-u build \
-v $(readlink -f $SSH_AUTH_SOCK):/ssh-agent \
+ -v "$HOME/osmo-ci:/osmo-ci:ro" \
-v "$PWD:/build" \
-v "$HOME/.ssh:/home/build/.ssh:ro" \
\
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40229?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: If5257e7f5e3e2f9e09c52fa558a63e34c276b9a6
Gerrit-Change-Number: 40229
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>