- gerrit-log - lists.osmocom.org

[S] Change in libosmo-netif[master]: stream: Improve error handling and logging in write_cb
by pespin 27 Feb '26

27 Feb '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email ) Change subject: stream: Improve error handling and logging in write_cb ...................................................................... Patch Set 2: (1 comment) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/42191/comment/94c91aea_84bd991… : PS2, Line 609: strerror_r(-res, errbuf, sizeof(errbuf)); > "The strerror_r() function is similar to strerror(), but is thread safe" Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I68468f0452cbc86b6210bbd1dbfa251579270adb Gerrit-Change-Number: 42191 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Feb 2026 14:27:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-netif[master]: stream: Improve error handling and logging in write_cb
by pespin 27 Feb '26

27 Feb '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email ) Change subject: stream: Improve error handling and logging in write_cb ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/42191/comment/c311814c_244e72d… : PS2, Line 609: strerror_r(-res, errbuf, sizeof(errbuf)); > Why do you use strerror_r instead of strerror here? "The strerror_r() function is similar to strerror(), but is thread safe" -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I68468f0452cbc86b6210bbd1dbfa251579270adb Gerrit-Change-Number: 42191 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Feb 2026 14:27:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: mgw: Improve failure message in f_TC_one_crcx_loopback_rtp()
by pespin 27 Feb '26

27 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42195?usp=email ) Change subject: mgw: Improve failure message in f_TC_one_crcx_loopback_rtp() ...................................................................... mgw: Improve failure message in f_TC_one_crcx_loopback_rtp() Change-Id: I51c656371c330e4689738321d0739e280cab530d --- M mgw/MGCP_Test.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn index 934179c..36cd94c 100644 --- a/mgw/MGCP_Test.ttcn +++ b/mgw/MGCP_Test.ttcn @@ -1935,10 +1935,10 @@ if (one_phase) { /* osmo-mgw knows both local and remote RTP address. Expect all packets to be reflected. */ if (stats.num_pkts_tx != stats.num_pkts_rx) { - setverdict(fail); + setverdict(fail, "stats.num_pkts_tx=", stats.num_pkts_tx, " != stats.num_pkts_rx=", stats.num_pkts_rx); } if (stats.bytes_payload_tx != stats.bytes_payload_rx) { - setverdict(fail); + setverdict(fail, "stats.bytes_payload_tx=", stats.bytes_payload_tx, " != stats.bytes_payload_rx=", stats.bytes_payload_rx); } } else { /* osmo-mgw knows only the local RTP address. Expect no packets to be reflected. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42195?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I51c656371c330e4689738321d0739e280cab530d Gerrit-Change-Number: 42195 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: stp: Enable tracking of NULL memory context
by pespin 27 Feb '26

27 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42213?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: stp: Enable tracking of NULL memory context ...................................................................... stp: Enable tracking of NULL memory context Similar to what's done in most of the OsmoCNI programs. This allows dumpinng the NULL context using VTY command 'show talloc-context all'. Change-Id: I4a925967e5bb61c346cf6c4dd2c89b6aaea44b94 --- M stp/stp_main.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/stp/stp_main.c b/stp/stp_main.c index fb5d202..4a1b59b 100644 --- a/stp/stp_main.c +++ b/stp/stp_main.c @@ -216,6 +216,9 @@ srand(time(NULL)); + /* Track the use of talloc NULL memory contexts */ + talloc_enable_null_tracking(); + tall_stp_ctx = talloc_named_const(NULL, 1, "osmo-stp"); msgb_talloc_ctx_init(tall_stp_ctx, 0); osmo_init_logging2(tall_stp_ctx, &log_info); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42213?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4a925967e5bb61c346cf6c4dd2c89b6aaea44b94 Gerrit-Change-Number: 42213 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: tcap: Fix wrong address type printed in log line
by pespin 27 Feb '26

27 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42214?usp=email ) Change subject: tcap: Fix wrong address type printed in log line ...................................................................... tcap: Fix wrong address type printed in log line Change-Id: I28b0d488159d9fa88e69e8c8b2e53a97b461763a --- M src/tcap_as_loadshare.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index f00347c..5a52f83 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -314,7 +314,7 @@ rc = sua_addr_parse(&calling_addr, sua, SUA_IEI_SRC_ADDR); if (rc < 0) { - LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP Destination Address\n"); + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP Source Address\n"); return -3; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42214?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I28b0d488159d9fa88e69e8c8b2e53a97b461763a Gerrit-Change-Number: 42214 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: tcap: Fix return code in tcap_as_rx_sccp_asp()
by pespin 27 Feb '26

27 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email ) Change subject: tcap: Fix return code in tcap_as_rx_sccp_asp() ...................................................................... tcap: Fix return code in tcap_as_rx_sccp_asp() That code path is not an error, simply the message is not TCAP. Take the chance to clarify the behavior of the function. Change-Id: I54c4a1bbaa8e107cf433cc898658a672c2b53c3c --- M src/tcap_as_loadshare.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 9c969d3..336692d 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -270,7 +270,7 @@ * @param opc M3UA opc * @param dpc M3UA DPC * @param sccp_msg pointer to a msg. - * @return 0 on successful handling, < 0 on error cases (missing IE, decoding errors) + * @return 0 on successful handling (TCAP fully processed, non-TCAP ignored), < 0 on error cases (missing IE, decoding errors) */ int tcap_as_rx_sccp_asp(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp, uint32_t opc, uint32_t dpc, struct msgb *sccp_msg) { @@ -286,7 +286,7 @@ /* TCAP uses only connectionless SCCP messages */ if (sua->hdr.msg_class != SUA_MSGC_CL && sua->hdr.msg_class != SUA_CL_CLDT) - return -2; + return 0; rc = sua_addr_parse(&calling_addr, sua, SUA_IEI_SRC_ADDR); if (rc < 0) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42210?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I54c4a1bbaa8e107cf433cc898658a672c2b53c3c Gerrit-Change-Number: 42210 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: tcap: Lower log level failing to parse msg
by pespin 27 Feb '26

27 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42211?usp=email ) Change subject: tcap: Lower log level failing to parse msg ...................................................................... tcap: Lower log level failing to parse msg invalid rx packets should be logged as NOTICED, not as ERROR. Change-Id: Idef5736ee2481260f958eece2f5a3bfc009b3d69 --- M src/tcap_as_loadshare.c 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 336692d..803dcd8 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -78,7 +78,7 @@ rc = osmo_asn1_tcap_decode(tcapmsg, data, len); if (rc < 0) { - LOGPAS(as, DLTCAP, LOGL_DEBUG, "Error decoding TCAP message rc: %d, message: %s\n", + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Error decoding TCAP message rc: %d, message: %s\n", rc, osmo_hexdump(data, len)); goto free_asn; } @@ -280,7 +280,7 @@ int rc; struct xua_msg *sua = osmo_sccp_to_xua(sccp_msg); if (!sua) { - LOGPAS(as, DLTCAP, LOGL_ERROR, "Unable to parse SCCP message\n"); + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP message\n"); return -1; } @@ -290,14 +290,14 @@ rc = sua_addr_parse(&calling_addr, sua, SUA_IEI_SRC_ADDR); if (rc < 0) { - LOGPAS(as, DLTCAP, LOGL_ERROR, "Unable to parse SCCP Destination Address\n"); + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP Destination Address\n"); return -3; } /* retrieve + decode destination address */ rc = sua_addr_parse(&called_addr, sua, SUA_IEI_DEST_ADDR); if (rc < 0) { - LOGPAS(as, DLTCAP, LOGL_ERROR, "Unable to parse SCCP Destination Address\n"); + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP Destination Address\n"); return -4; } @@ -325,7 +325,7 @@ rc = parse_tcap(as, ie_data->dat, ie_data->len, &parsed); if (rc <= 0) { - LOGPAS(as, DLTCAP, LOGL_ERROR, "Failed get TCAP otid/dtid.\n"); + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Failed get TCAP otid/dtid.\n"); return -7; } @@ -451,7 +451,7 @@ /* decode SCCP and convert to a SUA/xUA representation */ sua = osmo_sccp_to_xua(sccp_msg); if (!sua) { - LOGPAS(as, DLTCAP, LOGL_ERROR, "Unable to parse SCCP message\n"); + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP message\n"); rc = -EPROTONOSUPPORT; goto out_free_msgb; } @@ -465,13 +465,13 @@ rc = sua_addr_parse(&calling_addr, sua, SUA_IEI_SRC_ADDR); if (rc < 0) { - LOGPAS(as, DLTCAP, LOGL_ERROR, "Unable to parse SCCP Source Address\n"); + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP Source Address\n"); goto out_free_sua; } rc = sua_addr_parse(&called_addr, sua, SUA_IEI_DEST_ADDR); if (rc < 0) { - LOGPAS(as, DLTCAP, LOGL_ERROR, "Unable to parse SCCP Destination Address\n"); + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Unable to parse SCCP Destination Address\n"); goto out_free_sua; } @@ -505,7 +505,7 @@ if (rc <= 0) { rate_ctr_inc2(as->ctrg, SS7_AS_CTR_RX_TCAP_FAILED); - LOGPAS(as, DLTCAP, LOGL_ERROR, "Failed get TCAP otid/dtid.\n"); + LOGPAS(as, DLTCAP, LOGL_NOTICE, "Failed get TCAP otid/dtid.\n"); rc = -EINVAL; goto out_free_sua; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42211?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Idef5736ee2481260f958eece2f5a3bfc009b3d69 Gerrit-Change-Number: 42211 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: tcap: Support TID with length 1..4
by pespin 27 Feb '26

27 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email ) Change subject: tcap: Support TID with length 1..4 ...................................................................... tcap: Support TID with length 1..4 As described in ITU Q.773 4.2.1.3: "The length of a Transaction ID is 1 to 4 octets." asn.1 files also describe TIDs the following way: OrigTransactionID ::= [APPLICATION 8] IMPLICIT OCTET STRING (SIZE (1..4) ) DestTransactionID ::=[APPLICATION 9] IMPLICIT OCTET STRING (SIZE (1..4) ) Take the chance to avoid asserting based on received external input msg. Related: SYS#5423 Change-Id: I2748d85624e4be708f7554ee3e60a5bda9162845 --- M src/sccp2sua.c M src/ss7_internal.h M src/tcap_as_loadshare.c 3 files changed, 42 insertions(+), 19 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/sccp2sua.c b/src/sccp2sua.c index 87d9d05..9ca1d7a 100644 --- a/src/sccp2sua.c +++ b/src/sccp2sua.c @@ -35,8 +35,8 @@ #include <osmocom/sigtran/sccp_helpers.h> #include <osmocom/sigtran/protocol/sua.h> #include "xua_msg.h" - #include "xua_internal.h" +#include "ss7_internal.h" #include "sccp_internal.h" /* libosmocore candidates */ @@ -54,14 +54,6 @@ msgb_put_u8(msg, (val >> 8) & 0xff); } -/*! \brief load a 24bit value as big-endian */ -static uint32_t load_24be(const void *ptr) -{ - const uint8_t *data = ptr; - return (data[0] << 16) | (data[1] << 8) | data[2]; -} - - /*! \brief Parse ISUP style address of BCD digets * \param[out] out_digits user-allocated buffer for ASCII digits diff --git a/src/ss7_internal.h b/src/ss7_internal.h index b70954e..f93eb52 100644 --- a/src/ss7_internal.h +++ b/src/ss7_internal.h @@ -44,5 +44,12 @@ #define ss7_llist_round_robin(list, state, struct_type, entry_name) \ llist_entry(_ss7_llist_round_robin(list, state), struct_type, entry_name) +/*! \brief load a 24bit value as big-endian */ +static inline uint32_t load_24be(const void *ptr) +{ + const uint8_t *data = ptr; + return (data[0] << 16) | (data[1] << 8) | data[2]; +} + /* VTY */ #define XUA_VAR_STR "(sua|m3ua|ipa)" diff --git a/src/tcap_as_loadshare.c b/src/tcap_as_loadshare.c index 803dcd8..f00347c 100644 --- a/src/tcap_as_loadshare.c +++ b/src/tcap_as_loadshare.c @@ -1,4 +1,4 @@ -/* TCAP ID based ASP Load-Sharing */ +/* TCAP ID based ASP Load-Sharing, ITU-T Q.771-Q.775 */ /* (C) 2025 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de> * All Rights Reserved @@ -60,11 +60,31 @@ uint32_t dtid; }; -static inline uint32_t tcap_id_from_octet_str(const OCTET_STRING_t *src) +/* Obtain TID in 32BE format from octetstring. +* returns 0 on success, negative on error. */ +static int tcap_id_from_octet_str(uint32_t *tid, const OCTET_STRING_t *src) { - OSMO_ASSERT(src->size == 4); + switch (src->size) { + case 4: + *tid = osmo_load32be(src->buf); + break; + case 3: + *tid = load_24be(src->buf); + break; + case 2: + *tid = osmo_load16be(src->buf); + break; + case 1: + *tid = src->buf[0]; + break; + default: + LOGP(DLTCAP, LOGL_NOTICE, "Rx TCAP message with unexpected TID length %zu\n", + src->size); + *tid = 0; + return -EINVAL; + } - return osmo_load32be(src->buf); + return 0; } /* returns negative on error, mask with any/both OTID_SET|DTID_SET on success */ @@ -88,33 +108,37 @@ case TCAP_TCMessage_PR_begin: { TCAP_Begin_t part = tcapmsg->choice.begin; - ids->otid = tcap_id_from_octet_str(&part.otid); + if ((rc = tcap_id_from_octet_str(&ids->otid, &part.otid)) < 0) + goto free_asn; rc = OTID_SET; break; } case TCAP_TCMessage_PR_continue: { TCAP_Continue_t part = tcapmsg->choice.Continue; - ids->otid = tcap_id_from_octet_str(&part.otid); - ids->dtid = tcap_id_from_octet_str(&part.dtid); + if ((rc = tcap_id_from_octet_str(&ids->otid, &part.otid)) < 0) + goto free_asn; + if ((rc = tcap_id_from_octet_str(&ids->dtid, &part.dtid)) < 0) + goto free_asn; rc = OTID_SET | DTID_SET; break; } case TCAP_TCMessage_PR_end: { TCAP_End_t part = tcapmsg->choice.end; - ids->dtid = tcap_id_from_octet_str(&part.dtid); + if ((rc = tcap_id_from_octet_str(&ids->dtid, &part.dtid)) < 0) + goto free_asn; rc = DTID_SET; break; } case TCAP_TCMessage_PR_abort: { TCAP_Abort_t part = tcapmsg->choice.abort; - ids->dtid = tcap_id_from_octet_str(&part.dtid); + if ((rc = tcap_id_from_octet_str(&ids->dtid, &part.dtid)) < 0) + goto free_asn; rc = DTID_SET; break; } - /* No TID present */ case TCAP_TCMessage_PR_unidirectional: rc = 0; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2748d85624e4be708f7554ee3e60a5bda9162845 Gerrit-Change-Number: 42212 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: tcap: Lower log level failing to parse msg
by pespin 27 Feb '26

27 Feb '26

Attention is currently required from: daniel, fixeria, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42211?usp=email ) Change subject: tcap: Lower log level failing to parse msg ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42211?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Idef5736ee2481260f958eece2f5a3bfc009b3d69 Gerrit-Change-Number: 42211 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 27 Feb 2026 14:23:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-netif[master]: stream: Improve error handling and logging in write_cb
by osmith 27 Feb '26

27 Feb '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email ) Change subject: stream: Improve error handling and logging in write_cb ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/42191/comment/4ecafb6f_0b7a6f2… : PS2, Line 609: strerror_r(-res, errbuf, sizeof(errbuf)); Why do you use strerror_r instead of strerror here? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/42191?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I68468f0452cbc86b6210bbd1dbfa251579270adb Gerrit-Change-Number: 42191 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Feb 2026 13:57:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log