laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41143?usp=email )
Change subject: buildsystem/gen_links: catch broken symlinks
......................................................................
buildsystem/gen_links: catch broken symlinks
Tweak gen_links() to verify that each symlink target exists. If the
target does not exist, abort with an error:
ERROR in msc/gen_links.sh:
File not found:
../deps/titan.Libraries.TCCUsefulFunctions/src/TCCOpenSecurity_Functions.hh
Section:
DIR=../deps/titan.Libraries.TCCUsefulFunctions/src
FILES="…TCCOpenSecurity_Functions.hh…"
gen_links $DIR $FILES
This is slightly slower than the previous approach (which did not check
if the symlink target exists). But this prevents adding subtle bugs
that may not trigger every time (see 520ac3ab ("*/gen_links.sh: fix
wrong SDP_EncDec.cc symlink")).
Change-Id: I0da0ec30e5eaf65d0348e22900a5ee006dee9e44
---
M _buildsystem/gen_links.inc.sh
1 file changed, 18 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
diff --git a/_buildsystem/gen_links.inc.sh b/_buildsystem/gen_links.inc.sh
index 161754c..42f01b1 100644
--- a/_buildsystem/gen_links.inc.sh
+++ b/_buildsystem/gen_links.inc.sh
@@ -27,9 +27,24 @@
local files="$*"
for f in $files; do
- (ln -sf \
- "$(realpath "$TOPDIR/$PROJECTDIR/$dir/$f")" \
- "$BUILDDIR/$PROJECTDIR/$f") &
+ local target="$(realpath "$TOPDIR/$PROJECTDIR/$dir/$f")"
+ if ! [ -e "$target" ]; then
+ echo
+ echo "ERROR in $PROJECTDIR/gen_links.sh:"
+ echo
+ echo " File not found:"
+ echo " $dir/$f"
+ echo
+ echo " Section:"
+ echo " DIR=$dir"
+ echo " FILES=\"…$f…\""
+ echo " gen_links \$DIR \$FILES"
+ echo
+ exit 1
+ fi
+ ln -sf \
+ "$target" \
+ "$BUILDDIR/$PROJECTDIR/$f" &
done
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41143?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0da0ec30e5eaf65d0348e22900a5ee006dee9e44
Gerrit-Change-Number: 41143
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/41146?usp=email )
Change subject: OBS: stop building limesuite
......................................................................
OBS: stop building limesuite
Building limesuite is not needed anymore, as it is available at least
since debian 10 in the debian and ubuntu repositories. We have been
building the upstream version without changes.
Related: OS#6855
Change-Id: Id79ccf873fce8b3b4f61bd73ab89d6a95bd105c1
---
M scripts/obs/lib/config.py
M scripts/obs/lib/srcpkg.py
2 files changed, 0 insertions(+), 12 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py
index 92a3310..8282d9e 100644
--- a/scripts/obs/lib/config.py
+++ b/scripts/obs/lib/config.py
@@ -98,7 +98,6 @@
"strongswan-epdg",
]
projects_other = [
- "limesuite",
"neocon",
"open5gs",
]
@@ -106,7 +105,6 @@
git_url_default = "https://gerrit.osmocom.org" # /project gets appended
git_url_other = {
"libosmo-dsp": "https://gitea.osmocom.org/sdr/libosmo-dsp",
- "limesuite": "https://github.com/myriadrf/LimeSuite",
"neocon": "https://github.com/laf0rge/neocon",
"open5gs": "https://github.com/open5gs/open5gs",
"osmo-fl2k": "https://gitea.osmocom.org/sdr/osmo-fl2k",
@@ -129,7 +127,6 @@
git_latest_tag_pattern_default = tag_pattern()
git_latest_tag_pattern_other = {
"gapk": tag_pattern('v', c=r'(\.\d+)?'),
- "limesuite": tag_pattern('v'),
"open5gs": tag_pattern('v'),
"osmo-fl2k": tag_pattern('v'),
"rtl-sdr": tag_pattern('v'),
diff --git a/scripts/obs/lib/srcpkg.py b/scripts/obs/lib/srcpkg.py
index 3a09af3..b0f76b8 100644
--- a/scripts/obs/lib/srcpkg.py
+++ b/scripts/obs/lib/srcpkg.py
@@ -128,15 +128,6 @@
cwd=lib.git.get_repo_path("open5gs"))
-def prepare_project_limesuite():
- """ Fix bug in 23.10: https://github.com/myriadrf/LimeSuite/pull/386 """
- lib.run_cmd(["mv", "-v",
- "liblimesuite22.09-1.install",
- "liblimesuite23.10-1.install"],
- cwd=f"{lib.git.get_repo_path('limesuite')}/debian",
- check=False)
-
-
def run_generate_build_dep(project):
""" Run contrib/generate_build_dep.sh if it exists in the given project, to
to download sources for dependencies (see e.g. osmo_dia2gsup.git). """
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41146?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Id79ccf873fce8b3b4f61bd73ab89d6a95bd105c1
Gerrit-Change-Number: 41146
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/docker-playground/+/40734?usp=email )
Change subject: titan: upgrade to libfftranscode 0.6 (updated NGAP ASN.1 to V17.5.0)
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS1:
> I manually tested it still worked fine with successful tests, but it was still failing with the spec […]
Done
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/40734?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I56034ef75cd6cca88fc9d353e097086bce6d639c
Gerrit-Change-Number: 40734
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 24 Sep 2025 15:02:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>