July 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ttcn3-hacks[master]: GSUP_Templates: ts_GSUP_UL_REQ: add "(omit)" to templates
by lynxis lazus 14 Jul '25

14 Jul '25

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40667?usp=email ) Change subject: GSUP_Templates: ts_GSUP_UL_REQ: add "(omit)" to templates ...................................................................... GSUP_Templates: ts_GSUP_UL_REQ: add "(omit)" to templates The sending template can only support omit or having a value. Change-Id: I250960a1e1c19dfa1efa81f6bbc93efa07cb225c --- M library/GSUP_Templates.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/67/40667/1 diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index 36702d9..2a4bc65 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -410,8 +410,8 @@ tr_GSUP(OSMO_GSUP_MSGT_SEND_AUTH_INFO_RESULT, { tr_GSUP_IE_IMSI(imsi), *, auth_tuple_ie, * }); -template GSUP_PDU ts_GSUP_UL_REQ(hexstring imsi, GSUP_CnDomain dom := OSMO_GSUP_CN_DOMAIN_PS, - template octetstring source_name := omit) := +template (omit) GSUP_PDU ts_GSUP_UL_REQ(hexstring imsi, GSUP_CnDomain dom := OSMO_GSUP_CN_DOMAIN_PS, + template (omit) octetstring source_name := omit) := ts_GSUP(OSMO_GSUP_MSGT_UPDATE_LOCATION_REQUEST, f_gen_ts_ies(imsi, dom := dom, source_name := source_name)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40667?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I250960a1e1c19dfa1efa81f6bbc93efa07cb225c Gerrit-Change-Number: 40667 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: GSUP_Templates: fix whitespace issues
by lynxis lazus 14 Jul '25

14 Jul '25

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40668?usp=email ) Change subject: GSUP_Templates: fix whitespace issues ...................................................................... GSUP_Templates: fix whitespace issues Change-Id: I03be75063a71153bd2881afd1d741454c508fada --- M library/GSUP_Templates.ttcn 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/68/40668/1 diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index 2a4bc65..cdc0a72 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -448,8 +448,8 @@ template (omit) octetstring source_name := omit, template (omit) octetstring destination_name := omit) := ts_GSUP(OSMO_GSUP_MSGT_INSERT_DATA_RESULT, - f_gen_ts_ies(imsi, source_name := source_name, - destination_name := destination_name)); + f_gen_ts_ies(imsi, source_name := source_name, + destination_name := destination_name)); template GSUP_PDU tr_GSUP_ISD_RES(template hexstring imsi) := tr_GSUP_IMSI(OSMO_GSUP_MSGT_INSERT_DATA_RESULT, imsi); @@ -500,7 +500,7 @@ tr_GSUP_IE_IMSI(imsi), tr_GSUP_IE_Cause(cause) }); template (value) GSUP_PDU ts_GSUP_CHECK_IMEI_REQ(hexstring imsi, hexstring imei, - template (omit) octetstring source_name := omit) := + template (omit) octetstring source_name := omit) := ts_GSUP(OSMO_GSUP_MSGT_CHECK_IMEI_REQUEST, f_gen_ts_ies(imsi, imei := imei, source_name := source_name)); template GSUP_PDU tr_GSUP_CHECK_IMEI_REQ( -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40668?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I03be75063a71153bd2881afd1d741454c508fada Gerrit-Change-Number: 40668 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ttcn3-hacks[master]: GSUP Templates: fix empty destination_name in GSUP ISD/UL
by lynxis lazus 14 Jul '25

14 Jul '25

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666?usp=email ) Change subject: GSUP Templates: fix empty destination_name in GSUP ISD/UL ...................................................................... GSUP Templates: fix empty destination_name in GSUP ISD/UL The destination_name TLV should be either set with a valid name or not present, but a field with length 0 shouldn't be used. Change-Id: Ia89b5a82665e407fa578e5209fbcde0676326df0 --- M library/GSUP_Templates.ttcn 1 file changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/40666/1 diff --git a/library/GSUP_Templates.ttcn b/library/GSUP_Templates.ttcn index 227a7d2..36702d9 100644 --- a/library/GSUP_Templates.ttcn +++ b/library/GSUP_Templates.ttcn @@ -418,9 +418,9 @@ template GSUP_PDU tr_GSUP_UL_REQ(template hexstring imsi) := tr_GSUP_IMSI(OSMO_GSUP_MSGT_UPDATE_LOCATION_REQUEST, imsi); -template (value) GSUP_PDU ts_GSUP_UL_RES(hexstring imsi, octetstring destination_name := ''O) := - ts_GSUP(OSMO_GSUP_MSGT_UPDATE_LOCATION_RESULT, { valueof(ts_GSUP_IE_IMSI(imsi)), - valueof(ts_GSUP_IE_Destination_Name(destination_name))}); +template (omit) GSUP_PDU ts_GSUP_UL_RES(hexstring imsi, template (omit) octetstring destination_name := omit) := + ts_GSUP(OSMO_GSUP_MSGT_UPDATE_LOCATION_RESULT, + f_gen_ts_ies(imsi, destination_name := destination_name)); template GSUP_PDU tr_GSUP_UL_RES(template hexstring imsi, template octetstring destination_name := omit) := tr_GSUP(OSMO_GSUP_MSGT_UPDATE_LOCATION_RESULT, f_gen_tr_ies(imsi, destination_name := destination_name)); @@ -434,19 +434,19 @@ tr_GSUP(OSMO_GSUP_MSGT_UPDATE_LOCATION_ERROR, f_gen_tr_ies(imsi, cause := cause, destination_name := destination_name)); -template (value) GSUP_PDU ts_GSUP_ISD_REQ(hexstring imsi, hexstring msisdn, octetstring destination_name := ''O) := - ts_GSUP(OSMO_GSUP_MSGT_INSERT_DATA_REQUEST, { - valueof(ts_GSUP_IE_IMSI(imsi)), valueof(ts_GSUP_IE_MSISDN(msisdn)), - valueof(ts_GSUP_IE_Destination_Name(destination_name))}); +template (omit) GSUP_PDU ts_GSUP_ISD_REQ(hexstring imsi, hexstring msisdn, template (omit) octetstring destination_name := omit) := + ts_GSUP(OSMO_GSUP_MSGT_INSERT_DATA_REQUEST, + f_gen_ts_ies(imsi, destination_name := destination_name) & { + valueof(ts_GSUP_IE_MSISDN(msisdn)) }); template GSUP_PDU tr_GSUP_ISD_REQ(template hexstring imsi, template hexstring msisdn := ?, template octetstring destination_name := omit) := tr_GSUP(OSMO_GSUP_MSGT_INSERT_DATA_REQUEST, f_gen_tr_ies(imsi, msisdn := msisdn, destination_name := destination_name)); -template GSUP_PDU ts_GSUP_ISD_RES(hexstring imsi, - template octetstring source_name := omit, - template octetstring destination_name := omit) := +template (omit) GSUP_PDU ts_GSUP_ISD_RES(hexstring imsi, + template (omit) octetstring source_name := omit, + template (omit) octetstring destination_name := omit) := ts_GSUP(OSMO_GSUP_MSGT_INSERT_DATA_RESULT, f_gen_ts_ies(imsi, source_name := source_name, destination_name := destination_name)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40666?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia89b5a82665e407fa578e5209fbcde0676326df0 Gerrit-Change-Number: 40666 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[S] Change in osmo-ggsn[master]: gtp: SGSN Ctx: prevent a stack reference to be in **ie
by daniel 14 Jul '25

14 Jul '25

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40641?usp=email ) Change subject: gtp: SGSN Ctx: prevent a stack reference to be in **ie ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I feel like this could/should be a(n inline) function. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40641?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ideca8beb21c6cce7104721b4d80854448baf6c4e Gerrit-Change-Number: 40641 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 14 Jul 2025 16:01:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: SGSN: Iu: use correct service request type
by daniel 14 Jul '25

14 Jul '25

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40649?usp=email ) Change subject: SGSN: Iu: use correct service request type ...................................................................... Patch Set 3: (1 comment) File sgsn/SGSN_Tests_Iu.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40649/comment/d02a5c32_7857… : PS3, Line 213: SERVICE_TYPE_Signalling Why not use the default value and continue to omit if it's Signalling? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40649?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia47edd8ca916cf377da875583a3c4eb6ff5f1f52 Gerrit-Change-Number: 40649 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 14 Jul 2025 15:59:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-sgsn[master]: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS
by pespin 14 Jul '25

14 Jul '25

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40653?usp=email ) Change subject: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c Gerrit-Change-Number: 40653 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 14 Jul 2025 15:57:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-msc[master]: msc: Initial implementation of N-PCSTATE.ind
by pespin 14 Jul '25

14 Jul '25

Attention is currently required from: laforge, neels, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40630?usp=email ) Change subject: msc: Initial implementation of N-PCSTATE.ind ...................................................................... Patch Set 3: (1 comment) File src/libmsc/ran_peer.c: https://gerrit.osmocom.org/c/osmo-msc/+/40630/comment/98992f3b_2fa0f772?usp… : PS3, Line 131: /* N-PCSTATE.ind informs us the peer went down and is no longer reachable: */ > Done On second thoughts I think I'll actually add an FSM event for this. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40630?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ice1b2c163b1b0d134fcaa1c8bf543038a35fabdf Gerrit-Change-Number: 40630 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 14 Jul 2025 15:55:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-msc[master]: ran_peer: Introuce stats msc.ran_peers.{total,active}
by pespin 14 Jul '25

14 Jul '25

Attention is currently required from: neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40633?usp=email ) Change subject: ran_peer: Introuce stats msc.ran_peers.{total,active} ...................................................................... Patch Set 4: (2 comments) File include/osmocom/msc/gsm_data.h: https://gerrit.osmocom.org/c/osmo-msc/+/40633/comment/67d27499_f1864a66?usp… : PS4, Line 127: [MSC_STAT_RAN_PEERS_TOTAL] = { "msc.ran_peers.total", "Total RAN peers (BSC, RNC)", OSMO_STAT_ITEM_NO_UNIT, 4, 0}, > (maybe add "seen"? like "Total RAN peers seen since startup" ... […] Done File src/libmsc/ran_peer.c: https://gerrit.osmocom.org/c/osmo-msc/+/40633/comment/76651dc2_8240905e?usp… : PS4, Line 95: osmo_stat_item_dec(osmo_stat_item_group_get_item(net->statg, MSC_STAT_RAN_PEERS_TOTAL), 1); > you already count the state change in onleave(), so just make sure to change the state before/on dea […] Currently this FSM has a DISCARDING state exactly for the purpose of not being used 😄 I was even tempted submitting a patch removing it, but I didn't want to spend even more time changing existing stuff. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40633?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I36e40510c9a95f0c9cf5f32d2a7baab840aa8660 Gerrit-Change-Number: 40633 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Jul 2025 15:53:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS
by daniel 14 Jul '25

14 Jul '25

Attention is currently required from: fixeria, lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40653?usp=email ) Change subject: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ib9bee2f8d0b1f89986d15cf3ce6404ad76378c8c Gerrit-Change-Number: 40653 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 14 Jul 2025 15:51:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-msc[master]: ran_peer: Add specific API to free object
by pespin 14 Jul '25

14 Jul '25

Attention is currently required from: fixeria, laforge, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-msc/+/40632?usp=email ) Change subject: ran_peer: Add specific API to free object ...................................................................... Patch Set 4: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/40632/comment/830de391_6c8d72e9?usp… : PS2, Line 11: Swap the talloc tree parentship to have the fi be a child of the object, : which simplifies tear down triggered by FSM cleanup. > you may find that, but you have not convinced me yet. […] I already described it. It's really difficult to figure out whether a given object is being freed because there's no specific API to free it. There's multiple of osmo_fsm_inst_term() calls all over the code and it's non trivial to figure out where an object is freed. Do you mind telling me if I'm wrong and this object is being freed somewhere already? Because otherwise this change doesn't seem problematic in the PIVOTAL design. File src/libmsc/ran_peer.c: https://gerrit.osmocom.org/c/osmo-msc/+/40632/comment/c423c260_fc9b93ae?usp… : PS4, Line 81: void ran_peer_free(struct ran_peer *rp) > AFAIR the idea is to instead call osmo_fsm_inst_term() $ grep -r osmo_fsm_inst_term . | wc -l 37 And AFAICT none of those 37 calls is related to this object? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/40632?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I721de21a68a4e336ae508a995e3cfcca05d57efe Gerrit-Change-Number: 40632 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Jul 2025 15:45:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0