July 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-smlc[master]: Introduce stats msc.ran_peers.{total,active}
by fixeria 15 Jul '25

15 Jul '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-smlc/+/40679?usp=email ) Change subject: Introduce stats msc.ran_peers.{total,active} ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/40679?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Ib01576036f34ac7f21c5bce0155b50932eb9b72a Gerrit-Change-Number: 40679 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Jul 2025 10:09:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-smlc[master]: smlc: Initial implementation of N-PCSTATE.ind
by fixeria 15 Jul '25

15 Jul '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-smlc/+/40665?usp=email ) Change subject: smlc: Initial implementation of N-PCSTATE.ind ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/40665?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Id034a0c4d8bff0647a64658480dfa9b4cea563de Gerrit-Change-Number: 40665 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Jul 2025 10:07:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-iuh[master]: iu_client: Initial N-PCSTATE.ind support
by pespin 15 Jul '25

15 Jul '25

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40643?usp=email ) Change subject: iu_client: Initial N-PCSTATE.ind support ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40643?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I36818ca9d2ef42a68698e5c3b66367207d177b67 Gerrit-Change-Number: 40643 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 15 Jul 2025 10:01:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in osmo-smlc[master]: vty: Create smlc_vty.c
by fixeria 15 Jul '25

15 Jul '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-smlc/+/40678?usp=email ) Change subject: vty: Create smlc_vty.c ...................................................................... Patch Set 1: (2 comments) File src/osmo-smlc/smlc_main.c: https://gerrit.osmocom.org/c/osmo-smlc/+/40678/comment/c3af3688_b7ad45c7?us… : PS1, Line 22: osmocom/ctrl/control_vty.h not needed anymore? https://gerrit.osmocom.org/c/osmo-smlc/+/40678/comment/6f0f7f52_2e2f9340?us… : PS1, Line 32: #include <osmocom/vty/logging.h> : #include <osmocom/vty/command.h> : #i not needed anymore? -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/40678?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I6899602c3a6e22ee6ff93540466f839b2bf5ccc1 Gerrit-Change-Number: 40678 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Jul 2025 10:00:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-smlc[master]: cell_locations.h: Fix includes
by pespin 15 Jul '25

15 Jul '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/40677?usp=email ) Change subject: cell_locations.h: Fix includes ...................................................................... cell_locations.h: Fix includes No sigtran header is needed as a dependecy in that header. struct gsm0808_cell_id is defined in gsm0808_utils.h. Change-Id: Iceedd7a8c2e050e6631c5f471d2eb71ab8ee2432 --- M include/osmocom/smlc/cell_locations.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/include/osmocom/smlc/cell_locations.h b/include/osmocom/smlc/cell_locations.h index 9712718..5eb5d7e 100644 --- a/include/osmocom/smlc/cell_locations.h +++ b/include/osmocom/smlc/cell_locations.h @@ -23,7 +23,7 @@ #include <stdint.h> #include <osmocom/core/linuxlist.h> -#include <osmocom/sigtran/sccp_sap.h> +#include <osmocom/gsm/gsm0808_utils.h> struct osmo_gad; -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/40677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Iceedd7a8c2e050e6631c5f471d2eb71ab8ee2432 Gerrit-Change-Number: 40677 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-smlc[master]: lb_peer: Drop unused events CONNECTION_{SUCCESS,TIMEOUT}
by pespin 15 Jul '25

15 Jul '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/40674?usp=email ) Change subject: lb_peer: Drop unused events CONNECTION_{SUCCESS,TIMEOUT} ...................................................................... lb_peer: Drop unused events CONNECTION_{SUCCESS,TIMEOUT} Change-Id: If5d838e3c0cfdb08ea8a96330ea1de4fa73e091a --- M include/osmocom/smlc/lb_peer.h M src/osmo-smlc/lb_peer.c 2 files changed, 0 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/include/osmocom/smlc/lb_peer.h b/include/osmocom/smlc/lb_peer.h index dc226fa..5851a95 100644 --- a/include/osmocom/smlc/lb_peer.h +++ b/include/osmocom/smlc/lb_peer.h @@ -49,8 +49,6 @@ LB_PEER_EV_MSG_DOWN_CO, LB_PEER_EV_RX_RESET, LB_PEER_EV_RX_RESET_ACK, - LB_PEER_EV_CONNECTION_SUCCESS, - LB_PEER_EV_CONNECTION_TIMEOUT, }; struct lb_peer_ev_ctx { diff --git a/src/osmo-smlc/lb_peer.c b/src/osmo-smlc/lb_peer.c index 84d48fc..54e0ad2 100644 --- a/src/osmo-smlc/lb_peer.c +++ b/src/osmo-smlc/lb_peer.c @@ -363,8 +363,6 @@ OSMO_VALUE_STRING(LB_PEER_EV_MSG_DOWN_CO), OSMO_VALUE_STRING(LB_PEER_EV_RX_RESET), OSMO_VALUE_STRING(LB_PEER_EV_RX_RESET_ACK), - OSMO_VALUE_STRING(LB_PEER_EV_CONNECTION_SUCCESS), - OSMO_VALUE_STRING(LB_PEER_EV_CONNECTION_TIMEOUT), {} }; @@ -378,7 +376,6 @@ | S(LB_PEER_EV_RX_RESET) | S(LB_PEER_EV_MSG_UP_CO_INITIAL) | S(LB_PEER_EV_MSG_UP_CO) - | S(LB_PEER_EV_CONNECTION_TIMEOUT) , .out_state_mask = 0 | S(LB_PEER_ST_WAIT_RX_RESET) @@ -395,7 +392,6 @@ | S(LB_PEER_EV_RX_RESET_ACK) | S(LB_PEER_EV_MSG_UP_CO_INITIAL) | S(LB_PEER_EV_MSG_UP_CO) - | S(LB_PEER_EV_CONNECTION_TIMEOUT) , .out_state_mask = 0 | S(LB_PEER_ST_WAIT_RX_RESET) -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/40674?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: If5d838e3c0cfdb08ea8a96330ea1de4fa73e091a Gerrit-Change-Number: 40674 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-smlc[master]: lb_peer: Mark multiple funcs as static
by pespin 15 Jul '25

15 Jul '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/40673?usp=email ) Change subject: lb_peer: Mark multiple funcs as static ...................................................................... lb_peer: Mark multiple funcs as static Change-Id: I7178608444f72bfb93b816a0bedee336a5b4cafe --- M include/osmocom/smlc/lb_peer.h M src/osmo-smlc/lb_peer.c 2 files changed, 18 insertions(+), 19 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/include/osmocom/smlc/lb_peer.h b/include/osmocom/smlc/lb_peer.h index 7eabe4d..dc226fa 100644 --- a/include/osmocom/smlc/lb_peer.h +++ b/include/osmocom/smlc/lb_peer.h @@ -64,4 +64,3 @@ int lb_peer_up_l2(struct sccp_lb_inst *sli, const struct osmo_sccp_addr *calling_addr, bool co, uint32_t conn_id, struct msgb *l2); -void lb_peer_disconnect(struct sccp_lb_inst *sli, uint32_t conn_id); diff --git a/src/osmo-smlc/lb_peer.c b/src/osmo-smlc/lb_peer.c index f2dc715..84d48fc 100644 --- a/src/osmo-smlc/lb_peer.c +++ b/src/osmo-smlc/lb_peer.c @@ -88,7 +88,7 @@ #define lb_peer_state_chg(LB_PEER, NEXT_STATE) \ osmo_tdef_fsm_inst_state_chg((LB_PEER)->fi, NEXT_STATE, lb_peer_fsm_timeouts, g_smlc_tdefs, 5) -void lb_peer_discard_all_conns(struct lb_peer *lbp) +static void lb_peer_discard_all_conns(struct lb_peer *lbp) { struct lb_conn *lb_conn, *next; @@ -137,7 +137,7 @@ lb_peer_state_chg(lbp, LB_PEER_ST_READY); } -void lb_peer_reset(struct lb_peer *lbp) +static void lb_peer_reset(struct lb_peer *lbp) { struct bssap_le_pdu reset = { .discr = BSSAP_LE_MSG_DISCR_BSSMAP_LE, @@ -167,7 +167,18 @@ } } -void lb_peer_allstate_action(struct osmo_fsm_inst *fi, uint32_t event, void *data) +static void lb_peer_disconnect(struct sccp_lb_inst *sli, uint32_t conn_id) +{ + struct lb_conn *lb_conn; + llist_for_each_entry(lb_conn, &sli->lb_conns, entry) { + if (lb_conn->sccp_conn_id == conn_id) { + lb_conn_discard(lb_conn); + return; + } + } +} + +static void lb_peer_allstate_action(struct osmo_fsm_inst *fi, uint32_t event, void *data) { struct lb_peer *lbp = fi->priv; struct lb_peer_ev_ctx *ctx = data; @@ -196,7 +207,7 @@ } } -void lb_peer_st_wait_rx_reset(struct osmo_fsm_inst *fi, uint32_t event, void *data) +static void lb_peer_st_wait_rx_reset(struct osmo_fsm_inst *fi, uint32_t event, void *data) { struct lb_peer *lbp = fi->priv; struct lb_peer_ev_ctx *ctx; @@ -230,7 +241,7 @@ } } -void lb_peer_st_wait_rx_reset_ack(struct osmo_fsm_inst *fi, uint32_t event, void *data) +static void lb_peer_st_wait_rx_reset_ack(struct osmo_fsm_inst *fi, uint32_t event, void *data) { struct lb_peer *lbp = fi->priv; struct lb_peer_ev_ctx *ctx; @@ -265,7 +276,7 @@ } } -void lb_peer_st_ready(struct osmo_fsm_inst *fi, uint32_t event, void *data) +static void lb_peer_st_ready(struct osmo_fsm_inst *fi, uint32_t event, void *data) { struct lb_peer *lbp = fi->priv; struct lb_peer_ev_ctx *ctx; @@ -336,7 +347,7 @@ return 0; } -void lb_peer_fsm_cleanup(struct osmo_fsm_inst *fi, enum osmo_fsm_term_cause cause) +static void lb_peer_fsm_cleanup(struct osmo_fsm_inst *fi, enum osmo_fsm_term_cause cause) { struct lb_peer *lbp = fi->priv; lb_peer_discard_all_conns(lbp); @@ -482,14 +493,3 @@ return osmo_fsm_inst_dispatch(lb_peer->fi, event, &ctx); } - -void lb_peer_disconnect(struct sccp_lb_inst *sli, uint32_t conn_id) -{ - struct lb_conn *lb_conn; - llist_for_each_entry(lb_conn, &sli->lb_conns, entry) { - if (lb_conn->sccp_conn_id == conn_id) { - lb_conn_discard(lb_conn); - return; - } - } -} -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/40673?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I7178608444f72bfb93b816a0bedee336a5b4cafe Gerrit-Change-Number: 40673 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-smlc[master]: cell_locations.h: Fix includes
by fixeria 15 Jul '25

15 Jul '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-smlc/+/40677?usp=email ) Change subject: cell_locations.h: Fix includes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/40677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Iceedd7a8c2e050e6631c5f471d2eb71ab8ee2432 Gerrit-Change-Number: 40677 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Jul 2025 09:56:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-smlc[master]: lb_peer: Drop unused events CONNECTION_{SUCCESS,TIMEOUT}
by fixeria 15 Jul '25

15 Jul '25

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-smlc/+/40674?usp=email ) Change subject: lb_peer: Drop unused events CONNECTION_{SUCCESS,TIMEOUT} ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/40674?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: If5d838e3c0cfdb08ea8a96330ea1de4fa73e091a Gerrit-Change-Number: 40674 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Jul 2025 09:56:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-smlc[master]: lb_peer: Mark multiple funcs as static
by fixeria 15 Jul '25

15 Jul '25

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-smlc/+/40673?usp=email ) Change subject: lb_peer: Mark multiple funcs as static ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/40673?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I7178608444f72bfb93b816a0bedee336a5b4cafe Gerrit-Change-Number: 40673 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Jul 2025 09:55:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0