July 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ggsn[master]: sgsnemu: Initial support IPv4v6 PDP context type
by pespin 16 Jul '25

16 Jul '25

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17255?usp=email ) Change subject: sgsnemu: Initial support IPv4v6 PDP context type ...................................................................... Patch Set 5: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/17255?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: If6eb2f1a5d0fb71da80e289112a67dd2faa30b4b Gerrit-Change-Number: 17255 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 16 Jul 2025 17:08:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ggsn[master]: cosmetic: sgsnemu: Fix trailing whitespace
by pespin 16 Jul '25

16 Jul '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40713?usp=email ) Change subject: cosmetic: sgsnemu: Fix trailing whitespace ...................................................................... cosmetic: sgsnemu: Fix trailing whitespace Also make linter happy: sgsnemu/cmdline.c:4: WARNING:LEADING_SPACE: please, no spaces at the start of a line Change-Id: Ie89a9f9de64cd59d21341b6f381b32f56693840f --- M sgsnemu/cmdline.c M sgsnemu/cmdline.ggo 2 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/13/40713/1 diff --git a/sgsnemu/cmdline.c b/sgsnemu/cmdline.c index 604e76b..e287116 100644 --- a/sgsnemu/cmdline.c +++ b/sgsnemu/cmdline.c @@ -1,12 +1,12 @@ /* - File autogenerated by gengetopt version 2.22.6 - generated with the following command: - gengetopt --conf-parser - - The developers of gengetopt consider the fixed text that goes in all - gengetopt output files to be in the public domain: - we make no copyright claims on it. -*/ + * File autogenerated by gengetopt version 2.22.6 + * generated with the following command: + * gengetopt --conf-parser + * + * The developers of gengetopt consider the fixed text that goes in all + * gengetopt output files to be in the public domain: + * we make no copyright claims on it. + */ /* If we use autoconf. */ #ifdef HAVE_CONFIG_H diff --git a/sgsnemu/cmdline.ggo b/sgsnemu/cmdline.ggo index 0d074aa..54db05b 100644 --- a/sgsnemu/cmdline.ggo +++ b/sgsnemu/cmdline.ggo @@ -1,11 +1,11 @@ # OsmoGGSN - Gateway GPRS Support Node # Copyright (C) 2002, 2003, 2004 Mondru AB. -# +# # The contents of this file may be used under the terms of the GNU # General Public License Version 2, provided that the above copyright # notice and this permission notice is included in all copies or # substantial portions of the software. -# +# # Use # gengetopt --conf-parser < cmdline.ggo # linux-2.6/scripts/Lindent cmdline.c -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/40713?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ie89a9f9de64cd59d21341b6f381b32f56693840f Gerrit-Change-Number: 40713 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-ggsn[master]: sgsnemu: Refactor arg/cfg parser to use talloc
by pespin 16 Jul '25

16 Jul '25

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17758?usp=email ) Change subject: sgsnemu: Refactor arg/cfg parser to use talloc ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/17758?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ie0d48a12a8349be5a859a03191421cbd9cc324cc Gerrit-Change-Number: 17758 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmocore[master]: gsm_04_08*.h: Reference successor TS 24.008
by pespin 16 Jul '25

16 Jul '25

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/32494?usp=email ) Change subject: gsm_04_08*.h: Reference successor TS 24.008 ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie81d725bc7fa3a2b38b40304dd672b6c4c66f283 Gerrit-Change-Number: 32494 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in ...osmo-epdg[master]: Use new 'pre-create tundev' feature from gtp_u_kmod
by pespin 16 Jul '25

16 Jul '25

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35993?usp=email ) Change subject: Use new 'pre-create tundev' feature from gtp_u_kmod ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35993?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I2297b8a75e75cc8095ae1485f73c49c5e6b26c4e Gerrit-Change-Number: 35993 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in docker-playground[master]: ttcn3-epdg: Use new 'pre-create tundev' feature from gtp_u_kmod
by pespin 16 Jul '25

16 Jul '25

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35994?usp=email ) Change subject: ttcn3-epdg: Use new 'pre-create tundev' feature from gtp_u_kmod ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35994?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie7e2b4fadef69c889b12792fc2b8050f1ef5c684 Gerrit-Change-Number: 35994 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[master]: Use proper SCCP release cause enum value instead of hardcoded value
by pespin 16 Jul '25

16 Jul '25

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34925?usp=email ) Change subject: Use proper SCCP release cause enum value instead of hardcoded value ...................................................................... Abandoned RE-submitted as https://gerrit.osmocom.org/c/osmo-hnbgw/+/40712 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If44e7c4a3166822d7732b7af4c136b8f97898dc0 Gerrit-Change-Number: 34925 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[master]: Depend on libosmo-sccp package
by pespin 16 Jul '25

16 Jul '25

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34927?usp=email ) Change subject: Depend on libosmo-sccp package ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34927?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idf88da2d1aa126acd1c784ff096ab79349364f85 Gerrit-Change-Number: 34927 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-hnbgw[master]: Use proper SCCP release cause enum value instead of hardcoded value
by pespin 16 Jul '25

16 Jul '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/40712?usp=email ) Change subject: Use proper SCCP release cause enum value instead of hardcoded value ...................................................................... Use proper SCCP release cause enum value instead of hardcoded value There's no behavior change since the enum item has value 0. Change-Id: I9de79db8e16cf425919b678d837b46f24ffe9bbe --- M src/osmo-hnbgw/hnbgw_sccp.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/12/40712/1 diff --git a/src/osmo-hnbgw/hnbgw_sccp.c b/src/osmo-hnbgw/hnbgw_sccp.c index 5baef06..6f01f7c 100644 --- a/src/osmo-hnbgw/hnbgw_sccp.c +++ b/src/osmo-hnbgw/hnbgw_sccp.c @@ -448,7 +448,8 @@ return -1; } - rc = osmo_sccp_tx_disconn(hsu->sccp_user, scu_conn_id, NULL, 0); + rc = osmo_sccp_tx_disconn(hsu->sccp_user, scu_conn_id, NULL, + SCCP_RELEASE_CAUSE_END_USER_ORIGINATED); if (rc) LOG_HSU(hsu, DCN, LOGL_ERROR, "Failed to send SCCP N-DISCONNECT.req(%u)\n", scu_conn_id); return rc; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/40712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I9de79db8e16cf425919b678d837b46f24ffe9bbe Gerrit-Change-Number: 40712 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-smlc[master]: sccp: Handle N-NOTICE.ind (Routing Failure of SCCP CL messages)
by pespin 16 Jul '25

16 Jul '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-smlc/+/40711?usp=email ) Change subject: sccp: Handle N-NOTICE.ind (Routing Failure of SCCP CL messages) ...................................................................... sccp: Handle N-NOTICE.ind (Routing Failure of SCCP CL messages) ITU Q.714 2.8: """ When an end node is informed of a routing failure, this information is forwarded towards the SCCP user by using the N-DISCONNECT primitive (refer to reason for release in 2.1.1.2.4/Q.711) or the N-NOTICE primitive (refer to reason for return in 2.2.2.2.4/Q.711) """ We are already handling N-DISCONNECT.ind for CO messages, but N-NOTICE.ind for CL messages was not being handled. If CL messages are not arriving to the Lb peer, then reset the link and mark the peer as disconnected, until a new RESET can successfully fo through. Related: OS#5917 Change-Id: I4bfea43a99c768162faefde06558941f697bd718 --- M src/osmo-smlc/sccp_lb_inst.c 1 file changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-smlc refs/changes/11/40711/1 diff --git a/src/osmo-smlc/sccp_lb_inst.c b/src/osmo-smlc/sccp_lb_inst.c index bfe8a0e..cea74bf 100644 --- a/src/osmo-smlc/sccp_lb_inst.c +++ b/src/osmo-smlc/sccp_lb_inst.c @@ -85,6 +85,36 @@ return sli; } +static void handle_notice_ind(struct sccp_lb_inst *sli, const struct osmo_scu_notice_param *ni) +{ + struct lb_peer *lbp; + + lbp = lb_peer_find(sli, &ni->calling_addr); + if (!lbp) { + LOG_SCCP_LB(sli, LOGL_DEBUG, "(calling_addr=%s) N-NOTICE.ind cause=%u='%s' importance=%u didn't match any lb_peer, ignoring\n", + osmo_sccp_addr_dump(&ni->calling_addr), + ni->cause, osmo_sccp_return_cause_name(ni->cause), + ni->importance); + return; + } + + LOG_LB_PEER(lbp, LOGL_NOTICE, "N-NOTICE.ind cause=%u='%s' importance=%u\n", + ni->cause, osmo_sccp_return_cause_name(ni->cause), + ni->importance); + + switch (ni->cause) { + case SCCP_RETURN_CAUSE_SUBSYSTEM_CONGESTION: + case SCCP_RETURN_CAUSE_NETWORK_CONGESTION: + /* Transient failures (hopefully), keep going. */ + return; + default: + break; + } + + /* Messages are not arriving to lb_peer. Signal it is unavailable to update local state. */ + osmo_fsm_inst_dispatch(lbp->fi, LB_PEER_EV_UNAVAILABLE, NULL); +} + static void handle_pcstate_ind(struct sccp_lb_inst *sli, const struct osmo_scu_pcstate_param *pcst) { struct osmo_ss7_instance *cs7 = osmo_sccp_get_ss7(sli->sccp); @@ -253,6 +283,11 @@ rc = lb_peer_up_l2(sli, peer_addr, false, 0, oph->msg); break; + case OSMO_PRIM(OSMO_SCU_PRIM_N_NOTICE, PRIM_OP_INDICATION): + handle_notice_ind(sli, &prim->u.notice); + rc = 0; + break; + case OSMO_PRIM(OSMO_SCU_PRIM_N_PCSTATE, PRIM_OP_INDICATION): handle_pcstate_ind(sli, &prim->u.pcstate); rc = 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/40711?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: I4bfea43a99c768162faefde06558941f697bd718 Gerrit-Change-Number: 40711 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0