July 2025 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-s1gw[master]: debian: add copyright file

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40765?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: debian: add copyright file ...................................................................... debian: add copyright file Change-Id: I95d9314f7f858c02a6ac10641c958bbf13677814 --- A debian/copyright 1 file changed, 47 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/debian/copyright b/debian/copyright new file mode 100644 index 0000000..d9fcc54 --- /dev/null +++ b/debian/copyright @@ -0,0 +1,47 @@ +Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ +Source: https://gitea.osmocom.org/erlang/osmo-s1gw +Upstream-Name: osmo-s1gw + +Files: src/*.erl + include/*.hrl + debian/* +Copyright: sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> +License: AGPL-3.0-or-later + +Files: contrib/osmo-s1gw.sh +Copyright: sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> +License: MPL-2.0 + + +License: AGPL-3.0-or-later + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU Affero General Public License as + published by the Free Software Foundation; either version 3 of the + License, or (at your option) any later version. + . + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + . + You should have received a copy of the GNU Affero General Public License + along with this program. If not, see <https://www.gnu.org/licenses/>. + . + Additional Permission under GNU AGPL version 3 section 7: + . + If you modify this Program, or any covered work, by linking or + combining it with runtime libraries of Erlang/OTP as released by + Ericsson on https://www.erlang.org (or a modified version of these + libraries), containing parts covered by the terms of the Erlang Public + License (https://www.erlang.org/EPLICENSE), the licensors of this + Program grant you additional permission to convey the resulting work + without the need to license the runtime libraries of Erlang/OTP under + the GNU Affero General Public License. Corresponding Source for a + non-source form of such a combination shall include the source code + for the parts of the runtime libraries of Erlang/OTP used as well as + that of the covered work. + +License: MPL-2.0 + This Source Code Form is subject to the terms of the Mozilla Public + License, v. 2.0. If a copy of the MPL was not distributed with this + file, You can obtain one at https://mozilla.org/MPL/2.0/. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40765?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I95d9314f7f858c02a6ac10641c958bbf13677814 Gerrit-Change-Number: 40765 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

[S] Change in osmo-dev[master]: gen_makefile: support new Osmocom erlang makefiles

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/40770?usp=email ) Change subject: gen_makefile: support new Osmocom erlang makefiles ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40770?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I92d6fc6eb5a11068d4b3baca55dfb3abdedbbbf1 Gerrit-Change-Number: 40770 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Jul 2025 09:45:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: podman: add libnftables-dev

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40773?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: testenv: podman: add libnftables-dev ...................................................................... testenv: podman: add libnftables-dev This is required for building osmo-s1gw from source in podman, otherwise: /home/user/.cache/osmo-ttcn3-testenv/podman/make3/osmo-s1gw/default/lib/enftables/c_src/enftables.c:16:10: fatal error: nftables/libnftables.h: No such file or directory 16 | #include <nftables/libnftables.h> | ^~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. Change-Id: I0ae94f73f0875048d9a71d1582627e57e60425c6 --- M _testenv/data/podman/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/_testenv/data/podman/Dockerfile b/_testenv/data/podman/Dockerfile index 4a5e965..d79bda9 100644 --- a/_testenv/data/podman/Dockerfile +++ b/_testenv/data/podman/Dockerfile @@ -54,6 +54,7 @@ libmicrohttpd-dev \ libmnl-dev \ libmongoc-dev \ + libnftables-dev \ libnghttp2-dev \ libnl-route-3-dev \ libortp-dev \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40773?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0ae94f73f0875048d9a71d1582627e57e60425c6 Gerrit-Change-Number: 40773 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw/testenv: adjust to use new launcher script

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40772?usp=email ) Change subject: s1gw/testenv: adjust to use new launcher script ...................................................................... s1gw/testenv: adjust to use new launcher script osmo-s1gw now gets started through a launcher script. Depends: osmo-s1gw I5681ca103daf1c497218b4513b0ca97b1aae03d3 Change-Id: Ief1579154bf46b9bc2551535ede3e1f14456d65d --- M s1gw/testenv.cfg 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/s1gw/testenv.cfg b/s1gw/testenv.cfg index 2d04162..7456ec2 100644 --- a/s1gw/testenv.cfg +++ b/s1gw/testenv.cfg @@ -4,7 +4,9 @@ config=S1GW_Tests.cfg [s1gw] -program=ERL_FLAGS="-config osmo-s1gw.config" osmo-s1gw +program=osmo-s1gw -c osmo-s1gw.config -r "$TESTENV_INSTALL_DIR"/usr/lib/osmo-s1gw make=osmo-s1gw package=osmo-s1gw copy=osmo-s1gw.config +# Remove *_latest after osmo-s1gw >= 0.3.x is released +program_latest=ERL_FLAGS="-config osmo-s1gw.config" osmo-s1gw -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40772?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ief1579154bf46b9bc2551535ede3e1f14456d65d Gerrit-Change-Number: 40772 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw/testenv: adjust to use new launcher script

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40772?usp=email ) Change subject: s1gw/testenv: adjust to use new launcher script ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40772?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ief1579154bf46b9bc2551535ede3e1f14456d65d Gerrit-Change-Number: 40772 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Jul 2025 09:44:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: Add $install_dir/usr/bin to $PATH

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40771?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: testenv: Add $install_dir/usr/bin to $PATH ...................................................................... testenv: Add $install_dir/usr/bin to $PATH When building programs from source, don't look only in $install_dir/bin, but also in $install_dir/usr/bin for the binaries. osmo-s1gw installs to usr/bin with recent changes and other programs may do this too. Related: osmo-s1gw I5681ca103daf1c497218b4513b0ca97b1aae03d3 Change-Id: I8d652dba94bbd44217a3034ac012b6568941347d --- M _testenv/testenv/cmd.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/_testenv/testenv/cmd.py b/_testenv/testenv/cmd.py index e8598f0..afe9003 100644 --- a/_testenv/testenv/cmd.py +++ b/_testenv/testenv/cmd.py @@ -86,6 +86,7 @@ if install_dir and install_dir != "/": path += f":{os.path.join(install_dir, 'bin')}" + path += f":{os.path.join(install_dir, 'usr/bin')}" if podman: path += ":/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40771?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8d652dba94bbd44217a3034ac012b6568941347d Gerrit-Change-Number: 40771 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

[M] Change in ...osmo-s1gw[master]: Makefile: generate and install complete release package

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40756?usp=email ) Change subject: Makefile: generate and install complete release package ...................................................................... Patch Set 5: Code-Review+2 This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40756?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I5681ca103daf1c497218b4513b0ca97b1aae03d3 Gerrit-Change-Number: 40756 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Jul 2025 09:41:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 3 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Makefile: add REBAR_BASE_DIR variable

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40781?usp=email ) Change subject: Makefile: add REBAR_BASE_DIR variable ...................................................................... Makefile: add REBAR_BASE_DIR variable This allows building and running osmo-dia2gsup out-of-tree. Specifically it allows calling "make install" from osmo-dev, which it will do after the related patch is merged. Related: osmo-dev I92d6fc6eb5a11068d4b3baca55dfb3abdedbbbf1 Change-Id: I9511341bced7d658eacb34250569dfbfe37c084c --- M Makefile 1 file changed, 9 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/Makefile b/Makefile index 4fe7282..0033622 100644 --- a/Makefile +++ b/Makefile @@ -1,3 +1,5 @@ +# where rebar3 stores build output +REBAR_BASE_DIR ?= _build # config file used by 'run' and 'shell' CONFIG ?= examples/dev.config # directory paths for 'install' @@ -12,7 +14,7 @@ rebar3 escriptize run: build - ERL_FLAGS='-config $(CONFIG)' _build/default/bin/osmo-dia2gsup + ERL_FLAGS='-config $(CONFIG)' $(REBAR_BASE_DIR)/default/bin/osmo-dia2gsup shell: build rebar3 shell --config $(CONFIG) @@ -24,7 +26,7 @@ rebar3 dialyzer install: build - install -Dm0755 _build/default/bin/osmo-dia2gsup \ + install -Dm0755 $(REBAR_BASE_DIR)/default/bin/osmo-dia2gsup \ $(DESTDIR)$(BINDIR)/osmo-dia2gsup install -Dm0644 examples/sys.config \ $(DESTDIR)$(CONFDIR)/osmo-dia2gsup.config @@ -32,12 +34,12 @@ $(DESTDIR)$(SYSTEMDUNITDIR)/osmo_dia2gsup.service clean: -# Avoid running rebar3 clean if _build doesn't exist, since it would try -# to fetch deps from the Internet and that may not be avaialble when in -# OBS build. -ifneq ("$(wildcard _build/.*)", "") +# Avoid running rebar3 clean if $(REBAR_BASE_DIR) doesn't exist, since it would +# try to fetch deps from the Internet and that may not be avaialble when in OBS +# build. +ifneq ("$(wildcard $(REBAR_BASE_DIR)/.*)", "") rebar3 clean - rm -rf _build/ + rm -rf $(REBAR_BASE_DIR) else rm -f src/diameter_*.erl endif -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40781?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I9511341bced7d658eacb34250569dfbfe37c084c Gerrit-Change-Number: 40781 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Makefile: add REBAR_BASE_DIR variable

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40781?usp=email ) Change subject: Makefile: add REBAR_BASE_DIR variable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/40781?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I9511341bced7d658eacb34250569dfbfe37c084c Gerrit-Change-Number: 40781 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Jul 2025 09:27:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month, 3 weeks

1
0
0 0

[S] Change in osmo-dev[master]: gen_makefile: support new Osmocom erlang makefiles

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/40770?usp=email ) Change subject: gen_makefile: support new Osmocom erlang makefiles ...................................................................... Patch Set 2: (1 comment) File gen_makefile.py: https://gerrit.osmocom.org/c/osmo-dev/+/40770/comment/25d500df_9c3c35de?usp… : PS1, Line 375: for i in {build_proj}/default/bin/*; do \\ : if [ -e "$$i" ]; then \\ : install -v -Dm755 "$$i" -t {shlex.quote(args.install_prefix)}/bin/; \\ > Ack, I'll give that a try. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40770?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I92d6fc6eb5a11068d4b3baca55dfb3abdedbbbf1 Gerrit-Change-Number: 40770 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Jul 2025 09:18:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 month, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2025