July 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: Fix static str buf in osmo_ss7_route_print() too small

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40557?usp=email ) Change subject: Fix static str buf in osmo_ss7_route_print() too small ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40557?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I40c9ac38b60b01f64bec01ddd10a63759dbdec81 Gerrit-Change-Number: 40557 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Jul 2025 16:10:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month

1
0
0 0

[M] Change in libosmo-sigtran[master]: Introduce initial route status support

by laforge

Attention is currently required from: daniel, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40556?usp=email ) Change subject: Introduce initial route status support ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Icb4f78f8da9de5a611cb6311722bf3acf1a68fc5 Gerrit-Change-Number: 40556 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Jul 2025 16:10:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month

1
0
0 0

[S] Change in osmo-remsim[master]: bankd: implicit remove a client mapping when creating a new mapping

by pespin

Attention is currently required from: Hoernchen, laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-remsim/+/40570?usp=email ) Change subject: bankd: implicit remove a client mapping when creating a new mapping ...................................................................... Patch Set 3: (1 comment) File src/bankd/bankd_main.c: https://gerrit.osmocom.org/c/osmo-remsim/+/40570/comment/720f84d3_b770c3f7?… : PS3, Line 219: LOGPFSML(srvc->fi, LOGL_NOTICE, "slot already conntect to client %d:%d. Removing old mapping.\n", s/connctect/connected. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/40570?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Iae3f86a6e695e2d6580151b203df1dd0e2db625b Gerrit-Change-Number: 40570 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 02 Jul 2025 16:09:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 month

1
0
0 0

[S] Change in libosmo-sigtran[master]: Improve error log when adding >16 ASPs to an AS

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40571?usp=email ) Change subject: Improve error log when adding >16 ASPs to an AS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40571?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id9d13e6de24acd6465a099052a48c8b322a8f245 Gerrit-Change-Number: 40571 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 02 Jul 2025 16:08:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: remsim: bankd: add TC for creating a mapping with a busy client

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40568?usp=email ) Change subject: remsim: bankd: add TC for creating a mapping with a busy client ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40568?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I57112758167c2a29fae9df0cf1e2691c5a8e7bed Gerrit-Change-Number: 40568 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 02 Jul 2025 16:07:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 month

1
0
0 0

[S] Change in osmo-remsim[master]: bankd: implicit remove a client mapping when creating a new mapping

by lynxis lazus

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/40570?usp=email to look at the new patch set (#3). Change subject: bankd: implicit remove a client mapping when creating a new mapping ...................................................................... bankd: implicit remove a client mapping when creating a new mapping After a desynchronisation between the server and bankd happen (e.g. restart the server), the server might request a mapping between a client slot and a bankd slot while the bankd still has a different mapping for the same client slot. Example before this commit: * server -> bankd: New Mapping (client 1/0, bankd 1/0) * server <- bankd: Ack * Restart server * server -> bankd: New Mapping (client 1/0, bankd 2/0) * server <- bankd: Reject (commit change to Ack) Previous the second mapping got rejected, while the server had no chance of knowing or asking the bankd about the old mapping. Related: SYS#7470 Change-Id: Iae3f86a6e695e2d6580151b203df1dd0e2db625b --- M src/bankd/bankd_main.c 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/70/40570/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/40570?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Iae3f86a6e695e2d6580151b203df1dd0e2db625b Gerrit-Change-Number: 40570 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

1 month

1
0
0 0

[S] Change in libosmo-sigtran[master]: Improve error log when adding >16 ASPs to an AS

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40571?usp=email ) Change subject: Improve error log when adding >16 ASPs to an AS ...................................................................... Improve error log when adding >16 ASPs to an AS Change-Id: Id9d13e6de24acd6465a099052a48c8b322a8f245 --- M src/ss7_as.c M src/ss7_as_vty.c 2 files changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/71/40571/1 diff --git a/src/ss7_as.c b/src/ss7_as.c index fac5ffe..16da09f 100644 --- a/src/ss7_as.c +++ b/src/ss7_as.c @@ -169,6 +169,7 @@ } } + LOGPAS(as, DLSS7, LOGL_ERROR, "Failed adding ASP %s to AS, ASP table is full!\n", asp->cfg.name); return -ENOSPC; } diff --git a/src/ss7_as_vty.c b/src/ss7_as_vty.c index c34bbed..6ea170e 100644 --- a/src/ss7_as_vty.c +++ b/src/ss7_as_vty.c @@ -110,9 +110,15 @@ CMD_ATTR_IMMEDIATE) { struct osmo_ss7_as *as = vty->index; + int rc = osmo_ss7_as_add_asp(as, argv[0]); - if (osmo_ss7_as_add_asp(as, argv[0])) { - vty_out(vty, "cannot find ASP '%s'%s", argv[0], VTY_NEWLINE); + if (rc < 0) { + if (rc == -ENODEV) + vty_out(vty, "%% Cannot find ASP '%s'%s", argv[0], VTY_NEWLINE); + else if (rc == -ENOSPC) + vty_out(vty, + "%% Cannot associate ASP '%s' to AS '%s': ASP table for the AS is full!%s", + argv[0], as->cfg.name, VTY_NEWLINE); return CMD_WARNING; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40571?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id9d13e6de24acd6465a099052a48c8b322a8f245 Gerrit-Change-Number: 40571 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 month

1
0
0 0

[S] Change in osmo-remsim[master]: bankd: implicit remove a client mapping when creating a new mapping

by lynxis lazus

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/40570?usp=email to look at the new patch set (#2). Change subject: bankd: implicit remove a client mapping when creating a new mapping ...................................................................... bankd: implicit remove a client mapping when creating a new mapping After a desynchronisation between the server and bankd happen (e.g. restart the server), the server might request a mapping between a client slot and a bankd slot while the bankd still has a different mapping for the same client slot. Example before this commit: * server -> bankd: New Mapping (client 1/0, bankd 1/0) * server <- bankd: Ack * Restart server * server -> bankd: New Mapping (client 1/0, bankd 2/0) * server <- bankd: Reject (commit change to Ack) Previous the second mapping got rejected, while the server had no chance of knowing or asking the bankd to whats the old mapping was. Related: SYS#7470 Change-Id: Iae3f86a6e695e2d6580151b203df1dd0e2db625b --- M src/bankd/bankd_main.c 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/70/40570/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/40570?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Iae3f86a6e695e2d6580151b203df1dd0e2db625b Gerrit-Change-Number: 40570 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: remsim: bankd: add TC for creating a mapping with a busy client

by lynxis lazus

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40568?usp=email to look at the new patch set (#2). Change subject: remsim: bankd: add TC for creating a mapping with a busy client ...................................................................... remsim: bankd: add TC for creating a mapping with a busy client Test if a busy client is implicit removed when creating a new mapping for the same client with a different bankd slot. After a desynchronisation between the server and bankd happen (e.g. restart the server), the server might request a mapping between a client slot and a bankd slot while the bankd still has a different mapping for the same client slot. Example before this commit: * server -> bankd: New Mapping (client 1/0, bankd 1/0) * server <- bankd: Ack * Restart server * server -> bankd: New Mapping (client 1/0, bankd 2/0) * server <- bankd: Ack (implicit remove mapping to bankd 1/0) Related: SYS#7470 Change-Id: I57112758167c2a29fae9df0cf1e2691c5a8e7bed --- M remsim/RemsimBankd_Tests.ttcn 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/68/40568/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40568?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I57112758167c2a29fae9df0cf1e2691c5a8e7bed Gerrit-Change-Number: 40568 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

1 month

1
0
0 0

[S] Change in osmo-remsim[master]: bankd: implicit remove a client mapping when creating a new mapping

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/40570?usp=email ) Change subject: bankd: implicit remove a client mapping when creating a new mapping ...................................................................... bankd: implicit remove a client mapping when creating a new mapping After a desynchronisation between the server and bankd happen (e.g. restart the server), the server might request a mapping between a client slot and a bankd slot while the bankd still has a different mapping for the same client slot. Example before this commit: * server -> bankd: New Mapping (Client 1/0, Bankd 1/0) * server <- bankd: Ack * Restart server * server -> bankd: New Mapping (Client 1/0, Bankd 2/0) * server <- bankd: Reject (commit change to Ack) Previous the second mapping got rejected, while the server had no chance of knowing or asking the bankd to whats the old mapping was. Related: SYS#7470 Change-Id: Iae3f86a6e695e2d6580151b203df1dd0e2db625b --- M src/bankd/bankd_main.c 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/70/40570/1 diff --git a/src/bankd/bankd_main.c b/src/bankd/bankd_main.c index c43fe97..b7a94b6 100644 --- a/src/bankd/bankd_main.c +++ b/src/bankd/bankd_main.c @@ -207,7 +207,8 @@ } else { rspro2bank_slot(&bs, &creq->bank); rspro2client_slot(&cs, &creq->client); - /* check if map exists */ + + /* check if slot map exists */ map = slotmap_by_bank(g_bankd->slotmaps, &bs); if (map) { if (client_slot_equals(&map->client, &cs)) { @@ -215,10 +216,20 @@ resp = rspro_gen_CreateMappingRes(ResultCode_ok); goto send_resp; } else { - LOGPFSML(srvc->fi, LOGL_NOTICE, "implicitly removing slotmap\n"); + LOGPFSML(srvc->fi, LOGL_NOTICE, "slot already conntect to client %d:%d. Removing old mapping.\n", + map->client.client_id, map->client.slot_nr); bankd_srvc_remove_mapping(map); } } + + /* check if client map exists */ + map = slotmap_by_client(g_bankd->slotmaps, &cs); + if (map) { + LOGPFSML(srvc->fi, LOGL_NOTICE, "client already connected to slot %d:%d. Removing old mapping.\n", + map->bank.bank_id, map->bank.slot_nr); + bankd_srvc_remove_mapping(map); + } + /* Add a new mapping */ map = slotmap_add(g_bankd->slotmaps, &bs, &cs); if (!map) { -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/40570?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Iae3f86a6e695e2d6580151b203df1dd0e2db625b Gerrit-Change-Number: 40570 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2025