July 2025 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: Differentiate between dynamic and static routes

by pespin

Attention is currently required from: laforge, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40543?usp=email ) Change subject: Differentiate between dynamic and static routes ...................................................................... Patch Set 5: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40543/comment/cba04870_c991a… : PS5, Line 12: amic routes should not be stored in config, ie. not appear : during "show running-config" or "write running-config > (Not for this change, ideas) For a dynamic route, should the user allowed to ban a certain route? Or […] Yes, you can add a route with higher prio through vty. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40543?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic6c6b46084a1e4063ebf1f5d13e0e03386bb4c45 Gerrit-Change-Number: 40543 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 01 Jul 2025 13:55:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 4 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: pcu: TC_sns_del: improve test stability

by daniel

Attention is currently required from: lynxis lazus. daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40565?usp=email ) Change subject: pcu: TC_sns_del: improve test stability ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40565?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icb32e5f46ba7950848343efc46aee67e2397de5d Gerrit-Change-Number: 40565 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 01 Jul 2025 13:55:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 4 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: RAW_NS: SNS: allow to set the transaction id of Add/Chg/Del procedures

by lynxis lazus

lynxis lazus has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40566?usp=email ) Change subject: RAW_NS: SNS: allow to set the transaction id of Add/Chg/Del procedures ...................................................................... RAW_NS: SNS: allow to set the transaction id of Add/Chg/Del procedures Using hardcoded transaction ids are working, but for the TC_SNS_del it would result in descending transaction ids. Related: OS#6751 Change-Id: I1ea0424232ed925fee623568eb0edccdf1ae0368 --- M library/RAW_NS.ttcnpp 1 file changed, 15 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/40566/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40566?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1ea0424232ed925fee623568eb0edccdf1ae0368 Gerrit-Change-Number: 40566 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder

3 weeks, 4 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: PCU: TC_sns_del: use ascending transaction ids

by lynxis lazus

lynxis lazus has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40567?usp=email ) Change subject: PCU: TC_sns_del: use ascending transaction ids ...................................................................... PCU: TC_sns_del: use ascending transaction ids The test case TC_sns_del is doing 2 SNS transactions. One to prepare the test by changing the weight and a second to do the deletion of a NSVC. Do those 2 with ascending transaction ids. Related: OS#6751 Change-Id: I3dfeb02673745f324fd70e5abf03eed7667789d0 --- M pcu/PCU_Tests_SNS.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/67/40567/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40567?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3dfeb02673745f324fd70e5abf03eed7667789d0 Gerrit-Change-Number: 40567 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder

3 weeks, 4 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: PCU: TC_sns_del: use ascending transaction ids

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40567?usp=email ) Change subject: PCU: TC_sns_del: use ascending transaction ids ...................................................................... PCU: TC_sns_del: use ascending transaction ids The test case TC_sns_del is doing 2 SNS transactions. One to prepare the test by changing the weight and a second to do the deletion of a NSVC. Do those 2 with ascending transaction ids. Change-Id: I3dfeb02673745f324fd70e5abf03eed7667789d0 --- M pcu/PCU_Tests_SNS.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/67/40567/1 diff --git a/pcu/PCU_Tests_SNS.ttcn b/pcu/PCU_Tests_SNS.ttcn index c2fa927..698ed6a 100644 --- a/pcu/PCU_Tests_SNS.ttcn +++ b/pcu/PCU_Tests_SNS.ttcn @@ -354,11 +354,11 @@ testcase TC_sns_del() runs on RAW_Test_CT { f_sns_bringup_1c1u(); - f_outgoing_sns_chg_weight(idx_chg := 0, w_sig := 1, w_user := 1, idx := 0); + f_outgoing_sns_chg_weight(idx_chg := 0, w_sig := 1, w_user := 1, idx := 0, tid := 30); f_sleep(1.0); - f_TC_sns_del(); + f_TC_sns_del(tid := 31); f_clean_ns_codec(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40567?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3dfeb02673745f324fd70e5abf03eed7667789d0 Gerrit-Change-Number: 40567 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 4 days

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: RAW_NS: SNS: allow to set the transaction id of Add/Chg/Del procedures

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40566?usp=email ) Change subject: RAW_NS: SNS: allow to set the transaction id of Add/Chg/Del procedures ...................................................................... RAW_NS: SNS: allow to set the transaction id of Add/Chg/Del procedures Using hardcoded transaction ids are working, but for the TC_SNS_del it would result in descending transaction ids. Change-Id: I1ea0424232ed925fee623568eb0edccdf1ae0368 --- M library/RAW_NS.ttcnpp 1 file changed, 15 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/40566/1 diff --git a/library/RAW_NS.ttcnpp b/library/RAW_NS.ttcnpp index a7cdb8a..e7f32d2 100644 --- a/library/RAW_NS.ttcnpp +++ b/library/RAW_NS.ttcnpp @@ -498,7 +498,7 @@ NSCP[idx].send(ts_SNS_ACK(g_nsconfig.nsei, rx.pDU_SNS_Add.transactionID)); } -function f_outgoing_sns_add(integer idx_add, uint8_t w_sig := 1, uint8_t w_user := 1, integer idx := 0, template (omit) NsCause cause := omit) +function f_outgoing_sns_add(integer idx_add, uint8_t w_sig := 1, uint8_t w_user := 1, integer idx := 0, template (omit) NsCause cause := omit, integer tid := 23) runs on RAW_NS_CT { log("f_outgoing_sns_add(idx_add=", idx_add, ")"); var PDU_NS rx; @@ -512,8 +512,8 @@ if (isvalue(cause) and valueof(cause) == NS_CAUSE_UNKNOWN_IP_ENDPOINT) { ack_v4 := v4; } - NSCP[idx].send(ts_SNS_ADD(g_nsconfig.nsei, 23, v4)); - rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, 23, cause, ack_v4)); + NSCP[idx].send(ts_SNS_ADD(g_nsconfig.nsei, tid, v4)); + rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, tid, cause, ack_v4)); } else { var template (omit) IP6_Elements v6 := { ts_SNS_IPv6(nsvc_cfg.provider.ip.local_ip, nsvc_cfg.provider.ip.local_udp_port, @@ -522,8 +522,8 @@ if (isvalue(cause) and valueof(cause) == NS_CAUSE_UNKNOWN_IP_ENDPOINT) { ack_v6 := v6; } - NSCP[idx].send(ts_SNS_ADD(g_nsconfig.nsei, 23, omit, v6)); - rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, 23, cause, omit, ack_v6)); + NSCP[idx].send(ts_SNS_ADD(g_nsconfig.nsei, tid, omit, v6)); + rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, tid, cause, omit, ack_v6)); } } @@ -549,7 +549,7 @@ } -function f_outgoing_sns_del(integer idx_del, uint8_t w_sig := 1, uint8_t w_user := 1, integer idx := 0) +function f_outgoing_sns_del(integer idx_del, uint8_t w_sig := 1, uint8_t w_user := 1, integer idx := 0, integer tid := 24) runs on RAW_NS_CT { log("f_outgoing_sns_del(idx_del=", idx_del, ")"); var PDU_NS rx; @@ -558,18 +558,18 @@ var template (omit) IP4_Elements v4 := { ts_SNS_IPv4(nsvc_cfg.provider.ip.local_ip, nsvc_cfg.provider.ip.local_udp_port, w_sig, w_user) }; - NSCP[idx].send(ts_SNS_DEL(g_nsconfig.nsei, 24, omit, v4)); - rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, 24, omit, v4)); + NSCP[idx].send(ts_SNS_DEL(g_nsconfig.nsei, tid, omit, v4)); + rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, tid, omit, v4)); } else { var template (omit) IP6_Elements v6 := { ts_SNS_IPv6(nsvc_cfg.provider.ip.local_ip, nsvc_cfg.provider.ip.local_udp_port, w_sig, w_user) }; - NSCP[idx].send(ts_SNS_DEL(g_nsconfig.nsei, 24, omit, omit, v6)); - rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, 24, omit, omit, v6)); + NSCP[idx].send(ts_SNS_DEL(g_nsconfig.nsei, tid, omit, omit, v6)); + rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, tid, omit, omit, v6)); } } -function f_outgoing_sns_chg_weight(integer idx_chg, uint8_t w_sig, uint8_t w_user, integer idx := 0) +function f_outgoing_sns_chg_weight(integer idx_chg, uint8_t w_sig, uint8_t w_user, integer idx := 0, integer tid := 25) runs on RAW_NS_CT { log("f_outgoing_sns_chg_weight(idx_chg=", idx_chg, ")"); var PDU_NS rx; @@ -578,14 +578,14 @@ var template (omit) IP4_Elements v4 := { ts_SNS_IPv4(nsvc_cfg.provider.ip.local_ip, nsvc_cfg.provider.ip.local_udp_port, w_sig, w_user) }; - NSCP[idx].send(ts_SNS_CHG_WEIGHT(g_nsconfig.nsei, 25, v4)); - rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, 25, omit, omit)); + NSCP[idx].send(ts_SNS_CHG_WEIGHT(g_nsconfig.nsei, tid, v4)); + rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, tid, omit, omit)); } else { var template (omit) IP6_Elements v6 := { ts_SNS_IPv6(nsvc_cfg.provider.ip.local_ip, nsvc_cfg.provider.ip.local_udp_port, w_sig, w_user) }; - NSCP[idx].send(ts_SNS_CHG_WEIGHT(g_nsconfig.nsei, 25, omit, v6)); - rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, 25, omit, omit, omit)); + NSCP[idx].send(ts_SNS_CHG_WEIGHT(g_nsconfig.nsei, tid, omit, v6)); + rx := f_ns_exp(tr_SNS_ACK(g_nsconfig.nsei, tid, omit, omit, omit)); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40566?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1ea0424232ed925fee623568eb0edccdf1ae0368 Gerrit-Change-Number: 40566 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 4 days

1
0
0 0

[M] Change in pysim[master]: smdpp: less verbose by default

by lynxis lazus

Attention is currently required from: Hoernchen, dexter. lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/40468?usp=email ) Change subject: smdpp: less verbose by default ...................................................................... Patch Set 6: (4 comments) File osmo-smdpp.py: https://gerrit.osmocom.org/c/pysim/+/40468/comment/fe755d09_6e09e9cf?usp=em… : PS6, Line 112: #print("Using nameConstraints parsing for variant O certificate") Should this debug? Or not could you drop the line? https://gerrit.osmocom.org/c/pysim/+/40468/comment/d910e1e8_ea275842?usp=em… : PS6, Line 117: #print("Using GSMA permittedEins parsing for newer certificate variant") Should this debug? Or not could you drop the line? https://gerrit.osmocom.org/c/pysim/+/40468/comment/8ab4caee_de9dd93b?usp=em… : PS6, Line 362: #logger.debug("Rx JSON: %s" % json.dumps(content)) logger.debug()? or remove the line? https://gerrit.osmocom.org/c/pysim/+/40468/comment/20fed223_eb34ca1a?usp=em… : PS6, Line 370: logger.debug("Tx JSON: %s" % json.dumps(output)[:200]) Is this an expensive operations because the object is huge (json.dumps)? You could use `logger.debug("foo %s", foo), the logger will do the string replacement if debug is enabled. To save the json.dumps() in case debug is not present, you could hide it behind an if. `if logger.isEnabledFor(logging.DEBUG): logger.debug("Tx JSON: %s" % json.dumps(output)[:200]) ` -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40468?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I04a72b8f52417862d4dcba1f0743700dd942ef49 Gerrit-Change-Number: 40468 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 01 Jul 2025 13:08:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 weeks, 4 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: pcu: TC_sns_del: improve test stability

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40565?usp=email ) Change subject: pcu: TC_sns_del: improve test stability ...................................................................... pcu: TC_sns_del: improve test stability Add a sleep 1 to ensure the BSSGP flow Ack flows before removing the SNS. Further add a data weight to the other NSVC to have at least one valid NSVC with data weights. Otherwise the NSEI would become unavailable. Related: OS#6751 Change-Id: Icb32e5f46ba7950848343efc46aee67e2397de5d --- M pcu/PCU_Tests_SNS.ttcn 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/40565/1 diff --git a/pcu/PCU_Tests_SNS.ttcn b/pcu/PCU_Tests_SNS.ttcn index 3e7f81c..c2fa927 100644 --- a/pcu/PCU_Tests_SNS.ttcn +++ b/pcu/PCU_Tests_SNS.ttcn @@ -354,9 +354,11 @@ testcase TC_sns_del() runs on RAW_Test_CT { f_sns_bringup_1c1u(); + f_outgoing_sns_chg_weight(idx_chg := 0, w_sig := 1, w_user := 1, idx := 0); + + f_sleep(1.0); f_TC_sns_del(); - f_clean_ns_codec(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40565?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icb32e5f46ba7950848343efc46aee67e2397de5d Gerrit-Change-Number: 40565 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 4 days

1
0
0 0

[M] Change in libosmo-sigtran[master]: Differentiate between dynamic and static routes

by lynxis lazus

Attention is currently required from: laforge, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40543?usp=email ) Change subject: Differentiate between dynamic and static routes ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40543?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic6c6b46084a1e4063ebf1f5d13e0e03386bb4c45 Gerrit-Change-Number: 40543 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 01 Jul 2025 12:56:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 4 days

1
0
0 0

[M] Change in libosmo-sigtran[master]: Differentiate between dynamic and static routes

by lynxis lazus

Attention is currently required from: laforge, pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40543?usp=email ) Change subject: Differentiate between dynamic and static routes ...................................................................... Patch Set 5: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40543/comment/043059b7_a6e63… : PS5, Line 12: amic routes should not be stored in config, ie. not appear : during "show running-config" or "write running-config (Not for this change, ideas) For a dynamic route, should the user allowed to ban a certain route? Or blackhole it via vty? I mean if a dynamic route is wrong, is it possible to overwrite it by a manual route? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40543?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic6c6b46084a1e4063ebf1f5d13e0e03386bb4c45 Gerrit-Change-Number: 40543 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 01 Jul 2025 12:56:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 weeks, 4 days

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2025