June 2025 - gerrit-log - lists.osmocom.org

[L] Change in osmo-ttcn3-hacks[master]: 5gc: Implement AKA authentication

by Jenkins Builder

Attention is currently required from: daniel, fixeria, jolly, laforge. Jenkins Builder has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413?usp=email ) Change subject: 5gc: Implement AKA authentication ...................................................................... Patch Set 4: (11 comments) File 5gc/key_derivation.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/3ea30a49_1a51… : PS4, Line 49: } adding a line without newline at end of file File 5gc/milenage.c: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/02b2c656_57c9… : PS4, Line 30: typedef struct ast_aes { do not add new typedefs Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/2695cbe0_5008… : PS4, Line 31: unsigned char raw[AST_CRYPTO_AES_BLOCKSIZE / 8]; code indent should use tabs where possible Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/a21e0ede_fff7… : PS4, Line 31: unsigned char raw[AST_CRYPTO_AES_BLOCKSIZE / 8]; please, no spaces at the start of a line Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/53f0b3c6_8e3d… : PS4, Line 36: if (key == NULL || ctx == NULL) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/7cd957de_5b23… : PS4, Line 49: if ((ctx = EVP_CIPHER_CTX_new()) == NULL) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/e937821a_367b… : PS4, Line 54: if ((res = EVP_CipherInit(ctx, EVP_aes_128_ecb(), key->raw, NULL, 1)) <= 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/ae54d109_17b5… : PS4, Line 58: if ((res = EVP_CipherUpdate(ctx, out, &outlen, in, inlen)) <= 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/a5839687_fb2b… : PS4, Line 62: if ((res = EVP_CipherFinal(ctx, final, &finallen)) <= 0) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/35aa138a_7243… : PS4, Line 80: exit (0); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413/comment/4609f1a6_39ea… : PS4, Line 105: for (p = s, f = 0; f < len; f++, p += 3) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I11527f47e4310863124f3f02148e3f71da7d911e Gerrit-Change-Number: 40413 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Jun 2025 15:21:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 weeks, 6 days

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: 5gc: Implement AKA authentication

by pespin

Attention is currently required from: daniel, fixeria, jolly, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413?usp=email ) Change subject: 5gc: Implement AKA authentication ...................................................................... Patch Set 4: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40413?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I11527f47e4310863124f3f02148e3f71da7d911e Gerrit-Change-Number: 40413 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Jun 2025 15:21:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

2 weeks, 6 days

1
0
0 0

[S] Change in osmo-msc[master]: vlr: extend the subscriber invalidate callback with reasons

by pespin

Attention is currently required from: lynxis lazus, neels. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email ) Change subject: vlr: extend the subscriber invalidate callback with reasons ...................................................................... Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie5b687318b106a230fcee52deba86649641004b3 Gerrit-Change-Number: 38488 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 03 Jun 2025 13:56:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 6 days

1
0
0 0

[S] Change in osmo-msc[master]: vlr: extend the subscriber invalidate callback with reasons

by lynxis lazus

Attention is currently required from: lynxis lazus, neels. Hello Jenkins Builder, neels, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Code-Review+2 by neels, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: vlr: extend the subscriber invalidate callback with reasons ...................................................................... vlr: extend the subscriber invalidate callback with reasons The VLR must be allowed to notify the MSC if a subscriber becomes invalid. There are multiple cases when this happens: a) if the subscriber didn't do a Location Update Procedure within the given periodic timer. b) if the HLR does a Cancel Location Procedure with reason withdraw c) if the HLR does a Cancel Location Procedure with reason update location. d) duplicate entries (unsure if this is valid, but keeping the code as is) Change-Id: Ie5b687318b106a230fcee52deba86649641004b3 --- M include/osmocom/vlr/vlr.h M src/libmsc/gsm_04_08.c M src/libvlr/vlr.c 3 files changed, 11 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/88/38488/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie5b687318b106a230fcee52deba86649641004b3 Gerrit-Change-Number: 38488 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

2 weeks, 6 days

1
0
0 0

[XS] Change in osmo-msc[master]: libvlr: replace strncpy with OSMO_STRLCPY_ARRAY

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, daniel, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/39565?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: libvlr: replace strncpy with OSMO_STRLCPY_ARRAY ...................................................................... libvlr: replace strncpy with OSMO_STRLCPY_ARRAY The compile warns about these strncpys because they might not null terminated. Even the next line ensures this. Also replace osmo_strlcpy with OSMO_STRLCPY_ARRAY when possible. Change-Id: I96a27ef42cb06dd2365f5c9902933323c7caf9a8 --- M src/libvlr/vlr_auth_fsm.c M src/libvlr/vlr_lu_fsm.c M src/libvlr/vlr_sgs.c 3 files changed, 3 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/65/39565/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39565?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I96a27ef42cb06dd2365f5c9902933323c7caf9a8 Gerrit-Change-Number: 39565 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

2 weeks, 6 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/MGCP_Emulation: Fix Dynamic test case error returning unbound...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40417?usp=email ) Change subject: library/MGCP_Emulation: Fix Dynamic test case error returning unbound value ...................................................................... library/MGCP_Emulation: Fix Dynamic test case error returning unbound value As spotted today while running HNBGW_Tests.TC_rab_assignment, probably after upgrade to titan 11: 17:54:36.223786 1570 MGCP_Emulation.ttcn:241 Dynamic test case error: Copying an unbound charstring value. The error happened because in that failure path the component running the function was not stopped, and hence an unset variable was returned. Hence, make sure we tear everything down (including component going through the failure path). Change-Id: Id1d28924e90ed80199b61a143dac35fc6f50de68 --- M library/MGCP_Emulation.ttcn 1 file changed, 29 insertions(+), 24 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/library/MGCP_Emulation.ttcn b/library/MGCP_Emulation.ttcn index 7106f63..8dd3d3f 100644 --- a/library/MGCP_Emulation.ttcn +++ b/library/MGCP_Emulation.ttcn @@ -35,6 +35,7 @@ import from MGCP_Templates all; import from Osmocom_Types all; import from IPL4asp_Types all; +import from Misc_Helpers all; type component MGCP_ConnHdlr { /* Simple send/recv without caring about peer addr+port. Used with multi_conn_mode=false. */ @@ -149,8 +150,9 @@ return MgcpEndpointTable[i].comp_ref; } } - setverdict(fail, "MGCP Endpoint Table not found by Endpoint", ep); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("MGCP Endpoint Table not found by Endpoint", ep)); + return MgcpEndpointTable[0].comp_ref; /* Make compiler happy returning something */ } private function f_ep_by_comp(MGCP_ConnHdlr client) @@ -161,8 +163,9 @@ return MgcpEndpointTable[i].endpoint; } } - setverdict(fail, "MGCP Endpoint Table not found by component ", client); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("MGCP Endpoint Table not found by component ", client)); + return MgcpEndpointTable[0].endpoint; /* Make compiler happy returning something */ } private function f_ep_table_add(MGCP_ConnHdlr comp_ref, MgcpEndpoint ep) @@ -175,7 +178,7 @@ return; } } - testcase.stop("MGCP Endpoint Table full!"); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "MGCP Endpoint Table full!"); } private function f_ep_table_del(MGCP_ConnHdlr comp_ref, MgcpEndpoint ep) @@ -189,8 +192,8 @@ return; } } - setverdict(fail, "MGCP Endpoint Table: Couldn't find to-be-deleted entry!"); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("MGCP Endpoint Table: Couldn't find to-be-deleted entry!")); } private function f_ep_table_change_connhdlr(MGCP_ConnHdlr comp_ref, MgcpEndpoint ep) @@ -203,8 +206,8 @@ return; } } - setverdict(fail, "MGCP Endpoint Table: Couldn't find entry to move to ", comp_ref); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("MGCP Endpoint Table: Couldn't find entry to move to ", comp_ref)); } /* Check if the given transaction ID is a pending CRCX. If yes, return true + remove */ @@ -235,8 +238,8 @@ } else { var MgcpEndpoint ep; if (f_mgcp_find_param(msg, "Z", ep) == false) { - setverdict(fail, "No SpecificEndpointName in MGCP response", msg); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("No SpecificEndpointName in MGCP response", msg)); } return ep; } @@ -280,8 +283,8 @@ res := MGCP_CodecPort_CtrlFunct.f_IPL4_connect(MGCP, p.callagent_ip, p.callagent_udp_port, p.mgw_ip, p.mgw_udp_port, -1, { udp:={} }); } if (not ispresent(res.connId)) { - setverdict(fail, "Could not connect MGCP socket, check your configuration"); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Could not connect MGCP socket, check your configuration")); } g_mgcp_conn_id := res.connId; @@ -329,8 +332,8 @@ p.callagent_udp_port := mrf.remPort; res := MGCP_CodecPort_CtrlFunct.f_IPL4_connect(MGCP, p.callagent_ip, p.callagent_udp_port, p.mgw_ip, p.mgw_udp_port, g_mgcp_conn_id, { udp:={} }); if (not ispresent(res.connId)) { - setverdict(fail, "Could not connect MGCP socket, check your configuration"); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Could not connect MGCP socket, check your configuration")); } } if (ischosen(mrf.msg.command)) { @@ -358,8 +361,8 @@ } } } else { - setverdict(fail, "Received unexpected MGCP response: ", mrf.msg.response); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Received unexpected MGCP response: ", mrf.msg.response)); } } [] MGCP_PROC.getcall(MGCPEM_register:{?,?}) -> param(crit, vc_conn) { @@ -448,8 +451,9 @@ return ret; } } - setverdict(fail, "Couldn't find Expect for CRCX", cmd); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Couldn't find Expect for CRCX", cmd)); + return MgcpExpectTable[0].vc_conn; /* Make compiler happy returning something */ } private function f_create_expect(ExpectCriteria crit, MGCP_ConnHdlr hdlr) @@ -459,8 +463,8 @@ /* Check an entry like this is not already present */ for (i := 0; i < sizeof(MgcpExpectTable); i := i+1) { if (crit == MgcpExpectTable[i].crit) { - setverdict(fail, "Crit already present", crit); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Crit already present", crit)); } } for (i := 0; i < sizeof(MgcpExpectTable); i := i+1) { @@ -471,7 +475,7 @@ return; } } - testcase.stop("No space left in MgcpExpectTable") + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "No space left in MgcpExpectTable"); } /* client/conn_hdlr side function to use procedure port to create expect in emulation */ @@ -528,8 +532,9 @@ return "AMR-WB"; } - setverdict(fail, "Unknown payload type ", pt); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Unknown payload type ", pt)); + return ""; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40417?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id1d28924e90ed80199b61a143dac35fc6f50de68 Gerrit-Change-Number: 40417 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 6 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/MGCP_Emulation: Fix Dynamic test case error returning unbound...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40417?usp=email ) Change subject: library/MGCP_Emulation: Fix Dynamic test case error returning unbound value ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40417/comment/1d49e65d_0b3c… : PS1, Line 10: MGCP_Emulation.ttcn:241 Dynamic test case error: Copying an unbound charstring value. BTW, this is due to a bug in TITAN 11.0.0: https://paste.debian.net/1377895/ (`TC_selftest` is failing) which has been fixed (https://gitlab.eclipse.org/eclipse/titan/titan.core/-/issues/752) in 11.1.0. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40417?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id1d28924e90ed80199b61a143dac35fc6f50de68 Gerrit-Change-Number: 40417 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Jun 2025 09:20:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

2 weeks, 6 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: library/MGCP_Emulation: Fix Dynamic test case error returning unbound...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40417?usp=email ) Change subject: library/MGCP_Emulation: Fix Dynamic test case error returning unbound value ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40417?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id1d28924e90ed80199b61a143dac35fc6f50de68 Gerrit-Change-Number: 40417 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 03 Jun 2025 09:18:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

2 weeks, 6 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: allow passing -j/--jobs together with -b/--binary-repo

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40418?usp=email ) Change subject: testenv: allow passing -j/--jobs together with -b/--binary-repo ...................................................................... testenv: allow passing -j/--jobs together with -b/--binary-repo Not only the -j/--jobs is used when building the IUT components, but also when building the testsuite itself (PARALLEL_MAKE var). Change-Id: I3eb596f2c4e5de1b624c238e34785e798d2099c3 --- M _testenv/testenv/__init__.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/_testenv/testenv/__init__.py b/_testenv/testenv/__init__.py index 6118b65..9b5e944 100644 --- a/_testenv/testenv/__init__.py +++ b/_testenv/testenv/__init__.py @@ -87,7 +87,6 @@ group.add_argument("-i", "--io-uring", action="store_true", help="set LIBOSMO_IO_BACKEND=IO_URING") group = sub_run.add_argument_group("source/binary options", "All components are built from source by default.") - group = group.add_mutually_exclusive_group() group.add_argument( "-b", "--binary-repo", -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40418?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3eb596f2c4e5de1b624c238e34785e798d2099c3 Gerrit-Change-Number: 40418 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

2 weeks, 6 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: Makefile: add global per-project clean target

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40409?usp=email ) Change subject: Makefile: add global per-project clean target ...................................................................... Makefile: add global per-project clean target Change-Id: I434ecbe3f3dd25ea770d8f2d7adfa62c67dc0c1d --- M Makefile 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/Makefile b/Makefile index c64e130..7a9ddb8 100644 --- a/Makefile +++ b/Makefile @@ -114,6 +114,12 @@ @git clean -fx "$(1)" endef +define DIR_clean_template +.PHONY: $(1)/clean +$(1)/clean: + $(MAKE) -C $(BUILDDIR)/$(1) clean +endef + define DIR_all_template $(1): $(1)/all .PHONY: $(1)/all @@ -126,6 +132,7 @@ $(eval $(call DIR_Makefile_template,$(dir))) \ $(eval $(call DIR_compile_template,$(dir))) \ $(eval $(call DIR_clean_old_template,$(dir))) \ + $(eval $(call DIR_clean_template,$(dir))) \ $(eval $(call DIR_all_template,$(dir))) \ ) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40409?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I434ecbe3f3dd25ea770d8f2d7adfa62c67dc0c1d Gerrit-Change-Number: 40409 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

2 weeks, 6 days

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2025