Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40416?usp=email )
Change subject: testenv: run "make deps" every time
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40416?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I02668530ce36c51a1c641fb816464c9c8e6ded9e
Gerrit-Change-Number: 40416
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 02 Jun 2025 08:50:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40416?usp=email )
Change subject: testenv: run "make deps" every time
......................................................................
testenv: run "make deps" every time
The previous logic of not always running "make deps" was useful when
"make deps" would take a long time to complete even if there were no
changes. But this has been fixed in c7e40d6a ("Makefile: avoid fetching
deps if not needed"). Run it every time now in order to fix that deps
are not updated after deps/Makefile gets changed.
Change-Id: I02668530ce36c51a1c641fb816464c9c8e6ded9e
---
M _testenv/testenv/testsuite.py
1 file changed, 1 insertion(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/16/40416/1
diff --git a/_testenv/testenv/testsuite.py b/_testenv/testenv/testsuite.py
index 5ddbf3e..6d0335e 100644
--- a/_testenv/testenv/testsuite.py
+++ b/_testenv/testenv/testsuite.py
@@ -19,14 +19,8 @@
def update_deps():
- deps_marker = os.path.join(testenv.args.cache, "ttcn3-deps-updated")
- if os.path.exists(deps_marker):
- return
-
logging.info("Updating osmo-ttcn3-hacks/deps")
- deps_dir = os.path.join(ttcn3_hacks_dir, "deps")
- testenv.cmd.run(["make", "-C", deps_dir])
- testenv.cmd.run(["touch", deps_marker])
+ testenv.cmd.run(["make", "deps"], cwd=ttcn3_hacks_dir)
def prepare_testsuite_dir():
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40416?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I02668530ce36c51a1c641fb816464c9c8e6ded9e
Gerrit-Change-Number: 40416
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40405?usp=email )
Change subject: 5gc: Fix upfd failing to start outside podman
......................................................................
Patch Set 5:
(2 comments)
File 5gc/open5gs/testenv.sh:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40405/comment/b13e30e2_c7ef… :
PS5, Line 7: echo "Run 'testenv.py run ggsn' instead."
```suggestion
echo "Run 'testenv.py run 5gc' instead."
```
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40405/comment/52092bfc_f5a9… :
PS5, Line 74: ;;
clean up in case of crash and when done:
```suggestion
del_tun_all
;;
```
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40405?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5d3e0c3b7391d312304190acf07b347320481275
Gerrit-Change-Number: 40405
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 02 Jun 2025 07:14:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40412?usp=email )
Change subject: 5gc: Initial NAS transmitting support
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40412?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I951e98217b0150eed58fabb8e50a4782c1a3b510
Gerrit-Change-Number: 40412
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 02 Jun 2025 07:08:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40414?usp=email )
Change subject: bts: f_init(): print testcasename() in the IUT's logs
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40414?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I16136f32d7143edfc1638e359ef5b1066c248732
Gerrit-Change-Number: 40414
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 02 Jun 2025 06:30:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40415?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: bsc: fix race condition in RSLEm
......................................................................
bsc: fix race condition in RSLEm
It may happen that the RSLEm component receives a DChan message
earlier than we suspend the DChan processing. We saw this once:
RSL for unknown Dchan
BSC_Tests.ttcn:12769 BSC_Tests control part
BSC_Tests.ttcn:5888 TC_ho_int_a5_4 testcase
Let's guard against this by calling f_rslem_suspend() earlier.
Change-Id: I012d4db05538d294a6b4aa85be4a40bb0bad28a3
---
M bsc/BSC_Tests.ttcn
1 file changed, 9 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/15/40415/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40415?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I012d4db05538d294a6b4aa85be4a40bb0bad28a3
Gerrit-Change-Number: 40415
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40415?usp=email )
Change subject: bsc: fix race condition in f_tc_ho_int()
......................................................................
bsc: fix race condition in f_tc_ho_int()
It may happen that the RSLEm component receives a Handover Command
earlier than we suspend the DChan processing. We saw this once:
RSL for unknown Dchan
BSC_Tests.ttcn:12769 BSC_Tests control part
BSC_Tests.ttcn:5888 TC_ho_int_a5_4 testcase
Let's guard against this by calling f_rslem_suspend() earlier.
Change-Id: I012d4db05538d294a6b4aa85be4a40bb0bad28a3
---
M bsc/BSC_Tests.ttcn
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/15/40415/1
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 1badaa5..54c9897 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -5781,10 +5781,11 @@
old_chan_nr := -,
expect_target_tsc := c_BtsParams[1].tsc
};
- /* issue hand-over command on VTY, from BTS 0 to BTS 1 */
- f_vty_handover(BSCVTY, 0, 0, g_chan_nr, 1);
+
/* temporarily suspend DChan processing on BTS1 to avoid race with RSLEM_register */
f_rslem_suspend(RSL1_PROC);
+ /* issue hand-over command on VTY, from BTS 0 to BTS 1 */
+ f_vty_handover(BSCVTY, 0, 0, g_chan_nr, 1);
/* From the MGW perspective, a handover is is characterized by
* performing one MDCX operation with the MGW. So we expect to see
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40415?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I012d4db05538d294a6b4aa85be4a40bb0bad28a3
Gerrit-Change-Number: 40415
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
