osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40427?usp=email )
Change subject: OBS: remove libosmo-sccp-legacy
......................................................................
OBS: remove libosmo-sccp-legacy
Stop building libosmo-sccp-legacy, which is not needed anymore since
osmo-msc 1.13.0 has been tagged some time ago.
Change-Id: I086e3eff10e79bddd8ec23927b46cc58a7101de6
---
M scripts/obs/lib/config.py
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/27/40427/1
diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py
index c6f373e..dc67757 100644
--- a/scripts/obs/lib/config.py
+++ b/scripts/obs/lib/config.py
@@ -58,7 +58,6 @@
"libosmo-gprs",
"libosmo-netif",
"libosmo-pfcp",
- "libosmo-sccp-legacy", # can be dropped after osmo-msc >= 1.12.x release
"libosmo-sigtran",
"libosmocore",
"libsmpp34",
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40427?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I086e3eff10e79bddd8ec23927b46cc58a7101de6
Gerrit-Change-Number: 40427
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Attention is currently required from: jolly.
laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/40423?usp=email )
Change subject: Corrected decoding of MSISDN IE and IMEI IE
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/40423?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: Idd2bee3d8f662d028001392cfd0332a265fbc91a
Gerrit-Change-Number: 40423
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 04 Jun 2025 13:21:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40424?usp=email )
Change subject: Corrected description of MSISDN IE and IMEI IE coding
......................................................................
Corrected description of MSISDN IE and IMEI IE coding
1 2 3 4 5 6 7 8
+-------------------------------+
| MSISDN IE type |Res| octet 1
+-------------------------------+
| Length of IE content | octet 2
+-------------------------------+
| Length of BCD content | octet 3
+-------------------------------+
| Digit 1 | Digit 2 | octet 4..n
| .... | |
+-------------------------------+
The length of the BCD content specifies how many subsequent octets
contain BCD data (it does *not* indicate the number of digits).
This length must be less than the total length of the IE content.
Any octets following the BCD content shall be ignored.
Related: OS#6797
Change-Id: I4db05e4a01199334b75fffd60270b88f541b98f4
---
M common/chapters/gsup.adoc
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/common/chapters/gsup.adoc b/common/chapters/gsup.adoc
index f5cce14..824ac90 100644
--- a/common/chapters/gsup.adoc
+++ b/common/chapters/gsup.adoc
@@ -1510,6 +1510,10 @@
BCD Number in 3GPP TS 24.008. It will be stored by the SGSN or VLR and then passed as is
to the GGSN during the activation of the primary PDP Context.
+The length of the BCD content specifies how many subsequent octets contain BCD data
+(it does *not* indicate the number of digits). This length must be less than the total
+length of the IE content. Any octets following the BCD content shall be ignored.
+
[packetdiag]
----
{
@@ -1519,9 +1523,7 @@
0-6: PDP type IEI
7: Res
8-15: Length of IE content
- 16-19: NPI
- 20-22: TON
- 23: ext
+ 16-23: Length of BCD content
24-27: Digit 1
28-31: Digit 2
32-35: Digit ...
@@ -1628,6 +1630,7 @@
==== IMEI
The IMEI encoded as Called Party BCD Number in 3GPP TS 24.008.
+This IE has the same format as described in <<gsup-ie-msisdn>>.
[[gsup-ie-imei-result]]
==== IMEI Check Result
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40424?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I4db05e4a01199334b75fffd60270b88f541b98f4
Gerrit-Change-Number: 40424
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40421?usp=email )
Change subject: S1AP_Emulation: Remove commented duplicated function
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40421?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1d6871d2a735a4bf39c87f6c976bd5d5630e9c04
Gerrit-Change-Number: 40421
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Jun 2025 13:16:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40420?usp=email )
Change subject: mme: Move LTE_CryptoFunction* to library/
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40420?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I76f86beeb2c49110eea0fac6abffee8307a3c22c
Gerrit-Change-Number: 40420
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Jun 2025 13:16:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes