Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email )
Change subject: asp: Introduce support to configure and enable TCP keep-alive
......................................................................
Patch Set 2:
(1 comment)
File src/ss7_asp_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481/comment/dd48b83f_46a23… :
PS2, Line 512: "num-ostreams"
> Where these values are coming from? […]
Acknowledged
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I2a9338053e741fb6dab94492c6bdc2badaf7afb1
Gerrit-Change-Number: 40481
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Jun 2025 14:13:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: daniel, fixeria, laforge, osmith, pespin.
Hello Jenkins Builder, daniel, fixeria, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-netif/+/40478?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: stream: Support configuring TCP keep-alive pars
......................................................................
stream: Support configuring TCP keep-alive pars
for servers, the param can either be set on the link (which will be
automatically inherited/applied for all accepted conn sockets), or can
be set specifically on a srv conn socket.
The second is useful when user can supply different parameters for different
clients connected to the listening socket, eg. ASP configuration in
libosmo-sigtran.
Change-Id: Ie748ad581c1c42f4c24f9409ce7d34d419cbca8b
---
M TODO-RELEASE
M include/osmocom/netif/stream.h
M include/osmocom/netif/stream_private.h
M src/stream.c
M src/stream_cli.c
M src/stream_srv.c
6 files changed, 232 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/78/40478/3
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/40478?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ie748ad581c1c42f4c24f9409ce7d34d419cbca8b
Gerrit-Change-Number: 40478
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/40485?usp=email )
Change subject: stream_srv: Improve API documentation
......................................................................
stream_srv: Improve API documentation
Change-Id: Ib41eeef3a21ec55a175b6bbb818d05c091b46df5
---
M src/stream_srv.c
1 file changed, 9 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/85/40485/1
diff --git a/src/stream_srv.c b/src/stream_srv.c
index be950ce..5ffb28b 100644
--- a/src/stream_srv.c
+++ b/src/stream_srv.c
@@ -628,7 +628,7 @@
}
/*! Set given parameter of stream_srv_link to given value.
- * \param[in] cli stream client on which to set parameter.
+ * \param[in] link stream server link on which to set parameter.
* \param[in] par identifier of the parameter to be set.
* \param[in] val value of the parameter to be set.
* \param[in] val_len length of the parameter value.
@@ -916,7 +916,10 @@
* \param[in] read_cb Call-back to call when the socket is readable
* \param[in] closed_cb Call-back to call when the connection is closed
* \param[in] data User data to save in the new Stream Server struct
- * \returns Stream Server in case of success; NULL on error */
+ * \returns Stream Server in case of success; NULL on error
+ *
+ * Note: In case of error, the caller is responsible for closing the fd.
+ */
struct osmo_stream_srv *
osmo_stream_srv_create(void *ctx, struct osmo_stream_srv_link *link, int fd,
osmo_stream_srv_read_cb_t read_cb,
@@ -959,7 +962,10 @@
* \param[in] link Stream Server Link to which we belong
* \param[in] fd system file descriptor of the new connection
* \param[in] data User data to save in the new Stream Server struct
- * \returns Stream Server in case of success; NULL on error */
+ * \returns Stream Server in case of success; NULL on error
+ *
+ * Note: In case of error, the caller is responsible for closing the fd.
+ */
struct osmo_stream_srv *
osmo_stream_srv_create2(void *ctx, struct osmo_stream_srv_link *link, int fd, void *data)
{
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/40485?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ib41eeef3a21ec55a175b6bbb818d05c091b46df5
Gerrit-Change-Number: 40485
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/40479?usp=email )
Change subject: stream: Support configuring TCP_USER_TIMEOUT parameter
......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/netif/stream_private.h:
https://gerrit.osmocom.org/c/libosmo-netif/+/40479/comment/b2d41628_87b7b15… :
PS2, Line 52: stream_setsockopt_tcp_user_timeout
> cosmetic: move it above, closer to the other `stream_setsockopt_tcp_*()` API.
No, imho it belongs here below the tcp_pars struct.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/40479?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I22c7df92b463cf4ca82854a12ec24337d53e8b20
Gerrit-Change-Number: 40479
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Jun 2025 14:04:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email )
Change subject: asp: Introduce support to configure and enable TCP keep-alive
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
File src/ss7_asp.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481/comment/a71e40f6_ac62e… :
PS2, Line 800: rc =
You're assigning a value to `rc`, but then after the `switch` it gets overwritten.
File src/ss7_asp_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481/comment/15830fce_6cc78… :
PS2, Line 512: "num-ostreams"
Where these values are coming from?
They're not part of `ASP_TCP_PARAM_KEEPALIVE_CFG_FIELDS`.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I2a9338053e741fb6dab94492c6bdc2badaf7afb1
Gerrit-Change-Number: 40481
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Jun 2025 12:57:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: daniel, laforge, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/40478?usp=email )
Change subject: stream: Support configuring TCP keep-alive pars
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/stream_srv.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/40478/comment/486b5b12_a4bc176… :
PS2, Line 1004: Note: In case of error, the caller is responsible for closing the fd.
looks unrelated
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/40478?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ie748ad581c1c42f4c24f9409ce7d34d419cbca8b
Gerrit-Change-Number: 40478
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Jun 2025 12:39:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes