June 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bsc[master]: meas_feed: Increase default txqueue len to 1024

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40496?usp=email ) Change subject: meas_feed: Increase default txqueue len to 1024 ...................................................................... meas_feed: Increase default txqueue len to 1024 Depending on the BSC size we potentially have a very large number of measurement reports. They occur every 480ms on each active logical channel, so with a 4-TRX BTS of 12 SDCCH + 60 TCH/H we have up to 144 measurement reports per second per BTS. Therefore, a BSC-global meas_feed transmit queue limit of 100 msgb might be a bit low. This also follows the default osmo_io txqueue len which was increased recently to 1024. Related: SYS#7508 Change-Id: Ib4382adc05cf6776952801ad7edad230db1ec454 --- M include/osmocom/bsc/meas_feed.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, approved diff --git a/include/osmocom/bsc/meas_feed.h b/include/osmocom/bsc/meas_feed.h index 447eab8..5aa4606 100644 --- a/include/osmocom/bsc/meas_feed.h +++ b/include/osmocom/bsc/meas_feed.h @@ -35,7 +35,7 @@ }; #define MEAS_FEED_VERSION 1 -#define MEAS_FEED_TXQUEUE_MAX_LEN_DEFAULT 100 +#define MEAS_FEED_TXQUEUE_MAX_LEN_DEFAULT 1024 int meas_feed_cfg_set(const char *dst_host, uint16_t dst_port); void meas_feed_scenario_set(const char *name); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40496?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib4382adc05cf6776952801ad7edad230db1ec454 Gerrit-Change-Number: 40496 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 days, 6 hours

1
0
0 0

[XS] Change in osmo-bsc[master]: meas_feed: Increase default txqueue len to 1024

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40496?usp=email ) Change subject: meas_feed: Increase default txqueue len to 1024 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40496?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib4382adc05cf6776952801ad7edad230db1ec454 Gerrit-Change-Number: 40496 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 20 Jun 2025 12:49:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 days, 6 hours

1
0
0 0

[XS] Change in osmo-bsc[master]: meas_feed: Increase default txqueue len to 1024

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40496?usp=email ) Change subject: meas_feed: Increase default txqueue len to 1024 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40496?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib4382adc05cf6776952801ad7edad230db1ec454 Gerrit-Change-Number: 40496 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Jun 2025 12:48:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 days, 6 hours

1
0
0 0

[XS] Change in osmo-bsc[master]: meas_feed: Increase default txqueue len to 1024

by laforge

laforge has uploaded a new patch set (#2) to the change originally created by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40496?usp=email ) Change subject: meas_feed: Increase default txqueue len to 1024 ...................................................................... meas_feed: Increase default txqueue len to 1024 Depending on the BSC size we potentially have a very large number of measurement reports. They occur every 480ms on each active logical channel, so with a 4-TRX BTS of 12 SDCCH + 60 TCH/H we have up to 144 measurement reports per second per BTS. Therefore, a BSC-global meas_feed transmit queue limit of 100 msgb might be a bit low. This also follows the default osmo_io txqueue len which was increased recently to 1024. Related: SYS#7508 Change-Id: Ib4382adc05cf6776952801ad7edad230db1ec454 --- M include/osmocom/bsc/meas_feed.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/96/40496/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40496?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib4382adc05cf6776952801ad7edad230db1ec454 Gerrit-Change-Number: 40496 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

3 days, 6 hours

1
0
0 0

[XS] Change in osmo-bsc[master]: meas_feed: change default transmit queue length from 100 to 1000

by laforge

laforge has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40497?usp=email ) Change subject: meas_feed: change default transmit queue length from 100 to 1000 ...................................................................... Abandoned duplicate of 40496 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40497?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd038a14690ab0e0af4f8df8239ec23df37e468 Gerrit-Change-Number: 40497 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de>

3 days, 6 hours

1
0
0 0

[XS] Change in osmo-bsc[master]: meas_feed: change default transmit queue length from 100 to 1000

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40497?usp=email ) Change subject: meas_feed: change default transmit queue length from 100 to 1000 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: https://gerrit.osmocom.org/c/osmo-bsc/+/40496 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40497?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd038a14690ab0e0af4f8df8239ec23df37e468 Gerrit-Change-Number: 40497 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 20 Jun 2025 12:46:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

3 days, 6 hours

1
0
0 0

[XS] Change in osmo-bsc[master]: meas_feed: change default transmit queue length from 100 to 1000

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40497?usp=email ) Change subject: meas_feed: change default transmit queue length from 100 to 1000 ...................................................................... meas_feed: change default transmit queue length from 100 to 1000 Depending on the BSC size we potentially have a very large number of measurement reports. They occur every 480ms on each active logical channel, so with a 4-TRX BTS of 12 SDCCH + 60 TCH/H we have up to 144 measurement reports per second per BTS. Therefore, a BSC-global meas_feed transmit queue limit of 100 msgb might be a bit low. Change-Id: Icdd038a14690ab0e0af4f8df8239ec23df37e468 Related: SYS#7508 --- M include/osmocom/bsc/meas_feed.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/97/40497/1 diff --git a/include/osmocom/bsc/meas_feed.h b/include/osmocom/bsc/meas_feed.h index 447eab8..23ebdc7 100644 --- a/include/osmocom/bsc/meas_feed.h +++ b/include/osmocom/bsc/meas_feed.h @@ -35,7 +35,7 @@ }; #define MEAS_FEED_VERSION 1 -#define MEAS_FEED_TXQUEUE_MAX_LEN_DEFAULT 100 +#define MEAS_FEED_TXQUEUE_MAX_LEN_DEFAULT 1000 int meas_feed_cfg_set(const char *dst_host, uint16_t dst_port); void meas_feed_scenario_set(const char *name); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40497?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd038a14690ab0e0af4f8df8239ec23df37e468 Gerrit-Change-Number: 40497 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

3 days, 6 hours

1
0
0 0

[XS] Change in osmo-bsc[master]: meas_feed: Increase default txqueue len to 1024

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40496?usp=email ) Change subject: meas_feed: Increase default txqueue len to 1024 ...................................................................... meas_feed: Increase default txqueue len to 1024 Increase it to a higher number, which may be needed when BSC is serving lots of lchans. This also follows the default osmo_io txqueue len which was increased recently to 1024. Related: SYS#7508 Change-Id: Ib4382adc05cf6776952801ad7edad230db1ec454 --- M include/osmocom/bsc/meas_feed.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/96/40496/1 diff --git a/include/osmocom/bsc/meas_feed.h b/include/osmocom/bsc/meas_feed.h index 447eab8..5aa4606 100644 --- a/include/osmocom/bsc/meas_feed.h +++ b/include/osmocom/bsc/meas_feed.h @@ -35,7 +35,7 @@ }; #define MEAS_FEED_VERSION 1 -#define MEAS_FEED_TXQUEUE_MAX_LEN_DEFAULT 100 +#define MEAS_FEED_TXQUEUE_MAX_LEN_DEFAULT 1024 int meas_feed_cfg_set(const char *dst_host, uint16_t dst_port); void meas_feed_scenario_set(const char *name); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40496?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib4382adc05cf6776952801ad7edad230db1ec454 Gerrit-Change-Number: 40496 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

3 days, 6 hours

1
0
0 0

[M] Change in libosmo-sigtran[master]: asp: Introduce support to configure and enable TCP keep-alive

by pespin

Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email ) Change subject: asp: Introduce support to configure and enable TCP keep-alive ...................................................................... Patch Set 3: (1 comment) File src/ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481/comment/d1a878f9_97a6a… : PS3, Line 801: > This is a "well-known" way to write a "NO-OP" in C which can basically be used to let compiler see t […] "this way" = storing return code in a var and not using it, instead of not storing it. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2a9338053e741fb6dab94492c6bdc2badaf7afb1 Gerrit-Change-Number: 40481 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Jun 2025 12:05:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

3 days, 7 hours

1
0
0 0

[M] Change in libosmo-sigtran[master]: asp: Introduce support to configure and enable TCP keep-alive

by pespin

Attention is currently required from: fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email ) Change subject: asp: Introduce support to configure and enable TCP keep-alive ...................................................................... Patch Set 3: (1 comment) File src/ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481/comment/6841a513_de993… : PS3, Line 801: > what kind of syntax is that "(void) rc;" without assigning any value to rc? I don't know what it is […] This is a "well-known" way to write a "NO-OP" in C which can basically be used to let compiler see the var as used and don't warn about, ie. stating that it's known by programmer that the variable is not used. I prefer having it this way since it shows the reader that there's a return code, plus allows debugging the return code with the debugger. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2a9338053e741fb6dab94492c6bdc2badaf7afb1 Gerrit-Change-Number: 40481 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Jun 2025 12:04:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

3 days, 7 hours

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2025