May 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[rel-1.11.1]: lapd: Take talloc msgb ownership when enqueueing it

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/40221?usp=email ) Change subject: lapd: Take talloc msgb ownership when enqueueing it ...................................................................... lapd: Take talloc msgb ownership when enqueueing it Otherwise the msg talloc reference is kept parented at some unknown pointer in some unknown upper layer, which may cause memory corruption or use-after-free. Related: OS#6728 Change-Id: I32729060b5a18576310b3789da522f4392d9611e (cherry picked from commit 630d9b81c8464a0e859dd6c5c72ab88a00b61841) --- M src/isdn/lapd_core.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/isdn/lapd_core.c b/src/isdn/lapd_core.c index b32ed26..caaf092 100644 --- a/src/isdn/lapd_core.c +++ b/src/isdn/lapd_core.c @@ -1922,6 +1922,8 @@ LOGDL(dl, LOGL_INFO, "writing message to send-queue: l3len: %d\n", msgb_l3len(msg)); + /* Take ownership of msg, since we are keeping it around in this layer: */ + talloc_steal(tall_lapd_ctx, msg); /* Write data into the send queue */ msgb_enqueue(&dl->send_queue, msg); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40221?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: rel-1.11.1 Gerrit-Change-Id: I32729060b5a18576310b3789da522f4392d9611e Gerrit-Change-Number: 40221 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months

1
0
0 0

[XS] Change in osmo-dev[master]: gen_makefile: fix building open5gs

by pespin

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/40231?usp=email ) Change subject: gen_makefile: fix building open5gs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40231?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I6da15a0d825d06a20fe435e3545fa92a27c80cb9 Gerrit-Change-Number: 40231 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 13:14:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[XS] Change in osmo-dev[master]: gen_makefile: fix building open5gs

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/40231?usp=email ) Change subject: gen_makefile: fix building open5gs ...................................................................... gen_makefile: fix building open5gs Fix that gen_src_proj_copy() returns a relative path for projects where src_copy is not needed (either because the option is disabled or because the project doesn't use autotools, such as open5gs). This leads to generating the wrong build_to_src dir below, where os.path.relpath is getting called on the generated src_proj_copy: build_to_src = os.path.relpath(src_proj_copy, build_proj) Fix for: $ ./testenv.py run hss --podman … ===== .make.open5gs.configure chmod -R ug+w open5gs rm -rf open5gs mkdir -p open5gs cd open5gs; CFLAGS=-g meson setup ../../../../../../../code/osmo-dev/src/open5gs . \ --prefix /home/user/.cache/osmo-ttcn3-testenv/podman/usr ERROR: Neither directory contains a build file meson.build. make: *** [Makefile:4501: .make.open5gs.configure] Error 1 Fixes: 9cf2b98e ("gen_makefile: add --autoreconf-in-src-copy arg") Change-Id: I6da15a0d825d06a20fe435e3545fa92a27c80cb9 --- M gen_makefile.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/31/40231/1 diff --git a/gen_makefile.py b/gen_makefile.py index 548137d..c6e4a0b 100755 --- a/gen_makefile.py +++ b/gen_makefile.py @@ -437,7 +437,7 @@ def gen_src_proj_copy(src_proj, make_dir, proj): if not is_src_copy_needed(proj): - return src_proj + return os.path.join(make_dir, src_proj) return os.path.join(make_dir, "src_copy", proj) def gen_make(proj, deps, configure_opts, jobs, make_dir, src_dir, build_dir, url, push_url, sudo_make_install, no_ldconfig, ldconfig_without_sudo, make_check): -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40231?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I6da15a0d825d06a20fe435e3545fa92a27c80cb9 Gerrit-Change-Number: 40231 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months

1
0
0 0

[M] Change in osmo-bsc[master]: meas_json: add command line option to specify binding ip

by pespin

Attention is currently required from: Michael Iedema, fixeria. pespin has posted comments on this change by Michael Iedema. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email ) Change subject: meas_json: add command line option to specify binding ip ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3baa80c95b373e3f9483a2778bd195ff99bbdec0 Gerrit-Change-Number: 40224 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Iedema <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Michael Iedema <michael(a)kapsulate.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 12:24:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[M] Change in osmo-bsc[master]: meas_json: add command line option to specify binding ip

by iedemam

Attention is currently required from: pespin. iedemam has posted comments on this change by iedemam. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email ) Change subject: meas_json: add command line option to specify binding ip ...................................................................... Patch Set 3: (3 comments) Patchset: PS3: Thanks @pespin@sysmocom.de. Updated accordingly. File src/utils/meas_json.c: https://gerrit.osmocom.org/c/osmo-bsc/+/40224/comment/fef3b455_16211fbf?usp… : PS2, Line 47: static char *bind_ip = NULL; > No need to "= NULL", global vars are zero-initialized by default. Done https://gerrit.osmocom.org/c/osmo-bsc/+/40224/comment/eee0b969_2c648a29?usp… : PS2, Line 257: bind_ip = NULL; > Not needed, global vars are zero-initialized by default. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3baa80c95b373e3f9483a2778bd195ff99bbdec0 Gerrit-Change-Number: 40224 Gerrit-PatchSet: 3 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 12:13:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months

1
0
0 0

[M] Change in osmo-bsc[master]: meas_json: add command line option to specify binding ip

by iedemam

Attention is currently required from: iedemam. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: meas_json: add command line option to specify binding ip ...................................................................... meas_json: add command line option to specify binding ip Change-Id: I3baa80c95b373e3f9483a2778bd195ff99bbdec0 --- M src/utils/meas_json.c 1 file changed, 70 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/24/40224/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3baa80c95b373e3f9483a2778bd195ff99bbdec0 Gerrit-Change-Number: 40224 Gerrit-PatchSet: 3 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com>

4 months

1
0
0 0

[S] Change in libosmocore[rel-1.11.1]: Bump version: 1.11.0.3-5e10c → 1.11.1

by osmith

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/40223?usp=email ) Change subject: Bump version: 1.11.0.3-5e10c → 1.11.1 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > @osmith@sysmocom. […] yup! -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40223?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: rel-1.11.1 Gerrit-Change-Id: If22e810464a33bcadbd03462b4a84bc303377fae Gerrit-Change-Number: 40223 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 12:04:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

4 months

1
0
0 0

[S] Change in libosmocore[rel-1.11.1]: Bump version: 1.11.0.3-5e10c → 1.11.1

by fixeria

Attention is currently required from: laforge, osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/40223?usp=email ) Change subject: Bump version: 1.11.0.3-5e10c → 1.11.1 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: @osmith@sysmocom.de are `LIBVERSION` changes looking good? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40223?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: rel-1.11.1 Gerrit-Change-Id: If22e810464a33bcadbd03462b4a84bc303377fae Gerrit-Change-Number: 40223 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 06 May 2025 12:02:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/master-builds: add osmo-rp2040-firmware

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40230?usp=email ) Change subject: jobs/master-builds: add osmo-rp2040-firmware ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40230?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I94a6135fa48d47fe92007d570670f6f5403ce11b Gerrit-Change-Number: 40230 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 11:23:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/master: pass osmo-ci to docker

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40229?usp=email ) Change subject: jobs/master: pass osmo-ci to docker ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If5257e7f5e3e2f9e09c52fa558a63e34c276b9a6 Gerrit-Change-Number: 40229 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 May 2025 11:23:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2025