April 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: Set 'hnbap-allow-tmsi 1' by default

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39978?usp=email ) Change subject: Set 'hnbap-allow-tmsi 1' by default ...................................................................... Set 'hnbap-allow-tmsi 1' by default Due to historical reasons [0], we didn't allow UE Registration with (P)TMSI by default, only with IMSI. The historical reasons were fixed a long time ago, and hence why virtually every osmo-hnbgw you can find nowadays (see doc/examples/ dir) contained an explicit "hnbap-allow-tmsi 1" to override the default behavior. However, the fact that this was not the default behavior causes some problems on production network which didn't have this config set explicitly. Hence, enable it by default. [0] Original osmo-hnbgw code in osmo-iuh.git 12181a937ff5658af49e12c57cb08ecba859e1f1 where this feature was added explains with more detail the problem. If UE registered with TMSI, then the HNBGW at the time didn't have information about its IMSI and hence could not page the UE from IMSI. Since ~5.5 years ago (Sep 2019 in osmo-sgsn.git 10b3d70fea9628eecb58f07e1bce31f63823edfb), osmo-sgsn already sends a Common Id to the HNBGW containing the UE IMSI when it registers, so the HNBGW has no related problem anymore. The VTY command is left available in the event somebody wants to operate osmo-hnbgw with a broken MSC/SGSN (like older mentioned osmo-sgsn). Related: SYS#7430 Change-Id: I3c4c0decf34959fc2d5683b02224f27d204aa5e9 --- M doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg M doc/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg M doc/examples/osmo-hnbgw/osmo-hnbgw.cfg M src/osmo-hnbgw/hnbgw.c M src/osmo-hnbgw/hnbgw_vty.c M tests/osmo-hnbgw-vty-test.cfg 6 files changed, 4 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/78/39978/1 diff --git a/doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg b/doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg index 671d790..ee9c89e 100644 --- a/doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg +++ b/doc/examples/osmo-hnbgw/osmo-hnbgw-cs7.cfg @@ -13,7 +13,6 @@ plmn 001 01 iuh local-ip 0.0.0.0 - hnbap-allow-tmsi 1 msc 0 remote-addr my-msc sgsn 0 diff --git a/doc/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg b/doc/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg index 7599427..13835ad 100644 --- a/doc/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg +++ b/doc/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg @@ -11,7 +11,6 @@ plmn 001 01 iuh local-ip 0.0.0.0 - hnbap-allow-tmsi 1 mgw 0 remote-ip 127.0.0.1 local-port 2729 diff --git a/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg b/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg index 996a3ae..dd82788 100644 --- a/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg +++ b/doc/examples/osmo-hnbgw/osmo-hnbgw.cfg @@ -11,7 +11,6 @@ plmn 001 01 iuh local-ip 0.0.0.0 - hnbap-allow-tmsi 1 mgw 0 remote-ip 127.0.0.1 local-port 2729 diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c index d4515a8..8da6364 100644 --- a/src/osmo-hnbgw/hnbgw.c +++ b/src/osmo-hnbgw/hnbgw.c @@ -975,6 +975,7 @@ /* strdup so we can easily talloc_free in the VTY code */ g_hnbgw->config.iuh_local_ip = talloc_strdup(g_hnbgw, HNBGW_LOCAL_IP_DEFAULT); g_hnbgw->config.iuh_local_port = IUH_DEFAULT_SCTP_PORT; + g_hnbgw->config.hnbap_allow_tmsi = true; g_hnbgw->config.log_prefix_hnb_id = true; g_hnbgw->config.accept_all_hnb = true; diff --git a/src/osmo-hnbgw/hnbgw_vty.c b/src/osmo-hnbgw/hnbgw_vty.c index 68d4b1f..d99a998 100644 --- a/src/osmo-hnbgw/hnbgw_vty.c +++ b/src/osmo-hnbgw/hnbgw_vty.c @@ -334,7 +334,7 @@ "hnbap-allow-tmsi (0|1)", "Allow HNBAP UE Register messages with TMSI or PTMSI identity\n" "Only accept IMSI identity, reject TMSI or PTMSI\n" - "Accept IMSI, TMSI or PTMSI as UE identity\n") + "Accept IMSI, TMSI or PTMSI as UE identity (default)\n") { g_hnbgw->config.hnbap_allow_tmsi = (*argv[0] == '1'); return CMD_SUCCESS; @@ -1039,8 +1039,8 @@ if (port && port != IUH_DEFAULT_SCTP_PORT) vty_out(vty, " local-port %u%s", port, VTY_NEWLINE); - if (g_hnbgw->config.hnbap_allow_tmsi) - vty_out(vty, " hnbap-allow-tmsi 1%s", VTY_NEWLINE); + if (!g_hnbgw->config.hnbap_allow_tmsi) + vty_out(vty, " hnbap-allow-tmsi 0%s", VTY_NEWLINE); return CMD_SUCCESS; } diff --git a/tests/osmo-hnbgw-vty-test.cfg b/tests/osmo-hnbgw-vty-test.cfg index 6f9c0b6..11327a3 100644 --- a/tests/osmo-hnbgw-vty-test.cfg +++ b/tests/osmo-hnbgw-vty-test.cfg @@ -32,7 +32,6 @@ hnbgw iuh local-ip 0.0.0.0 - hnbap-allow-tmsi 1 mgw 0 remote-ip 127.0.0.1 local-port 2729 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39978?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I3c4c0decf34959fc2d5683b02224f27d204aa5e9 Gerrit-Change-Number: 39978 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: Add ttcn3-pcap-client-test-io_uring

by pespin

Attention is currently required from: laforge, osmith, pespin. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/39943?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+2 by osmith, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: jobs/ttcn3-testsuites-testenv: Add ttcn3-pcap-client-test-io_uring ...................................................................... jobs/ttcn3-testsuites-testenv: Add ttcn3-pcap-client-test-io_uring Since osmo-pcap.git Change-Id I72e8a6ceb4fb1eb70372e13bb139ead0e2bc0860, osmo-pcap-client uses osmo_stream which in turn uses osmo_io (which can u io_uring backend). Hence, add io-uring backend to the test matrix for this project. Change-Id: I817b4d27cd2e8faabf2ebb5ad28f025535571282 --- M jobs/ttcn3-testsuites-testenv.yml 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/43/39943/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39943?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I817b4d27cd2e8faabf2ebb5ad28f025535571282 Gerrit-Change-Number: 39943 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-hnbgw[master]: cosmetic: Add spec references for RUA, RANAP, HNBAP

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39977?usp=email ) Change subject: cosmetic: Add spec references for RUA, RANAP, HNBAP ...................................................................... cosmetic: Add spec references for RUA, RANAP, HNBAP Change-Id: I0e638befaa1e5093dc0c95e77414bfd9d9179a66 --- M include/osmocom/hnbgw/hnbgw_hnbap.h M include/osmocom/hnbgw/hnbgw_ranap.h M include/osmocom/hnbgw/hnbgw_rua.h M src/osmo-hnbgw/hnbgw_hnbap.c M src/osmo-hnbgw/hnbgw_ranap.c M src/osmo-hnbgw/hnbgw_rua.c 6 files changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/77/39977/1 diff --git a/include/osmocom/hnbgw/hnbgw_hnbap.h b/include/osmocom/hnbgw/hnbgw_hnbap.h index d0af955..2f0c5b4 100644 --- a/include/osmocom/hnbgw/hnbgw_hnbap.h +++ b/include/osmocom/hnbgw/hnbgw_hnbap.h @@ -1,3 +1,4 @@ +/* HNBAP, 3GPP TS 25.469 */ #pragma once #include <osmocom/hnbgw/hnbgw.h> diff --git a/include/osmocom/hnbgw/hnbgw_ranap.h b/include/osmocom/hnbgw/hnbgw_ranap.h index 50504e6..31f2f57 100644 --- a/include/osmocom/hnbgw/hnbgw_ranap.h +++ b/include/osmocom/hnbgw/hnbgw_ranap.h @@ -1,3 +1,4 @@ +/* RANAP, 3GPP TS 25.413 */ #pragma once #include <osmocom/hnbgw/hnbgw.h> diff --git a/include/osmocom/hnbgw/hnbgw_rua.h b/include/osmocom/hnbgw/hnbgw_rua.h index 0bf2de8..b7e7ee6 100644 --- a/include/osmocom/hnbgw/hnbgw_rua.h +++ b/include/osmocom/hnbgw/hnbgw_rua.h @@ -1,3 +1,4 @@ +/* RUA, 3GPP TS 25.468 */ #pragma once #include <osmocom/hnbgw/hnbgw.h> diff --git a/src/osmo-hnbgw/hnbgw_hnbap.c b/src/osmo-hnbgw/hnbgw_hnbap.c index e373600..99a27f5 100644 --- a/src/osmo-hnbgw/hnbgw_hnbap.c +++ b/src/osmo-hnbgw/hnbgw_hnbap.c @@ -1,4 +1,4 @@ -/* hnb-gw specific code for HNBAP */ +/* hnb-gw specific code for HNBAP, 3GPP TS 25.469 */ /* (C) 2015 by Harald Welte <laforge(a)gnumonks.org> * All Rights Reserved diff --git a/src/osmo-hnbgw/hnbgw_ranap.c b/src/osmo-hnbgw/hnbgw_ranap.c index 7fb7dcb..83215f7 100644 --- a/src/osmo-hnbgw/hnbgw_ranap.c +++ b/src/osmo-hnbgw/hnbgw_ranap.c @@ -1,4 +1,4 @@ -/* hnb-gw specific code for RANAP */ +/* hnb-gw specific code for RANAP, 3GPP TS 25.413 */ /* (C) 2015 by Harald Welte <laforge(a)gnumonks.org> * All Rights Reserved diff --git a/src/osmo-hnbgw/hnbgw_rua.c b/src/osmo-hnbgw/hnbgw_rua.c index b804b46..b3342f9 100644 --- a/src/osmo-hnbgw/hnbgw_rua.c +++ b/src/osmo-hnbgw/hnbgw_rua.c @@ -1,4 +1,4 @@ -/* hnb-gw specific code for RUA (Ranap User Adaption) */ +/* hnb-gw specific code for RUA (Ranap User Adaption), 3GPP TS 25.468 */ /* (C) 2015 by Harald Welte <laforge(a)gnumonks.org> * All Rights Reserved -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39977?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0e638befaa1e5093dc0c95e77414bfd9d9179a66 Gerrit-Change-Number: 39977 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: execute more GSUP-over-SMS tests via UTRAN

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39974?usp=email ) Change subject: msc: execute more GSUP-over-SMS tests via UTRAN ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39974?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia3c044ad04561a4ee6dbb4a3fe59fedd3ac79bba Gerrit-Change-Number: 39974 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Apr 2025 14:04:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmo-msc[master]: gsm0911_rcv_nc_ss(): avoid assertion failure in msc_a_put()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/39976?usp=email ) Change subject: gsm0911_rcv_nc_ss(): avoid assertion failure in msc_a_put() ...................................................................... gsm0911_rcv_nc_ss(): avoid assertion failure in msc_a_put() Change-Id: I724f0f0c9ef8611d3c3653e9370361b252127f72 Related: osmo-ttcn3-hacks.git If1d85a1b4b63b01b4565e53677acfd21e664e799 Related: OS#6756 --- M src/libmsc/gsm_09_11.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/76/39976/1 diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c index 442995e..508144a 100644 --- a/src/libmsc/gsm_09_11.c +++ b/src/libmsc/gsm_09_11.c @@ -144,7 +144,8 @@ GSM0480_MTYPE_RELEASE_COMPLETE); /* Decrement use counter that has been incremented by CM Service Request (SS). * If there is no other service request, the BSS connection will be released. */ - msc_a_put(msc_a, MSC_A_USE_CM_SERVICE_SS); + if (osmo_use_count_by(&msc_a->use_count, MSC_A_USE_CM_SERVICE_SS)) + msc_a_put(msc_a, MSC_A_USE_CM_SERVICE_SS); return -EINVAL; } @@ -156,7 +157,8 @@ GSM0480_MTYPE_RELEASE_COMPLETE); /* Decrement use counter that has been incremented by CM Service Request (SS). * If there is no other service request, the BSS connection will be released. */ - msc_a_put(msc_a, MSC_A_USE_CM_SERVICE_SS); + if (osmo_use_count_by(&msc_a->use_count, MSC_A_USE_CM_SERVICE_SS)) + msc_a_put(msc_a, MSC_A_USE_CM_SERVICE_SS); return -ENOMEM; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/39976?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I724f0f0c9ef8611d3c3653e9370361b252127f72 Gerrit-Change-Number: 39976 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: add TC_mo_ussd_evil_ms for OS#6756

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39975?usp=email ) Change subject: msc: add TC_mo_ussd_evil_ms for OS#6756 ...................................................................... msc: add TC_mo_ussd_evil_ms for OS#6756 This is an "evil MS" scenario that crashes current osmo-msc. Change-Id: If1d85a1b4b63b01b4565e53677acfd21e664e799 Related: OS#6756 --- M msc/MSC_Tests.ttcn M msc/expected-results.xml 2 files changed, 46 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/75/39975/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 527b71a..21e74f1 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -4393,6 +4393,50 @@ vc_conn.done; } +/* MO (mobile-originated) SS/USSD FACILITY for an unknown transaction, + * and CM SERVICE REQUEST with wrong establishment cause prior to that. + * This is an "evil MS" scenario that can be used to reproduce OS#6756. */ +friend function f_TC_mo_ussd_evil_ms(charstring id, BSC_ConnHdlrPars pars) +runs on BSC_ConnHdlr { + f_init_handler(pars); + + f_ran_register_imsi(g_pars.imsi, g_pars.tmsi); + f_create_gsup_expect(hex2str(g_pars.imsi)); + + /* Perform location update */ + f_perform_lu(); + + /* Send CM Service Request indicating *wrong* reason */ + f_establish_fully(EST_TYPE_MO_CALL); + + /* GSM 04.80 FACILITY message for a non-existing transaction */ + var template (value) PDU_ML3_MS_NW mo_ss_fac := ts_ML3_MO_SS_FACILITY( + tid := 1, /* An arbitrary transaction identifier */ + ti_flag := c_TIF_ORIG, /* Sent from the side that originates the TI */ + facility := f_rnd_octstring(23) /* We don't care about the Facility IE */ + ); + + /* Expected response from the network */ + var template PDU_ML3_NW_MS mt_ss_rel := tr_ML3_MT_SS_RELEASE_COMPLETE( + tid := 1, /* Same as in the FACILITY message */ + ti_flag := c_TIF_REPL, /* Sent to the side that originates the TI */ + facility := omit + ); + + /* Send GSM 04.80 FACILITY for non-existing transaction */ + BSSAP.send(ts_PDU_DTAP_MO(mo_ss_fac)); + + /* Expect GSM 04.80 RELEASE COMPLETE message */ + f_expect_mt_dtap_msg(mt_ss_rel); + f_expect_clear(); +} +testcase TC_mo_ussd_evil_ms() runs on MTC_CT { + var BSC_ConnHdlr vc_conn; + f_init(); + vc_conn := f_start_handler(refers(f_TC_mo_ussd_evil_ms), 111); + vc_conn.done; +} + /* Verify multiple concurrent MO SS/USSD transactions * (one subscriber - one transaction) */ @@ -7659,6 +7703,7 @@ execute( TC_lu_and_mt_csd() ); execute( TC_lu_and_mo_call_reass_for_mt_codec() ); + execute( TC_mo_ussd_evil_ms() ); /* XXX: crashes osmo-msc */ } diff --git a/msc/expected-results.xml b/msc/expected-results.xml index 2dc7e97..dacb840 100644 --- a/msc/expected-results.xml +++ b/msc/expected-results.xml @@ -94,6 +94,7 @@ <testcase classname='MSC_Tests' name='TC_proc_ss_for_unknown_session' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_proc_ss_paging_fail' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_proc_ss_abort' time='MASKED'/> + <testcase classname='MSC_Tests' name='TC_mo_ussd_evil_ms' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_multi_lu_and_mo_ussd' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_multi_lu_and_mt_ussd' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_cipher_complete_with_invalid_cipher' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If1d85a1b4b63b01b4565e53677acfd21e664e799 Gerrit-Change-Number: 39975 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: msc: execute more GSUP-over-SMS tests via UTRAN

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39974?usp=email ) Change subject: msc: execute more GSUP-over-SMS tests via UTRAN ...................................................................... msc: execute more GSUP-over-SMS tests via UTRAN Change-Id: Ia3c044ad04561a4ee6dbb4a3fe59fedd3ac79bba Related: 1cd11a05a ("MSC_Tests.ttcn: introduce TC_gsup_mt_multi_part_sms") Related: 8d0d7af27 ("msc: add TC_gsup_mt_sms_lu_delay for X36 (LU delay) timer") Related: e9de1515d ("msc: add TC_gsup_mt_sms_{paging,conn}_timeout") --- M msc/MSC_Tests.ttcn M msc/MSC_Tests_Iu.ttcn M msc/expected-results.xml 3 files changed, 55 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/74/39974/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 492a551..527b71a 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -3176,7 +3176,7 @@ /* Test multi-part MT-SMS over GSUP */ -private function f_tc_gsup_mt_multi_part_sms(charstring id, BSC_ConnHdlrPars pars) +friend function f_tc_gsup_mt_multi_part_sms(charstring id, BSC_ConnHdlrPars pars) runs on BSC_ConnHdlr { var SmsParameters spars := valueof(t_SmsPars); diff --git a/msc/MSC_Tests_Iu.ttcn b/msc/MSC_Tests_Iu.ttcn index 229ebb6..c78b86b 100644 --- a/msc/MSC_Tests_Iu.ttcn +++ b/msc/MSC_Tests_Iu.ttcn @@ -401,6 +401,52 @@ f_vty_config(MSCVTY, "msc", "no sms-over-gsup"); } +testcase TC_iu_gsup_mt_multi_part_sms() runs on MTC_CT { + var BSC_ConnHdlrPars pars; + var BSC_ConnHdlr vc_conn; + f_init(3); + pars := f_init_pars(1094, ran_idx := 2, ran_is_geran := false); + f_vty_config(MSCVTY, "msc", "sms-over-gsup"); + vc_conn := f_start_handler_with_pars(refers(f_tc_gsup_mt_multi_part_sms), pars); + vc_conn.done; + f_vty_config(MSCVTY, "msc", "no sms-over-gsup"); +} + +testcase TC_iu_gsup_mt_sms_lu_delay() runs on MTC_CT { + var BSC_ConnHdlrPars pars; + var BSC_ConnHdlr vc_conn; + f_init(3); + pars := f_init_pars(1095, ran_idx := 2, ran_is_geran := false); + f_vty_config(MSCVTY, "msc", "sms-over-gsup"); + f_vty_config(MSCVTY, "msc", "timer utran X36 2500"); /* 2.5s */ + vc_conn := f_start_handler_with_pars(refers(f_TC_gsup_mt_sms_lu_delay), pars); + vc_conn.done; + f_vty_config(MSCVTY, "msc", "timer utran X36 0"); + f_vty_config(MSCVTY, "msc", "no sms-over-gsup"); +} + +testcase TC_iu_gsup_mt_sms_paging_timeout() runs on MTC_CT { + var BSC_ConnHdlrPars pars; + var BSC_ConnHdlr vc_conn; + f_init(3); + pars := f_init_pars(1096, ran_idx := 2, ran_is_geran := false); + f_vty_config(MSCVTY, "msc", "sms-over-gsup"); + vc_conn := f_start_handler_with_pars(refers(f_TC_gsup_mt_sms_paging_timeout), pars); + vc_conn.done; + f_vty_config(MSCVTY, "msc", "no sms-over-gsup"); +} + +testcase TC_iu_gsup_mt_sms_conn_timeout() runs on MTC_CT { + var BSC_ConnHdlrPars pars; + var BSC_ConnHdlr vc_conn; + f_init(3); + pars := f_init_pars(1097, ran_idx := 2, ran_is_geran := false); + f_vty_config(MSCVTY, "msc", "sms-over-gsup"); + vc_conn := f_start_handler_with_pars(refers(f_TC_gsup_mt_sms_conn_timeout), pars); + vc_conn.done; + f_vty_config(MSCVTY, "msc", "no sms-over-gsup"); +} + testcase TC_iu_lu_and_mo_ussd_single_request() runs on MTC_CT { var BSC_ConnHdlr vc_conn; f_init(3); @@ -590,6 +636,10 @@ execute( TC_iu_gsup_mt_sms_err() ); execute( TC_iu_gsup_mt_sms_rp_mr() ); execute( TC_iu_gsup_mo_mt_sms_rp_mr() ); + execute( TC_iu_gsup_mt_multi_part_sms() ); + execute( TC_iu_gsup_mt_sms_lu_delay() ); + execute( TC_iu_gsup_mt_sms_paging_timeout() ); + execute( TC_iu_gsup_mt_sms_conn_timeout() ); execute( TC_iu_lu_and_mo_ussd_single_request() ); execute( TC_iu_lu_and_mt_ussd_notification() ); diff --git a/msc/expected-results.xml b/msc/expected-results.xml index ffe85a6..2dc7e97 100644 --- a/msc/expected-results.xml +++ b/msc/expected-results.xml @@ -229,6 +229,10 @@ <testcase classname='MSC_Tests_Iu' name='TC_iu_gsup_mt_sms_err' time='MASKED'/> <testcase classname='MSC_Tests_Iu' name='TC_iu_gsup_mt_sms_rp_mr' time='MASKED'/> <testcase classname='MSC_Tests_Iu' name='TC_iu_gsup_mo_mt_sms_rp_mr' time='MASKED'/> + <testcase classname='MSC_Tests_Iu' name='TC_iu_gsup_mt_multi_part_sms' time='MASKED'/> + <testcase classname='MSC_Tests_Iu' name='TC_iu_gsup_mt_sms_lu_delay' time='MASKED'/> + <testcase classname='MSC_Tests_Iu' name='TC_iu_gsup_mt_sms_paging_timeout' time='MASKED'/> + <testcase classname='MSC_Tests_Iu' name='TC_iu_gsup_mt_sms_conn_timeout' time='MASKED'/> <testcase classname='MSC_Tests_Iu' name='TC_iu_lu_and_mo_ussd_single_request' time='MASKED'/> <testcase classname='MSC_Tests_Iu' name='TC_iu_lu_and_mt_ussd_notification' time='MASKED'/> <testcase classname='MSC_Tests_Iu' name='TC_iu_lu_and_mo_ussd_during_mt_call' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39974?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia3c044ad04561a4ee6dbb4a3fe59fedd3ac79bba Gerrit-Change-Number: 39974 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[S] Change in osmo-pcap[master]: client: Avoid sending link frame over non-connected conn

by pespin

Attention is currently required from: fixeria, osmith, pespin. Hello Jenkins Builder, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcap/+/39945?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by osmith, Verified-1 by Jenkins Builder Change subject: client: Avoid sending link frame over non-connected conn ...................................................................... client: Avoid sending link frame over non-connected conn Otherwise error messages appear upon start when starting the capture and the conns haven't yet been established (they are started immediately afterwards in main.c). The errors are actually harmless since network code takes care of sending a link frame upon connection TCP/TLS handshake completes. Change-Id: I091523e1d9f644e97b114b4cc524307a83dd564f --- M include/osmo-pcap/osmo_pcap_client.h M src/osmo_client_core.c M src/osmo_client_network.c 3 files changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/45/39945/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39945?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I091523e1d9f644e97b114b4cc524307a83dd564f Gerrit-Change-Number: 39945 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[M] Change in osmo-pcap[master]: client: use osmo_stream_cli to transmit data to pcap-server

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39944?usp=email ) Change subject: client: use osmo_stream_cli to transmit data to pcap-server ...................................................................... Patch Set 5: (1 comment) File src/osmo_client_network.c: https://gerrit.osmocom.org/c/osmo-pcap/+/39944/comment/1941efc1_594eea3c?us… : PS4, Line 83: cannot never > we can, for instance if msgb queue is full. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39944?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I72e8a6ceb4fb1eb70372e13bb139ead0e2bc0860 Gerrit-Change-Number: 39944 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Apr 2025 13:32:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in docker-playground[master]: debian-bookworm-build: remove pysispm, pydbus

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/39973?usp=email ) Change subject: debian-bookworm-build: remove pysispm, pydbus ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/39973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I731e171c85d530984279dc05544b6f02cec7cb3c Gerrit-Change-Number: 39973 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 08 Apr 2025 13:13:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025