April 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-iuh[master]: ranap_common_ran: remove unused ctx args

by laforge

Attention is currently required from: fixeria, neels, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/39980?usp=email ) Change subject: ranap_common_ran: remove unused ctx args ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/39980?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I57b320c2fdd72d11b87507d0cd9c2e7b479e7fe4 Gerrit-Change-Number: 39980 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Apr 2025 09:04:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[M] Change in osmo-ci[master]: jobs/ttcn3: move ttcn3-ns-test to testenv

by osmith

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/39999?usp=email to look at the new patch set (#2). Change subject: jobs/ttcn3: move ttcn3-ns-test to testenv ...................................................................... jobs/ttcn3: move ttcn3-ns-test to testenv Move ttcn3-ns-test, ttcn3-ns-test-sns, ttcn3-ns-test-sgsn-sns to testenv. Add -latest and -asan variants while at it, as this is now supported. Keep ttcn3-ns-test-fr docker-playground based for now as this currently requires running on a debian 10 based node (see OS#6494#note-18). Change-Id: I50c56484754255830ae93a3e2afa884d50d86742 --- M jobs/ttcn3-testsuites-testenv.yml M jobs/ttcn3-testsuites.yml 2 files changed, 45 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/99/39999/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I50c56484754255830ae93a3e2afa884d50d86742 Gerrit-Change-Number: 39999 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

4 months, 1 week

1
0
0 0

[M] Change in osmo-ci[master]: jobs/ttcn3: move ttcn3-ns-test to testenv

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39999?usp=email ) Change subject: jobs/ttcn3: move ttcn3-ns-test to testenv ...................................................................... jobs/ttcn3: move ttcn3-ns-test to testenv Move ttcn3-ns-test, ttcn3-ns-test-sns, ttcn3-ns-test-sgsn-sns to testenv. Add -latest and -asan variants while at it, as this is now supported. Keep ttcn3-ns-test-fr docker-playground based for now as this currently requires running on a debian 10 based node (see OS6494#note-18). Change-Id: I50c56484754255830ae93a3e2afa884d50d86742 --- M jobs/ttcn3-testsuites-testenv.yml M jobs/ttcn3-testsuites.yml 2 files changed, 45 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/99/39999/1 diff --git a/jobs/ttcn3-testsuites-testenv.yml b/jobs/ttcn3-testsuites-testenv.yml index 644dcbf..12cd8d0 100644 --- a/jobs/ttcn3-testsuites-testenv.yml +++ b/jobs/ttcn3-testsuites-testenv.yml @@ -181,6 +181,21 @@ args: -b osmocom:nightly timer: H 10 * * * + - ttcn3-ns-test: # ~7 min + testsuite: ns + args: -b osmocom:nightly -c udp + timer: H 10 * * * + + - ttcn3-ns-test-sns: # ~3 min + testsuite: ns + args: -b osmocom:nightly -c sns + timer: H 10 * * * + + - ttcn3-ns-test-sgsn-sns: # ~ 1 min + testsuite: ns + args: -b osmocom:nightly -c sgsn_sns + timer: H 10 * * * + # --------------------------------------------- # Debian latest # --------------------------------------------- @@ -312,6 +327,21 @@ args: -b osmocom:latest timer: H 13 * * * + - ttcn3-ns-test-latest: # ~7 min + testsuite: ns + args: -b osmocom:latest -c udp + timer: H 13 * * * + + - ttcn3-ns-test-sns-latest: # ~3 min + testsuite: ns + args: -b osmocom:latest -c sns + timer: H 13 * * * + + - ttcn3-ns-test-sgsn-sns-latest: # ~ 1 min + testsuite: ns + args: -b osmocom:latest -c sgsn_sns + timer: H 13 * * * + # --------------------------------------------- # Debian nightly + io_uring (OS#6357) # --------------------------------------------- @@ -438,6 +468,21 @@ args: -b osmocom:nightly:asan timer: H 17 * * * + - ttcn3-ns-test-asan: # ~7 min + testsuite: ns + args: -b osmocom:nightly:asan -c udp + timer: H 17 * * * + + - ttcn3-ns-test-sns-asan: # ~3 min + testsuite: ns + args: -b osmocom:nightly:asan -c sns + timer: H 17 * * * + + - ttcn3-ns-test-sgsn-sns-asan: # ~ 1 min + testsuite: ns + args: -b osmocom:nightly:asan -c sgsn_sns + timer: H 17 * * * + - job-template: name: '{job-name}' project-type: freestyle diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml index 9a22f0b..6261af9 100644 --- a/jobs/ttcn3-testsuites.yml +++ b/jobs/ttcn3-testsuites.yml @@ -29,15 +29,9 @@ - ttcn3-gbproxy-test-fr: # ~26 min timer: H 03 * * * node: hdlc - - ttcn3-ns-test: # ~7 min - timer: H 04 * * * - - ttcn3-ns-test-sns: # ~3 min - timer: H 04 * * * - ttcn3-ns-test-fr: # ~10 min timer: H 04 * * * node: hdlc - - ttcn3-ns-test-sgsn-sns: # ~ 1 min - timer: H 04 * * * - ttcn3-fr-test: # ~ 10 min timer: H 04 * * * node: hdlc -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I50c56484754255830ae93a3e2afa884d50d86742 Gerrit-Change-Number: 39999 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: ansible/setup-jenkins-slave: add python3-packaging

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39998?usp=email ) Change subject: ansible/setup-jenkins-slave: add python3-packaging ...................................................................... ansible/setup-jenkins-slave: add python3-packaging With the related patch, testenv depends on python3-packaging. Install it on the jenkins nodes. Related: osmo-ttcn3-hacks Ic15e385b9c8bab5c0dc70276049d6ad5ae927a6a Change-Id: Ic6d3f3e75b4a31870195f9f6ac46c90119b92ee3 --- M ansible/setup-jenkins-slave.yml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/98/39998/1 diff --git a/ansible/setup-jenkins-slave.yml b/ansible/setup-jenkins-slave.yml index f2e0bcd..f0f81b3 100644 --- a/ansible/setup-jenkins-slave.yml +++ b/ansible/setup-jenkins-slave.yml @@ -12,6 +12,7 @@ - etckeeper - ncdu - osc # OS#6706 + - python3-packaging # testenv - rpm2cpio # OS#6706 - rsync - screen -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39998?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic6d3f3e75b4a31870195f9f6ac46c90119b92ee3 Gerrit-Change-Number: 39998 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months, 1 week

1
0
0 0

[M] Change in osmo-hnbgw[master]: Improve paging to support Paging Area ID

by osmith

Attention is currently required from: lynxis lazus, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39995?usp=email ) Change subject: Improve paging to support Paging Area ID ...................................................................... Patch Set 1: (3 comments) File src/osmo-hnbgw/cnlink_paging.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/39995/comment/5bcd51e3_71ebdd73?u… : PS1, Line 167: const char *cnlink_paging_add_ranap(struct hnbgw_cnlink *cnlink, RANAP_CN_DomainIndicator_t domain, const RANAP_PagingIEs_t *paging_ies) what is the purpose of passing the `RANAP_CN_DomainIndicator_t domain` parameter given that below it is just set as: `domain = paging_ies->cN_DomainIndicator;`? File src/osmo-hnbgw/hnbgw_ranap.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/39995/comment/a39af562_4e09b40d?u… : PS1, Line 328: { RANAP_PagingAreaID_PR_rAI, "RAI" }, why lowercase l and r in lAI and rAI? https://gerrit.osmocom.org/c/osmo-hnbgw/+/39995/comment/7beaed03_d875abfc?u… : PS1, Line 409: "Rx Paging from CN: decoding RANAP IE Paging Area ID failed\n"); maybe mention in the error msg that it is broadcasting instead? not sure if that would be obvious from log output otherwise -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I915254a39ee04898aa740674b4632a328f281955 Gerrit-Change-Number: 39995 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 10 Apr 2025 06:41:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

4 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: Fix RAC size in struct umts_cell_id

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39994?usp=email ) Change subject: Fix RAC size in struct umts_cell_id ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39994?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ide7dfd5d0ae87826cb7759d283be6da81dae90f4 Gerrit-Change-Number: 39994 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Apr 2025 06:20:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: Drop unused struct ue_context

by osmith

Attention is currently required from: fixeria, neels, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39982?usp=email ) Change subject: Drop unused struct ue_context ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39982?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0c887ab6e9674d7f123668ab38dee8cc6e66469d Gerrit-Change-Number: 39982 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Apr 2025 06:19:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[XS] Change in osmo-hnbgw[master]: Log paging response not matching any request by MI

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39993?usp=email ) Change subject: Log paging response not matching any request by MI ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39993?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I9c775901b5042b33382e56ac4e2c301524b734a1 Gerrit-Change-Number: 39993 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Apr 2025 06:18:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[S] Change in osmo-hnbgw[master]: Drop unused struct ue_context

by osmith

Attention is currently required from: fixeria, neels, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39982?usp=email ) Change subject: Drop unused struct ue_context ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39982?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0c887ab6e9674d7f123668ab38dee8cc6e66469d Gerrit-Change-Number: 39982 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Apr 2025 06:17:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: testenv: clone_project: fix getting latest version

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39991?usp=email ) Change subject: testenv: clone_project: fix getting latest version ...................................................................... testenv: clone_project: fix getting latest version Extend the logic for getting the last version, so it doesn't only work with libosmo-sigtran (where the last version happens to be the last one returned by "git ls-remote --tags") but also for libosmocore where this isn't the case. Filter the versions by the relevant ones and then sort them to get the highest one. Change-Id: Ic15e385b9c8bab5c0dc70276049d6ad5ae927a6a --- M _testenv/testenv/podman_install.py 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/_testenv/testenv/podman_install.py b/_testenv/testenv/podman_install.py index 1eaf7e8..27b08b4 100644 --- a/_testenv/testenv/podman_install.py +++ b/_testenv/testenv/podman_install.py @@ -3,6 +3,8 @@ import logging import multiprocessing import os +import packaging.version +import re import shlex import string import subprocess @@ -103,7 +105,15 @@ url = f"https://gerrit.osmocom.org/{project}" if testenv.args.binary_repo.endswith(":latest"): ls_remote = testenv.cmd.run(["git", "ls-remote", "--tags", url], capture_output=True, text=True) - branch = ls_remote.stdout.split("\n")[-2].split("refs/tags/")[1].split("^")[0] + tags = [] + pattern = re.compile("^\d+\.\d+\.\d+$") + for line in ls_remote.stdout.split("\n"): + if "refs/tags/" in line: + tag = line.split("refs/tags/")[1].split("^")[0] + if pattern.match(tag): + tags += [tag] + tags.sort(key=packaging.version.Version, reverse=True) + branch = tags[0] logging.info(f"{project}: cloning {branch}") testenv.cmd.run( -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39991?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic15e385b9c8bab5c0dc70276049d6ad5ae927a6a Gerrit-Change-Number: 39991 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2025