March 2025 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: AS loadsharing: Normal route distribution regardless of active state
by laforge 07 Mar '25

07 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39708?usp=email ) Change subject: AS loadsharing: Normal route distribution regardless of active state ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39708?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6daf114416c69c84bdc3042efcaf2918f91c2e87 Gerrit-Change-Number: 39708 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Mar 2025 12:57:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow requests to different hosts
by pespin 07 Mar '25

07 Mar '25

Attention is currently required from: dexter, fixeria, laforge. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39657?usp=email ) Change subject: HTTP_Adapter: allow requests to different hosts ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39657?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic87674f2381b3c6a1be6d0ce28a9e5403cda201b Gerrit-Change-Number: 39657 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Mar 2025 12:57:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: ASP loadsharing: Normal ASP distribution regardless of active state
by laforge 07 Mar '25

07 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39707?usp=email ) Change subject: ASP loadsharing: Normal ASP distribution regardless of active state ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39707?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2064fe89bac2d3bd86fee544a64ab21417e1c368 Gerrit-Change-Number: 39707 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Mar 2025 12:57:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: sccp: Allow marking UNIT-DATA.req Sequence Control param non-presence...
by pespin 07 Mar '25

07 Mar '25

Attention is currently required from: daniel, fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39690?usp=email ) Change subject: sccp: Allow marking UNIT-DATA.req Sequence Control param non-presence, set SLS ...................................................................... Patch Set 3: (1 comment) File src/sccp_sclc.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39690/comment/abe421ed_1efb3… : PS3, Line 84: xua->mtp.sls = rand() & 0xf; > this looks like it could by chance become the same sls as in the seq_ctrl present case below. […] It's totally fine and expected that the same SLS is used from time to time, after all it's only 4 bits. I simply forgot to add the preceding 0 "0x0f" here, but it's actually also correct this way. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39690?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I834e91c1ec337713b0e684cf4fd7de854150bef6 Gerrit-Change-Number: 39690 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Mar 2025 12:57:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: sccp_scrc: Improve logging of route lookup failure
by laforge 07 Mar '25

07 Mar '25

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39706?usp=email ) Change subject: sccp_scrc: Improve logging of route lookup failure ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I54a59f8b95451b473204d625acdc22dcfc94b631 Gerrit-Change-Number: 39706 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Mar 2025 12:56:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: es8p: fix typo
by dexter 07 Mar '25

07 Mar '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/39734?usp=email ) Change subject: es8p: fix typo ...................................................................... es8p: fix typo Change-Id: I241efe0c7ceab190b7729a6d88101501ca37652e --- M pySim/esim/es8p.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/34/39734/1 diff --git a/pySim/esim/es8p.py b/pySim/esim/es8p.py index dd653f8..dd0c4bc 100644 --- a/pySim/esim/es8p.py +++ b/pySim/esim/es8p.py @@ -97,7 +97,7 @@ self.notifications.append((event, address)) def gen_store_metadata_request(self) -> bytes: - """Generate encoded (but unsigned) StoreMetadataReqest DO (SGP.22 5.5.3)""" + """Generate encoded (but unsigned) StoreMetadataRequest DO (SGP.22 5.5.3)""" smr = { 'iccid': self.iccid_bin, 'serviceProviderName': self.spn, -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39734?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I241efe0c7ceab190b7729a6d88101501ca37652e Gerrit-Change-Number: 39734 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Server_Emulation: allow multiple HTTP server ports
by dexter 07 Mar '25

07 Mar '25

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39733?usp=email ) Change subject: HTTP_Server_Emulation: allow multiple HTTP server ports ...................................................................... HTTP_Server_Emulation: allow multiple HTTP server ports At the moment the HTTP_Server_Emulation component can only provide a single HTTP server. Let's extend it so that it can provide multiple HTTP server. Related: SYS#7339 Change-Id: I11df9df5c3041f977b458835e923c74abe3bba7b --- M eim/eIM_Tests.ttcn M ipad/IPAd_Tests.ttcn M library/HTTP_Server_Emulation.ttcn 3 files changed, 17 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/33/39733/1 diff --git a/eim/eIM_Tests.ttcn b/eim/eIM_Tests.ttcn index da5d571..5dcbdab 100644 --- a/eim/eIM_Tests.ttcn +++ b/eim/eIM_Tests.ttcn @@ -108,8 +108,8 @@ /* connect ES9+/HTTP-server ports */ if (isbound(vc_HTTP)) { - connect(vc_conn:HTTP_SRV, vc_HTTP:CLIENT); - connect(vc_conn:HTTP_SRV_PROC, vc_HTTP:CLIENT_PROC); + connect(vc_conn:HTTP_SRV[0], vc_HTTP:CLIENT); + connect(vc_conn:HTTP_SRV_PROC[0], vc_HTTP:CLIENT_PROC); } vc_conn.start(f_init_handler(fn, id, pars)); @@ -172,7 +172,7 @@ T.start; alt { - [] HTTP_SRV.receive({ request := ? }) -> value es9p_req { + [] HTTP_SRV[0].receive({ request := ? }) -> value es9p_req { dec_RemoteProfileProvisioningRequest_from_JSON(es9p_req.request.body, request); } [] T.timeout { @@ -187,7 +187,7 @@ private function f_es9p_send(RemoteProfileProvisioningResponse es9p_res) runs on eIM_ConnHdlr { var charstring es9p_res_json; enc_RemoteProfileProvisioningResponse_to_JSON(es9p_res, es9p_res_json); - HTTP_SRV.send(ts_http_resp(es9p_res_json)); + HTTP_SRV[0].send(ts_http_resp(es9p_res_json)); } /* Perform Es9p HTTP request/response cycle */ diff --git a/ipad/IPAd_Tests.ttcn b/ipad/IPAd_Tests.ttcn index 04e4b1d..c8f3928 100644 --- a/ipad/IPAd_Tests.ttcn +++ b/ipad/IPAd_Tests.ttcn @@ -134,8 +134,8 @@ vc_conn := IPAd_ConnHdlr.create(id); if (isbound(vc_HTTP)) { - connect(vc_conn:HTTP_SRV, vc_HTTP:CLIENT); - connect(vc_conn:HTTP_SRV_PROC, vc_HTTP:CLIENT_PROC); + connect(vc_conn:HTTP_SRV[0], vc_HTTP:CLIENT); + connect(vc_conn:HTTP_SRV_PROC[0], vc_HTTP:CLIENT_PROC); } vc_conn.start(f_init_handler(fn, id, pars)); @@ -352,7 +352,7 @@ T.start; alt { - [] HTTP_SRV.receive({ request_binary := ? }) -> value esipa_req_encoded { + [] HTTP_SRV[0].receive({ request_binary := ? }) -> value esipa_req_encoded { esipa_req := dec_EsipaMessageFromIpaToEim(esipa_req_encoded.request_binary.body); if (not istemplatekind(expected_esipa_req, "omit")) { if (not match(valueof(esipa_req), expected_esipa_req)) { @@ -372,7 +372,7 @@ private function f_esipa_send(EsipaMessageFromEimToIpa esipa_res) runs on IPAd_ConnHdlr { var octetstring esipa_res_encoded; esipa_res_encoded := enc_EsipaMessageFromEimToIpa(esipa_res); - HTTP_SRV.send(ts_http_resp(esipa_res_encoded)); + HTTP_SRV[0].send(ts_http_resp(esipa_res_encoded)); } /* Perform one ESipa HTTP request/response cycle */ @@ -392,7 +392,7 @@ var EsipaMessageFromIpaToEim esipa_req; esipa_req := f_esipa_receive(expected_esipa_req); - HTTP_SRV.send(ts_http_resp(''O)); + HTTP_SRV[0].send(ts_http_resp(''O)); return esipa_req; } diff --git a/library/HTTP_Server_Emulation.ttcn b/library/HTTP_Server_Emulation.ttcn index 16d142d..9270ccb 100644 --- a/library/HTTP_Server_Emulation.ttcn +++ b/library/HTTP_Server_Emulation.ttcn @@ -134,13 +134,16 @@ ***********************************************************************/ type component HTTP_ConnHdlr { - port HTTP_SRV_PT HTTP_SRV; - port HTTP_SRV_PROC_PT HTTP_SRV_PROC; + /* These ports are not connected to anything in this component, they + * serve as connection points for the component that extends this + * coponent. */ + port HTTP_SRV_PT HTTP_SRV[16]; + port HTTP_SRV_PROC_PT HTTP_SRV_PROC[16]; }; -function f_http_register() runs on HTTP_ConnHdlr { - HTTP_SRV_PROC.call(HTTPEM_register:{}) { - [] HTTP_SRV_PROC.getreply(HTTPEM_register:{}); +function f_http_register(integer id := 0) runs on HTTP_ConnHdlr { + HTTP_SRV_PROC[id].call(HTTPEM_register:{}) { + [] HTTP_SRV_PROC[id].getreply(HTTPEM_register:{}); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39733?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I11df9df5c3041f977b458835e923c74abe3bba7b Gerrit-Change-Number: 39733 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: add missing omit qualifiers
by dexter 07 Mar '25

07 Mar '25

Attention is currently required from: dexter. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39692?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: HTTP_Adapter: add missing omit qualifiers ...................................................................... HTTP_Adapter: add missing omit qualifiers On some function in the HTTP_Adapter module, the (omit) qualifiers are missing. Related: SYS#7339 Change-Id: I985021852cbe2bcce60b1466e8ec9c3820a0c0f8 --- M library/HTTP_Adapter.ttcn 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/92/39692/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39692?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I985021852cbe2bcce60b1466e8ec9c3820a0c0f8 Gerrit-Change-Number: 39692 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow requests to different hosts
by dexter 07 Mar '25

07 Mar '25

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39657?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: HTTP_Adapter: allow requests to different hosts ...................................................................... HTTP_Adapter: allow requests to different hosts The host that is requested via the HTTP_Adapter is configured once on initialization. This is fine if the test scenario only has exactly one destination to query. For multiple destinations, this model does not work. Let's add an http_pars parameter to the request functions, so that the user can direct the requests to different hosts dynamically. Related: SYS#7339 Change-Id: Ic87674f2381b3c6a1be6d0ce28a9e5403cda201b --- M library/HTTP_Adapter.ttcn 1 file changed, 27 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/57/39657/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39657?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic87674f2381b3c6a1be6d0ce28a9e5403cda201b Gerrit-Change-Number: 39657 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: HTTP_Adapter: allow requests to different hosts
by dexter 07 Mar '25

07 Mar '25

Attention is currently required from: fixeria, laforge, pespin. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39657?usp=email ) Change subject: HTTP_Adapter: allow requests to different hosts ...................................................................... Patch Set 3: (1 comment) File library/HTTP_Adapter.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39657/comment/70ae5f82_f6e2… : PS2, Line 23: template HTTP_Adapter_Params > Acknowledged Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39657?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic87674f2381b3c6a1be6d0ce28a9e5403cda201b Gerrit-Change-Number: 39657 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Mar 2025 11:24:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0