Attention is currently required from: daniel, fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39690?usp=email ) Change subject: sccp: Allow marking UNIT-DATA.req Sequence Control param non-presence, set SLS ...................................................................... Patch Set 3: (1 comment) File src/sccp_sclc.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39690/comment/abe421ed_1efb34... : PS3, Line 84: xua->mtp.sls = rand() & 0xf;

this looks like it could by chance become the same sls as in the seq_ctrl present case below. […] It's totally fine and expected that the same SLS is used from time to time, after all it's only 4 bits. I simply forgot to add the preceding 0 "0x0f" here, but it's actually also correct this way.

-- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39690?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I834e91c1ec337713b0e684cf4fd7de854150bef6 Gerrit-Change-Number: 39690 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Fri, 07 Mar 2025 12:57:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith@sysmocom.de>