Attention is currently required from: Hoernchen, osmith.
laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39439?usp=email )
Change subject: tame the linter
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39439?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: I745b741dedf2c2ed5679c289e70adcb01c750e4d
Gerrit-Change-Number: 39439
Gerrit-PatchSet: 9
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 13 Mar 2025 15:00:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39775?usp=email )
Change subject: stream_{cli,srv}: fix copy-paste in API docs
......................................................................
stream_{cli,srv}: fix copy-paste in API docs
Change-Id: I8ec783b8db36a017dc3fe111b0ca0938488ae03d
---
M src/stream_cli.c
M src/stream_srv.c
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/stream_cli.c b/src/stream_cli.c
index fa3ac76..0028dcc 100644
--- a/src/stream_cli.c
+++ b/src/stream_cli.c
@@ -873,10 +873,10 @@
return 0;
}
-/*! Set the socket type for the stream server link.
+/*! Set the socket domain for the stream client link.
* Any changes to this setting will only become active upon next (re)connect.
* \param[in] cli Stream Client to modify
- * \param[in] type Socket Domain (like AF_UNSPEC (default for IP), AF_UNIX, AF_INET, ...)
+ * \param[in] domain Socket Domain (like AF_UNSPEC (default for IP), AF_UNIX, AF_INET, ...)
* \returns zero on success, negative -errno on error.
*/
int osmo_stream_cli_set_domain(struct osmo_stream_cli *cli, int domain)
diff --git a/src/stream_srv.c b/src/stream_srv.c
index 366fe64..50efbb8 100644
--- a/src/stream_srv.c
+++ b/src/stream_srv.c
@@ -366,10 +366,10 @@
return 0;
}
-/*! Set the socket type for the stream server link.
+/*! Set the socket domain for the stream server link.
* Any changes to this setting will only become active upon next (re)connect.
* \param[in] link Stream Server Link to modify
- * \param[in] type Socket Domain (like AF_UNSPEC (default for IP), AF_UNIX, AF_INET, ...)
+ * \param[in] domain Socket Domain (like AF_UNSPEC (default for IP), AF_UNIX, AF_INET, ...)
* \returns zero on success, negative on error.
*/
int osmo_stream_srv_link_set_domain(struct osmo_stream_srv_link *link, int domain)
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39775?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I8ec783b8db36a017dc3fe111b0ca0938488ae03d
Gerrit-Change-Number: 39775
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39775?usp=email )
Change subject: stream_{cli,srv}: fix copy-paste in API docs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39775?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I8ec783b8db36a017dc3fe111b0ca0938488ae03d
Gerrit-Change-Number: 39775
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 13 Mar 2025 14:59:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes