March 2025 - gerrit-log - lists.osmocom.org

[XS] Change in libosmo-sigtran[master]: sccp_scrc: Improve logging of route lookup failure
by pespin 05 Mar '25

05 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39706?usp=email ) Change subject: sccp_scrc: Improve logging of route lookup failure ...................................................................... sccp_scrc: Improve logging of route lookup failure Change-Id: I54a59f8b95451b473204d625acdc22dcfc94b631 --- M src/sccp_scrc.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/06/39706/1 diff --git a/src/sccp_scrc.c b/src/sccp_scrc.c index 869235c..63ded9d 100644 --- a/src/sccp_scrc.c +++ b/src/sccp_scrc.c @@ -154,8 +154,9 @@ rt = ss7_instance_lookup_route(inst->ss7, &rtlabel); if (!rt) { - LOGP(DLSCCP, LOGL_ERROR, "MTP-TRANSFER.req from SCCP for " - "DPC %u: no route!\n", xua->mtp.dpc); + char buf[256]; + LOGP(DLSCCP, LOGL_ERROR, "MTP-TRANSFER.req from SCCP for %s: no route!\n", + ss7_route_label_to_str(buf, sizeof(buf), inst->ss7, &rtlabel)); return -1; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I54a59f8b95451b473204d625acdc22dcfc94b631 Gerrit-Change-Number: 39706 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: ASP loadsharing: Normal ASP distribution regardless of active state
by pespin 05 Mar '25

05 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39707?usp=email ) Change subject: ASP loadsharing: Normal ASP distribution regardless of active state ...................................................................... ASP loadsharing: Normal ASP distribution regardless of active state Before this patch, the normal ASP for a given loadshare eSLS entry (seed) would only be filled in with active ASPs. That means that if eg. N ASPs are configured but only 1 is successfully activated upon startup and a lot of traffic happens, the full eSLS will be filled with that ASP, and as a result all traffic will be sent to that ASP, with the exception during the time that ASP is inactive. Instead, we want to populate the eSLS table with Normal ASP field properly distributed over all ASPs. If a given ASP is not active at that time, then simply pick an Alternative ASP during that time. Change-Id: I2064fe89bac2d3bd86fee544a64ab21417e1c368 --- M src/osmo_ss7_as.c M src/ss7_as.h 2 files changed, 46 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/07/39707/1 diff --git a/src/osmo_ss7_as.c b/src/osmo_ss7_as.c index 35a2650..22fcb14 100644 --- a/src/osmo_ss7_as.c +++ b/src/osmo_ss7_as.c @@ -304,6 +304,33 @@ return asp; } +/* Pick an ASP serving AS in a round-robin fashion. + * During Loadshare eSLS table generation we want to pick Normal ASP + * in a distributed fashion, regardless of active state (Alternative ASP will + * be picked up temporarily later on if needed). + * Morevoer, we must use a different index from the "active" + * ss7_as_select_asp_roundrobin() below, in order to avoid tainting the + * distribution. */ +static struct osmo_ss7_asp *ss7_as_assign_asp_roundrobin(struct osmo_ss7_as *as) +{ + struct osmo_ss7_asp *asp; + unsigned int i; + unsigned int first_idx; + + first_idx = (as->cfg.last_asp_idx_assigned + 1) % ARRAY_SIZE(as->cfg.asps); + i = first_idx; + do { + asp = as->cfg.asps[i]; + if (asp) + break; + i = (i + 1) % ARRAY_SIZE(as->cfg.asps); + } while (i != first_idx); + as->cfg.last_asp_idx_assigned = i; + + return asp; +} + +/* Pick an active ASP serving AS in a round-robin fashion, to send a message to. */ static struct osmo_ss7_asp *ss7_as_select_asp_roundrobin(struct osmo_ss7_as *as) { struct osmo_ss7_asp *asp; @@ -397,17 +424,24 @@ /* No current ASP available, try to find a new current ASP: */ - /* No normal route selected yet: */ + /* No normal route assigned yet: */ if (!aeslse->normal_asp) { - asp = ss7_as_select_asp_roundrobin(as); - /* Either a normal route was selected or none found: */ + /* Establish a Normal ASP, regardless of active state: */ + asp = ss7_as_assign_asp_roundrobin(as); + /* No ASP found for Normal ASP, regardless of state... */ + if (!asp) + return NULL; aeslse->normal_asp = asp; - if (asp) - LOGPAS(as, DLSS7, LOGL_DEBUG, "Tx Loadshare: OPC=%u=%s,SLS=%u -> eSLS=%u: " - "picked Normal ASP '%s' round-robin style\n", - mtp->opc, osmo_ss7_pointcode_print(as->inst, mtp->opc), - mtp->sls, as_ext_sls, asp->cfg.name); - return asp; + LOGPAS(as, DLSS7, LOGL_DEBUG, "Tx Loadshare: OPC=%u=%s,SLS=%u -> eSLS=%u: " + "picked Normal ASP '%s' round-robin style\n", + mtp->opc, osmo_ss7_pointcode_print(as->inst, mtp->opc), + mtp->sls, as_ext_sls, aeslse->normal_asp->cfg.name); + if (osmo_ss7_asp_active(aeslse->normal_asp)) { + /* Found active Normal Route: */ + return aeslse->normal_asp; + } + /* Normal ASP was assigned, but it is not active, fall-through + * below to attempt transmission through Alternative ASP: */ } /* Normal ASP unavailable and no alternative ASP (or unavailable too). diff --git a/src/ss7_as.h b/src/ss7_as.h index c4dfdf6..13592e9 100644 --- a/src/ss7_as.h +++ b/src/ss7_as.h @@ -108,7 +108,9 @@ } pc_override; struct osmo_ss7_asp *asps[16]; - uint8_t last_asp_idx_sent; /* used for load-sharing traffic mode (round robin implementation) */ + /* used for load-sharing traffic mode (round robin implementation) */ + uint8_t last_asp_idx_assigned; + uint8_t last_asp_idx_sent; struct { /* How many bits from ITU SLS field (starting from least-significant-bit) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39707?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2064fe89bac2d3bd86fee544a64ab21417e1c368 Gerrit-Change-Number: 39707 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: route: osmo_ss7_route_name(): Use osmo_ss7_pointcode_print_buf()
by pespin 05 Mar '25

05 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39709?usp=email ) Change subject: route: osmo_ss7_route_name(): Use osmo_ss7_pointcode_print_buf() ...................................................................... route: osmo_ss7_route_name(): Use osmo_ss7_pointcode_print_buf() This allows callers to call osmo_ss7_route_name() together with osmo_ss7_pointcode_print() and osmo_ss7_pointcode_print2() in the same LOG line. Change-Id: Iccbd83eeaa0e1c2a6078ece8d5c6d7af6fd9d71a --- M src/osmo_ss7_route.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/09/39709/1 diff --git a/src/osmo_ss7_route.c b/src/osmo_ss7_route.c index f75e32a..7783f85 100644 --- a/src/osmo_ss7_route.c +++ b/src/osmo_ss7_route.c @@ -286,6 +286,8 @@ const char *osmo_ss7_route_name(struct osmo_ss7_route *rt, bool list_asps) { static char buf[256]; + char pc_str[MAX_PC_STR_LEN]; + char mask_str[MAX_PC_STR_LEN]; char *pos = buf; struct osmo_ss7_instance *inst; size_t l; @@ -304,8 +306,8 @@ } while (0) APPEND("pc=%u=%s mask=0x%x=%s", - rt->cfg.pc, osmo_ss7_pointcode_print(inst, rt->cfg.pc), - rt->cfg.mask, osmo_ss7_pointcode_print2(inst, rt->cfg.mask)); + rt->cfg.pc, osmo_ss7_pointcode_print_buf(pc_str, sizeof(pc_str), inst, rt->cfg.pc), + rt->cfg.mask, osmo_ss7_pointcode_print_buf(mask_str, sizeof(mask_str), inst, rt->cfg.mask)); if (rt->dest.as) { struct osmo_ss7_as *as = rt->dest.as; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39709?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iccbd83eeaa0e1c2a6078ece8d5c6d7af6fd9d71a Gerrit-Change-Number: 39709 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: AS loadsharing: Normal route distribution regardless of active state
by pespin 05 Mar '25

05 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39708?usp=email ) Change subject: AS loadsharing: Normal route distribution regardless of active state ...................................................................... AS loadsharing: Normal route distribution regardless of active state Before this patch, the normal route for a given loadshare eSLS entry (seed) would only be filled in with available routes. That means that if eg. N routes are configured but only 1 is really available upon startup and a lot of traffic happens, the full eSLS will be filled with that route, and as a result all traffic on that combined linkset will be sent through that route. Instead, we want to populate the eSLS table with Normal Route field properly distributed over all routes. If a given route is not active at that time, then simply pick an Alternative Route during that time. Change-Id: I6daf114416c69c84bdc3042efcaf2918f91c2e87 --- M src/osmo_ss7_combined_linkset.c M src/ss7_combined_linkset.h 2 files changed, 60 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/08/39708/1 diff --git a/src/osmo_ss7_combined_linkset.c b/src/osmo_ss7_combined_linkset.c index a741aba..37da4fc 100644 --- a/src/osmo_ss7_combined_linkset.c +++ b/src/osmo_ss7_combined_linkset.c @@ -151,11 +151,17 @@ } /* Update round robin state */ - if (rt == clset->last_route_roundrobin) { - ss7_llist_round_robin(&clset->routes, &clset->last_route_roundrobin, struct osmo_ss7_route, list); + if (rt == clset->last_route_roundrobin_ass) { + ss7_llist_round_robin(&clset->routes, &clset->last_route_roundrobin_ass, struct osmo_ss7_route, list); /* If there's only one left, remove state: */ - if (rt == clset->last_route_roundrobin) - clset->last_route_roundrobin = NULL; + if (rt == clset->last_route_roundrobin_ass) + clset->last_route_roundrobin_ass = NULL; + } + if (rt == clset->last_route_roundrobin_tx) { + ss7_llist_round_robin(&clset->routes, &clset->last_route_roundrobin_tx, struct osmo_ss7_route, list); + /* If there's only one left, remove state: */ + if (rt == clset->last_route_roundrobin_tx) + clset->last_route_roundrobin_tx = NULL; } llist_del(&rt->list); @@ -195,6 +201,36 @@ return NULL; } +/* Pick a Route from Combined Linkset in a round-robin fashion. + * During Loadshare eSLS table generation we want to pick Normal Route + * in a distributed fashion, regardless of active state (Alternative Route will + * be picked up temporarily later on if needed). + * Morevoer, we must use a different index from the "active" + * ss7_combined_linkset_select_route_roundrobin() below, in order to avoid tainting + * the distribution. + */ +static struct osmo_ss7_route *ss7_combined_linkset_assign_route_roundrobin(struct osmo_ss7_combined_linkset *clset) +{ + struct osmo_ss7_route *rt; + struct osmo_ss7_route *rt_found = NULL; + unsigned int i = 0; + + while (i < clset->num_routes) { + i++; + rt = ss7_llist_round_robin(&clset->routes, &clset->last_route_roundrobin_ass, struct osmo_ss7_route, list); + if (rt) { + rt_found = rt; + break; + } + } + + if (!rt_found) + return NULL; + + return rt_found; +} + +/* Pick an available route from Combined Linkset in a round-robin fashion, to send a message through. */ static struct osmo_ss7_route *ss7_combined_linkset_select_route_roundrobin(struct osmo_ss7_combined_linkset *clset) { struct osmo_ss7_route *rt; @@ -203,8 +239,8 @@ while (i < clset->num_routes) { i++; - rt = ss7_llist_round_robin(&clset->routes, &clset->last_route_roundrobin, struct osmo_ss7_route, list); - if (ss7_route_is_available(rt)) { + rt = ss7_llist_round_robin(&clset->routes, &clset->last_route_roundrobin_tx, struct osmo_ss7_route, list); + if (rt && ss7_route_is_available(rt)) { rt_found = rt; break; } @@ -256,18 +292,24 @@ /* No normal route selected yet: */ if (!eslse->normal_rt) { - rt = ss7_combined_linkset_select_route_roundrobin(clset); - /* Either a normal route was selected or none found: */ + /* Establish a Normal Route, regardless of available state: */ + rt = ss7_combined_linkset_assign_route_roundrobin(clset); + /* No route found for Normal Route, regardless of state... */ + if (!rt) + return NULL; eslse->normal_rt = rt; - if (rt) { - LOGPCLSET(clset, DLSS7, LOGL_DEBUG, "RT loookup: OPC=%u=%s,DPC=%u=%s,SLS=%u -> eSLS=%u: " - "picked Normal Route via '%s' round-robin style\n", - rtlabel->opc, osmo_ss7_pointcode_print(inst, rtlabel->opc), - rtlabel->dpc, osmo_ss7_pointcode_print2(inst, rtlabel->dpc), - rtlabel->sls, esls, - rt->dest.as ? rt->dest.as->cfg.name : "<linkset>"); + LOGPCLSET(clset, DLSS7, LOGL_DEBUG, "RT loookup: OPC=%u=%s,DPC=%u=%s,SLS=%u -> eSLS=%u: " + "picked Normal Route via '%s' round-robin style\n", + rtlabel->opc, osmo_ss7_pointcode_print(inst, rtlabel->opc), + rtlabel->dpc, osmo_ss7_pointcode_print2(inst, rtlabel->dpc), + rtlabel->sls, esls, + rt->dest.as ? rt->dest.as->cfg.name : "<linkset>"); + if (ss7_route_is_available(eslse->normal_rt)) { + /* Found available Normal Route: */ + return eslse->normal_rt; } - return rt; + /* Normal Route was assigned, but it is not active, fall-through + * below to attempt transmission through Alternative Route: */ } /* Normal route unavailable and no alternative route (or unavailable too). diff --git a/src/ss7_combined_linkset.h b/src/ss7_combined_linkset.h index b79810b..432ebd7 100644 --- a/src/ss7_combined_linkset.h +++ b/src/ss7_combined_linkset.h @@ -33,7 +33,8 @@ /*! list of \ref osmo_ss7_route */ struct llist_head routes; unsigned int num_routes; - void *last_route_roundrobin; + void *last_route_roundrobin_ass; + void *last_route_roundrobin_tx; struct { uint32_t pc; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39708?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6daf114416c69c84bdc3042efcaf2918f91c2e87 Gerrit-Change-Number: 39708 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: vty: Add cmd 'show cs7 instance <0-15> as name AS_NAME'
by pespin 05 Mar '25

05 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39710?usp=email ) Change subject: vty: Add cmd 'show cs7 instance <0-15> as name AS_NAME' ...................................................................... vty: Add cmd 'show cs7 instance <0-15> as name AS_NAME' As also available in Cisco ITP. Change-Id: I76be29aeacb60201ecb5bab2203f02e3cdfc0943 --- M src/osmo_ss7_vty.c M tests/vty/osmo_stp_test.vty 2 files changed, 65 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/10/39710/1 diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index 83890b8..63b127c 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -2358,29 +2358,43 @@ vty_out(vty, " point-code override patch-sccp both%s", VTY_NEWLINE); } -DEFUN(show_cs7_as, show_cs7_as_cmd, - "show cs7 instance <0-15> as (active|all|m3ua|sua)", - SHOW_STR CS7_STR INST_STR INST_STR "Application Server (AS)\n" - "Display all active ASs\n" - "Display all ASs (default)\n" - "Display all m3ua ASs\n" - "Display all SUA ASs\n") +static void show_one_as(struct vty *vty, struct osmo_ss7_as *as) +{ + vty_out(vty, "%-12s %-12s %-10u %-13s %4s %13s %3s %5s %4s %10s%s", + as->cfg.name, osmo_fsm_inst_state_name(as->fi), as->cfg.routing_key.context, + osmo_ss7_pointcode_print(as->inst, as->cfg.routing_key.pc), + "", "", "", "", "", osmo_ss7_as_traffic_mode_name(as->cfg.mode), + VTY_NEWLINE); +} + +static int show_as(struct vty *vty, int id, const char *as_name, const char *filter) { struct osmo_ss7_instance *inst; - struct osmo_ss7_as *as; - const char *filter = argv[1]; - int id = atoi(argv[0]); + struct osmo_ss7_as *as = NULL; inst = osmo_ss7_instance_find(id); if (!inst) { - vty_out(vty, "No SS7 instance %d found%s", id, VTY_NEWLINE); + vty_out(vty, "%% No SS7 instance %d found%s", id, VTY_NEWLINE); return CMD_WARNING; } + if (as_name) { + as = osmo_ss7_as_find_by_name(inst, as_name); + if (!as) { + vty_out(vty, "%% No AS '%s' found%s", as_name, VTY_NEWLINE); + return CMD_WARNING; + } + } + vty_out(vty, " Routing Routing Key Cic Cic Traffic%s", VTY_NEWLINE); vty_out(vty, "AS Name State Context Dpc Si Opc Ssn Min Max Mode%s", VTY_NEWLINE); vty_out(vty, "------------ ------------ ---------- ------------- ---- ------------- --- ----- ----- -------%s", VTY_NEWLINE); + if (as) { + show_one_as(vty, as); + return CMD_SUCCESS; + } + llist_for_each_entry(as, &inst->as_list, list) { if (filter && !strcmp(filter, "m3ua") && as->cfg.proto != OSMO_SS7_ASP_PROT_M3UA) continue; @@ -2388,15 +2402,37 @@ continue; if (filter && !strcmp(filter, "active") && !osmo_ss7_as_active(as)) continue; - vty_out(vty, "%-12s %-12s %-10u %-13s %4s %13s %3s %5s %4s %10s%s", - as->cfg.name, osmo_fsm_inst_state_name(as->fi), as->cfg.routing_key.context, - osmo_ss7_pointcode_print(as->inst, as->cfg.routing_key.pc), - "", "", "", "", "", osmo_ss7_as_traffic_mode_name(as->cfg.mode), - VTY_NEWLINE); + show_one_as(vty, as); } return CMD_SUCCESS; } +DEFUN(show_cs7_as, show_cs7_as_cmd, + "show cs7 instance <0-15> as (active|all|m3ua|sua)", + SHOW_STR CS7_STR INST_STR INST_STR "Application Server (AS)\n" + "Display all active ASs\n" + "Display all ASs (default)\n" + "Display all m3ua ASs\n" + "Display all SUA ASs\n") +{ + const char *filter = argv[1]; + int id = atoi(argv[0]); + + return show_as(vty, id, NULL, filter); +} + +DEFUN(show_cs7_as_name, show_cs7_as_name_cmd, + "show cs7 instance <0-15> as name AS_NAME", + SHOW_STR CS7_STR INST_STR INST_STR "Application Server (AS)\n" + "Look up AS with a given name\n" + "Name of the Application Server (AS)\n") +{ + int id = atoi(argv[0]); + const char *as_name = argv[1]; + + return show_as(vty, id, as_name, NULL); +} + /*********************************************************************** * SCCP addressbook handling ***********************************************************************/ @@ -3269,6 +3305,7 @@ install_node(&as_node, NULL); install_lib_element_ve(&show_cs7_as_cmd); + install_lib_element_ve(&show_cs7_as_name_cmd); install_lib_element(L_CS7_NODE, &cs7_as_cmd); install_lib_element(L_CS7_NODE, &no_cs7_as_cmd); install_lib_element(L_CS7_AS_NODE, &cfg_description_cmd); diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index 58a1ee0..81515c1 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -11,6 +11,7 @@ show cs7 instance <0-15> asp-assoc-status show cs7 instance <0-15> asp-assoc-status name ASP_NAME show cs7 instance <0-15> as (active|all|m3ua|sua) + show cs7 instance <0-15> as name AS_NAME show cs7 instance <0-15> route [POINT_CODE] show cs7 instance <0-15> route-lookup POINT_CODE from POINT_CODE sls <0-15> [list-asps] show cs7 instance <0-15> sccp addressbook @@ -35,6 +36,7 @@ show cs7 instance <0-15> asp-assoc-status show cs7 instance <0-15> asp-assoc-status name ASP_NAME show cs7 instance <0-15> as (active|all|m3ua|sua) + show cs7 instance <0-15> as name AS_NAME show cs7 instance <0-15> route [POINT_CODE] show cs7 instance <0-15> route-lookup POINT_CODE from POINT_CODE sls <0-15> [list-asps] show cs7 instance <0-15> sccp addressbook @@ -88,6 +90,7 @@ all Display all ASs (default) m3ua Display all m3ua ASs sua Display all SUA ASs + name Look up AS with a given name OsmoSTP# show cs7 instance 0 sccp ? addressbook List all SCCP addressbook entries @@ -402,6 +405,15 @@ ------------ ------------ ---------- ------------- ---- ------------- --- ----- ----- ------- my-ass AS_DOWN 0 0.0.0 override +OsmoSTP(config-cs7-as)# do show cs7 instance 0 as name my-ass + Routing Routing Key Cic Cic Traffic +AS Name State Context Dpc Si Opc Ssn Min Max Mode +------------ ------------ ---------- ------------- ---- ------------- --- ----- ----- ------- +my-ass AS_DOWN 0 0.0.0 override + +OsmoSTP(config-cs7-as)# do show cs7 instance 0 as name my-ass-not-exists +% No AS 'my-ass-not-exists' found + OsmoSTP(config-cs7-as)# asp my-asp OsmoSTP(config-cs7-as)# routing-key 0 3.2.1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39710?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I76be29aeacb60201ecb5bab2203f02e3cdfc0943 Gerrit-Change-Number: 39710 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: ASP loadsharing: vty: Add cmd 'show cs7 instance <0-15> as binding-ta...
by pespin 05 Mar '25

05 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39711?usp=email ) Change subject: ASP loadsharing: vty: Add cmd 'show cs7 instance <0-15> as binding-table name AS_NAME' ...................................................................... ASP loadsharing: vty: Add cmd 'show cs7 instance <0-15> as binding-table name AS_NAME' Similar to the one available in Cisco ITP, but output is organized differently, printed indexes by eSLS to fit our implementation. Change-Id: Ia2e16b541b229805be23971957f5f7edecf61ed1 --- M src/osmo_ss7_vty.c M tests/vty/osmo_stp_test.vty 2 files changed, 184 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/11/39711/1 diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index 63b127c..4344ea2 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -2433,6 +2433,49 @@ return show_as(vty, id, as_name, NULL); } +DEFUN(show_cs7_as_bindingtable_name, show_cs7_as_bindingtable_name_cmd, + "show cs7 instance <0-15> as binding-table name AS_NAME", + SHOW_STR CS7_STR INST_STR INST_STR "Application Server (AS)\n" + "Display binding table\n" + "Look up AS with a given name\n" + "Name of the Application Server (AS)\n") +{ + int id = atoi(argv[0]); + const char *as_name = argv[1]; + struct osmo_ss7_instance *inst; + struct osmo_ss7_as *as = NULL; + + inst = osmo_ss7_instance_find(id); + if (!inst) { + vty_out(vty, "No SS7 instance %d found%s", id, VTY_NEWLINE); + return CMD_WARNING; + } + + if (as_name) { + as = osmo_ss7_as_find_by_name(inst, as_name); + if (!as) { + vty_out(vty, "No AS %s found%s", as_name, VTY_NEWLINE); + return CMD_WARNING; + } + } + + vty_out(vty, "Loadshare Seed Normal ASP Active Alternative ASP Active%s", VTY_NEWLINE); + vty_out(vty, "-------------- --------------- ------ --------------- ------%s", VTY_NEWLINE); + + for (unsigned int i = 0; i < ARRAY_SIZE(as->aesls_table); i++) { + struct osmo_ss7_as_esls_entry *e = &as->aesls_table[i]; + vty_out(vty, "%-15u %-16s %-7s %-16s %-7s%s", + i, + e->normal_asp ? e->normal_asp->cfg.name : "-", + e->normal_asp ? (osmo_ss7_asp_active(e->normal_asp) ? "Yes" : "No") : "-", + e->alt_asp ? e->alt_asp->cfg.name : "-", + e->alt_asp ? (osmo_ss7_asp_active(e->alt_asp) ? "Yes" : "No") : "-", + VTY_NEWLINE); + } + + return CMD_SUCCESS; +} + /*********************************************************************** * SCCP addressbook handling ***********************************************************************/ @@ -3306,6 +3349,7 @@ install_node(&as_node, NULL); install_lib_element_ve(&show_cs7_as_cmd); install_lib_element_ve(&show_cs7_as_name_cmd); + install_lib_element_ve(&show_cs7_as_bindingtable_name_cmd); install_lib_element(L_CS7_NODE, &cs7_as_cmd); install_lib_element(L_CS7_NODE, &no_cs7_as_cmd); install_lib_element(L_CS7_AS_NODE, &cfg_description_cmd); diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index 81515c1..75f3eae 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -12,6 +12,7 @@ show cs7 instance <0-15> asp-assoc-status name ASP_NAME show cs7 instance <0-15> as (active|all|m3ua|sua) show cs7 instance <0-15> as name AS_NAME + show cs7 instance <0-15> as binding-table name AS_NAME show cs7 instance <0-15> route [POINT_CODE] show cs7 instance <0-15> route-lookup POINT_CODE from POINT_CODE sls <0-15> [list-asps] show cs7 instance <0-15> sccp addressbook @@ -37,6 +38,7 @@ show cs7 instance <0-15> asp-assoc-status name ASP_NAME show cs7 instance <0-15> as (active|all|m3ua|sua) show cs7 instance <0-15> as name AS_NAME + show cs7 instance <0-15> as binding-table name AS_NAME show cs7 instance <0-15> route [POINT_CODE] show cs7 instance <0-15> route-lookup POINT_CODE from POINT_CODE sls <0-15> [list-asps] show cs7 instance <0-15> sccp addressbook @@ -86,11 +88,12 @@ sccp Signalling Connection Control Part OsmoSTP# show cs7 instance 0 as ? - active Display all active ASs - all Display all ASs (default) - m3ua Display all m3ua ASs - sua Display all SUA ASs - name Look up AS with a given name + active Display all active ASs + all Display all ASs (default) + m3ua Display all m3ua ASs + sua Display all SUA ASs + name Look up AS with a given name + binding-table Display binding table OsmoSTP# show cs7 instance 0 sccp ? addressbook List all SCCP addressbook entries @@ -414,6 +417,138 @@ OsmoSTP(config-cs7-as)# do show cs7 instance 0 as name my-ass-not-exists % No AS 'my-ass-not-exists' found +OsmoSTP(config-cs7-as)# do show cs7 instance 0 as binding-table name my-ass +Loadshare Seed Normal ASP Active Alternative ASP Active +-------------- --------------- ------ --------------- ------ +0 - - - - +1 - - - - +2 - - - - +3 - - - - +4 - - - - +5 - - - - +6 - - - - +7 - - - - +8 - - - - +9 - - - - +10 - - - - +11 - - - - +12 - - - - +13 - - - - +14 - - - - +15 - - - - +16 - - - - +17 - - - - +18 - - - - +19 - - - - +20 - - - - +21 - - - - +22 - - - - +23 - - - - +24 - - - - +25 - - - - +26 - - - - +27 - - - - +28 - - - - +29 - - - - +30 - - - - +31 - - - - +32 - - - - +33 - - - - +34 - - - - +35 - - - - +36 - - - - +37 - - - - +38 - - - - +39 - - - - +40 - - - - +41 - - - - +42 - - - - +43 - - - - +44 - - - - +45 - - - - +46 - - - - +47 - - - - +48 - - - - +49 - - - - +50 - - - - +51 - - - - +52 - - - - +53 - - - - +54 - - - - +55 - - - - +56 - - - - +57 - - - - +58 - - - - +59 - - - - +60 - - - - +61 - - - - +62 - - - - +63 - - - - +64 - - - - +65 - - - - +66 - - - - +67 - - - - +68 - - - - +69 - - - - +70 - - - - +71 - - - - +72 - - - - +73 - - - - +74 - - - - +75 - - - - +76 - - - - +77 - - - - +78 - - - - +79 - - - - +80 - - - - +81 - - - - +82 - - - - +83 - - - - +84 - - - - +85 - - - - +86 - - - - +87 - - - - +88 - - - - +89 - - - - +90 - - - - +91 - - - - +92 - - - - +93 - - - - +94 - - - - +95 - - - - +96 - - - - +97 - - - - +98 - - - - +99 - - - - +100 - - - - +101 - - - - +102 - - - - +103 - - - - +104 - - - - +105 - - - - +106 - - - - +107 - - - - +108 - - - - +109 - - - - +110 - - - - +111 - - - - +112 - - - - +113 - - - - +114 - - - - +115 - - - - +116 - - - - +117 - - - - +118 - - - - +119 - - - - +120 - - - - +121 - - - - +122 - - - - +123 - - - - +124 - - - - +125 - - - - +126 - - - - +127 - - - - + OsmoSTP(config-cs7-as)# asp my-asp OsmoSTP(config-cs7-as)# routing-key 0 3.2.1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39711?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia2e16b541b229805be23971957f5f7edecf61ed1 Gerrit-Change-Number: 39711 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: AS loadsharing: show cs7 instance <0-15> route binding-table [POINT_C...
by pespin 05 Mar '25

05 Mar '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39712?usp=email ) Change subject: AS loadsharing: show cs7 instance <0-15> route binding-table [POINT_CODE] ...................................................................... AS loadsharing: show cs7 instance <0-15> route binding-table [POINT_CODE] Similar to the one available for ASP loadsharing: 'show cs7 instance <0-15> as binding-table name AS_NAME' This allows debugging the state of the loadsharing seed table. Change-Id: I31664ca795d1a8572077f173ae95b504bc019eb3 --- M src/osmo_ss7_vty.c M tests/vty/osmo_stp_route_prio.vty M tests/vty/osmo_stp_test.vty 3 files changed, 216 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/12/39712/1 diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index 4344ea2..6ef94c0 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -49,6 +49,7 @@ #include "ss7_as.h" #include "ss7_asp.h" #include "ss7_combined_linkset.h" +#include <ss7_linkset.h> #include "ss7_route.h" #include "ss7_route_table.h" #include "ss7_internal.h" @@ -607,6 +608,84 @@ return CMD_SUCCESS; } +DEFUN(show_cs7_route_bindingtable, show_cs7_route_bindingtable_cmd, + "show cs7 instance <0-15> route binding-table [POINT_CODE] [all-matches]", + SHOW_STR CS7_STR INST_STR INST_STR + "Routing Table\n" + "Display binding table\n" + "Destination Point Code\n" + "Display all matching Combination Links\n") +{ + int id = atoi(argv[0]); + bool all = argc > 2; + struct osmo_ss7_instance *inst; + uint32_t filter_pc = OSMO_SS7_PC_INVALID; + struct osmo_ss7_combined_linkset *clset; + + inst = osmo_ss7_instance_find(id); + if (!inst) { + vty_out(vty, "No SS7 instance %d found%s", id, VTY_NEWLINE); + return CMD_WARNING; + } + + if (argc > 1) { + int pc = osmo_ss7_pointcode_parse(inst, argv[1]); + if (pc < 0 || !osmo_ss7_pc_is_valid((uint32_t)pc)) { + vty_out(vty, "Invalid point code (%s)%s", argv[1], VTY_NEWLINE); + return CMD_WARNING; + } + filter_pc = (uint32_t)pc; + } + + llist_for_each_entry(clset, &inst->rtable_system->combined_linksets, list) { + if ((filter_pc != OSMO_SS7_PC_INVALID) && ((filter_pc & clset->cfg.mask) != clset->cfg.pc)) + continue; /* Skip combined linksets not matching destination */ + + vty_out(vty, "%sCombined Linkset: dpc=%u=%s, mask=0x%x=%s, prio=%u%s", VTY_NEWLINE, + (clset)->cfg.pc, osmo_ss7_pointcode_print(clset->rtable->inst, clset->cfg.pc), + (clset)->cfg.mask, osmo_ss7_pointcode_print2(clset->rtable->inst, clset->cfg.mask), + (clset)->cfg.priority, VTY_NEWLINE); + vty_out(vty, "Loadshare Seed Normal Route Available Alternative Route Available%s", VTY_NEWLINE); + vty_out(vty, "-------------- --------------------- --------- --------------------- ---------%s", VTY_NEWLINE); + + for (unsigned int i = 0; i < ARRAY_SIZE(clset->esls_table); i++) { + struct osmo_ss7_esls_entry *e = &clset->esls_table[i]; + char normal_buf[128]; + char alt_buf[128]; + + #define RT_DEST_SPRINTF(buf, rt) \ + do { \ + if (rt) { \ + if ((rt)->dest.as) { \ + snprintf(buf, sizeof(buf), "%s", (rt)->dest.as->cfg.name); \ + } else if ((rt)->dest.linkset) { \ + snprintf(buf, sizeof(buf), "%s", (rt)->dest.linkset->cfg.name); \ + } else { \ + snprintf(buf, sizeof(buf), "<error>"); \ + } \ + } else { \ + snprintf(buf, sizeof(buf), "-"); \ + } \ + } while (0) + + RT_DEST_SPRINTF(normal_buf, e->normal_rt); + RT_DEST_SPRINTF(alt_buf, e->alt_rt); + + vty_out(vty, "%-15u %-22s %-10s %-22s %-10s%s", + i, + normal_buf, + e->normal_rt ? (ss7_route_is_available(e->normal_rt) ? "Yes" : "No") : "-", + alt_buf, + e->alt_rt ? (ss7_route_is_available(e->alt_rt) ? "Yes" : "No") : "-", + VTY_NEWLINE); + } + + if (!all) + break; + } + return CMD_SUCCESS; +} + DEFUN(show_cs7_route_lookup, show_cs7_route_lookup_cmd, "show cs7 instance <0-15> route-lookup POINT_CODE from POINT_CODE sls <0-15> [list-asps]", SHOW_STR CS7_STR INST_STR INST_STR @@ -3369,6 +3448,7 @@ install_lib_element(L_CS7_AS_NODE, &as_pc_patch_sccp_cmd); install_lib_element_ve(&show_cs7_route_cmd); + install_lib_element_ve(&show_cs7_route_bindingtable_cmd); install_lib_element_ve(&show_cs7_route_lookup_cmd); vty_init_addr(); diff --git a/tests/vty/osmo_stp_route_prio.vty b/tests/vty/osmo_stp_route_prio.vty index 2b7cec6..9e34d6e 100644 --- a/tests/vty/osmo_stp_route_prio.vty +++ b/tests/vty/osmo_stp_route_prio.vty @@ -87,6 +87,140 @@ 3.2.1/14 INACC 0 5 as2 UNAVAIL ? UNAVAIL 3.2.1/14 INACC 7 6 as1 UNAVAIL ? UNAVAIL +OsmoSTP(config-cs7-rt)# do show cs7 instance 0 route binding-table 3.2.1 + +Combined Linkset: dpc=6161=3.2.1, mask=0x3fff=7.255.7, prio=2 +Loadshare Seed Normal Route Available Alternative Route Available +-------------- --------------------- --------- --------------------- --------- +0 - - - - +1 - - - - +2 - - - - +3 - - - - +4 - - - - +5 - - - - +6 - - - - +7 - - - - +8 - - - - +9 - - - - +10 - - - - +11 - - - - +12 - - - - +13 - - - - +14 - - - - +15 - - - - +16 - - - - +17 - - - - +18 - - - - +19 - - - - +20 - - - - +21 - - - - +22 - - - - +23 - - - - +24 - - - - +25 - - - - +26 - - - - +27 - - - - +28 - - - - +29 - - - - +30 - - - - +31 - - - - +32 - - - - +33 - - - - +34 - - - - +35 - - - - +36 - - - - +37 - - - - +38 - - - - +39 - - - - +40 - - - - +41 - - - - +42 - - - - +43 - - - - +44 - - - - +45 - - - - +46 - - - - +47 - - - - +48 - - - - +49 - - - - +50 - - - - +51 - - - - +52 - - - - +53 - - - - +54 - - - - +55 - - - - +56 - - - - +57 - - - - +58 - - - - +59 - - - - +60 - - - - +61 - - - - +62 - - - - +63 - - - - +64 - - - - +65 - - - - +66 - - - - +67 - - - - +68 - - - - +69 - - - - +70 - - - - +71 - - - - +72 - - - - +73 - - - - +74 - - - - +75 - - - - +76 - - - - +77 - - - - +78 - - - - +79 - - - - +80 - - - - +81 - - - - +82 - - - - +83 - - - - +84 - - - - +85 - - - - +86 - - - - +87 - - - - +88 - - - - +89 - - - - +90 - - - - +91 - - - - +92 - - - - +93 - - - - +94 - - - - +95 - - - - +96 - - - - +97 - - - - +98 - - - - +99 - - - - +100 - - - - +101 - - - - +102 - - - - +103 - - - - +104 - - - - +105 - - - - +106 - - - - +107 - - - - +108 - - - - +109 - - - - +110 - - - - +111 - - - - +112 - - - - +113 - - - - +114 - - - - +115 - - - - +116 - - - - +117 - - - - +118 - - - - +119 - - - - +120 - - - - +121 - - - - +122 - - - - +123 - - - - +124 - - - - +125 - - - - +126 - - - - +127 - - - - + OsmoSTP(config-cs7-rt)# ! NOW TEST LOOKUP FAILS AS EXPECTED (all route links are down): OsmoSTP(config-cs7-rt)# do show cs7 instance 0 route-lookup 3.2.1 from 0.0.1 sls 0 No route found for label 'OPC=1=0.0.1,DPC=6161=3.2.1,SLS=0' diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index 75f3eae..fbe69a8 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -14,6 +14,7 @@ show cs7 instance <0-15> as name AS_NAME show cs7 instance <0-15> as binding-table name AS_NAME show cs7 instance <0-15> route [POINT_CODE] + show cs7 instance <0-15> route binding-table [POINT_CODE] [all-matches] show cs7 instance <0-15> route-lookup POINT_CODE from POINT_CODE sls <0-15> [list-asps] show cs7 instance <0-15> sccp addressbook show cs7 instance <0-15> sccp users @@ -40,6 +41,7 @@ show cs7 instance <0-15> as name AS_NAME show cs7 instance <0-15> as binding-table name AS_NAME show cs7 instance <0-15> route [POINT_CODE] + show cs7 instance <0-15> route binding-table [POINT_CODE] [all-matches] show cs7 instance <0-15> route-lookup POINT_CODE from POINT_CODE sls <0-15> [list-asps] show cs7 instance <0-15> sccp addressbook show cs7 instance <0-15> sccp users -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I31664ca795d1a8572077f173ae95b504bc019eb3 Gerrit-Change-Number: 39712 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in libosmo-sigtran[master]: AS loadsharing: Introduce combined_linkset
by pespin 05 Mar '25

05 Mar '25

Attention is currently required from: osmith. Hello Jenkins Builder, daniel, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38731?usp=email to look at the new patch set (#14). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: AS loadsharing: Introduce combined_linkset ...................................................................... AS loadsharing: Introduce combined_linkset A "Combined linkset" is a set of routes for different AS or linksets whose destination (DPC & mask) and priority are the same. An SP is expected to load share traffic among linksets/AS of a given combined linkset, based on DPC/OPC,SLS. This means certain state or heuristics need to be stored in the combined linkset in order to keep forwarding messages of the same transaction (SLS) over the same specific AS/linkset. This commit introduces the osmo_ss7_combined_linkset object, which is roughly a set of osmo_ss7_route sharing DPC+MASK+PRIO key, and it is placed in between the osmo_ss7_route_table and osmo_ss7_route entries. User still operates/manages indiviual routes, but those are grouped internally inside its corresponding combined linkset. No routing change is implemented in this commit. Code is only tweaked minimally so far to retrieve the first route in the combined link. This will allow future work, i.e to: - Check if data can be sent over the combined link (at least one AS/linkset is ACTIVE), and otherwise try using a combined link with a less specific match (shorter prefix mask or/and lower priority). - Select one of the AS/linksets inserted the combined link, based on OPC/DPC/SLS of the message. Related: SYS#7112 Change-Id: I500ec74ba975e3c93071771027e4e5fe6000e6f3 --- M src/Makefile.am A src/osmo_ss7_combined_linkset.c M src/osmo_ss7_route.c M src/osmo_ss7_route_table.c M src/osmo_ss7_vty.c A src/ss7_combined_linkset.h M src/ss7_route.h M src/ss7_route_table.h 8 files changed, 357 insertions(+), 95 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/31/38731/14 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38731?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I500ec74ba975e3c93071771027e4e5fe6000e6f3 Gerrit-Change-Number: 38731 Gerrit-PatchSet: 14 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: AS loadsharing: Introduce AS rate_ctr rx:msu:sls:*
by pespin 05 Mar '25

05 Mar '25

Attention is currently required from: pespin. Hello Jenkins Builder, daniel, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39406?usp=email to look at the new patch set (#10). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: AS loadsharing: Introduce AS rate_ctr rx:msu:sls:* ...................................................................... AS loadsharing: Introduce AS rate_ctr rx:msu:sls:* Related: SYS#7112 Change-Id: I695bd3933a116323db45ab7f45dcf539791139aa --- M src/ipa.c M src/m3ua.c M src/osmo_ss7_as.c M src/ss7_as.h M src/sua.c 5 files changed, 43 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/06/39406/10 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I695bd3933a116323db45ab7f45dcf539791139aa Gerrit-Change-Number: 39406 Gerrit-PatchSet: 10 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: AS loadsharing: Introduce AS rate_ctr tx:msu:sls:*
by pespin 05 Mar '25

05 Mar '25

Hello Jenkins Builder, daniel, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39407?usp=email to look at the new patch set (#10). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: AS loadsharing: Introduce AS rate_ctr tx:msu:sls:* ...................................................................... AS loadsharing: Introduce AS rate_ctr tx:msu:sls:* Related: SYS#7112 Change-Id: Ia446e11ea24ecb021a3dddf5547aa2b3cdbbe60b --- M src/osmo_ss7_as.c M src/osmo_ss7_hmrt.c M src/ss7_as.h 3 files changed, 35 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/07/39407/10 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39407?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia446e11ea24ecb021a3dddf5547aa2b3cdbbe60b Gerrit-Change-Number: 39407 Gerrit-PatchSet: 10 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0