March 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-pcu[master]: tests/alloc: alloc_tbfs(): fix always true condition
by pespin 06 Mar '25

06 Mar '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcu/+/39698?usp=email ) Change subject: tests/alloc: alloc_tbfs(): fix always true condition ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Would you like to take a look? I saw a warning while compiling with clang, saying that the assert co […] I can take a look, but not right now, probably in a few days. Feel free to ping me then if I forget about it. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39698?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia345938512a2f4f92523596beb19d7c127a8a601 Gerrit-Change-Number: 39698 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Mar 2025 12:18:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: ASP loadsharing: Normal ASP distribution regardless of active state
by osmith 06 Mar '25

06 Mar '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39707?usp=email ) Change subject: ASP loadsharing: Normal ASP distribution regardless of active state ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39707?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2064fe89bac2d3bd86fee544a64ab21417e1c368 Gerrit-Change-Number: 39707 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Mar 2025 12:17:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: ASP loadsharing: Normal ASP distribution regardless of active state
by pespin 06 Mar '25

06 Mar '25

Attention is currently required from: osmith. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39707?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: ASP loadsharing: Normal ASP distribution regardless of active state ...................................................................... ASP loadsharing: Normal ASP distribution regardless of active state Before this patch, the normal ASP for a given loadshare eSLS entry (seed) would only be filled in with active ASPs. That means that if eg. N ASPs are configured but only 1 is successfully activated upon startup and a lot of traffic happens, the full eSLS will be filled with that ASP, and as a result all traffic will be sent to that ASP, with the exception during the time that ASP is inactive. Instead, we want to populate the eSLS table with Normal ASP field properly distributed over all ASPs. If a given ASP is not active at that time, then simply pick an Alternative ASP during that time. Change-Id: I2064fe89bac2d3bd86fee544a64ab21417e1c368 --- M src/osmo_ss7_as.c M src/ss7_as.h 2 files changed, 46 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/07/39707/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39707?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2064fe89bac2d3bd86fee544a64ab21417e1c368 Gerrit-Change-Number: 39707 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: AS loadsharing: Normal route distribution regardless of active state
by pespin 06 Mar '25

06 Mar '25

Attention is currently required from: osmith. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39708?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: AS loadsharing: Normal route distribution regardless of active state ...................................................................... AS loadsharing: Normal route distribution regardless of active state Before this patch, the normal route for a given loadshare eSLS entry (seed) would only be filled in with available routes. That means that if eg. N routes are configured but only 1 is really available upon startup and a lot of traffic happens, the full eSLS will be filled with that route, and as a result all traffic on that combined linkset will be sent through that route. Instead, we want to populate the eSLS table with Normal Route field properly distributed over all routes. If a given route is not active at that time, then simply pick an Alternative Route during that time. Change-Id: I6daf114416c69c84bdc3042efcaf2918f91c2e87 --- M src/osmo_ss7_combined_linkset.c M src/ss7_combined_linkset.h 2 files changed, 54 insertions(+), 29 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/08/39708/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39708?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6daf114416c69c84bdc3042efcaf2918f91c2e87 Gerrit-Change-Number: 39708 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: AS loadsharing: show cs7 instance <0-15> route binding-table [POINT_C...
by pespin 06 Mar '25

06 Mar '25

Attention is currently required from: osmith. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39712?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: AS loadsharing: show cs7 instance <0-15> route binding-table [POINT_CODE] ...................................................................... AS loadsharing: show cs7 instance <0-15> route binding-table [POINT_CODE] Similar to the one available for ASP loadsharing: 'show cs7 instance <0-15> as binding-table name AS_NAME' This allows debugging the state of the loadsharing seed table. Change-Id: I31664ca795d1a8572077f173ae95b504bc019eb3 --- M src/osmo_ss7_vty.c M tests/vty/osmo_stp_route_prio.vty M tests/vty/osmo_stp_test.vty 3 files changed, 218 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/12/39712/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I31664ca795d1a8572077f173ae95b504bc019eb3 Gerrit-Change-Number: 39712 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: route: osmo_ss7_route_name(): Use osmo_ss7_pointcode_print_buf()
by pespin 06 Mar '25

06 Mar '25

Attention is currently required from: pespin. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39709?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: route: osmo_ss7_route_name(): Use osmo_ss7_pointcode_print_buf() ...................................................................... route: osmo_ss7_route_name(): Use osmo_ss7_pointcode_print_buf() This allows callers to call osmo_ss7_route_name() together with osmo_ss7_pointcode_print() and osmo_ss7_pointcode_print2() in the same LOG line. Change-Id: Iccbd83eeaa0e1c2a6078ece8d5c6d7af6fd9d71a --- M src/osmo_ss7_route.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/09/39709/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39709?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iccbd83eeaa0e1c2a6078ece8d5c6d7af6fd9d71a Gerrit-Change-Number: 39709 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: AS loadsharing: show cs7 instance <0-15> route binding-table [POINT_C...
by pespin 06 Mar '25

06 Mar '25

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39712?usp=email ) Change subject: AS loadsharing: show cs7 instance <0-15> route binding-table [POINT_CODE] ...................................................................... Patch Set 1: (1 comment) File src/osmo_ss7_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39712/comment/e8144eef_c682e… : PS1, Line 656: #define RT_DEST_SPRINTF(buf, rt) \ > undef it at the end of the function? Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I31664ca795d1a8572077f173ae95b504bc019eb3 Gerrit-Change-Number: 39712 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Mar 2025 12:16:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: AS loadsharing: Normal route distribution regardless of active state
by pespin 06 Mar '25

06 Mar '25

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39708?usp=email ) Change subject: AS loadsharing: Normal route distribution regardless of active state ...................................................................... Patch Set 1: (1 comment) File src/osmo_ss7_combined_linkset.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39708/comment/42b55ea1_0a531… : PS1, Line 215: struct osmo_ss7_route *rt_found = NULL; > maybe shorten it as follows, without using rt_found? […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39708?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I6daf114416c69c84bdc3042efcaf2918f91c2e87 Gerrit-Change-Number: 39708 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Mar 2025 12:15:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: ASP loadsharing: Normal ASP distribution regardless of active state
by pespin 06 Mar '25

06 Mar '25

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39707?usp=email ) Change subject: ASP loadsharing: Normal ASP distribution regardless of active state ...................................................................... Patch Set 1: (1 comment) File src/osmo_ss7_as.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39707/comment/71cff7e6_98b71… : PS1, Line 311: Morevoer > Moreover Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39707?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I2064fe89bac2d3bd86fee544a64ab21417e1c368 Gerrit-Change-Number: 39707 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Mar 2025 12:14:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-bsc[master]: nokia: Fix uninitialized access
by pespin 06 Mar '25

06 Mar '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39701?usp=email ) Change subject: nokia: Fix uninitialized access ...................................................................... nokia: Fix uninitialized access /osmo-bsc/src/osmo-bsc/bts_nokia_site.c:1903:36: error: 'bcch_trx_nr' may be used uninitialized [-Werror=maybe-uninitialized] 1903 | if (trx->nr != bcch_trx_nr) { | Change-Id: I6bfdefb44235291a5a1f1c72e5a5149d15e19b8f --- M src/osmo-bsc/bts_nokia_site.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c index 4e3f63c..e5f2c9d 100644 --- a/src/osmo-bsc/bts_nokia_site.c +++ b/src/osmo-bsc/bts_nokia_site.c @@ -1884,7 +1884,7 @@ abis_nm_ack(bts, ref); if (bts->nokia.configured != 0) { struct gsm_bts_trx *trx; - uint8_t bcch_trx_nr; + int bcch_trx_nr = -1; /* we first need to unlock and reset the TRX that runs BCCH */ llist_for_each_entry(trx, &bts->trx_list, list) { if (trx->ts[0].pchan_from_config == GSM_PCHAN_CCCH || -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39701?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6bfdefb44235291a5a1f1c72e5a5149d15e19b8f Gerrit-Change-Number: 39701 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: domi <domi(a)tomcsanyi.net> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0