osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-remsim/+/39531?usp=email )
Change subject: Bump version: 1.0.0.76-ff79-dirty → 1.1.0
......................................................................
Bump version: 1.0.0.76-ff79-dirty → 1.1.0
Change-Id: I084a7cf36a6cce390c42ee44e7ac3d740e1785b4
---
M TODO-RELEASE
M configure.ac
M debian/changelog
M debian/control
M src/Makefile.am
5 files changed, 111 insertions(+), 16 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/31/39531/1
diff --git a/TODO-RELEASE b/TODO-RELEASE
index 730a421..0ed7189 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -1,12 +1,9 @@
# When cleaning up this file: bump API version in corresponding Makefile.am and rename corresponding debian/lib*.install
-# according to https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info…
-# In short:
+# according to https://osmocom.org/projects/cellular-infrastructure/wiki/Make_a_new_release
+# In short: https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info…
# LIBVERSION=c:r:a
# If the library source code has changed at all since the last update, then increment revision: c:r + 1:a.
-# If any interfaces have been added, removed, or changed since the last update: c + 1:0:0.
+# If any interfaces have been added, removed, or changed since the last update: c + 1:0:a.
# If any interfaces have been added since the last public release: c:r:a + 1.
# If any interfaces have been removed or changed since the last public release: c:r:0.
-#library what description / commit summary line
-libosmocore > 1.9.0 working (compiling) gsmtap_inst_fd2()
-libosmo-simtrace2 >= 0.9.0 required to compile (sim presence polarity)
-libosmo-netif >1.5.1 osmo_ipa_ka_fsm_inst APIs
+#library what description / commit summary line
diff --git a/configure.ac b/configure.ac
index ad2dcdb..a49c79b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -33,9 +33,9 @@
fi
PKG_PROG_PKG_CONFIG([0.20])
-PKG_CHECK_MODULES(OSMOCORE, libosmocore >= 1.6.0)
-PKG_CHECK_MODULES(OSMOGSM, libosmogsm >= 0.11.0)
-PKG_CHECK_MODULES(OSMONETIF, libosmo-netif >= 1.5.0)
+PKG_CHECK_MODULES(OSMOCORE, libosmocore >= 1.11.0)
+PKG_CHECK_MODULES(OSMOGSM, libosmogsm >= 1.11.0)
+PKG_CHECK_MODULES(OSMONETIF, libosmo-netif >= 1.6.0)
AC_ARG_ENABLE([remsim-server],[AS_HELP_STRING([--disable-remsim-server], [Build osmo-remsim-server])],
[osmo_ac_build_server="$enableval"],[osmo_ac_build_server="yes"])
@@ -64,8 +64,8 @@
[osmo_ac_build_client_st2="$enableval"],[osmo_ac_build_client_st2="yes"])
if test "$osmo_ac_build_client_st2" = "yes"; then
AC_DEFINE(BUILD_CLIENT_ST2, 1, [Define if we want to build osmo-remsim-client-st2])
- PKG_CHECK_MODULES(OSMOUSB, libosmousb >= 1.4.0)
- PKG_CHECK_MODULES(OSMOSIMTRACE2, libosmo-simtrace2 >= 0.8.0)
+ PKG_CHECK_MODULES(OSMOUSB, libosmousb >= 1.11.0)
+ PKG_CHECK_MODULES(OSMOSIMTRACE2, libosmo-simtrace2 >= 0.9.0)
PKG_CHECK_MODULES(USB, libusb-1.0)
fi
AM_CONDITIONAL(BUILD_CLIENT_ST2, test "x$osmo_ac_build_client_st2" = "xyes")
diff --git a/debian/changelog b/debian/changelog
index 63e8eaa..3161642 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,101 @@
+osmo-remsim (1.1.0) unstable; urgency=medium
+
+ [ Harald Welte ]
+ * manual: Document the logging configuration
+ * manual: update remsim-client options to match --help output
+ * manual: Update changelog, copyright, version
+ * Fix client_id/bank_id/slot_nr range in manual + --help output
+ * Check RSPRO component type; print error if type doesn't match
+ * server: Log connection establishment from bankd/client; warn on localhost
+ * server: Log keep-alive timeout and TCP disconnects
+ * server: Differentiate log levels, not everything is DEBUG
+ * bankd: Differentiate log levels, not everything is DEBUG
+ * server: Fix segfault in error path (client component ID != client)
+ * server: Detect duplicate client/bankd connection; drop new ones
+ * bankd: Better error messages during start-up
+ * encode actual hostname in RSPRO
+ * cosmetic: various typo/spelling fixes
+ * server: Fix various error paths if startup fails
+ * bankd: Log more clearly if we fail to open a PC/SC reader
+ * rspro_client_fsm: Log clientConnectResult != ok
+ * update git URLs (git -> https; gitea)
+ * bankd: log BankID:SlotNr in every log line
+ * main_fsm: Log bankd config (ip/port/bank_id/slot_nr) + disconnect
+ * bankd: Log not just ModemToCard but also CardToModem
+ * Install + package remsim-apitool as separate sub-package
+ * debian/control: Don't use misc:Package
+ * fix rpm spec file for packacing of apitool
+ * client: Log TPDU/ATR/PTS/slotStatus at INFO or NOTICE level
+ * bankd: Open PC/SC by default in EXCLUSIVE mode
+ * client: Fix '-a' command-line argument for ATR
+ * client: Option to ignore any ATR sent by bankd
+ * bankd: Don't log an "Error" if slotmap is removed
+ * remsim-client-st2: Proper error if not all endpoints can be found
+ * Fix various 'uninitialized variable' bugs reported by coverity
+ * rest_api: strtoul canot return negative
+ * remsim_server: handle osmo_fd_register() failure case
+ * rspro_server: Handle ipa_server_link_open() error case
+ * bankd_main: Avoid uninitialized variable
+ * rspro_client_fsm: Fix integer overflow calculating re-establishment delay
+ * user_ifdhandler: Fix missing check of osmo_fd_register return val
+ * user_shell: Fix unchecked return value of osmo_fd_register()
+ * user_simtrace2: Fix uninitialized ifm->path
+ * bankd: Don't use 127.0.0.1 as default IP address for the server
+ * README.md: Major update / meaningful content
+ * Add funding link to github mirror
+
+ [ Oliver Smith ]
+ * treewide: remove FSF address
+ * packaging: osmo-remsim-apitool needs py3-requests
+ * debian: set compat level to 10
+ * systemd: depend on networking-online.target
+ * src/rspro: regenerate to fix misleading indents
+ * checkpatch.conf: ignore rspro generated files
+ * debian/rules: don't compress pdfs
+ * contrib: remove rpm spec file
+ * contrib/jenkins: libosmo-abis after libosmo-netif
+
+ [ James Tavares ]
+ * bankd: add missing -p short form option
+ * ignore libtool artifacts from cross-compile environments
+ * bankd: edge detect RESET and VCC indications
+ * client: set the local/remote mode before inserting card
+ * bankd: Add GSMTAP functionality for SIM traffic
+ * bankd, client, server: add -L option to disable log coloring
+ * rspro_client: implement re-establish delay
+
+ [ Daniel Willmann ]
+ * remsim_client: Fix custom ATR '-a' option
+
+ [ Stephan Skrodzki ]
+ * another csv example for our usb CCID reader
+
+ [ arehbein ]
+ * bankd: Use gsmtap_inst_fd2()
+
+ [ Joey Berkovitz ]
+ * user_ifdhandler: Fix segfault on startup
+
+ [ Alexander Couzens ]
+ * remsim_client: add support to set sim presence pin polarity
+
+ [ Pau Espin Pedrol ]
+ * Replace deprecated ipa_msg_push_header()
+ * Fix uninitialized return value
+ * Remove rspro_client.c which is not used anyway
+ * Makefile:am: Improve formatting and order of CFLAGS and LIBS
+ * rspro: use osmo_stream to handle IPA connection
+ * server: Implement IPA server with osmo_stream
+ * Use new osmo_ipa_ka_fsm_inst APIs from libosmo-netif
+ * Drop dependency on libosmo-abis
+ * rspro_client_fsm: Fix missing return
+ * bankd: Fix typo in fprintf string output
+ * cosmetic: rspro_client_fsm: Document event handled in all_state
+ * Several logging improvements
+ * bankd: Add -T and -e cmdline params
+
+ -- Oliver Smith <osmith(a)sysmocom.de> Wed, 12 Feb 2025 15:54:41 +0100
+
osmo-remsim (1.0.0) unstable; urgency=medium
[ Harald Welte ]
diff --git a/debian/control b/debian/control
index 3e98465..9351cc5 100644
--- a/debian/control
+++ b/debian/control
@@ -9,9 +9,9 @@
pkg-config,
osmo-gsm-manuals-dev,
libcsv-dev,
- libosmocore-dev (>= 1.6.0),
- libosmo-netif-dev (>= 1.5.0),
- libosmo-simtrace2-dev (>= 0.8.0),
+ libosmocore-dev (>= 1.11.0),
+ libosmo-netif-dev (>= 1.6.0),
+ libosmo-simtrace2-dev (>= 0.9.0),
libpcsclite-dev,
libusb-1.0-0-dev,
libulfius-dev,
diff --git a/src/Makefile.am b/src/Makefile.am
index c2551a9..8a77f36 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -16,7 +16,7 @@
$(OSMOCORE_CFLAGS) \
$(NULL)
-RSPRO_LIBVERSION=2:0:0
+RSPRO_LIBVERSION=2:1:0
lib_LTLIBRARIES = libosmo-rspro.la
libosmo_rspro_la_LDFLAGS = $(AM_LDFLAGS) -version-info $(RSPRO_LIBVERSION)
# OSMONETIF_LIBS, OSMOGSM_LIBS not needed, we don't use any of its symbols, only the header above
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/39531?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I084a7cf36a6cce390c42ee44e7ac3d740e1785b4
Gerrit-Change-Number: 39531
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/39530?usp=email )
Change subject: Bump version: 0.8.1 → 0.9.0
......................................................................
Bump version: 0.8.1 → 0.9.0
Change-Id: I6965017fcd5323677ce11fd9860d4355eb8f770f
---
M TODO-RELEASE
M debian/changelog
M debian/control
M host/configure.ac
M host/lib/Makefile.am
5 files changed, 102 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/30/39530/1
diff --git a/TODO-RELEASE b/TODO-RELEASE
index 3b33942..0ed7189 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -3,10 +3,7 @@
# In short: https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info…
# LIBVERSION=c:r:a
# If the library source code has changed at all since the last update, then increment revision: c:r + 1:a.
-# If any interfaces have been added, removed, or changed since the last update: c + 1:0:0.
+# If any interfaces have been added, removed, or changed since the last update: c + 1:0:a.
# If any interfaces have been added since the last public release: c:r:a + 1.
# If any interfaces have been removed or changed since the last public release: c:r:0.
#library what description / commit summary line
-simtrace2 API/ABI change osmo_st2_transport new member
-simtrace2 API/ABI change cardemu_usb_msg_config new member
-simtrace2 API/ABI change add function osmo_st2_cardem_request_config2()
diff --git a/debian/changelog b/debian/changelog
index 99cfb8b..b19291c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,99 @@
+simtrace2 (0.9.0) unstable; urgency=medium
+
+ [ Oliver Smith ]
+ * host/contrib/simtrace2.spec.in: update
+ * treewide: remove FSF address
+ * contrib/jenkins.sh: set USE_CLANG=1
+ * Cosmetic: fix CI errors
+ * debian/rules: remove override_dh_autoreconf
+ * debian: set compat level to 10
+ * contrib/jenkins: tweak shell logic
+ * firmware/Makefile: don't use distribution's CFLAGS
+ * contrib: remove rpm spec file
+
+ [ Eric Wild ]
+ * firmware: add crc stub to all dfu apps to ensure reliable loading
+ * wireshark lua dissector: dissect more
+ * lua dissector: adjust usage instructions
+ * conrtrib/upload : upload elf files
+ * contrib/jenkins.sh : build and publish combined targets
+ * fw: only build the bl with clang
+
+ [ James Tavares ]
+ * simtrace2-tool: add "modem sim-card (insert|remove)" command
+ * firmware: add definition for main osc bypass when using external osc
+ * gitignore: add missing entries binaries
+ * firmware: bugfix: disable cardemu comms in local SIM mode
+ * main: rotor: erase immediately after send
+ * Fix missing generation of waiting-time-extension in some situations
+
+ [ Harald Welte ]
+ * host: Print strerror(errno) in case of problems opening the USB device
+ * cosmetic: Fix indent of printf() statement
+ * host: properly zero-initialize interface match structures
+ * contrib/simtrace.lua: Add VID/PID of all currentl simtrace2 devices
+ * cosmetic: contrib/simtrace.lua: more consistent formatting
+ * contrib/simtrace.lua: Add header with author/description/usage
+ * contrib/simtrace.lua: print length + slot-number in decimal only
+ * contrib/simtrace.lua: Don't print SIMTRACE_MSGT_ in every COL_INFO
+ * contrib/simtrace.lua: Dissect some more cardem related message types
+ * contrib/simtrace.lua: Register for "decode as..."
+ * cardem: Report the VCC voltage (if supported)
+ * card_emu_uart_interrupt: ASSERT if we get called with wrong uart_chan
+ * cardem: set more reasonable interrupt priorities
+ * host: Always initialize libosmocore logging before using it
+ * simtrace2-cardem-pcsc: rename 'flags' to 'status_flags'
+ * simtrace2-cardem-pcsc: Move all logging into libosmocore
+ * simtrace2-cardem-pcsc: Detect card power-up without RESET
+ * host: Don't pass -1 (converted to 255) as address
+ * simtrace2-cardem-pcsc: Fix copy+paste error in log message
+ * simtrace2-cardem-pcsc: continue in case of LIBUSB_TRANSFER_ERROR
+ * contrib/simtrace.lua: Add Flag bits + Data to COL_INFO
+ * Reduce bInterval of interrupt endpoints to avoid interrupt misses
+ * simtrace2-cardem-pcsc.c: Send APDUs via GSMTAP
+ * update git URLs (git -> https; gitea)
+ * cardem: reset the uC in case of USB disconnect
+ * cosmetic: Fix compile-time #error message string typo
+ * firmware/sniffer: Fix copy+paste when logging invalid INS bytes
+ * firmware/sniffer: Log parity errors, just like overruns and framing errors
+ * firmware/sniffer: refactor setting TPDU state
+ * firmware/sniffer: Log old and new state in ISO7816-3 state changes
+ * firmware/sniffer: Avoid extra call for rbuf_is_full
+ * firmware/sniffer: Fix programming error in PPS
+ * firmware/sniffer: Make all global variables 'static'
+ * firmware/sniffer: Group global variables in structs
+ * firmware/sniffer: Log cause of WT change
+ * firmware/sniffer: Rename global variable 'wt' to 'g_wt'
+ * firmware/sniffer: Disable TIMEOUT interrupts in USART IER on exit
+ * firmware/sniffer: Add + use 16bit ringbuffer
+ * firmware/sniffer: Pass PARITY/OVERRUN/FRAMING error via ringbuffer
+ * firmware/sniffer: Handle WT timeouts via ring-buffer
+ * firmware/sniffer: introduce #define for interrupt enable flags
+ * firmware/sniffer: Enable interrupts for overrun/parity/frame errors
+ * Fix unchecked return value of osmo_libusb_init()
+ * Add funding link to github mirror
+ * README.md: Fix mark-down nested bullet syntax
+ * README.md: Fix mark-down nested bullet syntax
+ * README.md: add links to SIMtrace2 and QMOD
+ * README.md: Add links to where hardware can be bought
+ * README.md: Add section on ngff_carem
+ * README.md: Add note to avoid using a VM
+
+ [ Alexander Couzens ]
+ * firmware: usb: call USBD_HAL_DISCONNECT while usb init to recover from resets
+ * ngff_cardem: cosmetic: fix superflous space
+ * dissector: add support for sim polarity
+ * firmware: allow to change the sim presence pin polarity
+ * simtrace2-cardem-pcsc: allow to set sim presence polarity
+
+ [ Vadim Yanitskiy ]
+ * host/cardem: fix integer overflow in process_do_rx_da()
+
+ [ Philipp Maier ]
+ * simtrace2-cardem-pcsc: mark reset events in GSMTAP trace
+
+ -- Oliver Smith <osmith(a)sysmocom.de> Wed, 12 Feb 2025 16:07:53 +0100
+
simtrace2 (0.8.1) unstable; urgency=medium
* host/contrib/simtrace2.spec.in: fix soname
diff --git a/debian/control b/debian/control
index cae4e8d..75826be 100644
--- a/debian/control
+++ b/debian/control
@@ -10,7 +10,7 @@
pkg-config,
git,
dh-autoreconf,
- libosmocore-dev (>= 1.4.0),
+ libosmocore-dev (>= 1.11.0),
libpcsclite-dev,
libnewlib-arm-none-eabi,
libusb-1.0-0-dev,
diff --git a/host/configure.ac b/host/configure.ac
index fd67f4a..83a2b23 100644
--- a/host/configure.ac
+++ b/host/configure.ac
@@ -56,9 +56,9 @@
CFLAGS="$saved_CFLAGS"
AC_SUBST(SYMBOL_VISIBILITY)
-PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.4.0)
-PKG_CHECK_MODULES(LIBOSMOSIM, libosmosim >= 1.4.0)
-PKG_CHECK_MODULES(LIBOSMOUSB, libosmousb >= 1.4.0)
+PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 1.11.0)
+PKG_CHECK_MODULES(LIBOSMOSIM, libosmosim >= 1.11.0)
+PKG_CHECK_MODULES(LIBOSMOUSB, libosmousb >= 1.11.0)
PKG_CHECK_MODULES(LIBUSB, libusb-1.0)
AC_ARG_ENABLE(sanitize,
diff --git a/host/lib/Makefile.am b/host/lib/Makefile.am
index e134c75..dbcb3f8 100644
--- a/host/lib/Makefile.am
+++ b/host/lib/Makefile.am
@@ -1,7 +1,7 @@
# This is _NOT_ the library release version, it's an API version.
# Please read chapter "Library interface versions" of the libtool documentation
# before making any modifications: https://www.gnu.org/software/libtool/manual/html_node/Versioning.html
-ST2_LIBVERSION=1:0:0
+ST2_LIBVERSION=2:0:1
AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_builddir)
AM_CFLAGS= -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOSIM_CFLAGS) $(LIBUSB_CFLAGS) $(COVERAGE_CFLAGS)
--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/39530?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I6965017fcd5323677ce11fd9860d4355eb8f770f
Gerrit-Change-Number: 39530
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Attention is currently required from: Hoernchen.
laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39471?usp=email )
Change subject: clang-format
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
like I commented in the other repo (AFAIR): How is this file used? By whom? Is there a pre-commit hook or manual? What is the expectation to the developer? Don't we want a server-side job that fails in case somebody pushes code not compliant to the format? ...
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39471?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ie5b21f02376fe4d0d47b0cda043a1d5bbb4d5d29
Gerrit-Change-Number: 39471
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Feb 2025 14:22:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Hoernchen.
laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39448?usp=email )
Change subject: fix some warnings and add some warning flags
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39448?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I55e1de7fe8428a5c6cdf741cdc0ae7c47aa7c8d8
Gerrit-Change-Number: 39448
Gerrit-PatchSet: 7
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Feb 2025 14:21:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Hoernchen.
laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447?usp=email )
Change subject: add ext power detect & dev reset
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File sysmoOCTSIM/main.c:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447/comment/61cb3803_dd… :
PS2, Line 329: void init_extpower_detect(void) {
> why are we adding four-space indented code to a file that looks like it uses tab-indent before?
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39447?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ied62450670dba2227daa96cbcd162cfe8414445a
Gerrit-Change-Number: 39447
Gerrit-PatchSet: 6
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Feb 2025 14:20:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>