lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

February 2025

  • 1 participants
  • 1182 discussions
[L] Change in libosmo-sigtran[master]: AS loadsharing: Initial routing implementation based on extended-SLS
by osmith 26 Feb '25

26 Feb '25
Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377?usp=email ) Change subject: AS loadsharing: Initial routing implementation based on extended-SLS ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0fb4ca4959096f748a23082efa0481300de56436 Gerrit-Change-Number: 39377 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Feb 2025 12:55:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[L] Change in libosmo-sigtran[master]: AS loadsharing: Introduce combined_linkset
by osmith 26 Feb '25

26 Feb '25
Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/38731?usp=email ) Change subject: AS loadsharing: Introduce combined_linkset ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38731?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I500ec74ba975e3c93071771027e4e5fe6000e6f3 Gerrit-Change-Number: 38731 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Feb 2025 12:54:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-hnbgw[master]: Log RAB_STATE name instead of value
by pespin 26 Feb '25

26 Feb '25
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/39602?usp=email ) Change subject: Log RAB_STATE name instead of value ...................................................................... Log RAB_STATE name instead of value Related: SYS#7338 Change-Id: I24593a1db1334052f3a79f59a521228393fc1ed7 --- M include/osmocom/hnbgw/context_map.h M src/osmo-hnbgw/kpi_ranap.c 2 files changed, 24 insertions(+), 6 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/include/osmocom/hnbgw/context_map.h b/include/osmocom/hnbgw/context_map.h index 8fe478c..f9bd251 100644 --- a/include/osmocom/hnbgw/context_map.h +++ b/include/osmocom/hnbgw/context_map.h @@ -2,6 +2,7 @@ #include <stdint.h> #include <osmocom/core/linuxlist.h> +#include <osmocom/core/utils.h> #include <osmocom/hnbgw/hnbgw.h> #include <osmocom/gsm/gsm48.h> @@ -117,6 +118,10 @@ RAB_STATE_ACTIVE, RAB_STATE_REL_REQ, }; +extern const struct value_string hnbgw_rab_state_names[]; +static inline const char *hnbgw_rab_state_name(enum rab_state val) +{ return get_value_string(hnbgw_rab_state_names, val); } + struct hnbgw_context_map { /* entry in the per-CN list of mappings */ diff --git a/src/osmo-hnbgw/kpi_ranap.c b/src/osmo-hnbgw/kpi_ranap.c index d731c5f..3f2c1b3 100644 --- a/src/osmo-hnbgw/kpi_ranap.c +++ b/src/osmo-hnbgw/kpi_ranap.c @@ -28,6 +28,13 @@ #include <osmocom/hnbgw/context_map.h> #include <osmocom/hnbgw/kpi.h> +const struct value_string hnbgw_rab_state_names[] = { + { RAB_STATE_INACTIVE, "INACTIVE" }, + { RAB_STATE_ACT_REQ, "ACT_REQ" }, + { RAB_STATE_ACTIVE, "ACTIVE" }, + { RAB_STATE_REL_REQ, "REL_REQ" }, + {} +}; /*********************************************************************** * DOWNLINK messages @@ -108,7 +115,8 @@ break; default: LOG_MAP(map, DRANAP, LOGL_NOTICE, - "Unexpected RAB Activation/Modification Req for RAB in state %u\n", map->rab_state[rab_id]); + "Unexpected RAB Activation/Modification Req for RAB in state %s\n", + hnbgw_rab_state_name(map->rab_state[rab_id])); break; } @@ -154,7 +162,8 @@ break; default: LOG_MAP(map, DRANAP, LOGL_NOTICE, - "Unexpected RAB Release Req in state %u\n", map->rab_state[rab_id]); + "Unexpected RAB Release Req in state %s\n", + hnbgw_rab_state_name(map->rab_state[rab_id])); break; } /* mark that RAB as release requested */ @@ -249,7 +258,8 @@ break; default: LOG_MAP(map, DRANAP, LOGL_NOTICE, - "Unexpected RAB Activation/Modification Conf for RAB in state %u\n", map->rab_state[rab_id]); + "Unexpected RAB Activation/Modification Conf for RAB in state %s\n", + hnbgw_rab_state_name(map->rab_state[rab_id])); break; } @@ -288,7 +298,8 @@ break; default: LOG_MAP(map, DRANAP, LOGL_NOTICE, - "Unexpected RAB Release Conf for RAB in state %u\n", map->rab_state[rab_id]); + "Unexpected RAB Release Conf for RAB in state %s\n", + hnbgw_rab_state_name(map->rab_state[rab_id])); break; } /* mark that RAB as released */ @@ -336,7 +347,8 @@ break; default: LOG_MAP(map, DRANAP, LOGL_NOTICE, - "Unexpected RAB Activation/Modification Failed for RAB in state %u\n", map->rab_state[rab_id]); + "Unexpected RAB Activation/Modification Failed for RAB in state %s\n", + hnbgw_rab_state_name(map->rab_state[rab_id])); break; } @@ -382,7 +394,8 @@ break; default: LOG_MAP(map, DRANAP, LOGL_NOTICE, - "Unexpected RAB Release Failed for RAB in state %u\n", map->rab_state[rab_id]); + "Unexpected RAB Release Failed for RAB in state %s\n", + hnbgw_rab_state_name(map->rab_state[rab_id])); break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/39602?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I24593a1db1334052f3a79f59a521228393fc1ed7 Gerrit-Change-Number: 39602 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[L] Change in libosmo-sigtran[master]: AS loadsharing: Initial routing implementation based on extended-SLS
by osmith 26 Feb '25

26 Feb '25
Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377?usp=email ) Change subject: AS loadsharing: Initial routing implementation based on extended-SLS ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File include/osmocom/sigtran/osmo_ss7.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377/comment/842140d8_9e3eb… : PS4, Line 129: internal > "private". […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0fb4ca4959096f748a23082efa0481300de56436 Gerrit-Change-Number: 39377 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Feb 2025 12:54:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
1 0
0 0
[L] Change in libosmo-sigtran[master]: AS loadsharing: Initial routing implementation based on extended-SLS
by pespin 26 Feb '25

26 Feb '25
Attention is currently required from: osmith. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: AS loadsharing: Initial routing implementation based on extended-SLS ...................................................................... AS loadsharing: Initial routing implementation based on extended-SLS This commit adds a new set of APIs and structs to support routing based on OPC,DPC,SLS fields and hence to support AS-loadshare. The routing decision is still actually left as beforehand, ie. the first AS/linkset in the combined_linkset is selected. This will allow future work, i.e to: - Check if data can be sent over the combined link (at least one AS/linkset is ACTIVE), and otherwise try using a combined link with a less specific match (shorter prefix mask or/and lower priority). - Select one of the AS/linksets in the combined link based on a round robin approach. Related: SYS#7112 Change-Id: I0fb4ca4959096f748a23082efa0481300de56436 --- M include/osmocom/sigtran/osmo_ss7.h M src/osmo_ss7_combined_linkset.c M src/osmo_ss7_hmrt.c M src/osmo_ss7_instance.c M src/osmo_ss7_route.c M src/osmo_ss7_route_table.c M src/osmo_ss7_vty.c M src/sccp_scrc.c M src/ss7_combined_linkset.h M src/ss7_instance.h M src/ss7_route_table.h M src/xua_rkm.c M src/xua_snm.c M tests/ss7/ss7_test.c M tests/vty/osmo_stp_test.vty 15 files changed, 293 insertions(+), 48 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/77/39377/5 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0fb4ca4959096f748a23082efa0481300de56436 Gerrit-Change-Number: 39377 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>
1 0
0 0
[L] Change in libosmo-sigtran[master]: AS loadsharing: Introduce combined_linkset
by pespin 26 Feb '25

26 Feb '25
Attention is currently required from: osmith. Hello Jenkins Builder, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38731?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: AS loadsharing: Introduce combined_linkset ...................................................................... AS loadsharing: Introduce combined_linkset A "Combined linkset" is a set of routes for different AS or linksets whose destination (DPC & mask) and priority are the same. An SP is expected to load share traffic among linksets/AS of a given combined linkset, based on DPC/OPC,SLS. This means certain state or heuristics need to be stored in the combined linkset in order to keep forwarding messages of the same transaction (SLS) over the same specific AS/linkset. This commit introduces the osmo_ss7_combined_linkset object, which is roughly a set of osmo_ss7_route sharing DPC+MASK+PRIO key, and it is placed in between the osmo_ss7_route_table and osmo_ss7_route entries. User still operates/manages indiviual routes, but those are grouped internally inside its corresponding combined linkset. No routing change is implemented in this commit. Code is only tweaked minimally so far to retrieve the first route in the combined link. This will allow future work, i.e to: - Check if data can be sent over the combined link (at least one AS/linkset is ACTIVE), and otherwise try using a combined link with a less specific match (shorter prefix mask or/and lower priority). - Select one of the AS/linksets inserted the combined link, based on OPC/DPC/SLS of the message. Related: SYS#7112 Change-Id: I500ec74ba975e3c93071771027e4e5fe6000e6f3 --- M src/Makefile.am A src/osmo_ss7_combined_linkset.c M src/osmo_ss7_route.c M src/osmo_ss7_route_table.c M src/osmo_ss7_vty.c A src/ss7_combined_linkset.h M src/ss7_route.h M src/ss7_route_table.h 8 files changed, 357 insertions(+), 95 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/31/38731/7 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/38731?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I500ec74ba975e3c93071771027e4e5fe6000e6f3 Gerrit-Change-Number: 38731 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-ci[master]: jobs/dahdi: build against linux latest stable too
by pespin 26 Feb '25

26 Feb '25
Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/39629?usp=email ) Change subject: jobs/dahdi: build against linux latest stable too ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39629?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib5031958d8b707bbdf32af9e582b7dabd9bd803c Gerrit-Change-Number: 39629 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Feb 2025 12:50:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in dahdi-linux[master]: firmware: download from https
by pespin 26 Feb '25

26 Feb '25
Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/39628?usp=email ) Change subject: firmware: download from https ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/39628?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ia0ecbd03984fa536275a97b06b5516be124ea69d Gerrit-Change-Number: 39628 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Feb 2025 12:50:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[L] Change in libosmo-sigtran[master]: AS loadsharing: Initial routing implementation based on extended-SLS
by pespin 26 Feb '25

26 Feb '25
Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377?usp=email ) Change subject: AS loadsharing: Initial routing implementation based on extended-SLS ...................................................................... Patch Set 4: (2 comments) File include/osmocom/sigtran/osmo_ss7.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377/comment/144fd5c2_123b2… : PS4, Line 129: internal > what do you mean with internal here? "private". The only use of this function outside of libosmo-sccp is in osmo-bsc where we do really special things to reuse the SCCPLite IPA conn to multiplex the MGCP from/to the MSC, which is kinda layering violation. That code really needs to be looked at (I'll probably be doing that) and figure out the best approach since it's really a niche use case there. Moreover, the existing osmo_ss7_route_lookup() doesn't allow providing a full route label to calculate the routing, which means it's more limited. I'll probably end up exporting the new ss7_instance_lookup_route() later on, but we can do that at a later point. File src/osmo_ss7_combined_linkset.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377/comment/59aca7af_6dd51… : PS4, Line 166: struct osmo_ss7_route *current_rt(const struct osmo_ss7_combined_linkset *clset, const struct osmo_ss7_esls_entry *eslse) > clset is not uses in this function? Acknowledged -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39377?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0fb4ca4959096f748a23082efa0481300de56436 Gerrit-Change-Number: 39377 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 26 Feb 2025 12:49:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-ci[master]: jobs/dahdi: build against linux latest stable too
by osmith 26 Feb '25

26 Feb '25
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/39629?usp=email ) Change subject: jobs/dahdi: build against linux latest stable too ...................................................................... jobs/dahdi: build against linux latest stable too As discussed with Harald, add a job that builds against the current latest release of the linux kernel. Change-Id: Ib5031958d8b707bbdf32af9e582b7dabd9bd803c --- M jobs/gerrit-verifications-dahdi.yml M jobs/master-builds-dahdi.yml 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/29/39629/1 diff --git a/jobs/gerrit-verifications-dahdi.yml b/jobs/gerrit-verifications-dahdi.yml index de11b25..78909c8 100644 --- a/jobs/gerrit-verifications-dahdi.yml +++ b/jobs/gerrit-verifications-dahdi.yml @@ -6,6 +6,7 @@ - "linux-4.19.y" - "linux-5.10.y" - "linux-6.1.y" + - "linux-rolling-stable" jobs: - 'gerrit-dahdi-linux-{type}-{linux-ver}' diff --git a/jobs/master-builds-dahdi.yml b/jobs/master-builds-dahdi.yml index d6e2bfd..7ba5985 100644 --- a/jobs/master-builds-dahdi.yml +++ b/jobs/master-builds-dahdi.yml @@ -6,6 +6,7 @@ - "linux-4.19.y" - "linux-5.10.y" - "linux-6.1.y" + - "linux-rolling-stable" jobs: - 'master-dahdi-linux-{type}-{linux-ver}' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39629?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib5031958d8b707bbdf32af9e582b7dabd9bd803c Gerrit-Change-Number: 39629 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 10
  • 11
  • 12
  • 13
  • 14
  • 15
  • 16
  • ...
  • 119
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.