November 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ci[master]: OBS: support building pyhss
by laforge 07 Nov '25

07 Nov '25

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41370?usp=email ) Change subject: OBS: support building pyhss ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41370?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I321090e811f7c5c142bf973c616d83cd5b2219ab Gerrit-Change-Number: 41370 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Nov 2025 08:25:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: OBS: set default distro to debian 13
by laforge 07 Nov '25

07 Nov '25

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41369?usp=email ) Change subject: OBS: set default distro to debian 13 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41369?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I7c1dcca90e46645a497fd547ce1243b414c53201 Gerrit-Change-Number: 41369 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Nov 2025 08:25:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: OBS: build_srcpkg: install rebar3 without apt
by laforge 07 Nov '25

07 Nov '25

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41368?usp=email ) Change subject: OBS: build_srcpkg: install rebar3 without apt ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File scripts/obs/data/build_srcpkg.Dockerfile: https://gerrit.osmocom.org/c/osmo-ci/+/41368/comment/b000c0ba_5672fb27?usp=… : PS1, Line 36: RU we should at least verify a cryptographic signatuer (if provided by upstream) or compare with a known hash when downloading arbitrary binaries from the web... -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41368?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9a51df03ac173118c35d501bd21c6d023a436844 Gerrit-Change-Number: 41368 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Nov 2025 08:25:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: OBS: gerrit_binpkgs: print verbose output
by laforge 07 Nov '25

07 Nov '25

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41367?usp=email ) Change subject: OBS: gerrit_binpkgs: print verbose output ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41367?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie1dbde603351b1d26b66f3834b645b1f1f5bbfc8 Gerrit-Change-Number: 41367 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Nov 2025 08:24:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: hlr: testenv: fix running pyhss from debian pkg
by osmith 07 Nov '25

07 Nov '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41372?usp=email ) Change subject: hlr: testenv: fix running pyhss from debian pkg ...................................................................... hlr: testenv: fix running pyhss from debian pkg Move the run_in_venv.sh script that is only used by pyhss from the generic location _testenv/data/scripts/run_in_venv.sh to hlr/pyhss/run_in_venv.sh and hardcode the path /opt/venvs/pyhss/bin/activate in there when running from binary packages. This is the path used in the binary package in the Osmocom OBS, the default path from dh_virtualenv. The package doesn't install pyhss_gsup etc. to /usr/bin, as these are usually not meant to be directly started without the systemd services that have the /opt/venvs/pyhss path hardcoded. Also put 'export PYHSS_CONFIG=config.yaml' in there, now that the script is pyhss specific. Related: https://dh-virtualenv.readthedocs.io/en/1.2.1/usage.html Change-Id: I0cdf1a9f220ddd2ef0866d0d11d1e3f6056a1cba --- D _testenv/data/scripts/run_in_venv.sh A hlr/pyhss/run_in_venv.sh M hlr/testenv_pyhss.cfg 3 files changed, 15 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/_testenv/data/scripts/run_in_venv.sh b/_testenv/data/scripts/run_in_venv.sh deleted file mode 100755 index b953a36..0000000 --- a/_testenv/data/scripts/run_in_venv.sh +++ /dev/null @@ -1,6 +0,0 @@ -#!/bin/sh -e -if [ -n "$TESTENV_INSTALL_DIR" ]; then - . "$TESTENV_INSTALL_DIR"/venv/bin/activate -fi - -"$@" diff --git a/hlr/pyhss/run_in_venv.sh b/hlr/pyhss/run_in_venv.sh new file mode 100755 index 0000000..a145a7d --- /dev/null +++ b/hlr/pyhss/run_in_venv.sh @@ -0,0 +1,12 @@ +#!/bin/sh -e +export PYHSS_CONFIG=config.yaml + +if [ "$TESTENV_INSTALL_DIR" = "/" ]; then + # Installed via debian package + . /opt/venvs/pyhss/bin/activate +else + # Built with osmo-dev + . "$TESTENV_INSTALL_DIR"/venv/bin/activate +fi + +"$@" diff --git a/hlr/testenv_pyhss.cfg b/hlr/testenv_pyhss.cfg index 4666d2d..9e9d430 100644 --- a/hlr/testenv_pyhss.cfg +++ b/hlr/testenv_pyhss.cfg @@ -5,14 +5,14 @@ copy=pyhss/HLR_Tests.cfg [pyhss_gsup] -program=PYHSS_CONFIG=config.yaml run_in_venv.sh pyhss_gsup +program=./run_in_venv.sh pyhss_gsup setup=wait_for_port.py -p 4222 make=pyhss package=pyhss -copy=pyhss/config.yaml +copy=pyhss/config.yaml pyhss/run_in_venv.sh [pyhss_api] -program=cd ../pyhss_gsup && PYHSS_CONFIG=config.yaml run_in_venv.sh pyhss_api +program=cd ../pyhss_gsup && ./run_in_venv.sh pyhss_api setup=./setup_db.sh make=pyhss package=pyhss -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41372?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0cdf1a9f220ddd2ef0866d0d11d1e3f6056a1cba Gerrit-Change-Number: 41372 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-asn1-tcap[master]: libosmo-asn1-tcap.pc.in: fix include path in Cflags
by pespin 06 Nov '25

06 Nov '25

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41374?usp=email ) Change subject: libosmo-asn1-tcap.pc.in: fix include path in Cflags ...................................................................... libosmo-asn1-tcap.pc.in: fix include path in Cflags Including header files from this library like this: #include <osmocom/tcap/OCTET_STRING.h> #include <osmocom/tcap/TCAP_TCMessage.h> currently fails if libosmo-asn1-tcap is installed to a non-standard location (other than /usr/include/). The reason is that this file tells the compiler to use the following include path: -I${includedir}/osmocom/tcap/ so the compiler will be looking for headers in there: ${includedir}/osmocom/tcap/osmocom/tcap/OCTET_STRING.h ${includedir}/osmocom/tcap/osmocom/tcap/TCAP_TCMessage.h This is wrong and will obviously fail. Let's use `-I${includedir}/` - this is what most of the Osmocom libraries specify in their `*.pc.in`. Change-Id: If65c43a34fd100ce712457dcf91abe2a8e49b7d2 Fixes: c454c74 ("Regenerate code with newer asn1c") Related: SYS#5423 --- M libosmo-asn1-tcap.pc.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/libosmo-asn1-tcap.pc.in b/libosmo-asn1-tcap.pc.in index 490dd41..17971a1 100644 --- a/libosmo-asn1-tcap.pc.in +++ b/libosmo-asn1-tcap.pc.in @@ -7,4 +7,4 @@ Description: C Utility Library Version: @VERSION@ Libs: -L${libdir} -losmo-asn1-tcap -Cflags: -I${includedir}/osmocom/tcap/ +Cflags: -I${includedir}/ -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41374?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: If65c43a34fd100ce712457dcf91abe2a8e49b7d2 Gerrit-Change-Number: 41374 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-asn1-tcap[master]: libosmo-asn1-tcap.pc.in: fix include path in Cflags
by pespin 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41374?usp=email ) Change subject: libosmo-asn1-tcap.pc.in: fix include path in Cflags ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41374?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: If65c43a34fd100ce712457dcf91abe2a8e49b7d2 Gerrit-Change-Number: 41374 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Nov 2025 20:43:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-asn1-tcap[master]: libosmo-asn1-tcap.pc.in: fix include path in Cflags
by fixeria 06 Nov '25

06 Nov '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41374?usp=email ) Change subject: libosmo-asn1-tcap.pc.in: fix include path in Cflags ...................................................................... libosmo-asn1-tcap.pc.in: fix include path in Cflags Including header files from this library like this: #include <osmocom/tcap/OCTET_STRING.h> #include <osmocom/tcap/TCAP_TCMessage.h> currently fails if libosmo-asn1-tcap is installed to a non-standard location (other than /usr/include/). The reason is that this file tells the compiler to use the following include path: -I${includedir}/osmocom/tcap/ so the compiler will be looking for headers in there: ${includedir}/osmocom/tcap/osmocom/tcap/OCTET_STRING.h ${includedir}/osmocom/tcap/osmocom/tcap/TCAP_TCMessage.h This is wrong and will obviously fail. Let's use `-I${includedir}/` - this is what most of the Osmocom libraries specify in their `*.pc.in`. Change-Id: If65c43a34fd100ce712457dcf91abe2a8e49b7d2 Fixes: c454c74 ("Regenerate code with newer asn1c") Related: SYS#5423 --- M libosmo-asn1-tcap.pc.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-asn1-tcap refs/changes/74/41374/1 diff --git a/libosmo-asn1-tcap.pc.in b/libosmo-asn1-tcap.pc.in index 490dd41..17971a1 100644 --- a/libosmo-asn1-tcap.pc.in +++ b/libosmo-asn1-tcap.pc.in @@ -7,4 +7,4 @@ Description: C Utility Library Version: @VERSION@ Libs: -L${libdir} -losmo-asn1-tcap -Cflags: -I${includedir}/osmocom/tcap/ +Cflags: -I${includedir}/ -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/41374?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: If65c43a34fd100ce712457dcf91abe2a8e49b7d2 Gerrit-Change-Number: 41374 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: fixup! build-system: depend on libosmo-asn1-tcap
by fixeria 06 Nov '25

06 Nov '25

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41373?usp=email ) Change subject: fixup! build-system: depend on libosmo-asn1-tcap ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41373?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9e6eec418a356f4e72acc03275c5c57261733323 Gerrit-Change-Number: 41373 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in libosmo-sigtran[master]: fixup! build-system: depend on libosmo-asn1-tcap
by fixeria 06 Nov '25

06 Nov '25

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41373?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: fixup! build-system: depend on libosmo-asn1-tcap ...................................................................... fixup! build-system: depend on libosmo-asn1-tcap Change-Id: I9e6eec418a356f4e72acc03275c5c57261733323 --- M contrib/jenkins.sh 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/73/41373/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41373?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9e6eec418a356f4e72acc03275c5c57261733323 Gerrit-Change-Number: 41373 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2025

2024

2023

2022

gerrit-log November 2025