October 2025 - gerrit-log - lists.osmocom.org

[XS] Change in ...osmo-s1gw[master]: debian: fixup: add missing libsctp dependency
by fixeria 06 Oct '25

06 Oct '25

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41173?usp=email ) Change subject: debian: fixup: add missing libsctp dependency ...................................................................... debian: fixup: add missing libsctp dependency I found `${libsctp:Version}` in `debian/control` of the erlang package (https://salsa.debian.org/erlang-team/packages/erlang) As it turns out, this is not a standard debhelper substvar (like `${shlibs:Depends}` or `${python3:Depends}`), but a custom one defined in `debian/rules`: dh_gencontrol -a -- -Vlibsctp:Version='$(LIBSCTPDEP)' Thus in our case it yields nothing. Use the package name instead. Change-Id: Ia74d75e86b1436fc7dcdfa40d90c7e0c2e5648a1 Fixes: 9455ca1 ("debian: add missing libsctp dependency") --- M debian/control 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/debian/control b/debian/control index 515e3b2..018077a 100644 --- a/debian/control +++ b/debian/control @@ -16,7 +16,7 @@ Architecture: any Depends: ${shlibs:Depends}, ${misc:Depends}, - ${libsctp:Version} + libsctp1 Suggests: osmo-s1gw-cli Multi-Arch: foreign Description: Osmocom S1 gateway -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41173?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ia74d75e86b1436fc7dcdfa40d90c7e0c2e5648a1 Gerrit-Change-Number: 41173 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in ...osmo-s1gw[master]: debian: fixup: add missing libsctp dependency
by osmith 06 Oct '25

06 Oct '25

Attention is currently required from: fixeria, jolly. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41173?usp=email ) Change subject: debian: fixup: add missing libsctp dependency ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41173?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ia74d75e86b1436fc7dcdfa40d90c7e0c2e5648a1 Gerrit-Change-Number: 41173 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Oct 2025 06:52:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo-s1gw[master]: README.md, doc/osmo-s1gw-cli.md: fix broken links
by osmith 06 Oct '25

06 Oct '25

Attention is currently required from: fixeria, jolly. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41171?usp=email ) Change subject: README.md, doc/osmo-s1gw-cli.md: fix broken links ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41171?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I2f035c6baf5ec19784bda915b802f28fd1063043 Gerrit-Change-Number: 41171 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Oct 2025 06:52:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: [REST] osmo-s1gw-cli.py: implement eNB/E-RAB list sorting
by osmith 06 Oct '25

06 Oct '25

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41172?usp=email ) Change subject: [REST] osmo-s1gw-cli.py: implement eNB/E-RAB list sorting ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41172?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iee7a922479fff7c2038f50325b5f6dfe39c16969 Gerrit-Change-Number: 41172 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Oct 2025 06:51:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in ...osmo-s1gw[master]: [REST] MetricsList: return 404 on invalid path
by osmith 06 Oct '25

06 Oct '25

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41170?usp=email ) Change subject: [REST] MetricsList: return 404 on invalid path ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41170?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: If5ab039654007ccf3703a2364b767eaa19e43461 Gerrit-Change-Number: 41170 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Oct 2025 06:47:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: [REST] Implement {Enb,Erab}Delete
by osmith 06 Oct '25

06 Oct '25

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41105?usp=email ) Change subject: [REST] Implement {Enb,Erab}Delete ...................................................................... Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41105?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I3576814f44d87551fdac6236ddbec6215ba07455 Gerrit-Change-Number: 41105 Gerrit-PatchSet: 10 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Oct 2025 06:46:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bts[master]: Fix build with debian 13
by osmith 06 Oct '25

06 Oct '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/41197?usp=email ) Change subject: Fix build with debian 13 ...................................................................... Fix build with debian 13 oml.c:461:20: error: returning 'HANDLE' {aka 'void *'} from a function with return type 'uint32_t' {aka 'unsigned int'} makes integer from pointer without a cast [-Wint-conversion] Change-Id: I0831e448692713c488c0590a86bdc99b37160f47 --- M src/osmo-bts-lc15/oml.c M src/osmo-bts-oc2g/oml.c 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/src/osmo-bts-lc15/oml.c b/src/osmo-bts-lc15/oml.c index 6f312e8..ce70d3c 100644 --- a/src/osmo-bts-lc15/oml.c +++ b/src/osmo-bts-lc15/oml.c @@ -458,7 +458,7 @@ { const struct lc15l1_hdl *fl1h = trx_lc15l1_hdl(trx); - return fl1h->hLayer1; + return (uint32_t)fl1h->hLayer1; } static int trx_close_compl_cb(struct gsm_bts_trx *trx, struct msgb *l1_msg, diff --git a/src/osmo-bts-oc2g/oml.c b/src/osmo-bts-oc2g/oml.c index 4b434e8..5244b68 100644 --- a/src/osmo-bts-oc2g/oml.c +++ b/src/osmo-bts-oc2g/oml.c @@ -473,7 +473,7 @@ { const struct oc2gl1_hdl *fl1h = trx_oc2gl1_hdl(trx); - return fl1h->hLayer1; + return (uint32_t)fl1h->hLayer1; } static int trx_close_compl_cb(struct gsm_bts_trx *trx, struct msgb *l1_msg, -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0831e448692713c488c0590a86bdc99b37160f47 Gerrit-Change-Number: 41197 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: Fix build with debian 13
by osmith 06 Oct '25

06 Oct '25

Attention is currently required from: dexter. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-bts/+/41197?usp=email ) Change subject: Fix build with debian 13 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: merging to get the master job passing again -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0831e448692713c488c0590a86bdc99b37160f47 Gerrit-Change-Number: 41197 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Oct 2025 05:59:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: Pass pylint 3.3.4 from debian trixie
by osmith 06 Oct '25

06 Oct '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41196?usp=email ) Change subject: Pass pylint 3.3.4 from debian trixie ...................................................................... Pass pylint 3.3.4 from debian trixie ************* Module osmo-smdpp osmo-smdpp.py:657:72: E0606: Possibly using variable 'iccid_str' before assignment (possibly-used-before-assignment) => False-positive: code paths that don't set iccid_str raise an error, so this shouldn't be a problem. ************* Module pySim-smpp2sim pySim-smpp2sim.py:427:4: E1101: Module 'twisted.internet.reactor' has no 'run' member (no-member) => False-positive: pylint doesn't recognize dynamically set attributes. ************* Module es9p_client contrib/es9p_client.py:126:11: E0606: Possibly using variable 'opts' before assignment (possibly-used-before-assignment) => Real bug, should be "self.opts". Related: https://stackoverflow.com/a/18712867 Change-Id: Id042ba0944b58d98d27e1222ac373c7206158a91 --- M contrib/es9p_client.py M osmo-smdpp.py M pyproject.toml 3 files changed, 6 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/contrib/es9p_client.py b/contrib/es9p_client.py index 15a96ae..e9a71fc 100755 --- a/contrib/es9p_client.py +++ b/contrib/es9p_client.py @@ -123,8 +123,8 @@ 'profileManagementOperation': PMO(self.opts.operation).to_bitstring(), 'notificationAddress': self.opts.notification_address or urlparse(self.opts.url).netloc, } - if opts.iccid: - ntf_metadata['iccid'] = h2b(swap_nibbles(opts.iccid)) + if self.opts.iccid: + ntf_metadata['iccid'] = h2b(swap_nibbles(self.opts.iccid)) if self.opts.operation == 'download': pird = { diff --git a/osmo-smdpp.py b/osmo-smdpp.py index a45f842..ed5046d 100755 --- a/osmo-smdpp.py +++ b/osmo-smdpp.py @@ -629,6 +629,7 @@ # If ctxParams1 contains a ctxParamsForCommonAuthentication data object, the SM-DP+ Shall [...] # TODO: We really do a very simplistic job here, this needs to be properly implemented later, # considering all the various cases, profile state, etc. + iccid_str = None if euiccSigned1['ctxParams1'][0] == 'ctxParamsForCommonAuthentication': cpca = euiccSigned1['ctxParams1'][1] matchingId = cpca.get('matchingId', None) diff --git a/pyproject.toml b/pyproject.toml index 9787c3b..8924896 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,3 +1,6 @@ [build-system] requires = ["setuptools", "wheel"] build-backend = "setuptools.build_meta" + +[tool.pylint.main] +ignored-classes = ["twisted.internet.reactor"] -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41196?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id042ba0944b58d98d27e1222ac373c7206158a91 Gerrit-Change-Number: 41196 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: Pass pylint 3.3.4 from debian trixie
by osmith 06 Oct '25

06 Oct '25

Attention is currently required from: dexter. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/pysim/+/41196?usp=email ) Change subject: Pass pylint 3.3.4 from debian trixie ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: merging to get the master job passing again -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41196?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id042ba0944b58d98d27e1222ac373c7206158a91 Gerrit-Change-Number: 41196 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 06 Oct 2025 05:58:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0