October 2025 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-abis[master]: osmo_trau_frame_encode(): reduce space requirement in common case
by fixeria 11 Oct '25

11 Oct '25

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41209?usp=email ) Change subject: osmo_trau_frame_encode(): reduce space requirement in common case ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41209?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I9f3541b0618ebef26e53b69041e5b74abefd3b85 Gerrit-Change-Number: 41209 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Sat, 11 Oct 2025 07:25:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-abis[master]: osmo_trau_frame_encode(): fix encoding of 16k O&M frames
by fixeria 11 Oct '25

11 Oct '25

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41208?usp=email ) Change subject: osmo_trau_frame_encode(): fix encoding of 16k O&M frames ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41208?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ia366d5b0385b764c492bbed9a030ca27db71fcff Gerrit-Change-Number: 41208 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Sat, 11 Oct 2025 07:22:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-abis[master]: trau_frame: add support for config frames of 3GPP Rel5+
by falconia 11 Oct '25

11 Oct '25

Attention is currently required from: keith. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41210?usp=email ) Change subject: trau_frame: add support for config frames of 3GPP Rel5+ ...................................................................... Patch Set 1: (1 comment) File src/trau/trau_frame.c: https://gerrit.osmocom.org/c/libosmo-abis/+/41210/comment/4e390bd5_1f568ee5… : PS1, Line 1371: * exception of newly added OSMO_TRAU16_FT_CONFIG, and for OSMO_TRAU8_SPEECH > This comment will not age well. […] The last time 3GPP defined a new frame type for GSM Abis was Release 5 (2002); the newly added frame type was the one in this patch. There have been no changes to TS 48.060 and 48.061 specs between Rel5 and the latest Rel18 - do you seriously expect any standards body to add another frame type to a 2G-specific, E1-specific spec? With the present patch, Osmocom trau_frame layer supports all TRAU frame types that have ever been defined by 3GPP or its predecessors. I really don't expect there to be any new ones. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41210?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ifbde07e4a3fb80e4faa0b6a6b32938ed98371c5b Gerrit-Change-Number: 41210 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Sat, 11 Oct 2025 05:05:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: keith <keith(a)rhizomatica.org>

1 0

[M] Change in libosmo-abis[master]: trau_frame: add support for config frames of 3GPP Rel5+
by keith 11 Oct '25

11 Oct '25

Attention is currently required from: falconia. keith has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41210?usp=email ) Change subject: trau_frame: add support for config frames of 3GPP Rel5+ ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: I can't speak to the accuracy of the en/decode functions as I have not studied the spec, but the author tends to know.. and I can't see how this can hurt File src/trau/trau_frame.c: https://gerrit.osmocom.org/c/libosmo-abis/+/41210/comment/cd301384_d1b270fc… : PS1, Line 1371: * exception of newly added OSMO_TRAU16_FT_CONFIG, and for OSMO_TRAU8_SPEECH This comment will not age well. 😊 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41210?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ifbde07e4a3fb80e4faa0b6a6b32938ed98371c5b Gerrit-Change-Number: 41210 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Sat, 11 Oct 2025 03:42:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-msc[master]: sqlite optimisation: check VLR earlier for dest. subscriber
by keith 11 Oct '25

11 Oct '25

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/41221?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: sqlite optimisation: check VLR earlier for dest. subscriber ...................................................................... sqlite optimisation: check VLR earlier for dest. subscriber sms_from_result() calls a number of sqlite3_column_XXX functions to build the SMS in memory. If the destination subscriber is not attached, the sms will be free'd immediatly anyway in smsq_take_next_sms() so let's check if the destination subscriber is present and attached before we call all the sqlite3 routines. Change-Id: Ibd07b9d200b48108d705ed4c461cc4ddfa421fd2 --- M src/libmsc/db.c M src/libmsc/sms_queue.c M tests/sms_queue/sms_queue_test.c M tests/sms_queue/sms_queue_test.ok 4 files changed, 26 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/21/41221/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41221?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibd07b9d200b48108d705ed4c461cc4ddfa421fd2 Gerrit-Change-Number: 41221 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder

1 0

[S] Change in osmo-msc[master]: sqlite optimisation: Avoid unneeded database operation
by keith 11 Oct '25

11 Oct '25

Attention is currently required from: pespin. keith has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email ) Change subject: sqlite optimisation: Avoid unneeded database operation ...................................................................... Patch Set 4: (1 comment) File src/libmsc/sms_queue.c: https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/3040a473_3ee1afc9?usp… : PS1, Line 123: struct gsm_sms_queue { > If you move the code block to be handled in signal callback, this probably can stay here. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I777155c0f818b979c636bb59953719e472771603 Gerrit-Change-Number: 28340 Gerrit-PatchSet: 4 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Oct 2025 22:42:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-msc[master]: sqlite optimisation: Avoid unneeded database operation
by keith 11 Oct '25

11 Oct '25

keith has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email ) Change subject: sqlite optimisation: Avoid unneeded database operation ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I777155c0f818b979c636bb59953719e472771603 Gerrit-Change-Number: 28340 Gerrit-PatchSet: 4 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Oct 2025 22:40:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in osmo-msc[master]: sqlite optimisation: Avoid unneeded database operation
by keith 10 Oct '25

10 Oct '25

Attention is currently required from: pespin. keith has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email ) Change subject: sqlite optimisation: Avoid unneeded database operation ...................................................................... Patch Set 3: (4 comments) File src/libmsc/db.c: https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/c37a6736_95fcdb80?usp… : PS1, Line 314: [DB_STMT_SMS_DEL_SENT_BY_ID] = > WIP I guess. I'm not really sure what statements might up end being wanted. […] Done File src/libmsc/gsm_04_11.c: https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/56fa6d48_3a7557b8?usp… : PS1, Line 871: /* msc_vlr tests will not pass any sms_queue, hence need to check smq != NULL */ > The db code contains similar "hacks" to have the tests pass. […] Done https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/9d5d1d91_f53f95bf?usp… : PS1, Line 873: db_sms_mark_delivered(sms); > Sounds like all this should be placed wherever S_SMS_DELIVERED signal is handled imho. Done File src/libmsc/sms_queue.c: https://gerrit.osmocom.org/c/osmo-msc/+/28340/comment/b9a4f25c_2bc10ab5?usp… : PS1, Line 607: /* Remember the subscriber and clear the pending entry */ > The cod eblock should be mover over here? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I777155c0f818b979c636bb59953719e472771603 Gerrit-Change-Number: 28340 Gerrit-PatchSet: 3 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Oct 2025 21:22:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: keith <keith(a)rhizomatica.org>

1 0

[S] Change in osmo-msc[master]: sqlite optimisation: Avoid unneeded database operation
by keith 10 Oct '25

10 Oct '25

keith has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email ) Change subject: sqlite optimisation: Avoid unneeded database operation ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28340?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I777155c0f818b979c636bb59953719e472771603 Gerrit-Change-Number: 28340 Gerrit-PatchSet: 3 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Oct 2025 21:21:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in osmo-msc[master]: Use unix timestamps in the SMS db
by keith 10 Oct '25

10 Oct '25

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28339?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Use unix timestamps in the SMS db ...................................................................... Use unix timestamps in the SMS db There's really no need to convert to/from human readable dateformat (YYYY-MM-DD HH:MM:SS) everytime we access a record in the SMS database. sqlite3 has pseudo column types. In fact this means the column type in the database schema is meaningless and anything will be accepted and stored. See (Flexible Typing) [1] It appears that more processing than might be expected is happening internally on such things as date conversions, as the database engine has to actually do verifications on the data. (Is this INT really an INT etc...) [1] https://www.sqlite.org/quirks.html Change-Id: I599a57666da22adf806b01ff095c8672d523a737 --- M src/libmsc/db.c 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/39/28339/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28339?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I599a57666da22adf806b01ff095c8672d523a737 Gerrit-Change-Number: 28339 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0