October 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-keyring[master]: osmocom.asc: update [expires: 2027-12-31]
by osmith 22 Oct '25

22 Oct '25

Attention is currently required from: fixeria. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmocom-keyring/+/41240?usp=email ) Change subject: osmocom.asc: update [expires: 2027-12-31] ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-keyring/+/41240?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-keyring Gerrit-Branch: master Gerrit-Change-Id: I6863a8e5a5351fd5c0e1d0717c01a0063050c13e Gerrit-Change-Number: 41240 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Oct 2025 13:05:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[osmith/2.1.2]: fix SCCP_MAX_OPTIONAL_DATA 128
by osmith 22 Oct '25

22 Oct '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41247?usp=email ) Change subject: fix SCCP_MAX_OPTIONAL_DATA 128 ...................................................................... fix SCCP_MAX_OPTIONAL_DATA 128 Related: SYS#7600 Change-Id: I841dbb2e8cbc13708ba7f5593f6bdd3b8da4329c (cherry picked from commit 6ea68a2308f8ad008e1e75959d2411999bc8c3eb) --- M include/osmocom/sccp/sccp_types.h M src/sccp_vty.c M tests/vty/osmo_stp_test.vty M tests/vty/ss7_asp_test.vty 4 files changed, 26 insertions(+), 8 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/sccp/sccp_types.h b/include/osmocom/sccp/sccp_types.h index 5be0392..ab688b3 100644 --- a/include/osmocom/sccp/sccp_types.h +++ b/include/osmocom/sccp/sccp_types.h @@ -24,7 +24,25 @@ #include <osmocom/core/endian.h> #include <osmocom/core/utils.h> -#define SCCP_MAX_OPTIONAL_DATA 130 +/* ITU Q.713 3.16 Data is a variable-length IE, meaning it has two header + * octets: + * - one octet of "Parameter name code", + * - plus one octet of length. + * + * In + * - 4.2 CR, + * - 4.3 CC, + * - 4.4 CREF, + * - 4.5 RLSD, + * there are optional "Data" IEs with length indicated as "3-130" octets: the + * minimum of 3 stems from the two header octets plus one data octet. Note that + * when there are zero data octets, the entire "Data" IE is omitted. + * + * Hence, the maximum of 130 includes the two header octets, and the actual + * maximum data length is 128. + */ +#define SCCP_MAX_OPTIONAL_DATA 128 + #define SCCP_MAX_DATA 256 /* Table 1/Q.713 - SCCP message types */ diff --git a/src/sccp_vty.c b/src/sccp_vty.c index 49f3577..a969423 100644 --- a/src/sccp_vty.c +++ b/src/sccp_vty.c @@ -174,10 +174,10 @@ "Adjust the upper bound for the optional data length (the payload) for CR, CC, CREF and RLSD messages." " For any Optional Data part larger than this value in octets, send CR, CC, CREF and RLSD" " messages without any payload, and send the data payload in a separate Data Form 1 message." - " ITU-T Q.713 sections 4.2 thru 4.5 define a limit of 130 bytes for the 'Data' parameter. This limit can be" + " ITU-T Q.713 sections 4.2 thru 4.5 define a limit of 128 bytes for the 'Data' parameter. This limit can be" " adjusted here. May be useful for interop with nonstandard SCCP peers.\n" "Set a non-standard maximum allowed number of bytes\n" - "Use the ITU-T Q.713 4.2 to 4.5 standard value of 130\n", + "Use the ITU-T Q.713 4.2 to 4.5 standard value of 128\n", CMD_ATTR_IMMEDIATE) { struct osmo_ss7_instance *ss7 = vty->index; diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index cb24560..56b48c5 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -528,11 +528,11 @@ <1-999999> Timer value, in seconds OsmoSTP(config-cs7)# sccp ? - max-optional-data Adjust the upper bound for the optional data length (the payload) for CR, CC, CREF and RLSD messages. For any Optional Data part larger than this value in octets, send CR, CC, CREF and RLSD messages without any payload, and send the data payload in a separate Data Form 1 message. ITU-T Q.713 sections 4.2 thru 4.5 define a limit of 130 bytes for the 'Data' parameter. This limit can be adjusted here. May be useful for interop with nonstandard SCCP peers. + max-optional-data Adjust the upper bound for the optional data length (the payload) for CR, CC, CREF and RLSD messages. For any Optional Data part larger than this value in octets, send CR, CC, CREF and RLSD messages without any payload, and send the data payload in a separate Data Form 1 message. ITU-T Q.713 sections 4.2 thru 4.5 define a limit of 128 bytes for the 'Data' parameter. This limit can be adjusted here. May be useful for interop with nonstandard SCCP peers. OsmoSTP(config-cs7)# sccp max-optional-data ? <0-999999> Set a non-standard maximum allowed number of bytes - standard Use the ITU-T Q.713 4.2 to 4.5 standard value of 130 + standard Use the ITU-T Q.713 4.2 to 4.5 standard value of 128 OsmoSTP(config-cs7)# show running-config ... !sccp max-optional-data @@ -563,7 +563,7 @@ OsmoSTP(config-cs7)# show running-config ... !sccp max-optional-data -OsmoSTP(config-cs7)# sccp max-optional-data 130 +OsmoSTP(config-cs7)# sccp max-optional-data 128 OsmoSTP(config-cs7)# show running-config ... !sccp max-optional-data diff --git a/tests/vty/ss7_asp_test.vty b/tests/vty/ss7_asp_test.vty index b565557..f83a452 100644 --- a/tests/vty/ss7_asp_test.vty +++ b/tests/vty/ss7_asp_test.vty @@ -513,11 +513,11 @@ <1-999999> Timer value, in seconds ss7_asp_vty_test(config-cs7)# sccp ? - max-optional-data Adjust the upper bound for the optional data length (the payload) for CR, CC, CREF and RLSD messages. For any Optional Data part larger than this value in octets, send CR, CC, CREF and RLSD messages without any payload, and send the data payload in a separate Data Form 1 message. ITU-T Q.713 sections 4.2 thru 4.5 define a limit of 130 bytes for the 'Data' parameter. This limit can be adjusted here. May be useful for interop with nonstandard SCCP peers. + max-optional-data Adjust the upper bound for the optional data length (the payload) for CR, CC, CREF and RLSD messages. For any Optional Data part larger than this value in octets, send CR, CC, CREF and RLSD messages without any payload, and send the data payload in a separate Data Form 1 message. ITU-T Q.713 sections 4.2 thru 4.5 define a limit of 128 bytes for the 'Data' parameter. This limit can be adjusted here. May be useful for interop with nonstandard SCCP peers. ss7_asp_vty_test(config-cs7)# sccp max-optional-data ? <0-999999> Set a non-standard maximum allowed number of bytes - standard Use the ITU-T Q.713 4.2 to 4.5 standard value of 130 + standard Use the ITU-T Q.713 4.2 to 4.5 standard value of 128 ss7_asp_vty_test(config-cs7)# show running-config ... !sccp max-optional-data -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41247?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: osmith/2.1.2 Gerrit-Change-Id: I841dbb2e8cbc13708ba7f5593f6bdd3b8da4329c Gerrit-Change-Number: 41247 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[osmith/2.1.2]: Bump version: 2.1.1.1-c7df-dirty → 2.1.2
by osmith 22 Oct '25

22 Oct '25

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41248?usp=email ) Change subject: Bump version: 2.1.1.1-c7df-dirty → 2.1.2 ...................................................................... Bump version: 2.1.1.1-c7df-dirty → 2.1.2 Change-Id: I13b99f313a58ac689c2c81aded5fdf95b498a6ca --- M debian/changelog M src/Makefile.am 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/debian/changelog b/debian/changelog index 59e9578..a417bb8 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +libosmo-sigtran (2.1.2) unstable; urgency=medium + + [ Neels Janosch Hofmeyr ] + * fix SCCP_MAX_OPTIONAL_DATA 128 + + -- Oliver Smith <osmith(a)sysmocom.de> Wed, 22 Oct 2025 12:43:56 +0200 + libosmo-sigtran (2.1.1) unstable; urgency=medium * snm: Fix generating wrong format in 'affected PCs' log string diff --git a/src/Makefile.am b/src/Makefile.am index 79c8d37..6492979 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -35,7 +35,7 @@ # This is _NOT_ the library release version, it's an API version. # Please read Chapter 6 "Library interface versions" of the libtool # documentation before making any modification -LIBVERSION=11:1:0 +LIBVERSION=11:2:0 libosmo_sigtran_la_SOURCES = \ ipa.c \ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41248?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: osmith/2.1.2 Gerrit-Change-Id: I13b99f313a58ac689c2c81aded5fdf95b498a6ca Gerrit-Change-Number: 41248 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[osmith/2.1.2]: fix SCCP_MAX_OPTIONAL_DATA 128
by osmith 22 Oct '25

22 Oct '25

Attention is currently required from: fixeria, laforge. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41247?usp=email ) Change subject: fix SCCP_MAX_OPTIONAL_DATA 128 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: cherry picked from master, as discussed -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41247?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: osmith/2.1.2 Gerrit-Change-Id: I841dbb2e8cbc13708ba7f5593f6bdd3b8da4329c Gerrit-Change-Number: 41247 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Oct 2025 13:02:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: Update key for Osmocom OBS
by laforge 22 Oct '25

22 Oct '25

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41244?usp=email ) Change subject: Update key for Osmocom OBS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id72581dc1cffb9d43dfc56aa16f2b1b9baf9c04f Gerrit-Change-Number: 41244 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Oct 2025 12:01:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ci[master]: Update Release.key for Osmocom OBS
by laforge 22 Oct '25

22 Oct '25

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41243?usp=email ) Change subject: Update Release.key for Osmocom OBS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaa333c148f01f518178990bc44c822a471dffbb8 Gerrit-Change-Number: 41243 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Oct 2025 12:01:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in docker-playground[master]: common/Release.key: update
by laforge 22 Oct '25

22 Oct '25

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/docker-playground/+/41242?usp=email ) Change subject: common/Release.key: update ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/41242?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I5bee715ad50830ab12472fc3946b30ec3d9ace16 Gerrit-Change-Number: 41242 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Oct 2025 12:01:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmocom-keyring[master]: Bump version: 1.1.0
by laforge 22 Oct '25

22 Oct '25

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmocom-keyring/+/41241?usp=email ) Change subject: Bump version: 1.1.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-keyring/+/41241?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-keyring Gerrit-Branch: master Gerrit-Change-Id: I1c3331bc4868293df2d3a4a2076f8b2d446e311a Gerrit-Change-Number: 41241 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Oct 2025 12:00:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmocom-keyring[master]: osmocom.asc: update [expires: 2027-12-31]
by laforge 22 Oct '25

22 Oct '25

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmocom-keyring/+/41240?usp=email ) Change subject: osmocom.asc: update [expires: 2027-12-31] ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-keyring/+/41240?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-keyring Gerrit-Branch: master Gerrit-Change-Id: I6863a8e5a5351fd5c0e1d0717c01a0063050c13e Gerrit-Change-Number: 41240 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Oct 2025 12:00:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: mme: use -c all
by laforge 22 Oct '25

22 Oct '25

Attention is currently required from: fixeria, jolly, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/41245?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: mme: use -c all ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/41245?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id2296c7cfe1660cc443f08efea209f8bf61aa8b6 Gerrit-Change-Number: 41245 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Oct 2025 12:00:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0