October 2025 - gerrit-log - lists.osmocom.org

[XS] Change in ...pyosmocom[master]: utils: h2i(): use list() to convert bytes to integers
by laforge 21 Oct '25

21 Oct '25

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39454?usp=email ) Change subject: utils: h2i(): use list() to convert bytes to integers ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39454?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Icb0d0803b7ae4e0b3a292ba96f58c26d0ca88abd Gerrit-Change-Number: 39454 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Oct 2025 20:27:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: utils: b2h()/i2h(): use bytes.hex() API
by laforge 21 Oct '25

21 Oct '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39453?usp=email ) Change subject: utils: b2h()/i2h(): use bytes.hex() API ...................................................................... utils: b2h()/i2h(): use bytes.hex() API Change-Id: Iaef25f614e7a4b1c3eb328e560bf9a300f70ae31 --- M src/osmocom/utils.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved dexter: Looks good to me, approved diff --git a/src/osmocom/utils.py b/src/osmocom/utils.py index 5947453..6c823ec 100644 --- a/src/osmocom/utils.py +++ b/src/osmocom/utils.py @@ -73,7 +73,7 @@ def b2h(b: bytearray) -> hexstr: """convert from a sequence of bytes to a string of hex nibbles""" - return hexstr(''.join(['%02x' % (x) for x in b])) + return hexstr(b.hex()) def h2i(s: Hexstr) -> List[int]: @@ -83,7 +83,7 @@ def i2h(s: List[int]) -> hexstr: """convert from a list of integers to a string of hex nibbles""" - return hexstr(''.join(['%02x' % (x) for x in s])) + return hexstr(bytes(s).hex()) def h2s(s: Hexstr) -> str: -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39453?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Iaef25f614e7a4b1c3eb328e560bf9a300f70ae31 Gerrit-Change-Number: 39453 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-mgw[master]: mgw: rtp-patch rfc5993hr: convert to each end's respective format
by laforge 21 Oct '25

21 Oct '25

Attention is currently required from: falconia, neels, pespin. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39869?usp=email ) Change subject: mgw: rtp-patch rfc5993hr: convert to each end's respective format ...................................................................... Patch Set 2: -Code-Review (1 comment) Patchset: PS2: I'd still want the unresolved comments to be adressed somehow. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6b446ad83c540fb8b7e1aae24b78c27010212d64 Gerrit-Change-Number: 39869 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Oct 2025 20:25:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-mgw[master]: mgw: rtp-patch rfc5993hr: convert to each end's respective format
by laforge 21 Oct '25

21 Oct '25

Attention is currently required from: falconia, neels, pespin. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39869?usp=email ) Change subject: mgw: rtp-patch rfc5993hr: convert to each end's respective format ...................................................................... Patch Set 2: Code-Review+1 (4 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/7a37b698_3f7988da?usp… : PS2, Line 691: * consider the full RTP chain of a single call: > The comment by @laforge@osmocom. […] Done https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/1e1de471_7286ebf5?usp… : PS2, Line 698: will always be RFC 5993 > > On AoIP, there is no discussion. […] Done https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/a0cf7996_312b9e4a?usp… : PS2, Line 1660: strcmp(conn_src->end.cset.codec->subtype_name, "GSM-HR-08") == 0 && conn_src->end.rfc5993_hr_convert) { > I originally had it split, but the overzealous linter forced me to join into this longer line! See t […] Done https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/dfea6621_0f340ae1?usp… : PS2, Line 1661: int rc = examine_rtp_rx_gsmhr(msg, conn_src); > It is called for every received packet. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6b446ad83c540fb8b7e1aae24b78c27010212d64 Gerrit-Change-Number: 39869 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Oct 2025 20:25:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: fixup: rsl: properly initialize MS/BS Power Control state
by laforge 21 Oct '25

21 Oct '25

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email ) Change subject: fixup: rsl: properly initialize MS/BS Power Control state ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: ping? Do we move initialization to the lchan activation or not? If not, we can proceed merging this -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39830?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I46c881d5a3959c2542610ed767e0f131d01f9f98 Gerrit-Change-Number: 39830 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Oct 2025 20:20:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-bts[master]: rsl: rsl_rx_chan_activ(): set TA=0 if not indicated by the BSC
by laforge 21 Oct '25

21 Oct '25

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/39829?usp=email ) Change subject: rsl: rsl_rx_chan_activ(): set TA=0 if not indicated by the BSC ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: ping? Do we move initialization to the lchan activation or not? If not, we can proceed merging this -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/39829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I83f26ff06cebdfe8d4e75944f496e9678310e2a2 Gerrit-Change-Number: 39829 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Oct 2025 20:20:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in pysim[master]: commands: do not use b2h with a string
by laforge 21 Oct '25

21 Oct '25

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/41236?usp=email ) Change subject: commands: do not use b2h with a string ...................................................................... commands: do not use b2h with a string The function h2b expects a bytearray and must not be used on a string. This is also true for nullstrings (''). Related: OS#6869 Change-Id: I0e28e6ec476901bf19aa0f8640e41c74aa6e3aa2 --- M pySim/commands.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/pySim/commands.py b/pySim/commands.py index f069db4..066a2c4 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -141,7 +141,7 @@ Returns: Tuple of (decoded_data, sw) """ - cmd = cmd_constr.build(cmd_data) if cmd_data else '' + cmd = cmd_constr.build(cmd_data) if cmd_data else b'' lc = i2h([len(cmd)]) if cmd_data else '' le = '00' if resp_constr else '' pdu = ''.join([cla, ins, p1, p2, lc, b2h(cmd), le]) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0e28e6ec476901bf19aa0f8640e41c74aa6e3aa2 Gerrit-Change-Number: 41236 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: commands: do not use b2h with a string
by laforge 21 Oct '25

21 Oct '25

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41236?usp=email ) Change subject: commands: do not use b2h with a string ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0e28e6ec476901bf19aa0f8640e41c74aa6e3aa2 Gerrit-Change-Number: 41236 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Oct 2025 19:32:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: commands: do not use b2h with a string
by fixeria 21 Oct '25

21 Oct '25

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41236?usp=email ) Change subject: commands: do not use b2h with a string ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41236?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0e28e6ec476901bf19aa0f8640e41c74aa6e3aa2 Gerrit-Change-Number: 41236 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Oct 2025 19:01:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...pyosmocom[master]: utils: b2h()/i2h(): use bytes.hex() API
by dexter 21 Oct '25

21 Oct '25

Attention is currently required from: fixeria. dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39453?usp=email ) Change subject: utils: b2h()/i2h(): use bytes.hex() API ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: This patch may fix the failing pysim verification: https://gerrit.osmocom.org/c/pysim/+/41236 I hope there is not more of such things, but we will see. This patch I think is correct. Wrong API usage must be fixed in the application that uses pyosmocom. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39453?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: Iaef25f614e7a4b1c3eb328e560bf9a300f70ae31 Gerrit-Change-Number: 39453 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 21 Oct 2025 15:48:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2025

2024

2023

2022

gerrit-log October 2025