January 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: RFC: add support to create a shallow copy

by osmith

Attention is currently required from: lynxis lazus. osmith has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39234?usp=email ) Change subject: RFC: add support to create a shallow copy ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: Thanks for making this! As I understand, the purpose is avoiding configure's error that one must run `make distclean` before being able to do an out-of-tree build with osmo-dev/testenv, if one ran `autoreconf -fi && ./configure` inside the source tree before (prepared an in-tree build)? If that is the case, then this is something I'd like to avoid as well and it seems in any case that patch would allow this. If not, then please explain what your motivation for this is :) > I think ttcn-hacks are still required to mount writeable, but we could also use such shallow copy for it as well. The source files from osmo-ttcn3-hacks [get copied to a cache directory with rsync](https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks/src/commit/d05a3a0e… (without deleting existing target files, so it keeps already built binary objects, and with excluding the .git dir). This happens outside of podman, and then only the cache directory gets mounted when running podman. This is mostly a workaround because we can't do an out-of-tree build with the current osmo-ttcn3-hacks buildsystem (and if we did another in-tree build then we would have potentially incompatible binary objects from compiling in podman vs. outside of podman). But this also has the effect that the source directory is not touched at all, like a read-only option. > Should I follow and add an argument for the main program? It would be also possible to use this without podman, however i'm using it with podman. I would prefer if we make this the default instead of opt-in (to avoid the "make distclean" error by default). But this also requires that it doesn't behave unexpected for users in other ways, some problems I currently see: * This does not handle dirty trees (modified/added/removed files that are not committed). Maybe it would make sense to add similar rsync logic instead, so this is handled as well? * I suggest we make it so that it runs on only exactly on the repositories we currently need for a build instead of all repositories. Also it shouldn't break when osmo-dev has just cloned a new repository because the user is building a project for which the git repos were not cloned yet. Therefore I think this logic needs to be moved to osmo-dev, as optional extra step before running `autoreconf -fi` / `configure` / compiling sources for each repository. testenv would then call osmo-dev with an argument to enable this feature. * (I found the term shallow copy for this a bit confusing, as I understand it usually means using [git clone --depth=](https://git-scm.com/docs/git-clone#Documentation/git-clone.txt-code--depthltdepthgtcode)) @lynxis@fe80.eu: so did I understand the motivation for this patch right and do you agree with my suggestion for moving this to osmo-dev etc.? If you prefer, I could also take this over. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39234?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0f1ac8852218f158ece14c176f05574f60d9d1f7 Gerrit-Change-Number: 39234 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 14 Jan 2025 14:38:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

5 months, 1 week

1
0
0 0

[S] Change in libosmo-netif[master]: add osmo_stream_cli_set_name_f()

by pespin

Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email ) Change subject: add osmo_stream_cli_set_name_f() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ide87f872246549d5963c3fac1627af397ef2e0c1 Gerrit-Change-Number: 39310 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jan 2025 14:38:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[S] Change in libosmo-netif[master]: add osmo_stream_cli_set_name_f()

by neels

Attention is currently required from: pespin. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email ) Change subject: add osmo_stream_cli_set_name_f() ...................................................................... Patch Set 2: (2 comments) Patchset: PS1: > I'm fine with merging this, I know several places where we are actually generating a string in a sta […] ack -> separate patch File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39310/comment/a82d2f8e_b7bbf94… : PS1, Line 674: osmo_stream_cli_set_name_f(cli, "%s", name); > I'd rather duplicate a couple lines than going through the whole vararg parsing here.... two reasons to disagree: a) the vararg parsing is not the slow part, the talloc is. There is no optimization effect. b) IIUC this code happens when establishing links, so it is not performance relevant. So this clearly calls for avoiding code dup instead of optimizing. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ide87f872246549d5963c3fac1627af397ef2e0c1 Gerrit-Change-Number: 39310 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jan 2025 14:00:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[S] Change in libosmo-netif[master]: add osmo_stream_cli_set_name_f()

by neels

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: add osmo_stream_cli_set_name_f() ...................................................................... add osmo_stream_cli_set_name_f() Change-Id: Ide87f872246549d5963c3fac1627af397ef2e0c1 --- M include/osmocom/netif/stream.h M src/stream_cli.c 2 files changed, 25 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/10/39310/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ide87f872246549d5963c3fac1627af397ef2e0c1 Gerrit-Change-Number: 39310 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: msc: add testenv.cfg

by osmith

Attention is currently required from: lynxis lazus. osmith has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39233?usp=email ) Change subject: msc: add testenv.cfg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39233?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia93115e3a27ac43b6530f2669e210f59169d75b9 Gerrit-Change-Number: 39233 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 14 Jan 2025 13:44:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: stp: set up all M3UA ports in array in steps

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39299?usp=email ) Change subject: stp: set up all M3UA ports in array in steps ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39299?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I585d9c768301bfd9ba849876923787137fc35981 Gerrit-Change-Number: 39299 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jan 2025 13:36:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Improve failure teardown using Misc_Helpers.f_shutdown

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39298?usp=email ) Change subject: stp: Improve failure teardown using Misc_Helpers.f_shutdown ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39298?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I776bc32b1bdb52d7e90102c4ab6ff7b0ef7a12c6 Gerrit-Change-Number: 39298 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jan 2025 13:35:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[XS] Change in osmo-ci[master]: remove build2-deb{10,11}build related config

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ci/+/39297?usp=email ) Change subject: remove build2-deb{10,11}build related config ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/39297?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I102e0cad667d8f2cf43c3535169cf3e32e04fca1 Gerrit-Change-Number: 39297 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 14 Jan 2025 13:33:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[XS] Change in osmo-bsc[master]: drop unused function decl abis_nm_rx()

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39312?usp=email ) Change subject: drop unused function decl abis_nm_rx() ...................................................................... drop unused function decl abis_nm_rx() Change-Id: I1fbbe551d0d216dca586d889f07499749f44ee37 --- M include/osmocom/bsc/abis_nm.h 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/include/osmocom/bsc/abis_nm.h b/include/osmocom/bsc/abis_nm.h index f55c29c..b7cf57b 100644 --- a/include/osmocom/bsc/abis_nm.h +++ b/include/osmocom/bsc/abis_nm.h @@ -67,7 +67,6 @@ int abis_nm_tlv_parse(struct tlv_parsed *tp, struct gsm_bts *bts, const uint8_t *buf, int len); int abis_nm_tlv_attr_primary_oml(struct tlv_parsed *tp, struct in_addr *ia, uint16_t *oml_port); int abis_nm_tlv_attr_unit_id(struct tlv_parsed *tp, char* unit_id, size_t buf_len); -int abis_nm_rx(struct msgb *msg); int abis_nm_opstart(struct gsm_bts *bts, uint8_t obj_class, uint8_t i0, uint8_t i1, uint8_t i2); int abis_nm_chg_adm_state(struct gsm_bts *bts, uint8_t obj_class, uint8_t i0, uint8_t i1, uint8_t i2, enum abis_nm_adm_state adm_state); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39312?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1fbbe551d0d216dca586d889f07499749f44ee37 Gerrit-Change-Number: 39312 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[XS] Change in osmo-pcap[master]: server: Move conn->file_hdr release to osmo_pcap_conn_close()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39314?usp=email ) Change subject: server: Move conn->file_hdr release to osmo_pcap_conn_close() ...................................................................... server: Move conn->file_hdr release to osmo_pcap_conn_close() We can always already release the file_hdr since we'll expect to receive a new one next time a connection is created. Change-Id: Ib822a0544b7a487614df28214813f31234eb6a0f --- M src/osmo_server_core.c M src/osmo_server_network.c 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/14/39314/1 diff --git a/src/osmo_server_core.c b/src/osmo_server_core.c index 5b9c2d4..9282694 100644 --- a/src/osmo_server_core.c +++ b/src/osmo_server_core.c @@ -339,6 +339,8 @@ conn->rem_wq.bfd.fd = -1; osmo_tls_release(&conn->tls_session); } + TALLOC_FREE(conn->file_hdr); + conn->file_hdr_len = 0; osmo_pcap_conn_close_trace(conn); osmo_pcap_conn_event(conn, "disconnect", NULL); diff --git a/src/osmo_server_network.c b/src/osmo_server_network.c index 21ff255..8f9d528 100644 --- a/src/osmo_server_network.c +++ b/src/osmo_server_network.c @@ -421,8 +421,6 @@ { osmo_pcap_conn_close(client); - TALLOC_FREE(client->file_hdr); - client->file_hdr_len = 0; client->rem_wq.bfd.fd = new_fd; if (osmo_fd_register(&client->rem_wq.bfd) != 0) { LOGP(DSERVER, LOGL_ERROR, "Failed to register fd.\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39314?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ib822a0544b7a487614df28214813f31234eb6a0f Gerrit-Change-Number: 39314 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025