January 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-pcap[master]: cosmetic: server: Fix formatting of return in main()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39313?usp=email ) Change subject: cosmetic: server: Fix formatting of return in main() ...................................................................... cosmetic: server: Fix formatting of return in main() Change-Id: I70af88cd62258f6b6de71d5ba9d8c29699c96f68 --- M src/osmo_server_main.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/13/39313/1 diff --git a/src/osmo_server_main.c b/src/osmo_server_main.c index 49ee449..e570e89 100644 --- a/src/osmo_server_main.c +++ b/src/osmo_server_main.c @@ -271,5 +271,5 @@ osmo_select_main(0); } - return(0); + return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39313?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I70af88cd62258f6b6de71d5ba9d8c29699c96f68 Gerrit-Change-Number: 39313 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[XS] Change in osmo-bsc[master]: drop unused function decl abis_nm_rx()

by pespin

Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39312?usp=email ) Change subject: drop unused function decl abis_nm_rx() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39312?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1fbbe551d0d216dca586d889f07499749f44ee37 Gerrit-Change-Number: 39312 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jan 2025 13:02:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[S] Change in libosmo-netif[master]: add osmo_stream_cli_set_name_f()

by pespin

Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email ) Change subject: add osmo_stream_cli_set_name_f() ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > FYI, this patch fell out of my work some months ago, which is now probably obsolete. […] I'm fine with merging this, I know several places where we are actually generating a string in a stack allocated buf then passing it to this API. I'd welcome though if you also add to this patch the counterpart for osmo_stream_srv (I think we can skip it for osmo_stream_srv_link, since usually there's no multiple of those which needs string generation). File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39310/comment/19e96e79_0acaf45… : PS1, Line 674: osmo_stream_cli_set_name_f(cli, "%s", name); I'd rather duplicate a couple lines than going through the whole vararg parsing here.... -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ide87f872246549d5963c3fac1627af397ef2e0c1 Gerrit-Change-Number: 39310 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jan 2025 13:02:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[XS] Change in osmo-bsc[master]: drop unused function decl abis_nm_rx()

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39312?usp=email ) Change subject: drop unused function decl abis_nm_rx() ...................................................................... drop unused function decl abis_nm_rx() Change-Id: I1fbbe551d0d216dca586d889f07499749f44ee37 --- M include/osmocom/bsc/abis_nm.h 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/12/39312/1 diff --git a/include/osmocom/bsc/abis_nm.h b/include/osmocom/bsc/abis_nm.h index f55c29c..b7cf57b 100644 --- a/include/osmocom/bsc/abis_nm.h +++ b/include/osmocom/bsc/abis_nm.h @@ -67,7 +67,6 @@ int abis_nm_tlv_parse(struct tlv_parsed *tp, struct gsm_bts *bts, const uint8_t *buf, int len); int abis_nm_tlv_attr_primary_oml(struct tlv_parsed *tp, struct in_addr *ia, uint16_t *oml_port); int abis_nm_tlv_attr_unit_id(struct tlv_parsed *tp, char* unit_id, size_t buf_len); -int abis_nm_rx(struct msgb *msg); int abis_nm_opstart(struct gsm_bts *bts, uint8_t obj_class, uint8_t i0, uint8_t i1, uint8_t i2); int abis_nm_chg_adm_state(struct gsm_bts *bts, uint8_t obj_class, uint8_t i0, uint8_t i1, uint8_t i2, enum abis_nm_adm_state adm_state); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39312?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1fbbe551d0d216dca586d889f07499749f44ee37 Gerrit-Change-Number: 39312 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[XS] Change in libosmo-netif[master]: api doc: stream.h: hint at how to select modern vs legacy mode

by pespin

Attention is currently required from: neels. pespin has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39309?usp=email ) Change subject: api doc: stream.h: hint at how to select modern vs legacy mode ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File include/osmocom/netif/stream.h: https://gerrit.osmocom.org/c/libosmo-netif/+/39309/comment/d351c0e8_d9b9017… : PS1, Line 36: * The legacy mode is chosen by invoking the older osmo_stream_srv_create(). We should actually start thinking about deprecating the old mode. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I651fadb1a00e51f347963418b7a6c5d320580d23 Gerrit-Change-Number: 39309 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 14 Jan 2025 12:58:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[S] Change in libosmo-netif[master]: add osmo_stream_cli_set_name_f()

by neels

neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email ) Change subject: add osmo_stream_cli_set_name_f() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: FYI, this patch fell out of my work some months ago, which is now probably obsolete. So there is no caller for this, yet i think it is a useful API... we can add it, or abandon, either way is fine -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ide87f872246549d5963c3fac1627af397ef2e0c1 Gerrit-Change-Number: 39310 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 14 Jan 2025 12:57:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

5 months, 1 week

1
0
0 0

[S] Change in libosmo-netif[master]: add osmo_stream_cli_set_name_f()

by Jenkins Builder

Jenkins Builder has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email ) Change subject: add osmo_stream_cli_set_name_f() ...................................................................... Patch Set 1: (1 comment) File src/stream_cli.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20939): https://gerrit.osmocom.org/c/libosmo-netif/+/39310/comment/029e4fa0_5ca2a44… : PS1, Line 694: talloc_free((char*)cli->name); "(foo*)" should be "(foo *)" -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ide87f872246549d5963c3fac1627af397ef2e0c1 Gerrit-Change-Number: 39310 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 14 Jan 2025 12:57:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

5 months, 1 week

1
0
0 0

[XS] Change in osmo-pcap[master]: tests: Remove unneeded .o files after osmo-pcap-server network/core f...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39311?usp=email ) Change subject: tests: Remove unneeded .o files after osmo-pcap-server network/core file split ...................................................................... tests: Remove unneeded .o files after osmo-pcap-server network/core file split Change-Id: I8c90d986c5ca60cc3c1083dc0c643d66044dc40e --- M tests/rotate_localtime/Makefile.am 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/11/39311/1 diff --git a/tests/rotate_localtime/Makefile.am b/tests/rotate_localtime/Makefile.am index f6ced6e..a9402aa 100644 --- a/tests/rotate_localtime/Makefile.am +++ b/tests/rotate_localtime/Makefile.am @@ -28,9 +28,7 @@ $(NULL) rotate_localtime_test_LDADD = \ - $(top_builddir)/src/osmo_pcap_file.o \ $(top_builddir)/src/osmo_server_core.o \ - $(top_builddir)/src/osmo_server_network.o \ $(top_builddir)/src/osmo_server_stats.o \ $(top_builddir)/src/osmo_tls.o \ $(LIBOSMOCORE_LIBS) \ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I8c90d986c5ca60cc3c1083dc0c643d66044dc40e Gerrit-Change-Number: 39311 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[S] Change in libosmo-netif[master]: add osmo_stream_cli_set_name_f()

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email ) Change subject: add osmo_stream_cli_set_name_f() ...................................................................... add osmo_stream_cli_set_name_f() Change-Id: Ide87f872246549d5963c3fac1627af397ef2e0c1 --- M include/osmocom/netif/stream.h M src/stream_cli.c 2 files changed, 25 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/10/39310/1 diff --git a/include/osmocom/netif/stream.h b/include/osmocom/netif/stream.h index f63560a..4f3db25 100644 --- a/include/osmocom/netif/stream.h +++ b/include/osmocom/netif/stream.h @@ -199,6 +199,7 @@ typedef int (*osmo_stream_cli_segmentation_cb_t)(struct msgb *msg); void osmo_stream_cli_set_name(struct osmo_stream_cli *cli, const char *name); +void osmo_stream_cli_set_name_f(struct osmo_stream_cli *cli, const char *fmt, ...); const char *osmo_stream_cli_get_name(const struct osmo_stream_cli *cli); void osmo_stream_cli_set_nodelay(struct osmo_stream_cli *cli, bool nodelay); int osmo_stream_cli_set_priority(struct osmo_stream_cli *cli, int sk_prio); diff --git a/src/stream_cli.c b/src/stream_cli.c index 48a8858..ec5325a 100644 --- a/src/stream_cli.c +++ b/src/stream_cli.c @@ -671,9 +671,31 @@ */ void osmo_stream_cli_set_name(struct osmo_stream_cli *cli, const char *name) { - osmo_talloc_replace_string(cli, &cli->name, name); + osmo_stream_cli_set_name_f(cli, "%s", name); +} + +/*! Set a name on the cli object using arguments like printf() (used during logging). + * \param[in] cli stream_cli whose name is to be set + * \param[in] name the name to be set on cli + */ +void osmo_stream_cli_set_name_f(struct osmo_stream_cli *cli, const char *fmt, ...); +{ + char *name = NULL; + + if (fmt) { + va_list ap; + + va_start(ap, fmt); + name = talloc_vasprintf(cli, fmt, ap); + va_end(ap); + } + + if (cli->name) + talloc_free((char*)cli->name); + cli->name = name; + if (cli->mode == OSMO_STREAM_MODE_OSMO_IO && cli->iofd) - osmo_iofd_set_name(cli->iofd, name); + osmo_iofd_set_name(cli->iofd, cli->name); } /*! Retrieve name previously set on the cli object (see osmo_stream_cli_set_name()). -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ide87f872246549d5963c3fac1627af397ef2e0c1 Gerrit-Change-Number: 39310 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[XS] Change in libosmo-netif[master]: api doc: stream.h: hint at how to select modern vs legacy mode

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39309?usp=email ) Change subject: api doc: stream.h: hint at how to select modern vs legacy mode ...................................................................... api doc: stream.h: hint at how to select modern vs legacy mode Change-Id: I651fadb1a00e51f347963418b7a6c5d320580d23 --- M include/osmocom/netif/stream.h 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/09/39309/1 diff --git a/include/osmocom/netif/stream.h b/include/osmocom/netif/stream.h index a132a27..f63560a 100644 --- a/include/osmocom/netif/stream.h +++ b/include/osmocom/netif/stream.h @@ -32,6 +32,9 @@ * For any new applications, you definitely should use the modern mode, as it provides you with a higher * layer of abstraction and allows you to perform efficient I/O using the io_uring backend of osmo_io. * + * The modern mode is chosen by invoking osmo_stream_srv_create2(). + * The legacy mode is chosen by invoking the older osmo_stream_srv_create(). + * * The two main objects are osmo_stream_srv_link (main server accept()ing incoming connections) and * osmo_stream_srv (a single given connection from a remote client). * @@ -160,6 +163,9 @@ * For any new applications, you definitely should use the modern mode, as it provides you with a higher * layer of abstraction and allows you to perform efficient I/O using the io_uring backend of osmo_io. * + * The modern mode is chosen by invoking osmo_stream_cli_set_read_cb2(). + * The legacy mode is chosen by invoking the older osmo_stream_cli_set_read_cb(). + * * A typical usage of osmo_stream_cli would look as follows: * * * call osmo_stream_cli_create() to create a new osmo_stream_cli -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I651fadb1a00e51f347963418b7a6c5d320580d23 Gerrit-Change-Number: 39309 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

5 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025