pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/39345?usp=email )
Change subject: gsm48_encode_bearer_cap(): properly set 'Structure' in octet 4
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Looks like some build slave has broken io_uring:
"+failure during io_uring_queue_init(): Operation not permitted"
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39345?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: pespin/rel-1.10.0
Gerrit-Change-Id: I563becfdae75e22de3b5e5de3c810334a74e7ffb
Gerrit-Change-Number: 39345
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 15 Jan 2025 16:41:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: csaba.sipos.
pespin has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email )
Change subject: nokia_site: add reset_type attribute
......................................................................
Patch Set 3:
(3 comments)
File src/osmo-bsc/bts_nokia_site.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/39315/comment/690f594c_c3afe783?usp… :
PS3, Line 604: { 2, "reserved" },
Maybe start it with a cap letter too? Or is this specified as so somewhere?
https://gerrit.osmocom.org/c/osmo-bsc/+/39315/comment/8ab8ef1b_81f40af9?usp… :
PS3, Line 1716: if (find_element(noh->data, len_data, NOKIA_EI_RESET_TYPE, &reset_type,
afaiu this IE is unrelated to the EI_BTS_TYPE above, so it probably makes much more sense to pul lal lthis new code outside the if block?
https://gerrit.osmocom.org/c/osmo-bsc/+/39315/comment/b70265eb_87b7a709?usp… :
PS3, Line 1718: LOG_BTS(bts, DNM, LOGL_INFO, "Rx BTS reset type = %s\n",
You probably want to do '%s' (with simple quotes) since the strings have spaces, to easiely understand the resulting string.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39315?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I0f31cd711768c963e5c14c0f4969ff76cb05c12b
Gerrit-Change-Number: 39315
Gerrit-PatchSet: 3
Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu>
Gerrit-Comment-Date: Wed, 15 Jan 2025 16:40:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: daniel, laforge, neels, osmith, pespin.
Hello Jenkins Builder, daniel, fixeria, laforge, neels, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-netif/+/39316?usp=email
to look at the new patch set (#2).
Change subject: stream: Introduce osmo_stream_{cli,srv}_set_segmentation_cb2
......................................................................
stream: Introduce osmo_stream_{cli,srv}_set_segmentation_cb2
This is useful for users requiring to store global state or access
external objects while segmenting.
For instance, figure out if too much data has been received according to
whatever external limits are expected according to configuration.
Change-Id: I6e8dd6ece13397074075f05a1a0a8dbdd80d8848
---
M TODO-RELEASE
M include/osmocom/netif/stream.h
M src/stream_cli.c
M src/stream_srv.c
4 files changed, 105 insertions(+), 23 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/16/39316/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39316?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I6e8dd6ece13397074075f05a1a0a8dbdd80d8848
Gerrit-Change-Number: 39316
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/39346?usp=email )
Change subject: osmo_io: Increase default queue max_length from 32 to 1024
......................................................................
osmo_io: Increase default queue max_length from 32 to 1024
The default value is way too low, and can be hit easily by apps
submitting several messages in one main loop run.
This is the case for instance of the Abis OML protocol, where a cascade
of "State Changed Event Reports" are sent for the whole object tree.
Set the default to a saner bigger value. In the end, increasing the
value doesn't hurt normal use of apps, and 1024 is still a fairly small
number to avoid the app eating the whole system memory if something
unexpected happens.
Change-Id: I92d5369af523f6297d45d4b534bb0f349ae74485
(cherry picked from commit 9cbc92e80e8a70131851b363c4438c216e559335)
---
M src/core/osmo_io.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/46/39346/1
diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c
index af096e6..98d8ef3 100644
--- a/src/core/osmo_io.c
+++ b/src/core/osmo_io.c
@@ -637,7 +637,7 @@
* The created osmo_io_fd is initialized with some default settings:
* * msgb allocations size: OSMO_IO_DEFAULT_MSGB_SIZE (1024)
* * msgb headroom: OSMO_IO_DEFAULT_MSGB_HEADROOM (128)
- * * tx_queue depth: 32
+ * * tx_queue depth: 1024
*
* Those values may be adjusted from their defaults by using osmo_iofd_set_alloc_info() and
* osmo_iofd_set_txqueue_max_length() on the osmo_io_fd.
@@ -696,7 +696,7 @@
iofd->msgb_alloc.size = OSMO_IO_DEFAULT_MSGB_SIZE;
iofd->msgb_alloc.headroom = OSMO_IO_DEFAULT_MSGB_HEADROOM;
- iofd->tx_queue.max_length = 32;
+ iofd->tx_queue.max_length = 1024;
INIT_LLIST_HEAD(&iofd->tx_queue.msg_queue);
return iofd;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39346?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libosmocore
Gerrit-Branch: pespin/rel-1.10.0
Gerrit-Change-Id: I92d5369af523f6297d45d4b534bb0f349ae74485
Gerrit-Change-Number: 39346
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>