January 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcu[master]: gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcu/+/39188?usp=email ) Change subject: gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2 ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File tests/rlcmac/RLCMACTest.err: https://gerrit.osmocom.org/c/osmo-pcu/+/39188/comment/9f934b35_042a9365?usp… : PS2, Line 42: DCSN1 INFO csnStreamDecoder (type: Pkt Resource Req (5)): PayloadType = 1 | spare = 0 | R = 0 | MESSAGE_TYPE = 5 | Exist_ACCESS_TYPE = 1 | ACCESS_TYPE = 3 | : ID | Choice PacketResourceRequestID = 1 | u.TLLI = 0x96cb3568 | : End ID | Exist_MS_Radio_Access_capability2 = 1 | : MS_Radio_Access_capability2 | MS_RA_capability_value { | Choice MS_RA_capability_value_Choice = 7 | u.Content length = 50 | offset = 1 | RF_Power_Capability = 4 | Exist_A5_bits = 1 | A5_bits = 80 | ES_IND = 1 | PS = 1 | VGCS = 0 | VBS = 0 | Exist_Multislot_capability = 1 | : Multislot_capability | Exist_HSCSD_multislot_class = 0 | Exist_GPRS_multislot_class = 1 | GPRS_multislot_class = 11 | GPRS_Extended_Dynamic_Allocation_Capability = 1 | Exist_SM = 1 | SMS_VALUE = 2 | SM_VALUE = 2 | Exist_ECSD_multislot_class = 0 | Exist_EGPRS_multislot_class = 1 | EGPRS_multislot_class = 11 | EGPRS_Extended_Dynamic_Allocation_Capability = 1 | Exist_DTM_GPRS_multislot_class = 0 | : End Multislot_capability | Exist_Eight_PSK_Power_Capability = 1 | Eight_PSK_Power_Capability = 2 | COMPACT_Interference_Measurement_Capability = 0 | Revision_Level_Indicator = 1 | UMTS_FDD_Radio_Access_Technology_Capability = 0 | UMTS_384_TDD_Radio_Access_Technology_Capability = 0 | CDMA2000_Radio_Access_Technology_Capability = 0 | UMTS_128_TDD_Radio_Access_Technology_Capability = NULL | GERAN_Feature_Package_1 = NULL | Modulation_based_multislot_class_support = NULL | GMSK_MultislotPowerProfile = NULL | EightPSK_MultislotProfile = NULL | MultipleTBF_Capability = NULL | DownlinkAdvancedReceiverPerformance = NULL | ExtendedRLC_MAC_ControlMessageSegmentionsCapability = NULL | DTM_EnhancementsCapability = NULL | PS_HandoverCapability = NULL | DTM_Handover_Capability = NULL | FlexibleTimeslotAssignment = NULL | GAN_PS_HandoverCapability = NULL | RLC_Non_persistentMode = NULL | ReducedLatencyCapability = NULL | UplinkEGPRS2 = NULL | DownlinkEGPRS2 = NULL | EUTRA_FDD_Support = NULL | EUTRA_TDD_Support = NULL | GERAN_To_EUTRAN_supportInGERAN_PTM = NULL | PriorityBasedReselectionSupport = NULL | MS_RA_capability_value } | : End MS_Radio_Access_capability2 | : Channel_Request_Description | PEAK_THROUGHPUT_CLASS = 9 | RADIO_PRIORITY = 0 | RLC_MODE = 0 | LLC_PDU_TYPE = 1 | RLC_OCTET_COUNT = 39 | : End Channel_Request_Description | Exist_CHANGE_MARK = 0 | C_VALUE = 19 | Exist_SIGN_VAR = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | Exist_AdditionsR99 = 1 | : AdditionsR99 | Exist_EGPRS_BEP_LinkQualityMeasurements = 0 | Exist_EGPRS_TimeslotLinkQualityMeasurements = 0 | Exist_PFI = 0 | MS_RAC_AdditionalInformationAvailable = 0 | RetransmissionOfPRR = 0 | Exist_AdditionsR5 = 1 | : AdditionsR5 | Exist_Iu_Mode_ChRequestDesk = 0 | Exist_HFN_LSB = 0 | Exist_AdditionsR6 = 1 | : AdditionsR6 | Exist_Ext_Channel_Request_desc = 0 | Exist_AdditionsR7 = 1 | : AdditionsR7 | EARLY_TBF_ESTABLISHMENT = 0 | Exist_EGPRS_BEP_LinkQualityMeasurements_type2 = 1 | : EGPRS_BEP_LinkQualityMeasurements_type2 | Exist_GMSK_MEAN_BEP = 1 | GMSK_MEAN_BEP = 5 | GMSK_CV_BEP = 3 | Exist_8PSK_MEAN_BEP = 0 | Exist_QPSK_MEAN_BEP = 0 | Exist_16QAM_NSR_MEAN_BEP = 1 | p16QAM_NSR_MEAN_BEP = 11 | DCSN1 ERROR csnStreamDecoder: error NEED_MORE BITS TO UNPACK (-5) at p16QAM_NSR_CV_BEP (idx 184): End EGPRS_BEP_LinkQualityMeasurements_type2 | : End AdditionsR7 | : End AdditionsR6 | : End AdditionsR5 | : End AdditionsR99 | > As I said, it's an unrelated problem. Early versions of 3GPP TS 44. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I061ac16df5e6413266de08884f791f0264791192 Gerrit-Change-Number: 39188 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 16:54:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: fix EGPRS BEP Link Quality Measurements Type 2

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/39187?usp=email ) Change subject: rlcmac: fix EGPRS BEP Link Quality Measurements Type 2 ...................................................................... rlcmac: fix EGPRS BEP Link Quality Measurements Type 2 This IE is defined in 3GPP TS 44.060 Table 12.5a.2.1. Each presence bit indicates presence of the next two entries, not one. This patch does affect the output of csn1_ts_44_060_test, though it does not fix decoding because it's caused by an unrelated problem. Related: osmo-pcu.git I061ac16df5e6413266de08884f791f0264791192 Change-Id: Iac4de18ef25386f774bb409201b7a7996d1c8824 --- M src/rlcmac/csn1_ts_44_060.c M tests/rlcmac/csn1_ts_44_060_test.err 2 files changed, 9 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/rlcmac/csn1_ts_44_060.c b/src/rlcmac/csn1_ts_44_060.c index 296c498..e8c03df 100644 --- a/src/rlcmac/csn1_ts_44_060.c +++ b/src/rlcmac/csn1_ts_44_060.c @@ -519,34 +519,35 @@ CSN_DESCR_END (Ext_Channel_Request_desc_t) +/* Table 12.5a.2.1 "EGPRS BEP Link Quality Measurements Type 2 Information elements" */ static const CSN_DESCR_BEGIN(EGPRS_BEP_LinkQualityMeasurements_type2_t) - M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_GMSK_MEAN_BEP, 1), + M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_GMSK_MEAN_BEP, 2), M_UINT (EGPRS_BEP_LinkQualityMeasurements_type2_t, GMSK_MEAN_BEP, 5), M_UINT (EGPRS_BEP_LinkQualityMeasurements_type2_t, GMSK_CV_BEP, 3), - M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_8PSK_MEAN_BEP, 1), + M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_8PSK_MEAN_BEP, 2), M_UINT (EGPRS_BEP_LinkQualityMeasurements_type2_t, p8PSK_MEAN_BEP, 5), M_UINT (EGPRS_BEP_LinkQualityMeasurements_type2_t, p8PSK_CV_BEP, 3), - M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_QPSK_MEAN_BEP, 1), + M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_QPSK_MEAN_BEP, 2), M_UINT (EGPRS_BEP_LinkQualityMeasurements_type2_t, QPSK_MEAN_BEP, 5), M_UINT (EGPRS_BEP_LinkQualityMeasurements_type2_t, QPSK_CV_BEP, 3), - M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_16QAM_NSR_MEAN_BEP, 1), + M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_16QAM_NSR_MEAN_BEP, 2), M_UINT (EGPRS_BEP_LinkQualityMeasurements_type2_t, p16QAM_NSR_MEAN_BEP, 5), M_UINT (EGPRS_BEP_LinkQualityMeasurements_type2_t, p16QAM_NSR_CV_BEP, 3), - M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_32QAM_NSR_MEAN_BEP, 1), + M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_32QAM_NSR_MEAN_BEP, 2), M_UINT (EGPRS_BEP_LinkQualityMeasurements_type2_t, p32QAM_NSR_MEAN_BEP, 5), M_UINT (EGPRS_BEP_LinkQualityMeasurements_type2_t, p32QAM_NSR_CV_BEP, 3), - M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_16QAM_HSR_MEAN_BEP, 1), + M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_16QAM_HSR_MEAN_BEP, 2), M_UINT (EGPRS_BEP_LinkQualityMeasurements_type2_t, p16QAM_HSR_MEAN_BEP, 5), M_UINT (EGPRS_BEP_LinkQualityMeasurements_type2_t, p16QAM_HSR_CV_BEP, 3), - M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_32QAM_HSR_MEAN_BEP, 1), + M_NEXT_EXIST (EGPRS_BEP_LinkQualityMeasurements_type2_t, Exist_32QAM_HSR_MEAN_BEP, 2), M_UINT (EGPRS_BEP_LinkQualityMeasurements_type2_t, p32QAM_HSR_MEAN_BEP, 5), M_UINT (EGPRS_BEP_LinkQualityMeasurements_type2_t, p32QAM_HSR_CV_BEP, 3), diff --git a/tests/rlcmac/csn1_ts_44_060_test.err b/tests/rlcmac/csn1_ts_44_060_test.err index 029e993..57a6391 100644 --- a/tests/rlcmac/csn1_ts_44_060_test.err +++ b/tests/rlcmac/csn1_ts_44_060_test.err @@ -39,7 +39,7 @@ DLCSN1 INFO osmo_csn1_stream_encode (type: Pkt Resource Req (5)): PayloadType = 1 | spare = 0 | R = 0 | MESSAGE_TYPE = 5 | Exist_ACCESS_TYPE = 1 | ACCESS_TYPE = 0 | : ID | u.TLLI = 1 | u.TLLI = 4180140003 | : End ID | Exist_MS_Radio_Access_capability2 = 1 | : MS_Radio_Access_capability2 | MS_RA_capability_value { | u.Content = 7 | RF_Power_Capability = 4 | Exist_A5_bits = 0 | ES_IND = 1 | PS = 1 | VGCS = 0 | VBS = 0 | Exist_Multislot_capability = 1 | : Multislot_capability | Exist_HSCSD_multislot_class = 0 | Exist_GPRS_multislot_class = 1 | GPRS_multislot_class = 12 | GPRS_Extended_Dynamic_Allocation_Capability = 1 | Exist_SM = 0 | Exist_ECSD_multislot_class = 0 | Exist_EGPRS_multislot_class = 1 | EGPRS_multislot_class = 12 | EGPRS_Extended_Dynamic_Allocation_Capability = 1 | Exist_DTM_GPRS_multislot_class = 0 | : End Multislot_capability | Exist_Eight_PSK_Power_Capability = 1 | Eight_PSK_Power_Capability = 2 | COMPACT_Interference_Measurement_Capability = 0 | Revision_Level_Indicator = 1 | UMTS_FDD_Radio_Access_Technology_Capability = 1 | UMTS_384_TDD_Radio_Access_Technology_Capability = 0 | CDMA2000_Radio_Access_Technology_Capability = 0 | UMTS_128_TDD_Radio_Access_Technology_Capability = 0 | GERAN_Feature_Package_1 = 1 | Exist_Extended_DTM_multislot_class = 0 | Modulation_based_multislot_class_support = 0 | Exist_HighMultislotCapability = 0 | Exist_GERAN_lu_ModeCapability = 0 | GMSK_MultislotPowerProfile = 0 | EightPSK_MultislotProfile = 0 | MultipleTBF_Capability = 0 | DownlinkAdvancedReceiverPerformance = 1 | ExtendedRLC_MAC_ControlMessageSegmentionsCapability = 1 | DTM_EnhancementsCapability = 0 | Exist_DTM_GPRS_HighMultislotClass = 0 | PS_HandoverCapability = 0 | DTM_Handover_Capability = 0 | Exist_DownlinkDualCarrierCapability_r7 = 0 | FlexibleTimeslotAssignment = 0 | GAN_PS_HandoverCapability = 0 | RLC_Non_persistentMode = 0 | ReducedLatencyCapability = 0 | UplinkEGPRS2 = 0 | DownlinkEGPRS2 = 0 | EUTRA_FDD_Support = 0 | EUTRA_TDD_Support = 0 | GERAN_To_EUTRAN_supportInGERAN_PTM = 0 | PriorityBasedReselectionSupport = 1 | u.Content length = 67 | MS_RA_capability_value } | : End MS_Radio_Access_capability2 | : Channel_Request_Description | PEAK_THROUGHPUT_CLASS = 6 | RADIO_PRIORITY = 3 | RLC_MODE = 0 | LLC_PDU_TYPE = 1 | RLC_OCTET_COUNT = 84 | : End Channel_Request_Description | Exist_CHANGE_MARK = 0 | C_VALUE = 14 | Exist_SIGN_VAR = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | Exist_AdditionsR99 = 1 | : AdditionsR99 | Exist_EGPRS_BEP_LinkQualityMeasurements = 0 | Exist_EGPRS_TimeslotLinkQualityMeasurements = 0 | Exist_PFI = 0 | MS_RAC_AdditionalInformationAvailable = 0 | RetransmissionOfPRR = 0 | Exist_AdditionsR5 = 0 | : End AdditionsR99 | Padding = 43| DLCSN1 INFO osmo_csn1_stream_decode (type: Pkt Resource Req (5)): PayloadType = 1 | spare = 0 | R = 0 | MESSAGE_TYPE = 5 | Exist_ACCESS_TYPE = 1 | ACCESS_TYPE = 2 | : ID | Choice PacketResourceRequestID = 1 | u.TLLI = 0xe1c5d364 | : End ID | Exist_MS_Radio_Access_capability2 = 1 | : MS_Radio_Access_capability2 | MS_RA_capability_value { | Choice MS_RA_capability_value_Choice = 7 | u.Content length = 46 | offset = 1 | RF_Power_Capability = 4 | Exist_A5_bits = 1 | A5_bits = 80 | ES_IND = 1 | PS = 1 | VGCS = 0 | VBS = 0 | Exist_Multislot_capability = 1 | : Multislot_capability | Exist_HSCSD_multislot_class = 0 | Exist_GPRS_multislot_class = 1 | GPRS_multislot_class = 12 | GPRS_Extended_Dynamic_Allocation_Capability = 1 | Exist_SM = 0 | Exist_ECSD_multislot_class = 0 | Exist_EGPRS_multislot_class = 1 | EGPRS_multislot_class = 12 | EGPRS_Extended_Dynamic_Allocation_Capability = 1 | Exist_DTM_GPRS_multislot_class = 0 | : End Multislot_capability | Exist_Eight_PSK_Power_Capability = 1 | Eight_PSK_Power_Capability = 2 | COMPACT_Interference_Measurement_Capability = 0 | Revision_Level_Indicator = 1 | UMTS_FDD_Radio_Access_Technology_Capability = 1 | UMTS_384_TDD_Radio_Access_Technology_Capability = 0 | CDMA2000_Radio_Access_Technology_Capability = 0 | UMTS_128_TDD_Radio_Access_Technology_Capability = 1 | GERAN_Feature_Package_1 = 1 | Exist_Extended_DTM_multislot_class = 0 | Modulation_based_multislot_class_support = 0 | GMSK_MultislotPowerProfile = NULL | EightPSK_MultislotProfile = NULL | MultipleTBF_Capability = NULL | DownlinkAdvancedReceiverPerformance = NULL | ExtendedRLC_MAC_ControlMessageSegmentionsCapability = NULL | DTM_EnhancementsCapability = NULL | PS_HandoverCapability = NULL | DTM_Handover_Capability = NULL | FlexibleTimeslotAssignment = NULL | GAN_PS_HandoverCapability = NULL | RLC_Non_persistentMode = NULL | ReducedLatencyCapability = NULL | UplinkEGPRS2 = NULL | DownlinkEGPRS2 = NULL | EUTRA_FDD_Support = NULL | EUTRA_TDD_Support = NULL | GERAN_To_EUTRAN_supportInGERAN_PTM = NULL | PriorityBasedReselectionSupport = NULL | MS_RA_capability_value } | : End MS_Radio_Access_capability2 | : Channel_Request_Description | PEAK_THROUGHPUT_CLASS = 6 | RADIO_PRIORITY = 0 | RLC_MODE = 0 | LLC_PDU_TYPE = 1 | RLC_OCTET_COUNT = 20 | : End Channel_Request_Description | Exist_CHANGE_MARK = 0 | C_VALUE = 0 | Exist_SIGN_VAR = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | Exist_AdditionsR99 = 1 | : AdditionsR99 | Exist_EGPRS_BEP_LinkQualityMeasurements = 0 | Exist_EGPRS_TimeslotLinkQualityMeasurements = 0 | Exist_PFI = 0 | MS_RAC_AdditionalInformationAvailable = 0 | RetransmissionOfPRR = 0 | Exist_AdditionsR5 = 0 | : End AdditionsR99 | Padding = 11|43|43|43| DLCSN1 INFO osmo_csn1_stream_encode (type: Pkt Resource Req (5)): PayloadType = 1 | spare = 0 | R = 0 | MESSAGE_TYPE = 5 | Exist_ACCESS_TYPE = 1 | ACCESS_TYPE = 2 | : ID | u.TLLI = 1 | u.TLLI = 3787838308 | : End ID | Exist_MS_Radio_Access_capability2 = 1 | : MS_Radio_Access_capability2 | MS_RA_capability_value { | u.Content = 7 | RF_Power_Capability = 4 | Exist_A5_bits = 1 | A5_bits = 80 | ES_IND = 1 | PS = 1 | VGCS = 0 | VBS = 0 | Exist_Multislot_capability = 1 | : Multislot_capability | Exist_HSCSD_multislot_class = 0 | Exist_GPRS_multislot_class = 1 | GPRS_multislot_class = 12 | GPRS_Extended_Dynamic_Allocation_Capability = 1 | Exist_SM = 0 | Exist_ECSD_multislot_class = 0 | Exist_EGPRS_multislot_class = 1 | EGPRS_multislot_class = 12 | EGPRS_Extended_Dynamic_Allocation_Capability = 1 | Exist_DTM_GPRS_multislot_class = 0 | : End Multislot_capability | Exist_Eight_PSK_Power_Capability = 1 | Eight_PSK_Power_Capability = 2 | COMPACT_Interference_Measurement_Capability = 0 | Revision_Level_Indicator = 1 | UMTS_FDD_Radio_Access_Technology_Capability = 1 | UMTS_384_TDD_Radio_Access_Technology_Capability = 0 | CDMA2000_Radio_Access_Technology_Capability = 0 | UMTS_128_TDD_Radio_Access_Technology_Capability = 1 | GERAN_Feature_Package_1 = 1 | Exist_Extended_DTM_multislot_class = 0 | Modulation_based_multislot_class_support = 0 | Exist_HighMultislotCapability = 0 | Exist_GERAN_lu_ModeCapability = 0 | GMSK_MultislotPowerProfile = 0 | EightPSK_MultislotProfile = 0 | MultipleTBF_Capability = 0 | DownlinkAdvancedReceiverPerformance = 0 | ExtendedRLC_MAC_ControlMessageSegmentionsCapability = 0 | DTM_EnhancementsCapability = 0 | Exist_DTM_GPRS_HighMultislotClass = 0 | PS_HandoverCapability = 0 | DTM_Handover_Capability = 0 | Exist_DownlinkDualCarrierCapability_r7 = 0 | FlexibleTimeslotAssignment = 0 | GAN_PS_HandoverCapability = 0 | RLC_Non_persistentMode = 0 | ReducedLatencyCapability = 0 | UplinkEGPRS2 = 0 | DownlinkEGPRS2 = 0 | EUTRA_FDD_Support = 0 | EUTRA_TDD_Support = 0 | GERAN_To_EUTRAN_supportInGERAN_PTM = 0 | PriorityBasedReselectionSupport = 0 | u.Content length = 74 | MS_RA_capability_value } | : End MS_Radio_Access_capability2 | : Channel_Request_Description | PEAK_THROUGHPUT_CLASS = 6 | RADIO_PRIORITY = 0 | RLC_MODE = 0 | LLC_PDU_TYPE = 1 | RLC_OCTET_COUNT = 20 | : End Channel_Request_Description | Exist_CHANGE_MARK = 0 | C_VALUE = 0 | Exist_SIGN_VAR = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | Exist_AdditionsR99 = 1 | : AdditionsR99 | Exist_EGPRS_BEP_LinkQualityMeasurements = 0 | Exist_EGPRS_TimeslotLinkQualityMeasurements = 0 | Exist_PFI = 0 | MS_RAC_AdditionalInformationAvailable = 0 | RetransmissionOfPRR = 0 | Exist_AdditionsR5 = 0 | : End AdditionsR99 | Padding = -DLCSN1 INFO osmo_csn1_stream_decode (type: Pkt Resource Req (5)): PayloadType = 1 | spare = 0 | R = 0 | MESSAGE_TYPE = 5 | Exist_ACCESS_TYPE = 1 | ACCESS_TYPE = 3 | : ID | Choice PacketResourceRequestID = 1 | u.TLLI = 0x96cb3568 | : End ID | Exist_MS_Radio_Access_capability2 = 1 | : MS_Radio_Access_capability2 | MS_RA_capability_value { | Choice MS_RA_capability_value_Choice = 7 | u.Content length = 50 | offset = 1 | RF_Power_Capability = 4 | Exist_A5_bits = 1 | A5_bits = 80 | ES_IND = 1 | PS = 1 | VGCS = 0 | VBS = 0 | Exist_Multislot_capability = 1 | : Multislot_capability | Exist_HSCSD_multislot_class = 0 | Exist_GPRS_multislot_class = 1 | GPRS_multislot_class = 11 | GPRS_Extended_Dynamic_Allocation_Capability = 1 | Exist_SM = 1 | SMS_VALUE = 2 | SM_VALUE = 2 | Exist_ECSD_multislot_class = 0 | Exist_EGPRS_multislot_class = 1 | EGPRS_multislot_class = 11 | EGPRS_Extended_Dynamic_Allocation_Capability = 1 | Exist_DTM_GPRS_multislot_class = 0 | : End Multislot_capability | Exist_Eight_PSK_Power_Capability = 1 | Eight_PSK_Power_Capability = 2 | COMPACT_Interference_Measurement_Capability = 0 | Revision_Level_Indicator = 1 | UMTS_FDD_Radio_Access_Technology_Capability = 0 | UMTS_384_TDD_Radio_Access_Technology_Capability = 0 | CDMA2000_Radio_Access_Technology_Capability = 0 | UMTS_128_TDD_Radio_Access_Technology_Capability = NULL | GERAN_Feature_Package_1 = NULL | Modulation_based_multislot_class_support = NULL | GMSK_MultislotPowerProfile = NULL | EightPSK_MultislotProfile = NULL | MultipleTBF_Capability = NULL | DownlinkAdvancedReceiverPerformance = NULL | ExtendedRLC_MAC_ControlMessageSegmentionsCapability = NULL | DTM_EnhancementsCapability = NULL | PS_HandoverCapability = NULL | DTM_Handover_Capability = NULL | FlexibleTimeslotAssignment = NULL | GAN_PS_HandoverCapability = NULL | RLC_Non_persistentMode = NULL | ReducedLatencyCapability = NULL | UplinkEGPRS2 = NULL | DownlinkEGPRS2 = NULL | EUTRA_FDD_Support = NULL | EUTRA_TDD_Support = NULL | GERAN_To_EUTRAN_supportInGERAN_PTM = NULL | PriorityBasedReselectionSupport = NULL | MS_RA_capability_value } | : End MS_Radio_Access_capability2 | : Channel_Request_Description | PEAK_THROUGHPUT_CLASS = 9 | RADIO_PRIORITY = 0 | RLC_MODE = 0 | LLC_PDU_TYPE = 1 | RLC_OCTET_COUNT = 39 | : End Channel_Request_Description | Exist_CHANGE_MARK = 0 | C_VALUE = 19 | Exist_SIGN_VAR = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | Exist_AdditionsR99 = 1 | : AdditionsR99 | Exist_EGPRS_BEP_LinkQualityMeasurements = 0 | Exist_EGPRS_TimeslotLinkQualityMeasurements = 0 | Exist_PFI = 0 | MS_RAC_AdditionalInformationAvailable = 0 | RetransmissionOfPRR = 0 | Exist_AdditionsR5 = 1 | : AdditionsR5 | Exist_Iu_Mode_ChRequestDesk = 0 | Exist_HFN_LSB = 0 | Exist_AdditionsR6 = 1 | : AdditionsR6 | Exist_Ext_Channel_Request_desc = 0 | Exist_AdditionsR7 = 1 | : AdditionsR7 | EARLY_TBF_ESTABLISHMENT = 0 | Exist_EGPRS_BEP_LinkQualityMeasurements_type2 = 1 | : EGPRS_BEP_LinkQualityMeasurements_type2 | Exist_GMSK_MEAN_BEP = 1 | GMSK_MEAN_BEP = 5 | GMSK_CV_BEP = 3 | Exist_8PSK_MEAN_BEP = 0 | p8PSK_CV_BEP = 2 | Exist_QPSK_MEAN_BEP = 1 | DLCSN1 ERROR osmo_csn1_stream_decode: error NEED_MORE BITS TO UNPACK (-5) at QPSK_MEAN_BEP (idx 181): End EGPRS_BEP_LinkQualityMeasurements_type2 | : End AdditionsR7 | : End AdditionsR6 | : End AdditionsR5 | : End AdditionsR99 | +DLCSN1 INFO osmo_csn1_stream_decode (type: Pkt Resource Req (5)): PayloadType = 1 | spare = 0 | R = 0 | MESSAGE_TYPE = 5 | Exist_ACCESS_TYPE = 1 | ACCESS_TYPE = 3 | : ID | Choice PacketResourceRequestID = 1 | u.TLLI = 0x96cb3568 | : End ID | Exist_MS_Radio_Access_capability2 = 1 | : MS_Radio_Access_capability2 | MS_RA_capability_value { | Choice MS_RA_capability_value_Choice = 7 | u.Content length = 50 | offset = 1 | RF_Power_Capability = 4 | Exist_A5_bits = 1 | A5_bits = 80 | ES_IND = 1 | PS = 1 | VGCS = 0 | VBS = 0 | Exist_Multislot_capability = 1 | : Multislot_capability | Exist_HSCSD_multislot_class = 0 | Exist_GPRS_multislot_class = 1 | GPRS_multislot_class = 11 | GPRS_Extended_Dynamic_Allocation_Capability = 1 | Exist_SM = 1 | SMS_VALUE = 2 | SM_VALUE = 2 | Exist_ECSD_multislot_class = 0 | Exist_EGPRS_multislot_class = 1 | EGPRS_multislot_class = 11 | EGPRS_Extended_Dynamic_Allocation_Capability = 1 | Exist_DTM_GPRS_multislot_class = 0 | : End Multislot_capability | Exist_Eight_PSK_Power_Capability = 1 | Eight_PSK_Power_Capability = 2 | COMPACT_Interference_Measurement_Capability = 0 | Revision_Level_Indicator = 1 | UMTS_FDD_Radio_Access_Technology_Capability = 0 | UMTS_384_TDD_Radio_Access_Technology_Capability = 0 | CDMA2000_Radio_Access_Technology_Capability = 0 | UMTS_128_TDD_Radio_Access_Technology_Capability = NULL | GERAN_Feature_Package_1 = NULL | Modulation_based_multislot_class_support = NULL | GMSK_MultislotPowerProfile = NULL | EightPSK_MultislotProfile = NULL | MultipleTBF_Capability = NULL | DownlinkAdvancedReceiverPerformance = NULL | ExtendedRLC_MAC_ControlMessageSegmentionsCapability = NULL | DTM_EnhancementsCapability = NULL | PS_HandoverCapability = NULL | DTM_Handover_Capability = NULL | FlexibleTimeslotAssignment = NULL | GAN_PS_HandoverCapability = NULL | RLC_Non_persistentMode = NULL | ReducedLatencyCapability = NULL | UplinkEGPRS2 = NULL | DownlinkEGPRS2 = NULL | EUTRA_FDD_Support = NULL | EUTRA_TDD_Support = NULL | GERAN_To_EUTRAN_supportInGERAN_PTM = NULL | PriorityBasedReselectionSupport = NULL | MS_RA_capability_value } | : End MS_Radio_Access_capability2 | : Channel_Request_Description | PEAK_THROUGHPUT_CLASS = 9 | RADIO_PRIORITY = 0 | RLC_MODE = 0 | LLC_PDU_TYPE = 1 | RLC_OCTET_COUNT = 39 | : End Channel_Request_Description | Exist_CHANGE_MARK = 0 | C_VALUE = 19 | Exist_SIGN_VAR = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | I_LEVEL_TN | Exist = 0 | Exist_AdditionsR99 = 1 | : AdditionsR99 | Exist_EGPRS_BEP_LinkQualityMeasurements = 0 | Exist_EGPRS_TimeslotLinkQualityMeasurements = 0 | Exist_PFI = 0 | MS_RAC_AdditionalInformationAvailable = 0 | RetransmissionOfPRR = 0 | Exist_AdditionsR5 = 1 | : AdditionsR5 | Exist_Iu_Mode_ChRequestDesk = 0 | Exist_HFN_LSB = 0 | Exist_AdditionsR6 = 1 | : AdditionsR6 | Exist_Ext_Channel_Request_desc = 0 | Exist_AdditionsR7 = 1 | : AdditionsR7 | EARLY_TBF_ESTABLISHMENT = 0 | Exist_EGPRS_BEP_LinkQualityMeasurements_type2 = 1 | : EGPRS_BEP_LinkQualityMeasurements_type2 | Exist_GMSK_MEAN_BEP = 1 | GMSK_MEAN_BEP = 5 | GMSK_CV_BEP = 3 | Exist_8PSK_MEAN_BEP = 0 | Exist_QPSK_MEAN_BEP = 0 | Exist_16QAM_NSR_MEAN_BEP = 1 | p16QAM_NSR_MEAN_BEP = 11 | DLCSN1 ERROR osmo_csn1_stream_decode: error NEED_MORE BITS TO UNPACK (-5) at p16QAM_NSR_CV_BEP (idx 184): End EGPRS_BEP_LinkQualityMeasurements_type2 | : End AdditionsR7 | : End AdditionsR6 | : End AdditionsR5 | : End AdditionsR99 | DLCSN1 INFO osmo_csn1_stream_encode (type: Pkt Resource Req (5)): PayloadType = 1 | spare = 0 | R = 0 | MESSAGE_TYPE = 5 | Exist_ACCESS_TYPE = 1 | ACCESS_TYPE = 3 | : ID | u.TLLI = 1 | u.TLLI = 2529899880 | : End ID | Exist_MS_Radio_Access_capability2 = 1 | : MS_Radio_Access_capability2 | MS_RA_capability_value { | u.Content = 7 | RF_Power_Capability = 4 | Exist_A5_bits = 1 | A5_bits = 80 | ES_IND = 1 | PS = 1 | VGCS = 0 | VBS = 0 | Exist_Multislot_capability = 1 | : Multislot_capability | Exist_HSCSD_multislot_class = 0 | Exist_GPRS_multislot_class = 1 | GPRS_multislot_class = 11 | GPRS_Extended_Dynamic_Allocation_Capability = 1 | Exist_SM = 1 | SMS_VALUE = 2 | SM_VALUE = 2 | Exist_ECSD_multislot_class = 0 | Exist_EGPRS_multislot_class = 1 | EGPRS_multislot_class = 11 | EGPRS_Extended_Dynamic_Allocation_Capability = 1 | Exist_DTM_GPRS_multislot_class = 0 | : End Multislot_capability | Exist_Eight_PSK_Power_Capability = 1 | Eight_PSK_Power_Capability = 2 | COMPACT_Interference_Measurement_Capability = 0 | Revision_Level_Indicator = 1 | UMTS_FDD_Radio_Access_Technology_Capability = 0 | UMTS_384_TDD_Radio_Access_Technology_Capability = 0 | CDMA2000_Radio_Access_Technology_Capability = 0 | UMTS_128_TDD_Radio_Access_Technology_Capability = 0 | GERAN_Feature_Package_1 = 0 | Exist_Extended_DTM_multislot_class = 0 | Modulation_based_multislot_class_support = 0 | Exist_HighMultislotCapability = 0 | Exist_GERAN_lu_ModeCapability = 0 | GMSK_MultislotPowerProfile = 0 | EightPSK_MultislotProfile = 0 | MultipleTBF_Capability = 0 | DownlinkAdvancedReceiverPerformance = 0 | ExtendedRLC_MAC_ControlMessageSegmentionsCapability = 0 | DTM_EnhancementsCapability = 0 | Exist_DTM_GPRS_HighMultislotClass = 0 | PS_HandoverCapability = 0 | DTM_Handover_Capability = 0 | Exist_DownlinkDualCarrierCapability_r7 = 0 | FlexibleTimeslotAssignment = 0 | GAN_PS_HandoverCapability = 0 | RLC_Non_persistentMode = 0 | ReducedLatencyCapability = 0 | UplinkEGPRS2 = 0 | DownlinkEGPRS2 = 0 | EUTRA_FDD_Support = 0 | EUTRA_TDD_Support = 0 | GERAN_To_EUTRAN_supportInGERAN_PTM = 0 | PriorityBasedReselectionSupport = 0 | u.Content length = 82 | MS_RA_capability_value } | : End MS_Radio_Access_capability2 | : Channel_Request_Description | PEAK_THROUGHPUT_CLASS = 9 | RADIO_PRIORITY = 0 | RLC_MODE = 0 | LLC_PDU_TYPE = 1 | RLC_OCTET_COUNT = 39 | : End Channel_Request_Description | Exist_CHANGE_MARK = 0 | C_VALUE = 19 | Exist_SIGN_VAR = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | I_LEVEL_TN : | Exist = 0 | DLCSN1 ERROR osmo_csn1_stream_encode: error NEED_MORE BITS TO UNPACK (-5) at (idx 184) DLGLOBAL ERROR Failed to encode an Uplink block: not enough bits in the output buffer (rc=-5) DLCSN1 INFO osmo_csn1_stream_decode (type: EGPRS Pkt DL ACK/NACK (8)): PayloadType = 1 | spare = 0 | R = 0 | MESSAGE_TYPE = 8 | DOWNLINK_TFI = 0 | MS_OUT_OF_MEMORY = 0 | Exist_EGPRS_ChannelQualityReport = 1 | : EGPRS_ChannelQualityReport | : EGPRS_BEP_LinkQualityMeasurements | Exist_MEAN_CV_BEP_GMSK = 0 | Exist_MEAN_CV_BEP_8PSK = 1 | MEAN_BEP_8PSK = 31 | CV_BEP_8PSK = 7 | : End EGPRS_BEP_LinkQualityMeasurements | C_VALUE = 58 | : EGPRS_TimeslotLinkQualityMeasurements | Exist_BEP_MEASUREMENTS = 0 | Exist_INTERFERENCE_MEASUREMENTS = 0 | : End EGPRS_TimeslotLinkQualityMeasurements | : End EGPRS_ChannelQualityReport | Exist_ChannelRequestDescription = 1 | : ChannelRequestDescription | PEAK_THROUGHPUT_CLASS = 6 | RADIO_PRIORITY = 0 | RLC_MODE = 0 | LLC_PDU_TYPE = 1 | RLC_OCTET_COUNT = 62 | : End ChannelRequestDescription | Exist_PFI = 0 | Exist_ExtensionBits = 0 | : EGPRS_AckNack | Desc = 0 | : Desc | FINAL_ACK_INDICATION = 0 | BEGINNING_OF_WINDOW = 1 | END_OF_WINDOW = 1 | STARTING_SEQUENCE_NUMBER = 1187 | Exist_CRBB = 0 | URBB = 127 | URBB = 255 | URBB = 255 | URBB = 238 | URBB = 0 | URBB = 0 | URBB = 0 | URBB = 0 | URBB = 0 | URBB = 0 | URBB = 0 | URBB = 0 | URBB = 0 | : End Desc | : End EGPRS_AckNack | Padding = -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/39187?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iac4de18ef25386f774bb409201b7a7996d1c8824 Gerrit-Change-Number: 39187 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: fix EGPRS BEP Link Quality Measurements Type 2

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/39187?usp=email ) Change subject: rlcmac: fix EGPRS BEP Link Quality Measurements Type 2 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/39187?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iac4de18ef25386f774bb409201b7a7996d1c8824 Gerrit-Change-Number: 39187 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 16:53:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 1 week

1
0
0 0

[L] Change in osmo-mgw[master]: mgw: CRCX: Split mgcp header pars parsing into a previous step

by neels

Attention is currently required from: laforge, pespin. neels has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39224?usp=email ) Change subject: mgw: CRCX: Split mgcp header pars parsing into a previous step ...................................................................... Patch Set 4: (23 comments) Patchset: PS4: I really love this patch! it feels like seeing your bicycle cleaned and repaired, and the weird noises are gone. (...except for dropping the logging context part, that feels a bit like removing the headlight =) File include/osmocom/mgcp/mgcp_protocol.h: https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/08e29747_e07c1c09?usp… : PS4, Line 7: #define MGCP_PARSE_HDR_PARS_OSMUX_CID_WILDCARD (-1) (IMHO enums are favorable to #defines) https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/8ad663e1_faf98080?usp… : PS4, Line 14: bool have_sdp; (i'd have called it 'sdp_present' -- 'have' sounds to me like requesting to generate something, not like indicating a parsing result. i see the name comes from a local var. AFAICT foo_present is the usual naming convention in osmocom... or might be just wishful thinking.) https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/c0b99a6b_f6438f90?usp… : PS4, Line 27: .x_osmo_ign = 0, (the " = 0" values are also there implicitly, so it could be just the two .mode and .remote_osmux_cid lines) https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/7fa32c0e_7e294259?usp… : PS4, Line 34: char *save; (naming: every struct member saves values -- so save what? maybe mgcp_msg_str?) https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/7f900303_e051ed9c?usp… : PS4, Line 38: /* MGCP Body: */ naming: the "body" in MGCP is the SDP message string starting with a blank line, so "MGCP Body: mgcp_header_pars" is a logical conflict File src/libosmo-mgcp/mgcp_msg.c: https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/31ab0de5_26e5bb52?usp… : PS4, Line 168: } (is this function 1:1 unchanged? if the function had not moved, it would be trivially visible from the diff; forward declarations help, or a separate patch for moving first) EDIT: it is not 1:1 unchanged. it drops logging context; commented on that in deail further below. https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/3b355116_43719194?usp… : PS4, Line 170: ha haders gonna hade https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/4498f117_736d11f7?usp… : PS4, Line 170: ea messeage https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/7496fb67_ffd305c0?usp… : PS4, Line 173: int mgcp_parse_hdr_pars(struct mgcp_parse_data *pdata) this is not public API, right? so i don't need to ask of you an opaque allocator function or future-proof structs, right. i'm asking because it's in libosmo-mgcp -- but that isn't installed, correct? https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/88769a89_6bb45204?usp… : PS4, Line 179: /* parse CallID C: and LocalParameters L: */ (i guess this comment can go, no useful information conveyed and not even accurate.) https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/f0da502d_e3822f1a?usp… : PS4, Line 180: e( (i think the linter now usually asks for a space when it is a for-loop style macro and not a function call, i mean "for_each_line (bla)"; i only recently adopted that space into my coding style, imho it's a sane convention.) https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/2185e18c_006e352c?usp… : PS4, Line 208: case '\0': (hmm i thought it was '\n\n' or '\r\n\r\n' delimiting the SDP body ... ah right, we pre-parse that and overwrite with '\0'? anyway, it's from before this patch.) https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/33d1333a_9b058023?usp… : PS4, Line 210: goto mgcp_header_done; 'return 0;' https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/654c4891_061274ff?usp… : PS4, Line 212: LOGP(DLMGCP, LOGL_NOTICE, "CRCX: unhandled option: '%c'/%d\n", *line, *line); (technically the caller should log instead of this function, based on the returned 539) https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/dd2467a1_da56e762?usp… : PS4, Line 218: return 0; have i ever seen a useless label =) https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/bd653b5d_b369ab6f?usp… : PS4, Line 257: LOGP(DLMGCP, LOGL_NOTICE, "wrong MGCP option format: '%s'\n", line); context-less logging is so 2009 patch removes the logging context: endp / trunk. it's of course always a pain to add logging context crossing layers, thinking of error_callback functions or a string returned or somesuch... i feel the reasons (what does MGCP parsing code care where the data fell out), but it would be very nice, in principle from API design, to allow logging context on MGCP parsing results -- rather adding more ctx than dropping existing ctx. this aspect is fairly important to me, it impacts sysadmin operations and basic usability of osmo-mgw in presence of errors. File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/e3a27bd3_cbe1df1f?usp… : PS4, Line 710: if (osmux_init(trunk) < 0) { drops logging context: endp reduced to just trunk. makes sense from POV that this setup is done once per trunk. but it is also nice to know which subscriber / which endp caused it. (otherwise i would favor adding the LOGP into osmux_init() itself / have a osmux_init_if_needed() in the main API.) https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/1af60a1c_de00feaf?usp… : PS4, Line 846: case -523: (i humbly favor passing the MGCP result codes as positive numbers, more like a result code enum, and less like -errno "nonsense". After all they are 1:1 sent out on the wire, and there seems no good reason for passing them negative?) https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/3803b41b_59321197?usp… : PS4, Line 853: return create_err_response(rq->trunk, NULL, -rc, "CRCX", pdata->trans); (hmm, no counter for this error path, probably an oversight by whichever patch added the counters. that's cool about this patch: now this omission shows clear as day, and was not readily visible in the earlier code) https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/93487c11_6d9bb1a5?usp… : PS4, Line 873: hpars->remote_osmux_cid = MGCP_PARSE_HDR_PARS_OSMUX_CID_UNSET; what i don't like here semantically: hpars is the pristine result of parsing some received PDU and should be immutable. By modifying it here, it is tainted. The flag to skip osmux when it is not enabled should live outside of the parsing result; so that in hypothetical logging and future vty dump code, we can still see that the peer did actually ask for osmux, and did not get it for other reasons. https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/12d1d027_a2e0a2da?usp… : PS4, Line 898: /* Update endp->x_osmo_ign: */ (lol funny comment) https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/e1609b96_e3f3b72f?usp… : PS4, Line 899: endp->x_osmo_ign |= hpars->x_osmo_ign; are you sure about `|=` instead of `=`??? how does one disable an X-Osmo-Ign once it is enabled? impossible? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3ee5158c254213203830fe9c38de11c15b4b19c1 Gerrit-Change-Number: 39224 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 16:52:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

5 months, 1 week

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: fix EGPRS BEP Link Quality Measurements Type 2

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/39187?usp=email ) Change subject: rlcmac: fix EGPRS BEP Link Quality Measurements Type 2 ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-gprs/+/39187/comment/e5d66923_661e0e7b… : PS1, Line 9: is IE is defined in 3GPP TS 44.060 Table 12.5a.2.1. > might manke sense to add the spec reference directly above the struct definition? Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/39187?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iac4de18ef25386f774bb409201b7a7996d1c8824 Gerrit-Change-Number: 39187 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 16:51:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

5 months, 1 week

1
0
0 0

[S] Change in osmo-pcu[master]: gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2

by fixeria

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/39188?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2 ...................................................................... gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2 This IE is defined in 3GPP TS 44.060 Table 12.5a.2.1. Each presence bit indicates presence of the next two entries, not one. This patch does affect the output of csn1_ts_44_060_test, though it does not fix decoding because it's caused by an unrelated problem. Related: libosmo-gprs.git Iac4de18ef25386f774bb409201b7a7996d1c8824 Change-Id: I061ac16df5e6413266de08884f791f0264791192 --- M src/gsm_rlcmac.c M tests/rlcmac/RLCMACTest.err 2 files changed, 10 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/88/39188/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I061ac16df5e6413266de08884f791f0264791192 Gerrit-Change-Number: 39188 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: fix EGPRS BEP Link Quality Measurements Type 2

by fixeria

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/39187?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: rlcmac: fix EGPRS BEP Link Quality Measurements Type 2 ...................................................................... rlcmac: fix EGPRS BEP Link Quality Measurements Type 2 This IE is defined in 3GPP TS 44.060 Table 12.5a.2.1. Each presence bit indicates presence of the next two entries, not one. This patch does affect the output of csn1_ts_44_060_test, though it does not fix decoding because it's caused by an unrelated problem. Related: osmo-pcu.git I061ac16df5e6413266de08884f791f0264791192 Change-Id: Iac4de18ef25386f774bb409201b7a7996d1c8824 --- M src/rlcmac/csn1_ts_44_060.c M tests/rlcmac/csn1_ts_44_060_test.err 2 files changed, 9 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/87/39187/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/39187?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Iac4de18ef25386f774bb409201b7a7996d1c8824 Gerrit-Change-Number: 39187 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[XS] Change in osmocom-bb[master]: trx_toolkit/clck_gen: Fix DeprecationWarning about Thread.setDaemon

by kirr

kirr has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39344?usp=email ) Change subject: trx_toolkit/clck_gen: Fix DeprecationWarning about Thread.setDaemon ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Thanks -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39344?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6ef70762f671b86342daa35a097532f0b620aaca Gerrit-Change-Number: 39344 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 16:44:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

5 months, 1 week

1
0
0 0

[M] Change in libosmo-netif[master]: stream: Introduce osmo_stream_{cli,srv}_set_segmentation_cb2

by fixeria

Attention is currently required from: daniel, laforge, neels, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39316?usp=email ) Change subject: stream: Introduce osmo_stream_{cli,srv}_set_segmentation_cb2 ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS1: > Please explain in COMMIT_MSG why you're adding this API. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39316?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I6e8dd6ece13397074075f05a1a0a8dbdd80d8848 Gerrit-Change-Number: 39316 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 16:42:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

[XS] Change in osmocom-bb[master]: trx_toolkit/clck_gen: Fix DeprecationWarning about Thread.setDaemon

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/39344?usp=email ) Change subject: trx_toolkit/clck_gen: Fix DeprecationWarning about Thread.setDaemon ...................................................................... trx_toolkit/clck_gen: Fix DeprecationWarning about Thread.setDaemon This warning is currently emitted each time trx_toolkit unittests are run: (osmo.venv) kirr@deca:~/src/osmocom/bb/src/target/trx_toolkit$ python -m unittest discover /home/kirr/src/osmocom/bb/src/target/trx_toolkit/clck_gen.py:71: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead self._thread.setDaemon(True) ............................................... ---------------------------------------------------------------------- Ran 47 tests in 0.997s OK -> Fix it by using Thread.daemon attribute directly as suggested by https://docs.python.org/3/library/threading.html#threading.Thread.setDaemon Change-Id: I6ef70762f671b86342daa35a097532f0b620aaca --- M src/target/trx_toolkit/clck_gen.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/src/target/trx_toolkit/clck_gen.py b/src/target/trx_toolkit/clck_gen.py index 15b653f..bf56f64 100755 --- a/src/target/trx_toolkit/clck_gen.py +++ b/src/target/trx_toolkit/clck_gen.py @@ -68,7 +68,7 @@ # Initialize and start a new thread self._thread = threading.Thread(target = self._worker) - self._thread.setDaemon(True) + self._thread.daemon = True self._thread.start() def stop(self): -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/39344?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6ef70762f671b86342daa35a097532f0b620aaca Gerrit-Change-Number: 39344 Gerrit-PatchSet: 1 Gerrit-Owner: kirr <kirr(a)nexedi.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 1 week

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025