January 2025 - gerrit-log - lists.osmocom.org

[S] Change in osmo-mgw[master]: mgw: mgcp_network.c: Simplify use of conn_rtp ptr

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39185?usp=email ) Change subject: mgw: mgcp_network.c: Simplify use of conn_rtp ptr ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39185?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I5bab15fc793434173660769a8e60dae4ae4aa4c6 Gerrit-Change-Number: 39185 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Jan 2025 19:35:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 3 weeks

1
0
0 0

[M] Change in osmo-mgw[master]: mgw: Rename and move code freeing endp connection

by daniel

Attention is currently required from: fixeria, pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39183?usp=email ) Change subject: mgw: Rename and move code freeing endp connection ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: TODO-RELEASE? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39183?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I9a87a07699dd8aa7856d5036e9b95a4ddf699a15 Gerrit-Change-Number: 39183 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Jan 2025 19:34:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months, 3 weeks

1
0
0 0

[M] Change in osmo-mgw[master]: mgw: Rename and move several get_conn funcs acting on endp object

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39184?usp=email ) Change subject: mgw: Rename and move several get_conn funcs acting on endp object ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Does that need an entry in TODO-RELEASE? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39184?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifff01331db68998e9e23f99d8836d96022d550c2 Gerrit-Change-Number: 39184 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Jan 2025 19:32:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months, 3 weeks

1
0
0 0

[M] Change in osmo-mgw[master]: mgw: Clean up access to conn_rtp from conn

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39186?usp=email ) Change subject: mgw: Clean up access to conn_rtp from conn ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39186?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iee2c19598e9570ea3b1ceba3cdfd2a5f5be2c954 Gerrit-Change-Number: 39186 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Jan 2025 19:27:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 3 weeks

1
0
0 0

[M] Change in ...pyosmocom[master]: construct: allow stripping of leading zeros with StripHeaderAdapter

by dexter

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39193?usp=email to look at the new patch set (#4). Change subject: construct: allow stripping of leading zeros with StripHeaderAdapter ...................................................................... construct: allow stripping of leading zeros with StripHeaderAdapter This patch adds a new class StripHeaderAdapter. This adapter class can be used to strip leading zeros in the same way that StripTrailerAdapter strips trailing zeros. Related: OS#6679 Change-Id: I1a9fff17abbbef0c5f6d45f58198debfa12e78b6 --- M src/osmocom/construct.py M tests/test_construct.py 2 files changed, 89 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/93/39193/4 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I1a9fff17abbbef0c5f6d45f58198debfa12e78b6 Gerrit-Change-Number: 39193 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

5 months, 3 weeks

1
0
0 0

[M] Change in ...pyosmocom[master]: construct: allow stripping of leading zeros with StripTrailerAdapter

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39193?usp=email ) Change subject: construct: allow stripping of leading zeros with StripTrailerAdapter ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > please implement this as a new adapter. […] I had that in mind too, but I wasn't sure if this would create too much code dup. I have added StripHeaderAdapter now. However, I am not sure about how much code we could really put into a base class. As far as I can see only the constructor could be shared. The majority of the code is very similar, but it is different. I think we should keep it like that. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I1a9fff17abbbef0c5f6d45f58198debfa12e78b6 Gerrit-Change-Number: 39193 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 02 Jan 2025 13:16:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

5 months, 3 weeks

1
0
0 0

[M] Change in ...pyosmocom[master]: construct: allow stripping of leading zeros with StripTrailerAdapter

by dexter

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39193?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review-1 by laforge, Verified+1 by Jenkins Builder Change subject: construct: allow stripping of leading zeros with StripTrailerAdapter ...................................................................... construct: allow stripping of leading zeros with StripTrailerAdapter The class StripTrailerAdapter is currently only able to strip zeros at the end of an integer. What it can not do is stripping leading zeros. Let's add a parameter for that and extend the unittests accordingly. Related: OS#6679 Change-Id: I1a9fff17abbbef0c5f6d45f58198debfa12e78b6 --- M src/osmocom/construct.py M tests/test_construct.py 2 files changed, 89 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/pyosmocom refs/changes/93/39193/3 -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I1a9fff17abbbef0c5f6d45f58198debfa12e78b6 Gerrit-Change-Number: 39193 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

5 months, 3 weeks

1
0
0 0

[XS] Change in pysim[master]: global_platform: add spec reference to help of --install-parameters

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/39197?usp=email ) Change subject: global_platform: add spec reference to help of --install-parameters ...................................................................... global_platform: add spec reference to help of --install-parameters Related: OS#6679 Change-Id: I7e8174d469e09ad130d2866663a65bdeb4afc35a --- M pySim/global_platform/__init__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/global_platform/__init__.py b/pySim/global_platform/__init__.py index 043a86a..c0607ae 100644 --- a/pySim/global_platform/__init__.py +++ b/pySim/global_platform/__init__.py @@ -724,7 +724,7 @@ inst_inst_parser.add_argument('--application-aid', type=is_hexstr, required=True, help='Application AID') inst_inst_parser.add_argument('--install-parameters', type=is_hexstr, default='', - help='Install Parameters') + help='Install Parameters (GPC_SPE_034, section 11.5.2.3.7, table 11-49)') inst_inst_parser.add_argument('--privilege', action='append', dest='privileges', default=[], choices=list(Privileges._construct.flags.keys()), help='Privilege granted to newly installed Application') -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7e8174d469e09ad130d2866663a65bdeb4afc35a Gerrit-Change-Number: 39197 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

5 months, 3 weeks

1
0
0 0

[XS] Change in pysim[master]: global_platform: fix command "delete"

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/39196?usp=email ) Change subject: global_platform: fix command "delete" ...................................................................... global_platform: fix command "delete" The delete command formats a TPDU, not APDU, which leads to warning messages Related: OS#6679 Change-Id: Id04c89acbd4f449cb974d3cb05024f11dba4684e --- M pySim/global_platform/__init__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/global_platform/__init__.py b/pySim/global_platform/__init__.py index 28cc01e..043a86a 100644 --- a/pySim/global_platform/__init__.py +++ b/pySim/global_platform/__init__.py @@ -791,7 +791,7 @@ self.delete(0x00, p2, cmd) def delete(self, p1:int, p2:int, data:Hexstr) -> ResTuple: - cmd_hex = "80E4%02x%02x%02x%s" % (p1, p2, len(data)//2, data) + cmd_hex = "80E4%02x%02x%02x%s00" % (p1, p2, len(data)//2, data) return self._cmd.lchan.scc.send_apdu_checksw(cmd_hex) est_scp02_parser = argparse.ArgumentParser() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39196?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id04c89acbd4f449cb974d3cb05024f11dba4684e Gerrit-Change-Number: 39196 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

5 months, 3 weeks

1
0
0 0

[XS] Change in pysim[master]: global_platform: remove unused code

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/39195?usp=email ) Change subject: global_platform: remove unused code ...................................................................... global_platform: remove unused code This commented out part is not needed anymore. Related: OS#6679 Change-Id: If1de0218f841159789ac86f6a13740c1cbd0a57a --- M pySim/global_platform/__init__.py 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/global_platform/__init__.py b/pySim/global_platform/__init__.py index fddab4e..28cc01e 100644 --- a/pySim/global_platform/__init__.py +++ b/pySim/global_platform/__init__.py @@ -897,13 +897,6 @@ super().__init__(aid=aid, name='ADF.ISD', desc='Issuer Security Domain') self.adf.scp_key_identity = 'ICCID' -#class CardProfileGlobalPlatform(CardProfile): -# ORDER = 23 -# -# def __init__(self, name='GlobalPlatform'): -# super().__init__(name, desc='GlobalPlatfomr 2.1.1', cla=['00','80','84'], sw=sw_table) - - class GpCardKeyset: """A single set of GlobalPlatform card keys and the associated KVN.""" def __init__(self, kvn: int, enc: bytes, mac: bytes, dek: bytes): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39195?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If1de0218f841159789ac86f6a13740c1cbd0a57a Gerrit-Change-Number: 39195 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

5 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025