January 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-mgw[master]: mgw: Use bool instead of int in local var

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39211?usp=email ) Change subject: mgw: Use bool instead of int in local var ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39211?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie46cb2909da2ec4279e1029cfaf7747c45f84b13 Gerrit-Change-Number: 39211 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Jan 2025 20:11:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 3 weeks

1
0
0 0

[XS] Change in osmo-mgw[master]: mgw: Avoid 2nd lookup of conn in endp during CRCX

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39208?usp=email ) Change subject: mgw: Avoid 2nd lookup of conn in endp during CRCX ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: NM, I just saw you did the rename already in another change File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/39208/comment/041b27c5_8673219a?usp… : PS1, Line 1025: conn = mgcp_conn_get_conn_rtp(_conn); > It's not really clear from reading what conn and _conn are, renaming conn to rtp{,_}conn would help. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39208?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8316e76a1789d4a8eaa1eb89bdaf86e25dc0a1e8 Gerrit-Change-Number: 39208 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Jan 2025 20:09:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>

5 months, 3 weeks

1
0
0 0

[M] Change in osmo-mgw[master]: mgw: CRCXMDCX/DLCX: rename conn and conn_rtp variables

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39210?usp=email ) Change subject: mgw: CRCXMDCX/DLCX: rename conn and conn_rtp variables ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39210?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I75ba9969af53d3e386c4070eb15de27e7378bfdc Gerrit-Change-Number: 39210 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Jan 2025 20:09:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 3 weeks

1
0
0 0

[XS] Change in osmo-mgw[master]: cosmetic: mgw: iuup: Update comment

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39204?usp=email ) Change subject: cosmetic: mgw: iuup: Update comment ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39204?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6e1448bf7e3bb7454754147e2b2e01844c157500 Gerrit-Change-Number: 39204 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Jan 2025 20:07:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 3 weeks

1
0
0 0

[XS] Change in osmo-mgw[master]: mgw: Avoid 2nd lookup of conn in endp during CRCX

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39208?usp=email ) Change subject: mgw: Avoid 2nd lookup of conn in endp during CRCX ...................................................................... Patch Set 1: (1 comment) File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/39208/comment/62286bf7_57432330?usp… : PS1, Line 1025: conn = mgcp_conn_get_conn_rtp(_conn); It's not really clear from reading what conn and _conn are, renaming conn to rtp{,_}conn would help. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39208?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8316e76a1789d4a8eaa1eb89bdaf86e25dc0a1e8 Gerrit-Change-Number: 39208 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Jan 2025 20:05:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

5 months, 3 weeks

1
0
0 0

[XS] Change in osmo-mgw[master]: mgw: constify mgcp_endp_avail() param

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39205?usp=email ) Change subject: mgw: constify mgcp_endp_avail() param ...................................................................... Patch Set 2: (1 comment) File src/libosmo-mgcp/mgcp_endp.c: https://gerrit.osmocom.org/c/osmo-mgw/+/39205/comment/27a5e8ee_c6b081c1?usp… : PS2, Line 525: epname_check = gen_e1_epname(NULL, endp->trunk->cfg->domain, `talloc_asprintf()` takes a `const void *` as first argument so instead change the signature of `gen_e1_epname()` to accept one as well. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31ed2f3abbcf024ee44f62e130dd4ec01611ae97 Gerrit-Change-Number: 39205 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Jan 2025 20:00:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

5 months, 3 weeks

1
0
0 0

[M] Change in osmo-mgw[master]: mgw: Rename and move code freeing endp connection

by pespin

Attention is currently required from: daniel, fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39183?usp=email ) Change subject: mgw: Rename and move code freeing endp connection ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > TODO-RELEASE? This is for osmo-mgw, not libosmo-mgcp-client, so no, not needed. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39183?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I9a87a07699dd8aa7856d5036e9b95a4ddf699a15 Gerrit-Change-Number: 39183 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Jan 2025 19:56:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>

5 months, 3 weeks

1
0
0 0

[M] Change in osmo-mgw[master]: mgw: Rename and move several get_conn funcs acting on endp object

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39184?usp=email ) Change subject: mgw: Rename and move several get_conn funcs acting on endp object ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Does that need an entry in TODO-RELEASE? This is for osmo-mgw, not libosmo-mgcp-client, so no, not needed. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39184?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifff01331db68998e9e23f99d8836d96022d550c2 Gerrit-Change-Number: 39184 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Jan 2025 19:56:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>

5 months, 3 weeks

1
0
0 0

[XS] Change in osmo-mgw[master]: mgw: mgcp_protocol: assert freeing last conn allows creating new conn

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39207?usp=email ) Change subject: mgw: mgcp_protocol: assert freeing last conn allows creating new conn ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39207?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib8c9089a7f04bc67e5bdfb1148cfc603f0e17bb7 Gerrit-Change-Number: 39207 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Jan 2025 19:54:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 3 weeks

1
0
0 0

[S] Change in osmo-mgw[master]: mgcp_endp: Add helpers accessing endp connections

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39206?usp=email ) Change subject: mgcp_endp: Add helpers accessing endp connections ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39206?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I77c298abf0a1488b91f58c9e76507ef8add0168e Gerrit-Change-Number: 39206 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 02 Jan 2025 19:45:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025