January 2025 - gerrit-log - lists.osmocom.org

[M] Change in ...pyosmocom[master]: construct: allow stripping of leading zeros with StripHeaderAdapter

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39193?usp=email ) Change subject: construct: allow stripping of leading zeros with StripHeaderAdapter ...................................................................... Patch Set 5: (1 comment) File src/osmocom/construct.py: https://gerrit.osmocom.org/c/python/pyosmocom/+/39193/comment/b2c0393c_a9f4… : PS4, Line 466: :[ > are you sure about that "[int]" sytntax? We usually use List[int] so far, following "from typing im […] I was thinking that this were correct, but I am not so sure about this anymore. I can not find any reference that would confirm if it is correct, so its probably wrong. (I wonder why the linter didn't complain) In this module we have only import typing, and we use typing.Xyz, so I have changed it to that style. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I1a9fff17abbbef0c5f6d45f58198debfa12e78b6 Gerrit-Change-Number: 39193 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 03 Jan 2025 16:54:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

5 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: mgw: Improve log and teardown upon unexpected mgcp resp received

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39219?usp=email ) Change subject: mgw: Improve log and teardown upon unexpected mgcp resp received ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I233075f5a88ed7f1f7de496664cdc7281aefa900 Gerrit-Change-Number: 39219 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 03 Jan 2025 15:13:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 3 weeks

1
0
0 0

[M] Change in osmo-mgw[master]: Rename and cleanup code allocating rtp/rtcp ports in trunk

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39223?usp=email ) Change subject: Rename and cleanup code allocating rtp/rtcp ports in trunk ...................................................................... Patch Set 1: (1 comment) File src/libosmo-mgcp/mgcp_trunk.c: https://gerrit.osmocom.org/c/osmo-mgw/+/39223/comment/b2d17e3d_247878a8?usp… : PS1, Line 315: conn On second look this could also be named conn_rtp -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39223?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib894afcb61609c247883d5ccdd7b8fbf29b2cbf8 Gerrit-Change-Number: 39223 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 03 Jan 2025 15:11:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

5 months, 3 weeks

1
0
0 0

[M] Change in osmo-mgw[master]: Rename and cleanup code allocating rtp/rtcp ports in trunk

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39223?usp=email ) Change subject: Rename and cleanup code allocating rtp/rtcp ports in trunk ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39223?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib894afcb61609c247883d5ccdd7b8fbf29b2cbf8 Gerrit-Change-Number: 39223 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 03 Jan 2025 15:07:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 3 weeks

1
0
0 0

[L] Change in osmo-mgw[master]: mgw: CRCX: Split mgcp header pars parsing into a previous step

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39224?usp=email ) Change subject: mgw: CRCX: Split mgcp header pars parsing into a previous step ...................................................................... Patch Set 1: (3 comments) File include/osmocom/mgcp/mgcp_msg.h: https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/fb710223_63ae146a?usp… : PS1, Line 29: #include <ctype.h> Seems unnecessary here File include/osmocom/mgcp/mgcp_protocol.h: https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/3491d1ca_95d5be6f?usp… : PS1, Line 31: //struct mgcp_parsed_body { : //}; Remove File src/libosmo-mgcp/mgcp_msg.c: https://gerrit.osmocom.org/c/osmo-mgw/+/39224/comment/9c273cb9_d00ac27f?usp… : PS1, Line 176: * \param[in] endp pointer to endpoint (only used for log output, may be NULL) I don't know if these helped debug issues in the past, but this change also makes the log messages a little less informative -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I3ee5158c254213203830fe9c38de11c15b4b19c1 Gerrit-Change-Number: 39224 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 03 Jan 2025 15:05:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

5 months, 3 weeks

1
0
0 0

[M] Change in osmo-mgw[master]: mgw: Rename and move code freeing endp connection

by laforge

Attention is currently required from: daniel, fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39183?usp=email ) Change subject: mgw: Rename and move code freeing endp connection ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39183?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I9a87a07699dd8aa7856d5036e9b95a4ddf699a15 Gerrit-Change-Number: 39183 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 03 Jan 2025 11:17:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 3 weeks

1
0
0 0

[M] Change in ...pyosmocom[master]: construct: allow stripping of leading zeros with StripHeaderAdapter

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39193?usp=email ) Change subject: construct: allow stripping of leading zeros with StripHeaderAdapter ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/osmocom/construct.py: https://gerrit.osmocom.org/c/python/pyosmocom/+/39193/comment/a7ecfa0f_8869… : PS4, Line 466: :[ are you sure about that "[int]" sytntax? We usually use List[int] so far, following "from typing import List" -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39193?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I1a9fff17abbbef0c5f6d45f58198debfa12e78b6 Gerrit-Change-Number: 39193 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 03 Jan 2025 11:17:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

5 months, 3 weeks

1
0
0 0

[XS] Change in osmo-pcu[master]: Add .checkpatch.conf, ignore src/gsm_rlcmac.c

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/39202?usp=email ) Change subject: Add .checkpatch.conf, ignore src/gsm_rlcmac.c ...................................................................... Add .checkpatch.conf, ignore src/gsm_rlcmac.c This file comes from wireshark (originally from Ericsson) and does not follow the kernel coding style - ignore it. Change-Id: I91e05f9742aaac6ec61a1668ce3b63e8da52032d --- A .checkpatch.conf 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/.checkpatch.conf b/.checkpatch.conf new file mode 100644 index 0000000..d808861 --- /dev/null +++ b/.checkpatch.conf @@ -0,0 +1 @@ +--exclude ^src/gsm_rlcmac.c$ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39202?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I91e05f9742aaac6ec61a1668ce3b63e8da52032d Gerrit-Change-Number: 39202 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 3 weeks

1
0
0 0

[S] Change in osmo-pcu[master]: gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcu/+/39188?usp=email ) Change subject: gsm_rlcmac: fix EGPRS BEP Link Quality Measurements Type 2 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39188?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I061ac16df5e6413266de08884f791f0264791192 Gerrit-Change-Number: 39188 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 03 Jan 2025 11:14:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 3 weeks

1
0
0 0

[XS] Change in osmo-pcu[master]: Add .checkpatch.conf, ignore src/gsm_rlcmac.c

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcu/+/39202?usp=email ) Change subject: Add .checkpatch.conf, ignore src/gsm_rlcmac.c ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/39202?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I91e05f9742aaac6ec61a1668ce3b63e8da52032d Gerrit-Change-Number: 39202 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 03 Jan 2025 11:14:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025