January 2025 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-mgw[master]: mgw: constify mgcp_endp_avail() param

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39205?usp=email ) Change subject: mgw: constify mgcp_endp_avail() param ...................................................................... mgw: constify mgcp_endp_avail() param Change-Id: I31ed2f3abbcf024ee44f62e130dd4ec01611ae97 --- M include/osmocom/mgcp/mgcp_endp.h M src/libosmo-mgcp/mgcp_endp.c 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: daniel: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/mgcp/mgcp_endp.h b/include/osmocom/mgcp/mgcp_endp.h index 4f41818..5ecebda 100644 --- a/include/osmocom/mgcp/mgcp_endp.h +++ b/include/osmocom/mgcp/mgcp_endp.h @@ -138,7 +138,7 @@ const struct mgcp_trunk *trunk); struct mgcp_endpoint *mgcp_endp_by_name(int *cause, const char *epname, struct mgcp_config *cfg); -bool mgcp_endp_avail(struct mgcp_endpoint *endp); +bool mgcp_endp_avail(const struct mgcp_endpoint *endp); void mgcp_endp_add_conn(struct mgcp_endpoint *endp, struct mgcp_conn *conn); void mgcp_endp_remove_conn(struct mgcp_endpoint *endp, struct mgcp_conn *conn); void mgcp_endp_free_conn_oldest(struct mgcp_endpoint *endp); diff --git a/src/libosmo-mgcp/mgcp_endp.c b/src/libosmo-mgcp/mgcp_endp.c index c91a00d..21df0a3 100644 --- a/src/libosmo-mgcp/mgcp_endp.c +++ b/src/libosmo-mgcp/mgcp_endp.c @@ -58,7 +58,7 @@ } /* Generate E1 endpoint name from given numeric parameters */ -static char *gen_e1_epname(void *ctx, const char *domain, unsigned int trunk_nr, +static char *gen_e1_epname(const void *ctx, const char *domain, unsigned int trunk_nr, uint8_t ts_nr, uint8_t ss_nr) { unsigned int rate; @@ -446,7 +446,7 @@ /* Check if the selected E1 endpoint is avalable, which means that none of * the overlapping endpoints are currently serving a call. (if the system * is properly configured such a situation should never ocurr!) */ -static bool endp_avail_e1(struct mgcp_endpoint *endp) +static bool endp_avail_e1(const struct mgcp_endpoint *endp) { /* The following map shows the overlapping of the subslots and their * respective rates. The numbers on the right running from top to bottom @@ -552,7 +552,7 @@ /*! check if an endpoint is available for any kind of operation. * \param[in] endp endpoint to check. * \returns true if endpoint is avalable, false it is blocked for any reason. */ -bool mgcp_endp_avail(struct mgcp_endpoint *endp) +bool mgcp_endp_avail(const struct mgcp_endpoint *endp) { switch (endp->trunk->trunk_type) { case MGCP_TRUNK_VIRTUAL: -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31ed2f3abbcf024ee44f62e130dd4ec01611ae97 Gerrit-Change-Number: 39205 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 2 weeks

1
0
0 0

[S] Change in osmo-mgw[master]: mgcp_endp: Add helpers accessing endp connections

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39206?usp=email ) Change subject: mgcp_endp: Add helpers accessing endp connections ...................................................................... mgcp_endp: Add helpers accessing endp connections This has several benefits: * easily improving/changing the impelemntation later on (eg. by storing a count instead of iterating the whole list). * Remove code complexity from mgcp_protocol.c. Change-Id: I77c298abf0a1488b91f58c9e76507ef8add0168e --- M include/osmocom/mgcp/mgcp_endp.h M src/libosmo-mgcp/mgcp_endp.c M src/libosmo-mgcp/mgcp_protocol.c 3 files changed, 25 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve daniel: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/include/osmocom/mgcp/mgcp_endp.h b/include/osmocom/mgcp/mgcp_endp.h index 5ecebda..fbe0850 100644 --- a/include/osmocom/mgcp/mgcp_endp.h +++ b/include/osmocom/mgcp/mgcp_endp.h @@ -139,6 +139,8 @@ struct mgcp_endpoint *mgcp_endp_by_name(int *cause, const char *epname, struct mgcp_config *cfg); bool mgcp_endp_avail(const struct mgcp_endpoint *endp); +unsigned int mgcp_endp_num_conns(const struct mgcp_endpoint *endp); +bool mgcp_endp_is_full(const struct mgcp_endpoint *endp); void mgcp_endp_add_conn(struct mgcp_endpoint *endp, struct mgcp_conn *conn); void mgcp_endp_remove_conn(struct mgcp_endpoint *endp, struct mgcp_conn *conn); void mgcp_endp_free_conn_oldest(struct mgcp_endpoint *endp); diff --git a/src/libosmo-mgcp/mgcp_endp.c b/src/libosmo-mgcp/mgcp_endp.c index 21df0a3..1d2287c 100644 --- a/src/libosmo-mgcp/mgcp_endp.c +++ b/src/libosmo-mgcp/mgcp_endp.c @@ -569,6 +569,24 @@ return false; } +/*! Get number of conns in an endpoint. + * \param[in] endp endpoint to check. + * \returns Number of connections present in the endpoint. */ +unsigned int mgcp_endp_num_conns(const struct mgcp_endpoint *endp) +{ + return llist_count(&endp->conns); +} + +/*! check if an endpoint can in current state allocate new conns. + * \param[in] endp endpoint to check. + * \returns true if more connections can be allowed on endpoint, false if it is already busy. */ +bool mgcp_endp_is_full(const struct mgcp_endpoint *endp) +{ + if (endp->type->max_conns == 0) + return false; + return mgcp_endp_num_conns(endp) >= endp->type->max_conns; +} + /*! claim endpoint, sets callid and activates endpoint, should be called at the * beginning of the CRCX procedure when it is clear that a new call should be * created. diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 6d315ca..a425c99 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -967,7 +967,7 @@ } /* Check if we are able to accept the creation of another connection */ - if (endp->type->max_conns > 0 && llist_count(&endp->conns) >= endp->type->max_conns) { + if (mgcp_endp_is_full(endp)) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "CRCX: endpoint full, max. %i connections allowed!\n", endp->type->max_conns); @@ -1173,7 +1173,7 @@ LOGPENDP(endp, DLMGCP, LOGL_ERROR, "MDCX: selected endpoint not available!\n"); return create_err_response(rq->trunk, NULL, 501, "MDCX", pdata->trans); } - if (llist_count(&endp->conns) <= 0) { + if (mgcp_endp_num_conns(endp) <= 0) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "MDCX: endpoint is not holding a connection.\n"); rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_NO_CONN)); @@ -1396,7 +1396,7 @@ if (rq->wildcarded) { int num_conns = 0; for (i = 0; i < trunk->number_endpoints; i++) { - num_conns += llist_count(&trunk->endpoints[i]->conns); + num_conns += mgcp_endp_num_conns(trunk->endpoints[i]); mgcp_endp_release(trunk->endpoints[i]); } rate_ctr_add(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_SUCCESS), num_conns); @@ -1458,7 +1458,7 @@ * that we drop all connections on that specific endpoint at once. * (See also RFC3435 Section F.7) */ if (!conn_id) { - int num_conns = llist_count(&endp->conns); + int num_conns = mgcp_endp_num_conns(endp); LOGPENDP(endp, DLMGCP, LOGL_NOTICE, "DLCX: missing ci (connectionIdentifier), will remove all connections (%d total) at once\n", num_conns); @@ -1492,7 +1492,7 @@ /* When all connections are closed, the endpoint will be released * in order to be ready to be used by another call. */ - if (llist_count(&endp->conns) <= 0) { + if (mgcp_endp_num_conns(endp) <= 0) { mgcp_endp_release(endp); LOGPENDP(endp, DLMGCP, LOGL_DEBUG, "DLCX: endpoint released\n"); } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39206?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I77c298abf0a1488b91f58c9e76507ef8add0168e Gerrit-Change-Number: 39206 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 2 weeks

1
0
0 0

[M] Change in osmo-mgw[master]: mgw: Split conn mode parsing and applying into conn

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39209?usp=email ) Change subject: mgw: Split conn mode parsing and applying into conn ...................................................................... mgw: Split conn mode parsing and applying into conn Change-Id: I456843de0be1997802905873c057a83430327f50 --- M include/osmocom/mgcp/mgcp_conn.h M include/osmocom/mgcp/mgcp_msg.h M include/osmocom/mgcp/mgcp_protocol.h M src/libosmo-mgcp/mgcp_conn.c M src/libosmo-mgcp/mgcp_msg.c M src/libosmo-mgcp/mgcp_protocol.c 6 files changed, 83 insertions(+), 62 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/include/osmocom/mgcp/mgcp_conn.h b/include/osmocom/mgcp/mgcp_conn.h index 106544a..26cdffc 100644 --- a/include/osmocom/mgcp/mgcp_conn.h +++ b/include/osmocom/mgcp/mgcp_conn.h @@ -24,6 +24,7 @@ #pragma once #include <osmocom/mgcp/mgcp.h> +#include <osmocom/mgcp/mgcp_common.h> #include <osmocom/mgcp/mgcp_network.h> #include <osmocom/mgcp/osmux.h> #include <osmocom/core/linuxlist.h> @@ -247,6 +248,7 @@ struct mgcp_conn *mgcp_conn_alloc(void *ctx, struct mgcp_endpoint *endp, enum mgcp_conn_type type, char *name); void mgcp_conn_free(struct mgcp_conn *conn); +int mgcp_conn_set_mode(struct mgcp_conn *conn, enum mgcp_connection_mode mode); char *mgcp_conn_dump(struct mgcp_conn *conn); struct mgcp_conn *mgcp_find_dst_conn(struct mgcp_conn *conn); void mgcp_conn_watchdog_kick(struct mgcp_conn *conn); diff --git a/include/osmocom/mgcp/mgcp_msg.h b/include/osmocom/mgcp/mgcp_msg.h index 9572d39..d11fb85 100644 --- a/include/osmocom/mgcp/mgcp_msg.h +++ b/include/osmocom/mgcp/mgcp_msg.h @@ -27,6 +27,8 @@ #include <stdint.h> #include <stdbool.h> +#include <osmocom/mgcp/mgcp_common.h> + struct mgcp_conn; struct mgcp_parse_data; struct mgcp_endpoint; @@ -34,8 +36,7 @@ void mgcp_disp_msg(unsigned char *message, unsigned int len, char *preamble); -int mgcp_parse_conn_mode(const char *msg, struct mgcp_endpoint *endp, - struct mgcp_conn *conn); +enum mgcp_connection_mode mgcp_parse_conn_mode(const char *msg); int mgcp_parse_header(struct mgcp_parse_data *pdata, char *data); diff --git a/include/osmocom/mgcp/mgcp_protocol.h b/include/osmocom/mgcp/mgcp_protocol.h index df134ab..ddb226b 100644 --- a/include/osmocom/mgcp/mgcp_protocol.h +++ b/include/osmocom/mgcp/mgcp_protocol.h @@ -1,5 +1,8 @@ #pragma once +#include <osmocom/core/utils.h> +#include <osmocom/mgcp/mgcp_common.h> + /* Internal structure while parsing a request */ struct mgcp_parse_data { struct mgcp_config *cfg; @@ -28,3 +31,9 @@ uint32_t mgcp_rtp_packet_duration(const struct mgcp_endpoint *endp, const struct mgcp_rtp_end *rtp); + +extern const struct value_string mgcp_connection_mode_strs[]; +static inline const char *mgcp_cmode_name(enum mgcp_connection_mode mode) +{ + return get_value_string(mgcp_connection_mode_strs, mode); +} diff --git a/src/libosmo-mgcp/mgcp_conn.c b/src/libosmo-mgcp/mgcp_conn.c index 403cbda..b4d971e 100644 --- a/src/libosmo-mgcp/mgcp_conn.c +++ b/src/libosmo-mgcp/mgcp_conn.c @@ -263,6 +263,37 @@ talloc_free(conn); } +/*! Parse connection mode. + * \param[in] conn Connection whose mode is being set + * \param[in] mode Mode to set + * \returns 0 on success, -1 on error */ +int mgcp_conn_set_mode(struct mgcp_conn *conn, enum mgcp_connection_mode mode) +{ + OSMO_ASSERT(conn); + if (mode == MGCP_CONN_NONE) { + LOGPCONN(conn, DLMGCP, LOGL_ERROR, + "missing connection mode\n"); + return -1; + } + conn->mode = mode; + LOGPCONN(conn, DLMGCP, LOGL_DEBUG, "connection mode '%s' %d\n", + mgcp_cmode_name(mode), conn->mode); + + /* Special handling for RTP connections */ + if (conn->type == MGCP_CONN_TYPE_RTP) { + struct mgcp_conn_rtp *conn_rtp = mgcp_conn_get_conn_rtp(conn); + conn_rtp->end.output_enabled = !!(conn->mode & MGCP_CONN_SEND_ONLY); + LOGPCONN(conn, DLMGCP, LOGL_DEBUG, "output_enabled %u\n", + conn_rtp->end.output_enabled); + } + + /* The VTY might change the connection mode at any time, so we have + * to hold a copy of the original connection mode */ + conn->mode_orig = conn->mode; + + return 0; +} + /*! dump basic connection information to human readable string. * \param[in] conn to dump * \returns human readable string */ diff --git a/src/libosmo-mgcp/mgcp_msg.c b/src/libosmo-mgcp/mgcp_msg.c index 2360a0b..f8ef50b 100644 --- a/src/libosmo-mgcp/mgcp_msg.c +++ b/src/libosmo-mgcp/mgcp_msg.c @@ -76,57 +76,24 @@ /*! Parse connection mode. * \param[in] mode as string (recvonly, sendrecv, sendonly confecho or loopback) - * \param[in] endp pointer to endpoint (only used for log output) - * \param[out] associated connection to be modified accordingly - * \returns 0 on success, -1 on error */ -int mgcp_parse_conn_mode(const char *mode, struct mgcp_endpoint *endp, - struct mgcp_conn *conn) + * \returns MGCP_CONN_* on success, MGCP_CONN_NONE on error */ +enum mgcp_connection_mode mgcp_parse_conn_mode(const char *mode) { - int ret = 0; - if (!mode) { - LOGPCONN(conn, DLMGCP, LOGL_ERROR, - "missing connection mode\n"); - return -1; - } - if (!conn) - return -1; - if (!endp) - return -1; + if (!mode) + return MGCP_CONN_NONE; if (strcasecmp(mode, "recvonly") == 0) - conn->mode = MGCP_CONN_RECV_ONLY; - else if (strcasecmp(mode, "sendrecv") == 0) - conn->mode = MGCP_CONN_RECV_SEND; - else if (strcasecmp(mode, "sendonly") == 0) - conn->mode = MGCP_CONN_SEND_ONLY; - else if (strcasecmp(mode, "confecho") == 0) - conn->mode = MGCP_CONN_CONFECHO; - else if (strcasecmp(mode, "loopback") == 0) - conn->mode = MGCP_CONN_LOOPBACK; - else { - LOGPCONN(conn, DLMGCP, LOGL_ERROR, - "unknown connection mode: '%s'\n", mode); - ret = -1; - } - - LOGPENDP(endp, DLMGCP, LOGL_DEBUG, "conn:%s\n", mgcp_conn_dump(conn)); - LOGPCONN(conn, DLMGCP, LOGL_DEBUG, "connection mode '%s' %d\n", - mode, conn->mode); - - /* Special handling for RTP connections */ - if (conn->type == MGCP_CONN_TYPE_RTP) { - struct mgcp_conn_rtp *conn_rtp = mgcp_conn_get_conn_rtp(conn); - conn_rtp->end.output_enabled = !!(conn->mode & MGCP_CONN_SEND_ONLY); - LOGPCONN(conn, DLMGCP, LOGL_DEBUG, "output_enabled %u\n", - conn_rtp->end.output_enabled); - } - - /* The VTY might change the connection mode at any time, so we have - * to hold a copy of the original connection mode */ - conn->mode_orig = conn->mode; - - return ret; + return MGCP_CONN_RECV_ONLY; + if (strcasecmp(mode, "sendrecv") == 0) + return MGCP_CONN_RECV_SEND; + if (strcasecmp(mode, "sendonly") == 0) + return MGCP_CONN_SEND_ONLY; + if (strcasecmp(mode, "confecho") == 0) + return MGCP_CONN_CONFECHO; + if (strcasecmp(mode, "loopback") == 0) + return MGCP_CONN_LOOPBACK; + return MGCP_CONN_NONE; } /*! Analyze and parse the the hader of an MGCP messeage string. diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 7df2544..6f94f39 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -59,6 +59,16 @@ return debug_last_endpoint_name; } +const struct value_string mgcp_connection_mode_strs[] = { + { MGCP_CONN_NONE, "none" }, + { MGCP_CONN_RECV_SEND, "sendrecv" }, + { MGCP_CONN_SEND_ONLY, "sendonly" }, + { MGCP_CONN_RECV_ONLY, "recvonly" }, + { MGCP_CONN_CONFECHO, "confecho" }, + { MGCP_CONN_LOOPBACK, "loopback" }, + { 0, NULL } +}; + /* A combination of LOGPENDP and LOGPTRUNK that automatically falls back to * LOGPTRUNK when the endp parameter is NULL */ #define LOGPEPTR(endp, trunk, cat, level, fmt, args...) \ @@ -870,7 +880,7 @@ int error_code = 400; const char *local_options = NULL; const char *callid = NULL; - const char *mode = NULL; + enum mgcp_connection_mode mode = MGCP_CONN_NONE; char *line; int have_sdp = 0, remote_osmux_cid = -2; struct mgcp_conn_rtp *conn = NULL; @@ -922,7 +932,7 @@ return create_err_response(rq->trunk, NULL, 523, "CRCX", pdata->trans); break; case 'M': - mode = (const char *)line + 3; + mode = mgcp_parse_conn_mode((const char *)line + 3); break; case 'X': if (strncasecmp("Osmux: ", line + 2, strlen("Osmux: ")) == 0) { @@ -959,9 +969,9 @@ return create_err_response(endp, endp, 516, "CRCX", pdata->trans); } - if (!mode) { + if (mode == MGCP_CONN_NONE) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, - "CRCX: insufficient parameters, missing mode\n"); + "CRCX: insufficient parameters, invalid mode\n"); rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_INVALID_MODE)); return create_err_response(endp, endp, 517, "CRCX", pdata->trans); } @@ -1023,15 +1033,15 @@ goto error2; } - conn = mgcp_conn_get_conn_rtp(_conn); - OSMO_ASSERT(conn); - - if (mgcp_parse_conn_mode(mode, endp, _conn) != 0) { + if (mgcp_conn_set_mode(_conn, mode) < 0) { error_code = 517; rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_INVALID_MODE)); goto error2; } + conn = mgcp_conn_get_conn_rtp(_conn); + OSMO_ASSERT(conn); + /* If X-Osmux (remote CID) was received (-1 is wilcard), alloc next avail CID as local CID */ if (remote_osmux_cid >= -1) { if (osmux_init_conn(conn) < 0) { @@ -1145,7 +1155,7 @@ int have_sdp = 0; char *line; const char *local_options = NULL; - const char *mode = NULL; + enum mgcp_connection_mode mode = MGCP_CONN_NONE; struct mgcp_conn_rtp *conn = NULL; const char *conn_id = NULL; int remote_osmux_cid = -2; @@ -1204,7 +1214,7 @@ local_options = (const char *)line + 3; break; case 'M': - mode = (const char *)line + 3; + mode = mgcp_parse_conn_mode((const char *)line + 3); break; case 'X': if (strncasecmp("Osmux: ", line + 2, strlen("Osmux: ")) == 0) { @@ -1246,14 +1256,15 @@ mgcp_conn_watchdog_kick(conn->conn); - if (mode) { - if (mgcp_parse_conn_mode(mode, endp, conn->conn) != 0) { + if (mode != MGCP_CONN_NONE) { + if (mgcp_conn_set_mode(conn->conn, mode) < 0) { rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_INVALID_MODE)); error_code = 517; goto error3; } - } else + } else { conn->conn->mode = conn->conn->mode_orig; + } /* Set local connection options, if present */ if (local_options) { -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39209?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I456843de0be1997802905873c057a83430327f50 Gerrit-Change-Number: 39209 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 2 weeks

1
0
0 0

[XS] Change in osmo-mgw[master]: mgw: Use bool instead of int in local var

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39211?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mgw: Use bool instead of int in local var ...................................................................... mgw: Use bool instead of int in local var Change-Id: Ie46cb2909da2ec4279e1029cfaf7747c45f84b13 --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved daniel: Looks good to me, but someone else must approve diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 2775d7a..98a0062 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -727,7 +727,7 @@ { struct mgcp_trunk *trunk = endp->trunk; - int patch_ssrc = expect_ssrc_change && trunk->force_constant_ssrc; + bool patch_ssrc = expect_ssrc_change && trunk->force_constant_ssrc; rtp->force_aligned_timing = trunk->force_aligned_timing; rtp->force_constant_ssrc = patch_ssrc ? 1 : 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39211?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie46cb2909da2ec4279e1029cfaf7747c45f84b13 Gerrit-Change-Number: 39211 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 2 weeks

1
0
0 0

[M] Change in osmo-mgw[master]: mgw: CRCXMDCX/DLCX: rename conn and conn_rtp variables

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39210?usp=email ) Change subject: mgw: CRCXMDCX/DLCX: rename conn and conn_rtp variables ...................................................................... mgw: CRCXMDCX/DLCX: rename conn and conn_rtp variables It's currently difficult to gasp whether a pointer is a conn or a conn_rtp, so rename it. Change-Id: I75ba9969af53d3e386c4070eb15de27e7378bfdc --- M src/libosmo-mgcp/mgcp_protocol.c 1 file changed, 78 insertions(+), 74 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve daniel: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c index 6f94f39..2775d7a 100644 --- a/src/libosmo-mgcp/mgcp_protocol.c +++ b/src/libosmo-mgcp/mgcp_protocol.c @@ -883,8 +883,8 @@ enum mgcp_connection_mode mode = MGCP_CONN_NONE; char *line; int have_sdp = 0, remote_osmux_cid = -2; - struct mgcp_conn_rtp *conn = NULL; - struct mgcp_conn *_conn = NULL; + struct mgcp_conn *conn = NULL; + struct mgcp_conn_rtp *conn_rtp = NULL; char conn_name[512]; int rc; @@ -1025,35 +1025,35 @@ } snprintf(conn_name, sizeof(conn_name), "%s", callid); - _conn = mgcp_conn_alloc(trunk->endpoints, endp, MGCP_CONN_TYPE_RTP, conn_name); - if (!_conn) { + conn = mgcp_conn_alloc(trunk->endpoints, endp, MGCP_CONN_TYPE_RTP, conn_name); + if (!conn) { LOGPENDP(endp, DLMGCP, LOGL_ERROR, "CRCX: unable to allocate RTP connection\n"); rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_ALLOC_CONN)); goto error2; } - if (mgcp_conn_set_mode(_conn, mode) < 0) { + if (mgcp_conn_set_mode(conn, mode) < 0) { error_code = 517; rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_INVALID_MODE)); goto error2; } - conn = mgcp_conn_get_conn_rtp(_conn); - OSMO_ASSERT(conn); + conn_rtp = mgcp_conn_get_conn_rtp(conn); + OSMO_ASSERT(conn_rtp); /* If X-Osmux (remote CID) was received (-1 is wilcard), alloc next avail CID as local CID */ if (remote_osmux_cid >= -1) { - if (osmux_init_conn(conn) < 0) { + if (osmux_init_conn(conn_rtp) < 0) { rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_NO_OSMUX)); goto error2; } if (remote_osmux_cid >= 0) { - conn->osmux.remote_cid_present = true; - conn->osmux.remote_cid = remote_osmux_cid; + conn_rtp->osmux.remote_cid_present = true; + conn_rtp->osmux.remote_cid = remote_osmux_cid; } } else if (endp->trunk->cfg->osmux.usage == OSMUX_USAGE_ONLY) { - LOGPCONN(_conn, DLMGCP, LOGL_ERROR, + LOGPCONN(conn, DLMGCP, LOGL_ERROR, "CRCX: osmux only and no osmux offered\n"); rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_NO_OSMUX)); goto error2; @@ -1064,7 +1064,7 @@ rc = set_local_cx_options(trunk->endpoints, &endp->local_options, local_options); if (rc != 0) { - LOGPCONN(_conn, DLMGCP, LOGL_ERROR, + LOGPCONN(conn, DLMGCP, LOGL_ERROR, "CRCX: invalid local connection options!\n"); error_code = rc; rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_INVALID_CONN_OPTIONS)); @@ -1073,8 +1073,8 @@ } /* Handle codec information and decide for a suitable codec */ - rc = handle_codec_info(conn, rq, have_sdp, true); - mgcp_codec_summary(conn); + rc = handle_codec_info(conn_rtp, rq, have_sdp, true); + mgcp_codec_summary(conn_rtp); if (rc) { error_code = rc; rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_CODEC_NEGOTIATION)); @@ -1082,60 +1082,60 @@ } /* Upgrade the conn type RTP_DEFAULT->RTP_IUUP if needed based on requested codec: */ /* TODO: "codec" probably needs to be moved from endp to conn */ - if (conn->type == MGCP_RTP_DEFAULT && strcmp(conn->end.codec->subtype_name, "VND.3GPP.IUFP") == 0) { - rc = mgcp_conn_iuup_init(conn); + if (conn_rtp->type == MGCP_RTP_DEFAULT && strcmp(conn_rtp->end.codec->subtype_name, "VND.3GPP.IUFP") == 0) { + rc = mgcp_conn_iuup_init(conn_rtp); } if (pdata->cfg->force_ptime) { - conn->end.packet_duration_ms = pdata->cfg->force_ptime; - conn->end.force_output_ptime = 1; + conn_rtp->end.packet_duration_ms = pdata->cfg->force_ptime; + conn_rtp->end.force_output_ptime = 1; } - mgcp_rtp_end_config(endp, 0, &conn->end); + mgcp_rtp_end_config(endp, 0, &conn_rtp->end); /* Find a local address for conn based on policy and initial SDP remote information, then find a free port for it */ - if (mgcp_get_local_addr(conn->end.local_addr, conn) < 0) { + if (mgcp_get_local_addr(conn_rtp->end.local_addr, conn_rtp) < 0) { rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_BIND_PORT)); goto error2; } - if (allocate_port(endp, conn) != 0) { + if (allocate_port(endp, conn_rtp) != 0) { rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_BIND_PORT)); goto error2; } - if (setup_rtp_processing(endp, conn) != 0) { - LOGPCONN(_conn, DLMGCP, LOGL_ERROR, + if (setup_rtp_processing(endp, conn_rtp) != 0) { + LOGPCONN(conn, DLMGCP, LOGL_ERROR, "CRCX: could not start RTP processing!\n"); rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_START_RTP)); goto error2; } /* Notify Osmux conn that CRCX was received */ - if (mgcp_conn_rtp_is_osmux(conn)) { - if (conn_osmux_event_rx_crcx_mdcx(conn) < 0) { - LOGPCONN(conn->conn, DLMGCP, LOGL_ERROR, "CRCX: Osmux handling failed!\n"); + if (mgcp_conn_rtp_is_osmux(conn_rtp)) { + if (conn_osmux_event_rx_crcx_mdcx(conn_rtp) < 0) { + LOGPCONN(conn, DLMGCP, LOGL_ERROR, "CRCX: Osmux handling failed!\n"); goto error2; } } - LOGPCONN(_conn, DLMGCP, LOGL_DEBUG, - "CRCX: Creating connection: port: %u\n", conn->end.local_port); + LOGPCONN(conn, DLMGCP, LOGL_DEBUG, + "CRCX: Creating connection: port: %u\n", conn_rtp->end.local_port); /* Send dummy packet, see also comments in mgcp_keepalive_timer_cb() */ OSMO_ASSERT(trunk->keepalive_interval >= MGCP_KEEPALIVE_ONCE); - if (_conn->mode & MGCP_CONN_RECV_ONLY && + if (conn->mode & MGCP_CONN_RECV_ONLY && trunk->keepalive_interval != MGCP_KEEPALIVE_NEVER) - send_dummy(endp, conn); + send_dummy(endp, conn_rtp); - LOGPCONN(_conn, DLMGCP, LOGL_NOTICE, + LOGPCONN(conn, DLMGCP, LOGL_NOTICE, "CRCX: connection successfully created\n"); rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_SUCCESS)); mgcp_endp_update(endp); /* NOTE: Only in the virtual trunk we allow dynamic endpoint names */ bool add_epname = rq->wildcarded && trunk->trunk_type == MGCP_TRUNK_VIRTUAL; - return create_response_with_sdp(endp, conn, "CRCX", pdata->trans, add_epname, true); + return create_response_with_sdp(endp, conn_rtp, "CRCX", pdata->trans, add_epname, true); error2: mgcp_endp_release(endp); LOGPENDP(endp, DLMGCP, LOGL_NOTICE, @@ -1156,7 +1156,8 @@ char *line; const char *local_options = NULL; enum mgcp_connection_mode mode = MGCP_CONN_NONE; - struct mgcp_conn_rtp *conn = NULL; + struct mgcp_conn *conn = NULL; + struct mgcp_conn_rtp *conn_rtp = NULL; const char *conn_id = NULL; int remote_osmux_cid = -2; int rc; @@ -1248,22 +1249,22 @@ return create_err_response(endp, endp, 515, "MDCX", pdata->trans); } - conn = mgcp_endp_get_conn_rtp(endp, conn_id); + conn = mgcp_endp_get_conn(endp, conn_id); if (!conn) { rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_CONN_NOT_FOUND)); return create_err_response(endp, endp, 400, "MDCX", pdata->trans); } - mgcp_conn_watchdog_kick(conn->conn); + mgcp_conn_watchdog_kick(conn); if (mode != MGCP_CONN_NONE) { - if (mgcp_conn_set_mode(conn->conn, mode) < 0) { + if (mgcp_conn_set_mode(conn, mode) < 0) { rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_INVALID_MODE)); error_code = 517; goto error3; } } else { - conn->conn->mode = conn->conn->mode_orig; + conn->mode = conn->mode_orig; } /* Set local connection options, if present */ @@ -1271,7 +1272,7 @@ rc = set_local_cx_options(trunk->endpoints, &endp->local_options, local_options); if (rc != 0) { - LOGPCONN(conn->conn, DLMGCP, LOGL_ERROR, + LOGPCONN(conn, DLMGCP, LOGL_ERROR, "MDCX: invalid local connection options!\n"); error_code = rc; rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_INVALID_CONN_OPTIONS)); @@ -1279,38 +1280,41 @@ } } + conn_rtp = mgcp_conn_get_conn_rtp(conn); + OSMO_ASSERT(conn_rtp); + /* Handle codec information and decide for a suitable codec */ - rc = handle_codec_info(conn, rq, have_sdp, false); - mgcp_codec_summary(conn); + rc = handle_codec_info(conn_rtp, rq, have_sdp, false); + mgcp_codec_summary(conn_rtp); if (rc) { error_code = rc; goto error3; } /* Upgrade the conn type RTP_DEFAULT->RTP_IUUP if needed based on requested codec: */ /* TODO: "codec" probably needs to be moved from endp to conn */ - if (conn->type == MGCP_RTP_DEFAULT && strcmp(conn->end.codec->subtype_name, "VND.3GPP.IUFP") == 0) - rc = mgcp_conn_iuup_init(conn); + if (conn_rtp->type == MGCP_RTP_DEFAULT && strcmp(conn_rtp->end.codec->subtype_name, "VND.3GPP.IUFP") == 0) + rc = mgcp_conn_iuup_init(conn_rtp); - if (mgcp_conn_rtp_is_osmux(conn)) { - OSMO_ASSERT(conn->osmux.local_cid_allocated); + if (mgcp_conn_rtp_is_osmux(conn_rtp)) { + OSMO_ASSERT(conn_rtp->osmux.local_cid_allocated); if (remote_osmux_cid < -1) { - LOGPCONN(conn->conn, DLMGCP, LOGL_ERROR, + LOGPCONN(conn, DLMGCP, LOGL_ERROR, "MDCX: Failed to parse Osmux CID!\n"); goto error3; } else if (remote_osmux_cid == -1) { - LOGPCONN(conn->conn, DLMGCP, LOGL_ERROR, + LOGPCONN(conn, DLMGCP, LOGL_ERROR, "MDCX: wilcard in MDCX is not supported!\n"); goto error3; - } else if (conn->osmux.remote_cid_present && - remote_osmux_cid != conn->osmux.remote_cid) { - LOGPCONN(conn->conn, DLMGCP, LOGL_ERROR, - "MDCX: changing already allocated CID is not supported!\n"); - goto error3; + } else if (conn_rtp->osmux.remote_cid_present && + remote_osmux_cid != conn_rtp->osmux.remote_cid) { + LOGPCONN(conn, DLMGCP, LOGL_ERROR, + "MDCX: changing already allocated CID is not supported!\n"); + goto error3; } else { - conn->osmux.remote_cid_present = true; - conn->osmux.remote_cid = remote_osmux_cid; - if (conn_osmux_event_rx_crcx_mdcx(conn) < 0) { - LOGPCONN(conn->conn, DLMGCP, LOGL_ERROR, + conn_rtp->osmux.remote_cid_present = true; + conn_rtp->osmux.remote_cid = remote_osmux_cid; + if (conn_osmux_event_rx_crcx_mdcx(conn_rtp) < 0) { + LOGPCONN(conn, DLMGCP, LOGL_ERROR, "MDCX: Osmux handling failed!\n"); goto error3; } @@ -1321,42 +1325,42 @@ to update our announced IP addr and re-bind our local end. This can happen for instance if MGW initially provided an IPv4 during CRCX ACK, and now MDCX tells us the remote has an IPv6 address. */ - if (mgcp_get_local_addr(new_local_addr, conn) < 0) { + if (mgcp_get_local_addr(new_local_addr, conn_rtp) < 0) { rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_BIND_PORT)); goto error3; } - if (strcmp(new_local_addr, conn->end.local_addr)) { - osmo_strlcpy(conn->end.local_addr, new_local_addr, sizeof(conn->end.local_addr)); - mgcp_free_rtp_port(&conn->end); - if (allocate_port(endp, conn) != 0) { + if (strcmp(new_local_addr, conn_rtp->end.local_addr)) { + osmo_strlcpy(conn_rtp->end.local_addr, new_local_addr, sizeof(conn_rtp->end.local_addr)); + mgcp_free_rtp_port(&conn_rtp->end); + if (allocate_port(endp, conn_rtp) != 0) { rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_BIND_PORT)); goto error3; } } - if (setup_rtp_processing(endp, conn) != 0) { + if (setup_rtp_processing(endp, conn_rtp) != 0) { rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_FAIL_START_RTP)); goto error3; } - mgcp_rtp_end_config(endp, 1, &conn->end); + mgcp_rtp_end_config(endp, 1, &conn_rtp->end); /* modify */ - LOGPCONN(conn->conn, DLMGCP, LOGL_DEBUG, - "MDCX: modified conn:%s\n", mgcp_conn_dump(conn->conn)); + LOGPCONN(conn, DLMGCP, LOGL_DEBUG, + "MDCX: modified conn:%s\n", mgcp_conn_dump(conn)); /* Send dummy packet, see also comments in mgcp_keepalive_timer_cb() */ OSMO_ASSERT(trunk->keepalive_interval >= MGCP_KEEPALIVE_ONCE); - if (conn->conn->mode & MGCP_CONN_RECV_ONLY && + if (conn->mode & MGCP_CONN_RECV_ONLY && trunk->keepalive_interval != MGCP_KEEPALIVE_NEVER) - send_dummy(endp, conn); + send_dummy(endp, conn_rtp); rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_MDCX_SUCCESS)); - LOGPCONN(conn->conn, DLMGCP, LOGL_NOTICE, + LOGPCONN(conn, DLMGCP, LOGL_NOTICE, "MDCX: connection successfully modified\n"); mgcp_endp_update(endp); - return create_response_with_sdp(endp, conn, "MDCX", pdata->trans, false, false); + return create_response_with_sdp(endp, conn_rtp, "MDCX", pdata->trans, false, false); error3: return create_err_response(endp, endp, error_code, "MDCX", pdata->trans); } @@ -1372,7 +1376,7 @@ char *line; char stats[1048]; const char *conn_id = NULL; - struct mgcp_conn_rtp *conn = NULL; + struct mgcp_conn *conn = NULL; unsigned int i; /* NOTE: In this handler we can not take it for granted that the endp @@ -1487,18 +1491,18 @@ } /* Find the connection */ - conn = mgcp_endp_get_conn_rtp(endp, conn_id); + conn = mgcp_endp_get_conn(endp, conn_id); if (!conn) { rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_DLCX_FAIL_INVALID_CONNID)); goto error3; } /* save the statistics of the current connection */ - mgcp_format_stats(stats, sizeof(stats), conn->conn); + mgcp_format_stats(stats, sizeof(stats), conn); /* delete connection */ - LOGPCONN(conn->conn, DLMGCP, LOGL_DEBUG, "DLCX: deleting conn:%s\n", - mgcp_conn_dump(conn->conn)); - mgcp_conn_free(conn->conn); + LOGPCONN(conn, DLMGCP, LOGL_DEBUG, "DLCX: deleting conn:%s\n", + mgcp_conn_dump(conn)); + mgcp_conn_free(conn); LOGPENDP(endp, DLMGCP, LOGL_NOTICE, "DLCX: connection successfully deleted\n"); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39210?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I75ba9969af53d3e386c4070eb15de27e7378bfdc Gerrit-Change-Number: 39210 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 2 weeks

1
0
0 0

[M] Change in osmo-mgw[master]: mgw: Split conn mode parsing and applying into conn

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39209?usp=email ) Change subject: mgw: Split conn mode parsing and applying into conn ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39209?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I456843de0be1997802905873c057a83430327f50 Gerrit-Change-Number: 39209 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Jan 2025 11:16:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 2 weeks

1
0
0 0

[M] Change in osmo-mgw[master]: mgw: CRCXMDCX/DLCX: rename conn and conn_rtp variables

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39210?usp=email ) Change subject: mgw: CRCXMDCX/DLCX: rename conn and conn_rtp variables ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39210?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I75ba9969af53d3e386c4070eb15de27e7378bfdc Gerrit-Change-Number: 39210 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Jan 2025 11:16:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 2 weeks

1
0
0 0

[XS] Change in osmo-mgw[master]: mgw: mgcp_protocol: assert freeing last conn allows creating new conn

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39207?usp=email ) Change subject: mgw: mgcp_protocol: assert freeing last conn allows creating new conn ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39207?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ib8c9089a7f04bc67e5bdfb1148cfc603f0e17bb7 Gerrit-Change-Number: 39207 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Jan 2025 11:14:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 2 weeks

1
0
0 0

[S] Change in osmo-mgw[master]: mgcp_endp: Add helpers accessing endp connections

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39206?usp=email ) Change subject: mgcp_endp: Add helpers accessing endp connections ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39206?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I77c298abf0a1488b91f58c9e76507ef8add0168e Gerrit-Change-Number: 39206 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Jan 2025 11:14:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 2 weeks

1
0
0 0

[XS] Change in osmo-mgw[master]: mgw: constify mgcp_endp_avail() param

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39205?usp=email ) Change subject: mgw: constify mgcp_endp_avail() param ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31ed2f3abbcf024ee44f62e130dd4ec01611ae97 Gerrit-Change-Number: 39205 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Jan 2025 11:09:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025