January 2025 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: osmo_iofd_register: fix the case of changing fd

by laforge

Attention is currently required from: falconia. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmocore/+/39276?usp=email ) Change subject: osmo_iofd_register: fix the case of changing fd ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39276?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If8b8486ad7934afa203dfe1e996c9217373a017b Gerrit-Change-Number: 39276 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 10 Jan 2025 13:05:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 2 weeks

1
0
0 0

[XS] Change in osmo-pcap[master]: server: Rename func client_data() -> zmq_send_client_data()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39283?usp=email ) Change subject: server: Rename func client_data() -> zmq_send_client_data() ...................................................................... server: Rename func client_data() -> zmq_send_client_data() Change-Id: I1b22046464cf969fb5d74b6c2580aaec1feffefa --- M src/osmo_server_network.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/83/39283/1 diff --git a/src/osmo_server_network.c b/src/osmo_server_network.c index f05413e..64d772a 100644 --- a/src/osmo_server_network.c +++ b/src/osmo_server_network.c @@ -89,8 +89,8 @@ pcap_zmq_send(conn->server->zmq_publ, data, strlen(data), 0); } -static void client_data(struct osmo_pcap_conn *conn, - struct osmo_pcap_data *data) +static void zmq_send_client_data(struct osmo_pcap_conn *conn, + struct osmo_pcap_data *data) { char *event_name; @@ -101,7 +101,7 @@ * This multi-part support is insane... so if we lose the first * or the last part of the multipart message stuff is going out * of sync. *great* As we can't do anything about it right now - * just close the eyese and send it. + * just close the eyes and send it. */ event_name = talloc_asprintf(conn, "data.v1.%s", conn->name); pcap_zmq_send(conn->server->zmq_publ, event_name, strlen(event_name), ZMQ_SNDMORE); @@ -466,7 +466,7 @@ time_t now = time(NULL); int rc; - client_data(conn, data); + zmq_send_client_data(conn, data); if (!conn->store) { update_last_write(conn, now); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39283?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I1b22046464cf969fb5d74b6c2580aaec1feffefa Gerrit-Change-Number: 39283 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

5 months, 2 weeks

1
0
0 0

[XS] Change in osmo-pcap[master]: cosmetic: server: Fix typo in comment

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39282?usp=email ) Change subject: cosmetic: server: Fix typo in comment ...................................................................... cosmetic: server: Fix typo in comment Change-Id: I03aa0137d5470717104f27cb55d4bde802d00a95 --- M src/osmo_server_network.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/82/39282/1 diff --git a/src/osmo_server_network.c b/src/osmo_server_network.c index be2c6e0..f05413e 100644 --- a/src/osmo_server_network.c +++ b/src/osmo_server_network.c @@ -135,7 +135,7 @@ if (!server->completed_path) return; - /* Assumption: curr_filename is anonicalized absolute pathname. */ + /* Assumption: curr_filename is canonical absolute pathname. */ /* basename and dirname may modify input param, and return a string * which shall not be freed, potentially pointing to the input param. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39282?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I03aa0137d5470717104f27cb55d4bde802d00a95 Gerrit-Change-Number: 39282 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

5 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-netif[master]: src/Makefile.am cosmetic: make it easier to extend

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39279?usp=email ) Change subject: src/Makefile.am cosmetic: make it easier to extend ...................................................................... src/Makefile.am cosmetic: make it easier to extend To make it easier to add new source files to libosmonetif_la_SOURCES list, make two cosmetic changes to it: * List stream.c before stream_{cli,srv}.c, matching the order that is used in other similar instances; * Use $(NULL) construct so that every source-naming line ends with a backslash. Change-Id: I98cf6d592fb66d5f22d486358ccdab06306ae3b0 --- M src/Makefile.am 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/src/Makefile.am b/src/Makefile.am index bd3f272..e3634be 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -23,9 +23,10 @@ prim.c \ rs232.c \ rtp.c \ + stream.c \ stream_cli.c \ stream_srv.c \ - stream.c + $(NULL) if ENABLE_LIBSCTP libosmonetif_la_SOURCES += sctp.c -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39279?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I98cf6d592fb66d5f22d486358ccdab06306ae3b0 Gerrit-Change-Number: 39279 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-netif[master]: include/osmocom/netif/Makefile.am cosmetic: make it easier to extend

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39278?usp=email ) Change subject: include/osmocom/netif/Makefile.am cosmetic: make it easier to extend ...................................................................... include/osmocom/netif/Makefile.am cosmetic: make it easier to extend To make it easier to add new headers to osmonetif_HEADERS list, make two cosmetic changes to it: * List all currently exported headers in alphabetical order; * Use $(NULL) construct so that every header-naming line ends with a backslash. Change-Id: I05ecbdb44286b842e158278fb07479846cd66806 --- M include/osmocom/netif/Makefile.am 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/include/osmocom/netif/Makefile.am b/include/osmocom/netif/Makefile.am index 3d8a56b..d518edb 100644 --- a/include/osmocom/netif/Makefile.am +++ b/include/osmocom/netif/Makefile.am @@ -4,14 +4,15 @@ osmonetif_HEADERS = amr.h \ datagram.h \ - jibuf.h \ - osmux.h \ ipa.h \ ipa_unit.h \ + jibuf.h \ + osmux.h \ prim.h \ rs232.h \ rtp.h \ - stream.h + stream.h \ + $(NULL) if ENABLE_LIBSCTP osmonetif_HEADERS += sctp.h -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39278?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I05ecbdb44286b842e158278fb07479846cd66806 Gerrit-Change-Number: 39278 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

5 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-netif[master]: src/Makefile.am cosmetic: make it easier to extend

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39279?usp=email ) Change subject: src/Makefile.am cosmetic: make it easier to extend ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39279?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I98cf6d592fb66d5f22d486358ccdab06306ae3b0 Gerrit-Change-Number: 39279 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 10 Jan 2025 12:49:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-netif[master]: include/osmocom/netif/Makefile.am cosmetic: make it easier to extend

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39278?usp=email ) Change subject: include/osmocom/netif/Makefile.am cosmetic: make it easier to extend ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39278?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I05ecbdb44286b842e158278fb07479846cd66806 Gerrit-Change-Number: 39278 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 10 Jan 2025 12:48:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 2 weeks

1
0
0 0

[S] Change in libosmocore[master]: osmo_iofd_register: fix the case of changing fd

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmocore/+/39276?usp=email ) Change subject: osmo_iofd_register: fix the case of changing fd ...................................................................... Patch Set 2: (1 comment) File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/39276/comment/b2929e89_4c90b18b?… : PS2, Line 759: if (fd >= 0) > No, the conditional is still needed. […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/39276?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If8b8486ad7934afa203dfe1e996c9217373a017b Gerrit-Change-Number: 39276 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 10 Jan 2025 12:47:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

5 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: nokia_site: change RSL bootstrap logic

by csaba.sipos

Attention is currently required from: csaba.sipos. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/39277?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: nokia_site: change RSL bootstrap logic ...................................................................... nokia_site: change RSL bootstrap logic Wait for BTS_CONF_COMPL and start RSL bootstrap after. This way the TRX SW load has enough time to complete and the RSL LAPD becomes available. Important for MetroSite, UltraSite BTS types. Change-Id: I7319a64f069d239a582547bc422058ff5848d2e2 Signed-off-by: csaba.sipos <metro4(a)freemail.hu> --- M src/osmo-bsc/bts_nokia_site.c 1 file changed, 15 insertions(+), 21 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/77/39277/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39277?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7319a64f069d239a582547bc422058ff5848d2e2 Gerrit-Change-Number: 39277 Gerrit-PatchSet: 2 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: csaba.sipos <metro4(a)freemail.hu>

5 months, 2 weeks

1
0
0 0

[XS] Change in libosmo-netif[master]: src/Makefile.am cosmetic: make it easier to extend

by fixeria

Attention is currently required from: falconia. fixeria has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39279?usp=email ) Change subject: src/Makefile.am cosmetic: make it easier to extend ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39279?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I98cf6d592fb66d5f22d486358ccdab06306ae3b0 Gerrit-Change-Number: 39279 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Fri, 10 Jan 2025 07:30:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

5 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2025