September 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: s1gw: rework f_pfcp_wait_assoc_setup() into f_ConnHdlr_pfcp_expect()

by fixeria

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38036?usp=email ) Change subject: s1gw: rework f_pfcp_wait_assoc_setup() into f_ConnHdlr_pfcp_expect() ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38036?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If691cb9df72672eddfbafdd8e03ae09c81b1ce71 Gerrit-Change-Number: 38036 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 05 Sep 2024 11:05:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

9 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw: send the actual Recovery Time Stamp

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38040?usp=email ) Change subject: s1gw: send the actual Recovery Time Stamp ...................................................................... s1gw: send the actual Recovery Time Stamp Change-Id: I350d28289526d8264ef9b70e796ef76ee7fcbb4b --- M s1gw/S1GW_ConnHdlr.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/40/38040/1 diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index 42707ec..c0188db 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -239,7 +239,7 @@ PFCP.send(ts_PFCP_Assoc_Setup_Resp(rx.sequence_number, ts_PFCP_Node_ID_fqdn("\07osmocom\03org"), ts_PFCP_Cause(REQUEST_ACCEPTED), - 1234)); /* FIXME: request the value from PFCPEM */ + f_pfcp_get_recovery_timestamp())); } function f_ConnHdlr_pfcp_expect(template (present) PDU_PFCP exp_rx := ?, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38040?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I350d28289526d8264ef9b70e796ef76ee7fcbb4b Gerrit-Change-Number: 38040 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[XS] Change in osmo-sip-connector[master]: sip.c: permit early media with both 183 and 180

by fixeria

Attention is currently required from: jolly, laforge, lynxis lazus, neels. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email ) Change subject: sip.c: permit early media with both 183 and 180 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/38039?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ia0072080c2e0bfb8b2bf751a248d3410a7723e79 Gerrit-Change-Number: 38039 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 05 Sep 2024 10:46:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[M] Change in ...pyosmocom[master]: Introduce a new 'hexstr' type to represent hex-strings

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38023?usp=email ) Change subject: Introduce a new 'hexstr' type to represent hex-strings ...................................................................... Patch Set 2: (2 comments) File src/osmocom/utils.py: https://gerrit.osmocom.org/c/python/pyosmocom/+/38023/comment/e1b3545e_9703… : PS2, Line 141: hexstr > the "problem" then is that we already have osmocom.utils. […] Oh, I forgot that there already exists `Hexstr` type, which is actually here in this file. There's indeed a naming conflict then, and replacing the former with this new class would likely cause hundreds of linting errors. The existing `Hexstr` is just an alias for `str`, which allows an instance of `str` to be passed. If we replace it with this class, we actually force API users to pass an instance of this new class and not `str`... I don't like having two classes with the same name and only the upper/lower case making them different, which is definitely confusing. On the other hand, I cannot think of a solution to this problem... Perhaps I should bite the bullet and suggest merging it as-is then. https://gerrit.osmocom.org/c/python/pyosmocom/+/38023/comment/3f4fd944_8b39… : PS2, Line 151: other > I was under the impression that the builtin "dunder" method return values are never type-annotated. […] I think you're right. We could say `-> bool` for the sake of completeness, but this is not strictly needed. For the `other: str`, I agree that the `str` should work. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38023?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I16c0df809bc11ec0f98e8ade404f9b82072e3a06 Gerrit-Change-Number: 38023 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 05 Sep 2024 10:43:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Support replying errors

by fixeria

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email ) Change subject: s1ap_proxy: Support replying errors ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: I did not expect my request to trigger such an emotional burst... I do understand your frustration, but this patch introduces significant changes to the core part of the S1GW (the proxy), so this is why I am worried about testing coverage and this is why I am so picky. And TBH, I still don't see how the metrics patch depends on this one and why are they both in the same patch set. > I'm not aware that you followed yourself the same constrains that you are now applying on me [...] > Please understand it's quite frustrating having my patches here for a few days (even a week) and then seeing your recent PFCP patches being pushed and merged quickly without seeing any related TTCN3 tests in gerrit, [...] This is true, and I acknowledge that the Heartbeat related patches have been merged without the respective TTCN-3 testing coverage. I started working on it, but got swallowed by design/implementation of problems with the PFCP Emulation component. I just pushed a patchset fixing the emulation component and adding the Heartbeat test: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38037 s1gw: add TC_pfcp_heartbeat > The ttcn3 testsuite is not yet in a state where new tests can easily be added. I am working on improving the TTCN-3 testsuite. Yes, the progress is slow, but as you know I am not a full time employee and I am working less hours then you. Even worse, I was side tracked by another ticket with Urgent priority and did not make as much progress as I expected. Adding **unit** tests is still a doable alternative. `test_erab_setup_pfcp_establish_error`, `test_erab_setup_pfcp_modify_error`, and `test_erab_release_pfcp_delete_error` are a good example of simulating errors in the unit tests. If you wish, I can take care of this patch, i.e. keep rebasing it and add testing coverage. Let it be my problem then, allowing you to focus on other features. I can try adding a unit test today. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4 Gerrit-Change-Number: 37924 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 05 Sep 2024 10:24:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[M] Change in ...pyosmocom[master]: Introduce a new 'hexstr' type to represent hex-strings

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38023?usp=email ) Change subject: Introduce a new 'hexstr' type to represent hex-strings ...................................................................... Patch Set 2: (1 comment) File src/osmocom/utils.py: https://gerrit.osmocom.org/c/python/pyosmocom/+/38023/comment/8fe2a513_88f7… : PS2, Line 151: other > `... […] I was under the impression that the builtin "dunder" method return values are never type-annotated. Otherwise you'd probably have to annotate every __init__ etc? Not sure if there's a PEP about that. As for the "other": I was thinking of Union[hexstr,str], but as the former is a subclass of the latter, str would work. Will make that chagne. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38023?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I16c0df809bc11ec0f98e8ade404f9b82072e3a06 Gerrit-Change-Number: 38023 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Sep 2024 10:21:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[M] Change in ...pyosmocom[master]: Introduce a new 'hexstr' type to represent hex-strings

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/38023?usp=email ) Change subject: Introduce a new 'hexstr' type to represent hex-strings ...................................................................... Patch Set 2: (1 comment) File src/osmocom/utils.py: https://gerrit.osmocom.org/c/python/pyosmocom/+/38023/comment/96ebe076_de41… : PS2, Line 141: hexstr > Class names should use CamelCase in python (according to PEP 8): […] the "problem" then is that we already have osmocom.utils.Hexstr as a type for type annotations: "Hexstr = NewType('Hexstr', str)" Indeed, once we have a proper, hexstr type (as introduced by this patch) *and* ported over all of pySim to that, the former would no longer be neeed. But simply replacing the existin Hexstr with that new 'class Hexstr' you propose - I'm not sure what kind of fallout that would mean? -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38023?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I16c0df809bc11ec0f98e8ade404f9b82072e3a06 Gerrit-Change-Number: 38023 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Sep 2024 10:19:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hss: Initial validation of Prometheus metrics

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38027?usp=email ) Change subject: hss: Initial validation of Prometheus metrics ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38027?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I507537c66a031b67518294daa8338f3836a90d6b Gerrit-Change-Number: 38027 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Sep 2024 10:16:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: Introduce Prometheus_Checker module

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38026?usp=email ) Change subject: Introduce Prometheus_Checker module ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38026?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iec5544ba74978918f1bddba12971f69a1824683e Gerrit-Change-Number: 38026 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Sep 2024 10:16:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: Misc_Helpers: Introduce API helper f_str_startswith

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38025?usp=email ) Change subject: Misc_Helpers: Introduce API helper f_str_startswith ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38025?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iad392ac652714a54a25954ea697f082d55772aa8 Gerrit-Change-Number: 38025 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 05 Sep 2024 10:16:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024