September 2024 - gerrit-log - lists.osmocom.org

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Support replying errors

by pespin

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email ) Change subject: s1ap_proxy: Support replying errors ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Yes, I mentioned why: […] And by "trapped" I don't mean people reviewing and asking me to do changes on the patches. I mean simply stored here to rotten. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4 Gerrit-Change-Number: 37924 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 04 Sep 2024 14:01:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Support replying errors

by pespin

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email ) Change subject: s1ap_proxy: Support replying errors ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Then please at least add unit tests here. I am aiming for good testing coverage. […] Yes, I mentioned why: 1- I need to keep maintaining and fixing conflicts with new commits being reviewed and merged while mine keep stuck here. 2- The testsuite infra needs to be improved at the same time too. Tbh, I sometimes have the feeling that while I try hard to push forward others patches as quickly as possible to improve their efforts, mine get trapped in here for no good reason for too much time, making it worse for everyone. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4 Gerrit-Change-Number: 37924 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 04 Sep 2024 13:59:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Support replying errors

by fixeria

Attention is currently required from: lynxis lazus, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email ) Change subject: s1ap_proxy: Support replying errors ...................................................................... Patch Set 4: Code-Review-1 (1 comment) Patchset: PS4: > I'd like these patches getting reviewed and merged so I don't have to keep maintaining/rebasing them […] Then please at least add unit tests here. I am aiming for good testing coverage. Is it so urgent to get this one merged before the one adding metrics? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4 Gerrit-Change-Number: 37924 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 04 Sep 2024 13:55:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Support replying errors

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email ) Change subject: s1ap_proxy: Support replying errors ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > I'd like these patches getting reviewed and merged so I don't have to keep maintaining/rebasing them […] The cases implemented by this patch were being reproduced when running ttcn3 at the time, due to unrelated race conditions in the tests, so it works. We can merge them now and once the ttcn3 testsuite infra improves add whatever tests are needed, otherwise we are playing chicken and egg here. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4 Gerrit-Change-Number: 37924 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 04 Sep 2024 13:55:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[M] Change in ...osmo-s1gw[master]: s1ap_proxy: Support replying errors

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email ) Change subject: s1ap_proxy: Support replying errors ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: I'd like these patches getting reviewed and merged so I don't have to keep maintaining/rebasing them. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I242e84fb09b00f4794b6e1aa770f348a0e60aea4 Gerrit-Change-Number: 37924 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 04 Sep 2024 13:53:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

9 months, 3 weeks

1
0
0 0

[L] Change in ...osmo-s1gw[master]: Introduce initial metrics support

by pespin

Attention is currently required from: fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37955?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Introduce initial metrics support ...................................................................... Introduce initial metrics support metrics are implemented with the "exometer" library. A reference config to export the metrics through statsd is provided. Change-Id: I952e198238384dca4be94f91a01d7cfff0a1471f --- M config/sys.config A include/s1gw_metrics.hrl M rebar.config M rebar.lock M src/osmo_s1gw.app.src M src/osmo_s1gw_sup.erl M src/pfcp_peer.erl M src/s1ap_proxy.erl A src/s1gw_metrics.erl M src/sctp_proxy.erl M src/sctp_server.erl A test/exometer_mock.erl M test/s1ap_proxy_test.erl 13 files changed, 330 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/55/37955/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37955?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I952e198238384dca4be94f91a01d7cfff0a1471f Gerrit-Change-Number: 37955 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[S] Change in ...osmo-s1gw[master]: pfcp_peer: store local/remote Recovery Time Stamp in #peer_state

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37961?usp=email ) Change subject: pfcp_peer: store local/remote Recovery Time Stamp in #peer_state ...................................................................... pfcp_peer: store local/remote Recovery Time Stamp in #peer_state The local Recovery Time Stamp is also needed for the Heartbeat procedure, so we need to store it in the in #peer_state. The remote Recovery Time Stamp can be used for detecting restart of the remote peer and may be used for introspection later. Change-Id: I4ad597e3f16058c91b16ad83ffc00c486817b3cf --- M src/pfcp_peer.erl 1 file changed, 9 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/pfcp_peer.erl b/src/pfcp_peer.erl index 44956da..86d42d3 100644 --- a/src/pfcp_peer.erl +++ b/src/pfcp_peer.erl @@ -76,6 +76,8 @@ sock :: gen_udp:socket(), loc_addr :: inet:ip_address(), rem_addr :: inet:ip_address(), + loc_rts :: pos_integer(), + rem_rts :: undefined | pos_integer(), seq_nr :: pfcp_seq_nr(), registry :: dict:dict() }). @@ -142,6 +144,7 @@ loc_addr = LocAddr, rem_addr = RemAddr, seq_nr = 0, + loc_rts = get_recovery_timestamp(), registry = dict:new()}}. @@ -168,9 +171,11 @@ #peer_state{sock = Sock} = S) -> case decode_pdu(Data, S) of #pfcp{type = association_setup_response, - ie = #{pfcp_cause := 'Request accepted'}} -> + ie = #{pfcp_cause := 'Request accepted', + recovery_time_stamp := #recovery_time_stamp{time = RRTS}}} -> ?LOG_INFO("Rx Association Setup Response (Request accepted)"), - {next_state, connected, S}; + {next_state, connected, + S#peer_state{rem_rts = RRTS}}; #pfcp{type = association_setup_response, ie = #{pfcp_cause := Cause}} -> ?LOG_ERROR("Rx Association Setup Response (~p)", [Cause]), @@ -365,9 +370,9 @@ %% 6.2.6 PFCP Association Setup Procedure %% 7.4.4.1 PFCP Association Setup Request -send_assoc_setup(S) -> +send_assoc_setup(#peer_state{loc_rts = LRTS} = S) -> IEs = #{node_id => #node_id{id = get_node_id(S)}, - recovery_time_stamp => #recovery_time_stamp{time = get_recovery_timestamp()}}, + recovery_time_stamp => #recovery_time_stamp{time = LRTS}}, send_pdu({association_setup_request, IEs}, S). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37961?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I4ad597e3f16058c91b16ad83ffc00c486817b3cf Gerrit-Change-Number: 37961 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[S] Change in ...osmo-s1gw[master]: pfcp_peer: log IP address / port of {in,out}going PDUs

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37962?usp=email ) Change subject: pfcp_peer: log IP address / port of {in,out}going PDUs ...................................................................... pfcp_peer: log IP address / port of {in,out}going PDUs Change-Id: I254853532d438440152e0d7cb3e0fe78ab75a98f --- M src/pfcp_peer.erl 1 file changed, 12 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/pfcp_peer.erl b/src/pfcp_peer.erl index 86d42d3..b190f12 100644 --- a/src/pfcp_peer.erl +++ b/src/pfcp_peer.erl @@ -167,9 +167,9 @@ {repeat_state, S}; %% Handle incoming PFCP PDU(s) -connecting(info, {udp, Sock, _FromIp, _FromPort, Data}, +connecting(info, {udp, Sock, FromIp, FromPort, Data}, #peer_state{sock = Sock} = S) -> - case decode_pdu(Data, S) of + case decode_pdu(Data, {FromIp, FromPort}, S) of #pfcp{type = association_setup_response, ie = #{pfcp_cause := 'Request accepted', recovery_time_stamp := #recovery_time_stamp{time = RRTS}}} -> @@ -213,9 +213,9 @@ {keep_state, S1, [{reply, From, Result}]}; %% Handle incoming PFCP PDU(s) -connected(info, {udp, Sock, _FromIp, _FromPort, Data}, +connected(info, {udp, Sock, FromIp, FromPort, Data}, #peer_state{sock = Sock} = S) -> - PDU = decode_pdu(Data, S), + PDU = decode_pdu(Data, {FromIp, FromPort}, S), route_pdu(PDU, S), {keep_state, S}; @@ -287,11 +287,13 @@ S#peer_state{registry = NReg}. --spec decode_pdu(binary(), peer_state()) -> pfcp_pdu(). -decode_pdu(Data, _S) -> - ?LOG_DEBUG("Rx encoded PFCP PDU: ~p", [Data]), +-spec decode_pdu(binary(), tuple(), peer_state()) -> pfcp_pdu(). +decode_pdu(Data, {FromIp, FromPort}, _S) -> + ?LOG_DEBUG("Rx encoded PFCP PDU from ~p:~p: ~p", + [Data, FromIp, FromPort]), PDU = pfcp_packet:decode(Data), - ?LOG_DEBUG("Rx PFCP PDU: ~p", [PDU]), + ?LOG_DEBUG("Rx PFCP PDU from ~p:~p: ~p", + [PDU, FromIp, FromPort]), %% TODO: check PDU#pfcp.seq_no %% TODO: there can be batched PDUs PDU. @@ -312,7 +314,8 @@ -spec send_data(binary(), peer_state()) -> ok | {error, term()}. send_data(Data, #peer_state{sock = Sock, rem_addr = RemAddr}) -> - ?LOG_DEBUG("Tx encoded PFCP PDU: ~p", [Data]), + ?LOG_DEBUG("Tx encoded PFCP PDU to ~p:~p: ~p", + [RemAddr, ?PFCP_PORT, Data]), gen_udp:send(Sock, RemAddr, ?PFCP_PORT, Data). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37962?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I254853532d438440152e0d7cb3e0fe78ab75a98f Gerrit-Change-Number: 37962 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[S] Change in ...osmo-s1gw[master]: pfcp_peer: implement the Heartbeat procedure

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37963?usp=email ) Change subject: pfcp_peer: implement the Heartbeat procedure ...................................................................... pfcp_peer: implement the Heartbeat procedure Change-Id: Ic4682d49f2e1df08d241500b7b4e75edadaeb91a --- M src/pfcp_peer.erl 1 file changed, 32 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/pfcp_peer.erl b/src/pfcp_peer.erl index b190f12..8c29a9f 100644 --- a/src/pfcp_peer.erl +++ b/src/pfcp_peer.erl @@ -169,7 +169,8 @@ %% Handle incoming PFCP PDU(s) connecting(info, {udp, Sock, FromIp, FromPort, Data}, #peer_state{sock = Sock} = S) -> - case decode_pdu(Data, {FromIp, FromPort}, S) of + PDU = decode_pdu(Data, {FromIp, FromPort}, S), + case PDU of #pfcp{type = association_setup_response, ie = #{pfcp_cause := 'Request accepted', recovery_time_stamp := #recovery_time_stamp{time = RRTS}}} -> @@ -180,7 +181,13 @@ ie = #{pfcp_cause := Cause}} -> ?LOG_ERROR("Rx Association Setup Response (~p)", [Cause]), {stop, {shutdown, assoc_setup_nack}}; - PDU -> + %% 3GPP TS 29.244, 6.2.2.2 Heartbeat Request + %% A CP function or UP function shall be prepared to receive a Heartbeat Request + %% at any time (even from unknown peers) and it shall reply with a Heartbeat Response. + #pfcp{type = heartbeat_request} -> + recv_heartbeat_request(PDU, {FromIp, FromPort}, S), + {keep_state, S}; + _ -> ?LOG_NOTICE("Rx unexpected PFCP PDU: ~p", [PDU]), {keep_state, S} end; @@ -216,7 +223,13 @@ connected(info, {udp, Sock, FromIp, FromPort, Data}, #peer_state{sock = Sock} = S) -> PDU = decode_pdu(Data, {FromIp, FromPort}, S), - route_pdu(PDU, S), + case PDU of + %% 3GPP TS 29.244, 6.2.2.2 Heartbeat Request + #pfcp{type = heartbeat_request} -> + recv_heartbeat_request(PDU, {FromIp, FromPort}, S); + _ -> + route_pdu(PDU, S) + end, {keep_state, S}; %% Catch-all handler for this state @@ -409,4 +422,20 @@ send_session_delete_req(SEID, S) -> send_pdu(SEID, {session_deletion_request, []}, S). + +%% 6.2.2 Heartbeat Procedure +%% 7.4.2 Heartbeat Messages +recv_heartbeat_request(#pfcp{type = heartbeat_request, + seq_no = SeqNr, + ie = ReqIEs}, + {FromIp, FromPort}, + #peer_state{loc_rts = LRTS} = S) -> + ?LOG_INFO("Rx Heartbeat Request from ~p:~p: ~p", [FromIp, FromPort, ReqIEs]), + RspIEs = #{recovery_time_stamp => #recovery_time_stamp{time = LRTS}}, + %% Fake #peer_state to force the right destination and SeqNr + {Result, _} = send_pdu({heartbeat_response, RspIEs}, + S#peer_state{seq_nr = SeqNr, + rem_addr = FromIp}), + Result. + %% vim:set ts=4 sw=4 et: -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37963?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic4682d49f2e1df08d241500b7b4e75edadaeb91a Gerrit-Change-Number: 37963 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

9 months, 3 weeks

1
0
0 0

[XS] Change in ...osmo-s1gw[master]: pfcp_peer: do not route incoming PDUs without SEID

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37964?usp=email ) Change subject: pfcp_peer: do not route incoming PDUs without SEID ...................................................................... Patch Set 1: (1 comment) File src/pfcp_peer.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37964/comment/0f5888b2_1f88… : PS1, Line 233: ?LOG_NOTICE("Rx unexpected PFCP PDU: ~p", [PDU]) > this should likely also generate some kind of PFCP error message back to the peer? Acknowledged -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37964?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7d33ec4e883b217b2b4f65e4866d9365c32c753d Gerrit-Change-Number: 37964 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 04 Sep 2024 13:12:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

9 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024