September 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: Remove unused function gsm_bts_by_lac()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38079?usp=email ) Change subject: Remove unused function gsm_bts_by_lac() ...................................................................... Remove unused function gsm_bts_by_lac() Change-Id: I0b17699f15fdce7766e9ec6acf21b16ac0ab7151 --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/gsm_data.c 2 files changed, 0 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/79/38079/1 diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index 7e47f49..715e8c9 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -1093,8 +1093,6 @@ enum gsm_bts_type parse_btstype(const char *arg); const char *btstype2str(enum gsm_bts_type type); -struct gsm_bts *gsm_bts_by_lac(struct gsm_network *net, unsigned int lac, - struct gsm_bts *start_bts); extern void *tall_bsc_ctx; diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c index 814cd56..87e3893 100644 --- a/src/osmo-bsc/gsm_data.c +++ b/src/osmo-bsc/gsm_data.c @@ -59,30 +59,6 @@ ts->e1_link.e1_ts_ss = e1_ts_ss; } -/* Search for a BTS in the given Location Area; optionally start searching - * with start_bts (for continuing to search after the first result) */ -struct gsm_bts *gsm_bts_by_lac(struct gsm_network *net, unsigned int lac, - struct gsm_bts *start_bts) -{ - struct gsm_bts *bts; - int skip = 0; - - if (start_bts) - skip = 1; - - llist_for_each_entry(bts, &net->bts_list, list) { - if (skip) { - if (start_bts == bts) - skip = 0; - continue; - } - - if (lac == GSM_LAC_RESERVED_ALL_BTS || bts->location_area_code == lac) - return bts; - } - return NULL; -} - static const struct value_string bts_gprs_mode_names[] = { { BTS_GPRS_NONE, "none" }, { BTS_GPRS_GPRS, "gprs" }, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38079?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0b17699f15fdce7766e9ec6acf21b16ac0ab7151 Gerrit-Change-Number: 38079 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in pysim[master]: pySim.euicc: Add 'get_data sgp02_eid' in ADF.ECASD of M2M eUICC

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38048?usp=email ) Change subject: pySim.euicc: Add 'get_data sgp02_eid' in ADF.ECASD of M2M eUICC ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38048?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6cca6f75d268229244c90b3f1f88e26c89a2b4e0 Gerrit-Change-Number: 38048 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 10 Sep 2024 15:07:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: pySim.transport: Also trace card reset events in ApduTracer

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38055?usp=email ) Change subject: pySim.transport: Also trace card reset events in ApduTracer ...................................................................... Patch Set 1: (1 comment) File pySim/transport/__init__.py: https://gerrit.osmocom.org/c/pysim/+/38055/comment/cc9cb772_a6b80d7e?usp=em… : PS1, Line 126: def _reset_card(self): class DummySimLink(LinkBase) in pySim-trace.py still lacks this method. That is why the jenkins tests fail. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38055?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia46b65124520eb2b8015dfa3f0a135b497668b92 Gerrit-Change-Number: 38055 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 10 Sep 2024 14:59:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

9 months, 2 weeks

1
0
0 0

[XS] Change in pysim[master]: pySim.commands: use _checksw during get_data() method

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38047?usp=email ) Change subject: pySim.commands: use _checksw during get_data() method ...................................................................... Patch Set 3: Code-Review+2 (2 comments) Patchset: PS3: I have checked back the spec, the status word in the successful case is 9000, so everything looks correct. File pySim/commands.py: https://gerrit.osmocom.org/c/pysim/+/38047/comment/35250192_52cc1886?usp=em… : PS3, Line 798: data, sw = self.send_apdu_checksw('%02xca%04x00' % (cla, tag)) maybe put a spec ref on top of the method? Something like: GPC_SPE_034 11.3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic784bf0c30b22e5e83843aa6694e2706b4b2ac48 Gerrit-Change-Number: 38047 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 10 Sep 2024 14:50:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: Initial support for >256 BTS

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38052?usp=email ) Change subject: Initial support for >256 BTS ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Patchset: PS5: I added extra checks for PCUIF bts id > 256 in follow-up patches. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38052?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I607a68efeb5f4a50cce107d11d3c5126b7d8f81a Gerrit-Change-Number: 38052 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Sep 2024 14:31:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: Log unsupported PCUIF for bts > 255

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc/+/38078?usp=email ) Change subject: Log unsupported PCUIF for bts > 255 ...................................................................... Log unsupported PCUIF for bts > 255 Since the "struct gsm_pcu_if"->bts_nr is still uint8_t, that means only the first 256 configured BTS can properly make use of the PCUIF interface and hence have gprs support. This is not a major problem as long as the BTS connected to osmo-bsc are of type osmo-bts, since usually those use a BTS co-located osmo-pcu, hence on each one bts_nr=0. But if we wanted to run them with osmo-bsc PCU co-located, (eg rbs2000), then we'd need to extend the PCUIF interface. Related: OS#6565 Related: SYS#7062 Change-Id: If5a8cd94195422989de3daa04be7ffc858c0a8eb --- M src/osmo-bsc/pcu_sock.c 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/78/38078/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38078?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If5a8cd94195422989de3daa04be7ffc858c0a8eb Gerrit-Change-Number: 38078 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder

9 months, 2 weeks

1
0
0 0

[M] Change in osmo-bsc[master]: Initial support for >256 BTS

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38052?usp=email ) Change subject: Initial support for >256 BTS ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: I added extra checks for PCUIF bts id > 256 in follow-up patches. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38052?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I607a68efeb5f4a50cce107d11d3c5126b7d8f81a Gerrit-Change-Number: 38052 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 10 Sep 2024 14:25:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: rsl_rx_pchan_rqd(): Clean up code path

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38075?usp=email ) Change subject: rsl_rx_pchan_rqd(): Clean up code path ...................................................................... rsl_rx_pchan_rqd(): Clean up code path * Use early return to simplify code indentation * use LOG_BTS macro Change-Id: I052600d8c7b1e948947a9cd989c8ae80f3c23259 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 15 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/75/38075/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 9d922d0..42a164a 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -1946,26 +1946,27 @@ uint8_t is_11bit; struct gsm_time gsm_time; - /* Process rach request and forward contained information to PCU */ - if (rqd->ref.ra == 0x7F) { + /* Process rach request and forward contained information to PCU: */ + + if (rqd->ref.ra == 0x7F) { /* 11bit RACH */ is_11bit = 1; /* FIXME: Also handle 11 bit rach requests */ - LOGP(DRSL, LOGL_ERROR, "BTS %d eleven bit access burst not supported yet!\n", rqd->bts->nr); + LOG_BTS(rqd->bts, DRSL, LOGL_ERROR, "CHAN RQD 11bit access burst not supported yet!\n"); return -EINVAL; - } else { - is_11bit = 0; - rqd_ta = rqd->ta; - - gsm_time.t1 = rqd->ref.t1; - gsm_time.t2 = rqd->ref.t2; - gsm_time.t3 = rqd->ref.t3_low | (rqd->ref.t3_high << 3); - fn = gsm_gsmtime2fn(&gsm_time); - - LOG_BTS(rqd->bts, DRSL, LOGL_INFO, "CHAN RQD: fn(t1=%u,t3=%u,t2=%u) = %u\n", - gsm_time.t1, gsm_time.t3, gsm_time.t2, fn); } + is_11bit = 0; + rqd_ta = rqd->ta; + + gsm_time.t1 = rqd->ref.t1; + gsm_time.t2 = rqd->ref.t2; + gsm_time.t3 = rqd->ref.t3_low | (rqd->ref.t3_high << 3); + fn = gsm_gsmtime2fn(&gsm_time); + + LOG_BTS(rqd->bts, DRSL, LOGL_INFO, "CHAN RQD: fn(t1=%u,t3=%u,t2=%u) = %u\n", + gsm_time.t1, gsm_time.t3, gsm_time.t2, fn); + return pcu_tx_rach_ind(rqd->bts, rqd_ta, rqd->ref.ra, fn, is_11bit, GSM_L1_BURST_TYPE_ACCESS_0); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38075?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I052600d8c7b1e948947a9cd989c8ae80f3c23259 Gerrit-Change-Number: 38075 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: pcu_info_update(): Simplify code path with early return

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38077?usp=email ) Change subject: pcu_info_update(): Simplify code path with early return ...................................................................... pcu_info_update(): Simplify code path with early return This makes it easy to add more checks, like done in a follow-up patch. Change-Id: I694a0403e93af4435062f2b4534f84943007df87 --- M src/osmo-bsc/pcu_sock.c 1 file changed, 10 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/77/38077/1 diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index d4eee44..83513f6 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -363,15 +363,16 @@ /* Allow test to overwrite it */ __attribute__((weak)) void pcu_info_update(struct gsm_bts *bts) { - if (pcu_connected(bts->network)) { - if (bsc_co_located_pcu(bts)) { - /* In cases where the CCU is connected via an E1 line, we transmit the connection parameters for the - * PDCH before we announce the other BTS related parameters. */ - if (is_e1_bts(bts)) - pcu_tx_e1_ccu_ind(bts); - pcu_tx_info_ind(bts); - } - } + if (!pcu_connected(bts->network)) + return; + if (!bsc_co_located_pcu(bts)) + return; + + /* In cases where the CCU is connected via an E1 line, we transmit the connection parameters for the + * PDCH before we announce the other BTS related parameters. */ + if (is_e1_bts(bts)) + pcu_tx_e1_ccu_ind(bts); + pcu_tx_info_ind(bts); } static int pcu_tx_data_ind(struct gsm_bts_trx_ts *ts, uint8_t sapi, uint32_t fn, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38077?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I694a0403e93af4435062f2b4534f84943007df87 Gerrit-Change-Number: 38077 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[master]: pcu_tx_rach_ind(): Avoid forwarding chan_rqd to PCU if not expected

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38076?usp=email ) Change subject: pcu_tx_rach_ind(): Avoid forwarding chan_rqd to PCU if not expected ...................................................................... pcu_tx_rach_ind(): Avoid forwarding chan_rqd to PCU if not expected Change-Id: Ic12aa9842227b2d815bb91f8587c8b258d07f169 --- M src/osmo-bsc/pcu_sock.c 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/76/38076/1 diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index 7b1aeae..d4eee44 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -419,10 +419,15 @@ /* Bail if no PCU is connected */ if (!pcu_connected(bts->network)) { - LOG_BTS(bts, DRSL, LOGL_ERROR, "CHAN RQD(GPRS) but PCU not connected!\n"); + LOG_BTS(bts, DPCU, LOGL_ERROR, "CHAN RQD(GPRS) but PCU not connected!\n"); return -ENODEV; } + if (!bsc_co_located_pcu(bts)) { + LOG_BTS(bts, DPCU, LOGL_ERROR, "CHAN RQD(GPRS) on BTS whose PCU is not BSC-colocated!\n"); + return -EINVAL; + } + LOG_BTS(bts, DPCU, LOGL_INFO, "Sending RACH indication: qta=%d, ra=%d, " "fn=%d\n", qta, ra, fn); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38076?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic12aa9842227b2d815bb91f8587c8b258d07f169 Gerrit-Change-Number: 38076 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024