September 2024 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bsc[master]: bts: Make sure bts_location entries in bts->loc_list are freed

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc/+/38082?usp=email ) Change subject: bts: Make sure bts_location entries in bts->loc_list are freed ...................................................................... bts: Make sure bts_location entries in bts->loc_list are freed This went unnoticed because so far there's not clear way to free a BTS, eg. through VTY. Change-Id: I4de3d56a4f1f6bd1fe880b72cdd384c2398dabc9 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts.c M src/osmo-bsc/bts_ctrl.c 3 files changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/82/38082/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38082?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4de3d56a4f1f6bd1fe880b72cdd384c2398dabc9 Gerrit-Change-Number: 38082 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[master]: bts: Make sure bts_location entries in bts->loc_list are freed

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38082?usp=email ) Change subject: bts: Make sure bts_location entries in bts->loc_list are freed ...................................................................... bts: Make sure bts_location entries in bts->loc_list are freed This went unnoticed because so far there's not clear way to free a BTS, eg. through VTY. Change-Id: I4de3d56a4f1f6bd1fe880b72cdd384c2398dabc9 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts.c M src/osmo-bsc/bts_ctrl.c 3 files changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/82/38082/1 diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index a8680d8..38e675a 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -337,7 +337,7 @@ /* list header in net->bts_list */ struct llist_head list; - /* Geographical location of the BTS */ + /* Geographical location of the BTS, head list of "struct bts_location" */ struct llist_head loc_list; /* number of this BTS in network */ diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 260e24e..e3d909f 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -156,6 +156,9 @@ static int gsm_bts_talloc_destructor(struct gsm_bts *bts) { + + /* Entries in bts->loc_list are freed by talloc recursively, no need to free them here. */ + paging_destructor(bts); bts_setup_ramp_remove(bts); diff --git a/src/osmo-bsc/bts_ctrl.c b/src/osmo-bsc/bts_ctrl.c index 48b1b8a..76806f4 100644 --- a/src/osmo-bsc/bts_ctrl.c +++ b/src/osmo-bsc/bts_ctrl.c @@ -169,7 +169,7 @@ return CTRL_CMD_ERROR; } - curloc = talloc_zero(tall_bsc_ctx, struct bts_location); + curloc = talloc_zero(bts, struct bts_location); if (!curloc) { talloc_free(tmp); goto oom; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38082?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4de3d56a4f1f6bd1fe880b72cdd384c2398dabc9 Gerrit-Change-Number: 38082 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: Clarify code around bts->loc_list

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38081?usp=email ) Change subject: Clarify code around bts->loc_list ...................................................................... Clarify code around bts->loc_list In set_bts_loc(): * Comment stating the entry was appended to the list was wrong. * location_equal() could be called with lastloc containing poisoned pointers (INIT_LLIST_HEAD), which is not that nice. Change-Id: I5b706dfd3a96f5e9b61907a727ef5887338e66c6 --- M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/bts_ctrl.c 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/81/38081/1 diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index aa31505..777807b 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -3289,12 +3289,12 @@ char timestr[50]; llist_for_each_entry(bts, &bsc_gsmnet->bts_list, list) { - if (llist_empty(&bts->loc_list)) { + curloc = llist_first_entry_or_null(&bts->loc_list, struct bts_location, list); + if (!curloc) { vty_out(vty, "BTS Nr: %d position invalid%s", bts->nr, VTY_NEWLINE); continue; } - curloc = llist_entry(bts->loc_list.next, struct bts_location, list); if (gmtime_r(&curloc->tstamp, &time) == NULL) { vty_out(vty, "Time conversion failed for BTS %d%s", bts->nr, VTY_NEWLINE); diff --git a/src/osmo-bsc/bts_ctrl.c b/src/osmo-bsc/bts_ctrl.c index f10ba29..48b1b8a 100644 --- a/src/osmo-bsc/bts_ctrl.c +++ b/src/osmo-bsc/bts_ctrl.c @@ -128,7 +128,7 @@ return CTRL_CMD_REPLY; } - curloc = llist_entry(bts->loc_list.next, struct bts_location, list); + curloc = llist_first_entry(&bts->loc_list, struct bts_location, list); cmd->reply = talloc_asprintf(cmd, "%lu,%s,%f,%f,%f", curloc->tstamp, get_value_string(bts_loc_fix_names, curloc->valid), curloc->lat, curloc->lon, curloc->height); @@ -183,14 +183,14 @@ curloc->height = atof(height); talloc_free(tmp); - lastloc = llist_entry(bts->loc_list.next, struct bts_location, list); + lastloc = llist_first_entry_or_null(&bts->loc_list, struct bts_location, list); - /* Add location to the end of the list */ + /* Add location to the start of the list */ llist_add(&curloc->list, &bts->loc_list); ret = get_bts_loc(cmd, data); - if (!location_equal(curloc, lastloc)) + if (!lastloc || !location_equal(curloc, lastloc)) bsc_gen_location_state_trap(bts); cleanup_locations(&bts->loc_list); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38081?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5b706dfd3a96f5e9b61907a727ef5887338e66c6 Gerrit-Change-Number: 38081 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[master]: pcu_tx_rach_ind(): Avoid forwarding chan_rqd to PCU if not expected

by pespin

Attention is currently required from: dexter, fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38076?usp=email ) Change subject: pcu_tx_rach_ind(): Avoid forwarding chan_rqd to PCU if not expected ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/38076/comment/084ba99a_5758962d?usp… : PS1, Line 426: bsc_co_located_pcu > Shouldn't this check be done in a common place like `pcu_sock_send()`? That's too late, since you don't have bts information there, only the uint8_t bts_nr which is already malfunctioning. I think in here it's fine. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38076?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic12aa9842227b2d815bb91f8587c8b258d07f169 Gerrit-Change-Number: 38076 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Sep 2024 15:43:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[master]: bsc_vty: Use gsm_bts_num() in ho_or_as()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38080?usp=email ) Change subject: bsc_vty: Use gsm_bts_num() in ho_or_as() ...................................................................... bsc_vty: Use gsm_bts_num() in ho_or_as() Change-Id: I49856a417a2be3a10c3bdf2553c52064f875ef94 --- M src/osmo-bsc/bsc_vty.c 1 file changed, 1 insertion(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/80/38080/1 diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index f04c7ec..aa31505 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -833,7 +833,6 @@ { struct gsm_network *net = gsmnet_from_vty(vty); struct gsm_subscriber_connection *conn; - struct gsm_bts *bts; struct gsm_bts *new_bts = NULL; unsigned int bts_nr = atoi(argv[0]); unsigned int trx_nr = atoi(argv[1]); @@ -845,12 +844,7 @@ unsigned int bts_nr_new = atoi(argv[4]); /* Lookup the BTS where we want to handover to */ - llist_for_each_entry(bts, &net->bts_list, list) { - if (bts->nr == bts_nr_new) { - new_bts = bts; - break; - } - } + new_bts = gsm_bts_num(net, bts_nr_new); if (!new_bts) { vty_out(vty, "%% Unable to trigger handover, specified bts #%u does not exist %s", -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38080?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I49856a417a2be3a10c3bdf2553c52064f875ef94 Gerrit-Change-Number: 38080 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: Remove unused function gsm_bts_by_lac()

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38079?usp=email ) Change subject: Remove unused function gsm_bts_by_lac() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38079?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I0b17699f15fdce7766e9ec6acf21b16ac0ab7151 Gerrit-Change-Number: 38079 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Sep 2024 15:31:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: Log unsupported PCUIF for bts > 255

by fixeria

Attention is currently required from: dexter, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38078?usp=email ) Change subject: Log unsupported PCUIF for bts > 255 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38078?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If5a8cd94195422989de3daa04be7ffc858c0a8eb Gerrit-Change-Number: 38078 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Sep 2024 15:31:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: pcu_info_update(): Simplify code path with early return

by fixeria

Attention is currently required from: dexter, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38077?usp=email ) Change subject: pcu_info_update(): Simplify code path with early return ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38077?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I694a0403e93af4435062f2b4534f84943007df87 Gerrit-Change-Number: 38077 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Sep 2024 15:25:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[XS] Change in osmo-bsc[master]: pcu_tx_rach_ind(): Avoid forwarding chan_rqd to PCU if not expected

by fixeria

Attention is currently required from: dexter, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38076?usp=email ) Change subject: pcu_tx_rach_ind(): Avoid forwarding chan_rqd to PCU if not expected ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/38076/comment/a8c73166_bd160d76?usp… : PS1, Line 426: bsc_co_located_pcu Shouldn't this check be done in a common place like `pcu_sock_send()`? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38076?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic12aa9842227b2d815bb91f8587c8b258d07f169 Gerrit-Change-Number: 38076 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Sep 2024 15:24:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: rsl_rx_pchan_rqd(): Clean up code path

by fixeria

Attention is currently required from: dexter, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/38075?usp=email ) Change subject: rsl_rx_pchan_rqd(): Clean up code path ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/38075?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I052600d8c7b1e948947a9cd989c8ae80f3c23259 Gerrit-Change-Number: 38075 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Sep 2024 15:23:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

9 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024