September 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: library/s1ap: comment out optional IE in tr_S1AP_InitialCtxSetupResp

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277?usp=email ) Change subject: library/s1ap: comment out optional IE in tr_S1AP_InitialCtxSetupResp ...................................................................... library/s1ap: comment out optional IE in tr_S1AP_InitialCtxSetupResp Change-Id: I4765036be69ff10adb8c510d4092834c4e923229 --- M library/s1ap/S1AP_Templates.ttcn 1 file changed, 9 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/library/s1ap/S1AP_Templates.ttcn b/library/s1ap/S1AP_Templates.ttcn index 0079649..5425fb1 100644 --- a/library/s1ap/S1AP_Templates.ttcn +++ b/library/s1ap/S1AP_Templates.ttcn @@ -710,7 +710,7 @@ ts_S1AP_InitialCtxSetupResp(template (value) MME_UE_S1AP_ID mme_id, template (value) ENB_UE_S1AP_ID enb_id, template (value) E_RABSetupListCtxtSURes rab_setup_items - /*OPTIONAL: template (value) E_RABList rab_items */ + /* OPTIONAL: template (omit) E_RABList rab_failed_items */ ) := { successfulOutcome := { procedureCode := id_InitialContextSetup, @@ -734,7 +734,7 @@ /*, { id := S1AP_Constants.id_E_RABFailedToSetupListCtxtSURes, criticality := ignore, - value_ := {E_RABList := rab_items} + value_ := {E_RABList := rab_failed_items} }*/ } } @@ -744,8 +744,9 @@ template (present) S1AP_PDU tr_S1AP_InitialCtxSetupResp(template (present) MME_UE_S1AP_ID mme_id := ?, template (present) ENB_UE_S1AP_ID enb_id := ?, - template (present) E_RABSetupListCtxtSURes rab_setup_items := ?, - template (present) E_RABList rab_items := ?) := { + template (present) E_RABSetupListCtxtSURes rab_setup_items := ? + /* OPTIONAL: template E_RABList rab_failed_items := * */ + ) := { successfulOutcome := { procedureCode := id_InitialContextSetup, criticality := reject, @@ -764,11 +765,13 @@ id := S1AP_Constants.id_E_RABSetupListCtxtSURes, criticality := ignore, value_ := {E_RABSetupListCtxtSURes := rab_setup_items} - }, { + }, + /*, { id := S1AP_Constants.id_E_RABFailedToSetupListCtxtSURes, criticality := ignore, value_ := {E_RABList := rab_items} - }, * + }, */ + * } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4765036be69ff10adb8c510d4092834c4e923229 Gerrit-Change-Number: 38277 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

10 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/pfcp: make Cause IE configurable in all templates

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38307?usp=email ) Change subject: library/pfcp: make Cause IE configurable in all templates ...................................................................... library/pfcp: make Cause IE configurable in all templates Change-Id: I76e52d3450cca87f5fead0f834fa58ce4902ddd8 --- M library/PFCP_Templates.ttcn 1 file changed, 22 insertions(+), 8 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/library/PFCP_Templates.ttcn b/library/PFCP_Templates.ttcn index 9635c4d..0726fd2 100644 --- a/library/PFCP_Templates.ttcn +++ b/library/PFCP_Templates.ttcn @@ -794,14 +794,15 @@ template (value) Node_ID node_id, template (value) OCT8 seid, template (value) F_SEID f_seid, - template (value) PFCP_Session_Establishment_Response.created_PDR_list created_pdr) + template (value) PFCP_Session_Establishment_Response.created_PDR_list created_pdr, + template (value) Cause cause := ts_PFCP_Cause(REQUEST_ACCEPTED)) modifies ts_PDU_PFCP_ := { seid := seid, sequence_number := seq_nr, message_body := { pfcp_session_establishment_response := { node_id := node_id, - cause := ts_PFCP_Cause(REQUEST_ACCEPTED), + cause := cause, offending_ie := omit, UP_F_SEID := f_seid, created_PDR_list := created_pdr, @@ -818,14 +819,15 @@ template (present) Node_ID node_id := ?, template (present) OCT8 seid := ?, template (present) F_SEID f_seid := ?, - template (present) PFCP_Session_Establishment_Response.created_PDR_list created_pdr := ?) + template (present) PFCP_Session_Establishment_Response.created_PDR_list created_pdr := ?, + template (present) Cause cause := tr_PFCP_Cause(REQUEST_ACCEPTED)) modifies tr_PDU_PFCP_ := { seid := seid, sequence_number := ?, message_body := { pfcp_session_establishment_response := { node_id := node_id, - cause := tr_PFCP_Cause(REQUEST_ACCEPTED), + cause := cause, offending_ie := *, UP_F_SEID := ?, created_PDR_list := created_pdr, @@ -911,13 +913,14 @@ /* 7.5.5 PFCP Session Modification Response */ template (value) PDU_PFCP ts_PFCP_Session_Mod_Resp(template (value) LIN3_BO_LAST seq_nr, - template (value) OCT8 seid) + template (value) OCT8 seid, + template (value) Cause cause := ts_PFCP_Cause(REQUEST_ACCEPTED)) modifies ts_PDU_PFCP_ := { seid := seid, sequence_number := seq_nr, message_body := { pfcp_session_modification_response := { - cause := ts_PFCP_Cause(REQUEST_ACCEPTED), + cause := cause, offending_IE := omit, created_PDR := omit, load_control_information := omit, @@ -930,11 +933,22 @@ } } template (present) PDU_PFCP -tr_PFCP_Session_Mod_Resp(template (present) OCT8 seid := ?) +tr_PFCP_Session_Mod_Resp(template (present) OCT8 seid := ?, + template (present) Cause cause := tr_PFCP_Cause(REQUEST_ACCEPTED)) modifies tr_PDU_PFCP_ := { seid := seid, message_body := { - pfcp_session_modification_response := ? + pfcp_session_modification_response := { + cause := cause, + offending_IE := *, + created_PDR := *, + load_control_information := *, + overload_control_information := *, + usage_report := *, + failed_rule_id := *, + additional_usage_reports_information := *, + created_updated_traffic_endpoint := * + } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38307?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I76e52d3450cca87f5fead0f834fa58ce4902ddd8 Gerrit-Change-Number: 38307 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

10 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: s1gw: TC_e_rab_setup: complete E-RAB release

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38238?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: s1gw: TC_e_rab_setup: complete E-RAB release ...................................................................... s1gw: TC_e_rab_setup: complete E-RAB release The MME originated E-RAB RELEASE procedure includes both: * [ENB <- MME] E-RAB RELEASE COMMAND, and * [ENB -> MME] E-RAB RELEASE RESPONSE. The later was overlooked in a99224c9, so add it. Change-Id: I856248d825b6ecf0635590b7bf02593cfae893d3 Fixes: a99224c9 "s1gw: TC_e_rab_setup: also test E-RAB release" --- M s1gw/S1GW_ConnHdlr.ttcn M s1gw/S1GW_Tests.ttcn 2 files changed, 43 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index a3d2aec..4c88252 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -445,6 +445,40 @@ return pdu; } +function f_ConnHdlr_tx_erab_release_rsp(in ERabList erabs, + MME_UE_S1AP_ID mme_ue_id := c_MME_UE_ID) +runs on ConnHdlr { + var template (value) E_RABReleaseListBearerRelComp items; + var ENB_UE_S1AP_ID enb_ue_id := g_pars.idx; + + for (var integer i := 0; i < lengthof(erabs); i := i + 1) { + var template (value) E_RABReleaseItemBearerRelComp item; + + item := ts_E_RABReleaseItemBearerRelComp(erabs[i].erab_id); + items[i] := ts_E_RABReleaseListBearerRelComp(item)[0]; + } + + f_ConnHdlr_tx_s1ap_from_enb(ts_S1AP_RABReleaseRsp(mme_ue_id, enb_ue_id, items)); +} + +function f_ConnHdlr_rx_erab_release_rsp(in ERabList erabs, + MME_UE_S1AP_ID mme_ue_id := c_MME_UE_ID) +runs on ConnHdlr return S1AP_PDU { + var template (present) E_RABReleaseListBearerRelComp items; + var ENB_UE_S1AP_ID enb_ue_id := g_pars.idx; + var S1AP_PDU pdu; + + for (var integer i := 0; i < lengthof(erabs); i := i + 1) { + var template (present) E_RABReleaseItemBearerRelComp item; + + item := tr_E_RABReleaseItemBearerRelComp(erabs[i].erab_id); + items[i] := tr_E_RABReleaseListBearerRelComp(item)[0]; + } + + f_ConnHdlr_rx_s1ap_from_enb(pdu, tr_S1AP_RABReleaseRsp(mme_ue_id, enb_ue_id, items)); + return pdu; +} + function f_ConnHdlr_tx_erab_release_ind(in ERabList erabs, S1AP_IEs.Cause cause := c_REL_CMD_CAUSE, MME_UE_S1AP_ID mme_ue_id := c_MME_UE_ID) @@ -663,6 +697,14 @@ f_ConnHdlr_rx_erab_release_cmd(erabs, cause); } +function f_ConnHdlr_erab_release_rsp(inout ERabList erabs) +runs on ConnHdlr { + log("[eNB -> S1GW] -> MME: E-RAB RELEASE RESPONSE"); + f_ConnHdlr_tx_erab_release_rsp(erabs); + log("eNB -> [S1GW -> MME]: E-RAB RELEASE RESPONSE"); + f_ConnHdlr_rx_erab_release_rsp(erabs); +} + function f_ConnHdlr_erab_release_ind(inout ERabList erabs, S1AP_IEs.Cause cause := c_REL_CMD_CAUSE) runs on ConnHdlr { diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn index 8a259d3..9713c1a 100644 --- a/s1gw/S1GW_Tests.ttcn +++ b/s1gw/S1GW_Tests.ttcn @@ -308,6 +308,7 @@ f_ConnHdlr_erab_setup_req(g_pars.erabs); f_ConnHdlr_erab_setup_rsp(g_pars.erabs); f_ConnHdlr_erab_release_cmd(g_pars.erabs); + f_ConnHdlr_erab_release_rsp(g_pars.erabs); f_ConnHdlr_s1ap_disconnect(); f_ConnHdlr_s1ap_unregister(g_pars.genb_id); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38238?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I856248d825b6ecf0635590b7bf02593cfae893d3 Gerrit-Change-Number: 38238 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

10 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: separate f_ConnHdlr_session_{establish,modify}()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38278?usp=email ) Change subject: s1gw: separate f_ConnHdlr_session_{establish,modify}() ...................................................................... s1gw: separate f_ConnHdlr_session_{establish,modify}() Change-Id: I95dc3be975a8f51f7535b96d1580ef70b85fa2e0 --- M s1gw/S1GW_ConnHdlr.ttcn 1 file changed, 38 insertions(+), 28 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index 4c88252..97df4c0 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -624,6 +624,42 @@ PFCP.send(resp); } +function f_ConnHdlr_session_establish(inout ERabList erabs) +runs on ConnHdlr { + for (var integer i := 0; i < lengthof(erabs); i := i + 1) { + log("UPF <- S1GW: PFCP Session Establishment Request for E-RAB ID ", erabs[i].erab_id); + var PDU_PFCP pdu := f_ConnHdlr_rx_session_establish_req(erabs[i]); + /* store peer's SEID, so that it can be used in outgoing PDUs later */ + erabs[i].pfcp_rem_seid := pdu.message_body.pfcp_session_establishment_request.CP_F_SEID.seid; + /* ask PFCPEM to route PDUs with the local SEID to us */ + f_PFCPEM_subscribe_seid(erabs[i].pfcp_loc_seid); + log("UPF -> S1GW: PFCP Session Establishment Response for E-RAB ID ", erabs[i].erab_id); + f_ConnHdlr_tx_session_establish_resp(erabs[i], pdu); + } +} + +function f_ConnHdlr_session_modify(in ERabList erabs) +runs on ConnHdlr { + for (var integer i := 0; i < lengthof(erabs); i := i + 1) { + log("UPF <- S1GW: PFCP Session Modification Request for E-RAB ID ", erabs[i].erab_id); + var PDU_PFCP pdu := f_ConnHdlr_rx_session_modify_req(erabs[i]); + log("UPF -> S1GW: PFCP Session Modification Response for E-RAB ID ", erabs[i].erab_id); + f_ConnHdlr_tx_session_modify_resp(erabs[i], pdu); + } +} + +function f_ConnHdlr_session_delete(in ERabList erabs) +runs on ConnHdlr { + for (var integer i := 0; i < lengthof(erabs); i := i + 1) { + log("UPF <- S1GW: PFCP Session Deletion Request for E-RAB ID ", erabs[i].erab_id); + var PDU_PFCP pdu := f_ConnHdlr_rx_session_delete_req(erabs[i]); + log("UPF -> S1GW: PFCP Session Deletion Response for E-RAB ID ", erabs[i].erab_id); + f_ConnHdlr_tx_session_delete_resp(erabs[i], pdu); + /* ask PFCPEM to *not* route PDUs with this SEID to us */ + f_PFCPEM_unsubscribe_seid(erabs[i].pfcp_loc_seid); + } +} + function f_ConnHdlr_erab_setup_req(inout ERabList erabs) runs on ConnHdlr { const OCT8 c_SEID0 := '0000000000000000'O; @@ -640,16 +676,7 @@ log("eNB <- [S1GW <- MME]: E-RAB SETUP REQUEST"); f_ConnHdlr_tx_erab_setup_req(erabs); - for (var integer i := 0; i < lengthof(erabs); i := i + 1) { - log("UPF <- S1GW: PFCP Session Establishment Request for E-RAB ID ", erabs[i].erab_id); - var PDU_PFCP pdu := f_ConnHdlr_rx_session_establish_req(erabs[i]); - /* store peer's SEID, so that it can be used in outgoing PDUs later */ - erabs[i].pfcp_rem_seid := pdu.message_body.pfcp_session_establishment_request.CP_F_SEID.seid; - /* ask PFCPEM to route PDUs with the local SEID to us */ - f_PFCPEM_subscribe_seid(erabs[i].pfcp_loc_seid); - log("UPF -> S1GW: PFCP Session Establishment Response for E-RAB ID ", erabs[i].erab_id); - f_ConnHdlr_tx_session_establish_resp(erabs[i], pdu); - } + f_ConnHdlr_session_establish(erabs); /* We're done establishing PFCP sessions, so at this point we no longer expect to * receive Session Establishment Request PDUs with SEID=0. Unregister and unlock @@ -665,28 +692,11 @@ runs on ConnHdlr { log("[eNB -> S1GW] -> MME: E-RAB SETUP RESPONSE"); f_ConnHdlr_tx_erab_setup_rsp(erabs); - for (var integer i := 0; i < lengthof(erabs); i := i + 1) { - log("UPF <- S1GW: PFCP Session Modification Request for E-RAB ID ", erabs[i].erab_id); - var PDU_PFCP pdu := f_ConnHdlr_rx_session_modify_req(erabs[i]); - log("UPF -> S1GW: PFCP Session Modification Response for E-RAB ID ", erabs[i].erab_id); - f_ConnHdlr_tx_session_modify_resp(erabs[i], pdu); - } + f_ConnHdlr_session_modify(erabs); log("eNB -> [S1GW -> MME]: E-RAB SETUP RESPONSE"); f_ConnHdlr_rx_erab_setup_rsp(erabs); } -private function f_ConnHdlr_session_delete(inout ERabList erabs) -runs on ConnHdlr { - for (var integer i := 0; i < lengthof(erabs); i := i + 1) { - log("UPF <- S1GW: PFCP Session Deletion Request for E-RAB ID ", erabs[i].erab_id); - var PDU_PFCP pdu := f_ConnHdlr_rx_session_delete_req(erabs[i]); - log("UPF -> S1GW: PFCP Session Deletion Response for E-RAB ID ", erabs[i].erab_id); - f_ConnHdlr_tx_session_delete_resp(erabs[i], pdu); - /* ask PFCPEM to *not* route PDUs with this SEID to us */ - f_PFCPEM_unsubscribe_seid(erabs[i].pfcp_loc_seid); - } -} - function f_ConnHdlr_erab_release_cmd(inout ERabList erabs, S1AP_IEs.Cause cause := c_REL_CMD_CAUSE) runs on ConnHdlr { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38278?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I95dc3be975a8f51f7535b96d1580ef70b85fa2e0 Gerrit-Change-Number: 38278 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

10 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: add testcases for INITIAL CONTEXT SETUP

by fixeria

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38279?usp=email ) Change subject: s1gw: add testcases for INITIAL CONTEXT SETUP ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38279?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I72e3ab932fee1de0fce8ddf4041b8f2174416bc1 Gerrit-Change-Number: 38279 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Sep 2024 11:44:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: separate f_ConnHdlr_session_{establish,modify}()

by fixeria

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38278?usp=email ) Change subject: s1gw: separate f_ConnHdlr_session_{establish,modify}() ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38278?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I95dc3be975a8f51f7535b96d1580ef70b85fa2e0 Gerrit-Change-Number: 38278 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Sep 2024 11:44:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/pfcp: make Cause IE configurable in all templates

by fixeria

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38307?usp=email ) Change subject: library/pfcp: make Cause IE configurable in all templates ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38307?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I76e52d3450cca87f5fead0f834fa58ce4902ddd8 Gerrit-Change-Number: 38307 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Sep 2024 11:44:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 2 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: library/pfcp: fix template restriction in PFCP_Session_Est_Resp

by fixeria

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38306?usp=email ) Change subject: library/pfcp: fix template restriction in PFCP_Session_Est_Resp ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38306?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icf070443ffb7cfff84559db40459d0e9629ad024 Gerrit-Change-Number: 38306 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Sep 2024 11:43:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: library/s1ap: comment out optional IE in tr_S1AP_InitialCtxSetupResp

by fixeria

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277?usp=email ) Change subject: library/s1ap: comment out optional IE in tr_S1AP_InitialCtxSetupResp ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4765036be69ff10adb8c510d4092834c4e923229 Gerrit-Change-Number: 38277 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Sep 2024 11:43:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

10 months, 2 weeks

1
0
0 0

[S] Change in osmo-msc[master]: Create transaction for all call indepenant SS messages

by fixeria

Attention is currently required from: jolly, neels. fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-msc/+/38305?usp=email ) Change subject: Create transaction for all call indepenant SS messages ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/38305/comment/4020c417_9d288750?usp… : PS1, Line 14: This patch ensures that a transaction is created even if the message : is not a REGISTER message I am fine with this approach in general, however it does not solve the problem globally. We have another early return code path when `trans_alloc()` returns `NULL`, for instance, and the connection would be kept alive for 5 seconds in that case. I know it's unlikely that `trans_alloc()` (actually the internal `malloc()` call) returns `NULL` on modern Linux systems, but it's just to illustrate that you're fixing only a very specific scenario here. IMO, a more generic approach would be to call `msc_a_release_cn()` as was suggested by Neels in https://osmocom.org/issues/6426#note-5. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38305?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic6765e5d480735e67d97f0f560da24653b26d487 Gerrit-Change-Number: 38305 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Sep 2024 11:43:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

10 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2024