July 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ttcn3-hacks[master]: eIM_Tests: Use real notificationAddress in ProfileINstallationResultData

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37495?usp=email ) Change subject: eIM_Tests: Use real notificationAddress in ProfileINstallationResultData ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37495?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I337ef32a424875ca9d9be178ae96f1a76383dd38 Gerrit-Change-Number: 37495 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 15 Jul 2024 14:53:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: eIM_Tests: Use real notificationAddress in ProfileINstallationResultData

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37495?usp=email ) Change subject: eIM_Tests: Use real notificationAddress in ProfileINstallationResultData ...................................................................... eIM_Tests: Use real notificationAddress in ProfileINstallationResultData The ProfileInstallationResultData currently contains a dummy address as notificationAddress. This means that the eIM may try to send the ProfileInstallationResultData to that dummy address instead to the testsuite. To prevent this, let's use the actual address as notificationAddress Related: SYS#6824 Change-Id: I337ef32a424875ca9d9be178ae96f1a76383dd38 --- M eim/eIM_Tests.ttcn M library/euicc/RSPDefinitions_Templates.ttcn M library/euicc/SGP32Definitions_Templates.ttcn 3 files changed, 26 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/95/37495/1 diff --git a/eim/eIM_Tests.ttcn b/eim/eIM_Tests.ttcn index 7930e4f..da5d571 100644 --- a/eim/eIM_Tests.ttcn +++ b/eim/eIM_Tests.ttcn @@ -468,7 +468,8 @@ private function f_TC_proc_indirect_prfle_dwnld(charstring id) runs on eIM_ConnHdlr { var charstring resource_id; var HTTP_Adapter_Params http_adapter_pars; - var charstring activationCode := "1$" & mp_es9p_ip & ":" & int2str(mp_es9p_port) & "$MyMatchingId" + var charstring smdpp_add := mp_es9p_ip & ":" & int2str(mp_es9p_port) + var charstring activationCode := "1$" & smdpp_add & "$MyMatchingId" f_http_register(); @@ -496,7 +497,7 @@ f_esipa_receive(tr_getBoundProfilePackageResponseEsipa); /* Handle notification */ - f_esipa_send(valueof(ts_handleNotificationEsipa_prfleInstRslt)); + f_esipa_send(valueof(ts_handleNotificationEsipa_prfleInstRslt(notificationAddress := smdpp_add))); f_es9p_transceive_empty_response(tr_handleNotification); f_rest_lookup_resource(resource_id, "download", tr_JSON_REST_success); diff --git a/library/euicc/RSPDefinitions_Templates.ttcn b/library/euicc/RSPDefinitions_Templates.ttcn index 4791cf5..ebc2490 100644 --- a/library/euicc/RSPDefinitions_Templates.ttcn +++ b/library/euicc/RSPDefinitions_Templates.ttcn @@ -211,24 +211,24 @@ /* GSMA SGP.22, section 2.5.6 */ template (present) ProfileInstallationResultData -tr_profileInstallationResultData := { +tr_profileInstallationResultData(template (present) charstring notificationAddress := ?) := { transactionId := ?, notificationMetadata := { seqNumber := ?, profileManagementOperation := ?, - notificationAddress := ?, + notificationAddress := notificationAddress, iccid := * }, smdpOid := ?, finalResult := ? } template (value) ProfileInstallationResultData -ts_profileInstallationResultData := { +ts_profileInstallationResultData(template (value) charstring notificationAddress := "smdp.example.com") := { transactionId := 'AABBCC'O, notificationMetadata := { seqNumber := 1234, profileManagementOperation := '01'B, /* is this correct? (notificationInstall) */ - notificationAddress := "smdp.example.com", + notificationAddress := notificationAddress, iccid := '123456789ABCDEFFAAAA'O }, smdpOid := id_rsp, /* random OBJECT IDENTIFIER for testing */ diff --git a/library/euicc/SGP32Definitions_Templates.ttcn b/library/euicc/SGP32Definitions_Templates.ttcn index d602d8e..fa21cd4 100644 --- a/library/euicc/SGP32Definitions_Templates.ttcn +++ b/library/euicc/SGP32Definitions_Templates.ttcn @@ -684,7 +684,7 @@ /* GSMA SGP.32, section 6.3.2.4 */ template (present) EsipaMessageFromIpaToEim -tr_handleNotificationEsipa_prfleInstRslt := { +tr_handleNotificationEsipa_prfleInstRslt(template (present) charstring notificationAddress := ?) := { handleNotificationEsipa := { pendingNotification := { profileInstallationResult := { @@ -695,11 +695,11 @@ } } template (value) EsipaMessageFromIpaToEim -ts_handleNotificationEsipa_prfleInstRslt := { +ts_handleNotificationEsipa_prfleInstRslt(template (value) charstring notificationAddress := "smdp.example.com") := { handleNotificationEsipa := { pendingNotification := { profileInstallationResult := { - profileInstallationResultData := ts_profileInstallationResultData, + profileInstallationResultData := ts_profileInstallationResultData(notificationAddress), euiccSignPIR := '5252525252525252525252525252525252525252525252525252525252525252 5353535353535353535353535353535353535353535353535353535353535353'O } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37495?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I337ef32a424875ca9d9be178ae96f1a76383dd38 Gerrit-Change-Number: 37495 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-asterisk: extensions.conf: Reject calls if all SIP UAs busy in ...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/37494?usp=email ) Change subject: ttcn3-asterisk: extensions.conf: Reject calls if all SIP UAs busy in call ...................................................................... ttcn3-asterisk: extensions.conf: Reject calls if all SIP UAs busy in call Before this patch, asterisk would ring on local SIP UAs already in a call, which is not the expected behavior for this project. Related: SYS#7003 Change-Id: Id9e3ead6e28a53793c6cceb6f23d5e6d987521d8 --- M ttcn3-asterisk-ims-ue-test/asterisk/extensions.conf 1 file changed, 22 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/94/37494/1 diff --git a/ttcn3-asterisk-ims-ue-test/asterisk/extensions.conf b/ttcn3-asterisk-ims-ue-test/asterisk/extensions.conf index 5688153..e02152f 100644 --- a/ttcn3-asterisk-ims-ue-test/asterisk/extensions.conf +++ b/ttcn3-asterisk-ims-ue-test/asterisk/extensions.conf @@ -6,15 +6,15 @@ same => n,Set(ENDPOINT_2_STATE=${DEVICE_STATE(PJSIP/0502)}) same => n,Set(ENDPOINT_3_STATE=${DEVICE_STATE(PJSIP/0503)}) same => n,Set(ENDPOINT_4_STATE=${DEVICE_STATE(PJSIP/0504)}) - same => n,Set(ENDPOINT_1_EXPR=$[$["${ENDPOINT_1_STATE}" = "UNAVAILABLE"] | $["${ENDPOINT_1_STATE}" = "UNKNOWN"] | $["${ENDPOINT_1_STATE}" = "INVALID"]]) - same => n,Set(ENDPOINT_2_EXPR=$[$["${ENDPOINT_2_STATE}" = "UNAVAILABLE"] | $["${ENDPOINT_2_STATE}" = "UNKNOWN"] | $["${ENDPOINT_2_STATE}" = "INVALID"]]) - same => n,Set(ENDPOINT_3_EXPR=$[$["${ENDPOINT_3_STATE}" = "UNAVAILABLE"] | $["${ENDPOINT_3_STATE}" = "UNKNOWN"] | $["${ENDPOINT_3_STATE}" = "INVALID"]]) - same => n,Set(ENDPOINT_4_EXPR=$[$["${ENDPOINT_4_STATE}" = "UNAVAILABLE"] | $["${ENDPOINT_4_STATE}" = "UNKNOWN"] | $["${ENDPOINT_4_STATE}" = "INVALID"]]) + same => n,Set(ENDPOINT_1_EXPR=$[$["${ENDPOINT_1_STATE}" = "NOT_INUSE"] | $["${ENDPOINT_1_STATE}" = "ONHOLD"]]) + same => n,Set(ENDPOINT_2_EXPR=$[$["${ENDPOINT_2_STATE}" = "NOT_INUSE"] | $["${ENDPOINT_2_STATE}" = "ONHOLD"]]) + same => n,Set(ENDPOINT_3_EXPR=$[$["${ENDPOINT_3_STATE}" = "NOT_INUSE"] | $["${ENDPOINT_3_STATE}" = "ONHOLD"]]) + same => n,Set(ENDPOINT_4_EXPR=$[$["${ENDPOINT_4_STATE}" = "NOT_INUSE"] | $["${ENDPOINT_4_STATE}" = "ONHOLD"]]) same => n,Set(DIALGROUP(CALL_VALID_LIST)=) ; clear list - same => n,ExecIf($[${ENDPOINT_1_EXPR} = 0]?Set(DIALGROUP(CALL_VALID_LIST,add)=PJSIP/0501)) - same => n,ExecIf($[${ENDPOINT_2_EXPR} = 0]?Set(DIALGROUP(CALL_VALID_LIST,add)=PJSIP/0502)) - same => n,ExecIf($[${ENDPOINT_3_EXPR} = 0]?Set(DIALGROUP(CALL_VALID_LIST,add)=PJSIP/0503)) - same => n,ExecIf($[${ENDPOINT_4_EXPR} = 0]?Set(DIALGROUP(CALL_VALID_LIST,add)=PJSIP/0504)) + same => n,ExecIf($[${ENDPOINT_1_EXPR} != 0]?Set(DIALGROUP(CALL_VALID_LIST,add)=PJSIP/0501)) + same => n,ExecIf($[${ENDPOINT_2_EXPR} != 0]?Set(DIALGROUP(CALL_VALID_LIST,add)=PJSIP/0502)) + same => n,ExecIf($[${ENDPOINT_3_EXPR} != 0]?Set(DIALGROUP(CALL_VALID_LIST,add)=PJSIP/0503)) + same => n,ExecIf($[${ENDPOINT_4_EXPR} != 0]?Set(DIALGROUP(CALL_VALID_LIST,add)=PJSIP/0504)) same => n,Return(${DIALGROUP(CALL_VALID_LIST)}) [from-phone] @@ -44,10 +44,9 @@ exten => _.!,1,Verbose(5,${EXTEN}: Call internal number from ${CALLERID(num)}) same => n,Set(GROUP()=IMSgroup) same => n,GotoIf($[${GROUP_COUNT(IMSgroup)} > 1]?999) - same => n,WaitForPrecondition(10,2000); same => n,Gosub(get-valid-endpoints,s,1()) same => n,Set(DIALGROUP(CALL_EVERYONE_LIST)=${GOSUB_RETVAL}) - same => n,Set(DIALGROUP(CALL_EVERYONE_LIST,del)=PJSIP/${CALLERID(num)}) ; remove the caller + same => n,WaitForPrecondition(10,2000) same => n,Dial(${DIALGROUP(CALL_EVERYONE_LIST)}) same => n,Hangup(16) same => 999,Verbose(1,${EXTEN}: VoLTE client already busy (${GROUP_COUNT(IMSgroup)}) rejecting call from IMS ${CALLERID(num)}) -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id9e3ead6e28a53793c6cceb6f23d5e6d987521d8 Gerrit-Change-Number: 37494 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: TC_internal_call_all_Nregistered: Answer Cancel when received

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37491?usp=email ) Change subject: asterisk: TC_internal_call_all_Nregistered: Answer Cancel when received ...................................................................... asterisk: TC_internal_call_all_Nregistered: Answer Cancel when received Otherwise CANCEL is not answered until the MO+MT SIP UAs have fully established the call, which causes Asterisk to retransmit the CANCEL several times. Change-Id: I72e9ecaf58156f3fe62c4fb2d8c74c82ab16aa78 --- M asterisk/Asterisk_Tests.ttcn 1 file changed, 23 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/91/37491/1 diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn index 71d3576..916339a 100644 --- a/asterisk/Asterisk_Tests.ttcn +++ b/asterisk/Asterisk_Tests.ttcn @@ -373,16 +373,19 @@ /* Make sure the desired MT is the one picking up first the call: */ COORD.send(COORD_CMD_PICKUP) to vc_conn_list[vc_conn_mt_idx]; - interleave { - [] COORD.receive(COORD_CMD_CALL_ESTABLISHED) from vc_conn_list[vc_conn_mo_idx]; - [] COORD.receive(COORD_CMD_CALL_ESTABLISHED) from vc_conn_list[vc_conn_mt_idx]; - } - - /* Pick up from other phone calls and expect CANCEL: */ for (var integer i := 0; i < num_conns; i := i + 1) { if (i != vc_conn_mo_idx and i != vc_conn_mt_idx) { COORD.send(COORD_CMD_PICKUP) to vc_conn_list[i]; - COORD.receive(COORD_CMD_CALL_CANCELLED) from vc_conn_list[i]; + } + } + + /* Pick up from other phone calls and expect CANCEL: */ + var boolean wait_mo := true, wait_mt := true; + for (var integer i := 0; i < num_conns; i := i + 1) { + alt { + [wait_mo] COORD.receive(COORD_CMD_CALL_ESTABLISHED) from vc_conn_list[vc_conn_mo_idx] { wait_mo := false }; + [wait_mt] COORD.receive(COORD_CMD_CALL_ESTABLISHED) from vc_conn_list[vc_conn_mt_idx] { wait_mt := false }; + [] COORD.receive(COORD_CMD_CALL_CANCELLED); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I72e9ecaf58156f3fe62c4fb2d8c74c82ab16aa78 Gerrit-Change-Number: 37491 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Introduce test TC_ims_call_mt_no_local_uas_registered

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37492?usp=email ) Change subject: asterisk: Introduce test TC_ims_call_mt_no_local_uas_registered ...................................................................... asterisk: Introduce test TC_ims_call_mt_no_local_uas_registered Change-Id: Ibf7ecfe67f90df060b0ae87f394424566ad0fed4 --- M asterisk/Asterisk_Tests.ttcn M asterisk/expected-results.xml 2 files changed, 72 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/92/37492/1 diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn index 916339a..d202c05 100644 --- a/asterisk/Asterisk_Tests.ttcn +++ b/asterisk/Asterisk_Tests.ttcn @@ -1019,6 +1019,67 @@ f_TC_ims_call_mt(false); } +/* Validate incoming IMS MT call is rejected if no UAs are registered, hence not available. */ +private function f_TC_ims_call_mt_IMS_ConnHdlr_603_Decline(charstring id) runs on IMS_ConnHdlr { + f_create_sip_expect(valueof(ts_SipUrl_from_Addr_Union(g_pars.subscr.registrar_sip_record.addr))); + as_IMS_register(); + COORD.send(IMS_COORD_CMD_REGISTERED); + setverdict(pass); + + COORD.receive(IMS_COORD_CMD_START); + f_IMS_mt_call_rejected(603, "Decline"); + setverdict(pass); + COORD.send(IMS_COORD_CMD_CALL_REJECTED); + + as_IMS_unregister(); +} +testcase TC_ims_call_mt_no_local_uas_registered() runs on test_CT { + var IMS_ConnHdlrPars ims_pars; + var IMS_ConnHdlr vc_conn_ims; + var AMI_Msg ami_msg; + const charstring c_ext_msisdn := "90829"; + + f_init(); + + ims_pars := f_init_IMS_ConnHdlrPars(); + + ims_pars.subscr.cp.calling := valueof(ts_SipAddr(ts_HostPort(ims_pars.realm), + ts_UserInfo(c_ext_msisdn))); + ims_pars.subscr.cp.called := valueof(ts_SipAddr(ts_HostPort(ims_pars.realm), + ts_UserInfo(ims_pars.subscr.msisdn))); + + vc_conn_ims := f_start_handler_IMS(refers(f_TC_ims_call_mt_IMS_ConnHdlr_603_Decline), ims_pars); + + f_AMI_IMS_register(ims_pars); + IMS_COORD.receive(IMS_COORD_CMD_REGISTERED) from vc_conn_ims; + + IMS_COORD.send(IMS_COORD_CMD_START) to vc_conn_ims; + + ami_msg := f_ami_wait_rx_msg(AMI_CLIENT, + tr_AMI_Event_Newchannel(mp_volte_ims_outbound_registration), + fail_others := false); + g_asterisk_chan_name := valueof(f_ami_msg_get_value(ami_msg, AMI_FIELD_CHANNEL)); + + f_ami_action_DedicatedBearerStatus(AMI_CLIENT, + g_asterisk_chan_name, + "Up", fail_others := false); + + /* Notify network released dedicated bearer: */ + IMS_COORD.receive(IMS_COORD_CMD_CALL_REJECTED) from vc_conn_ims; + AMI_CLIENT.clear; + f_ami_action_DedicatedBearerStatus(AMI_CLIENT, + g_asterisk_chan_name, + "Down", fail_others := false); + + /* Trigger unregistration: */ + f_sleep(1.0); + AMI_CLIENT.clear; + f_AMI_IMS_unregister(ims_pars); + + vc_conn_ims.done; + f_shutdown(); +} + control { execute( TC_internal_registration() ); execute( TC_internal_call_momt() ); @@ -1042,6 +1103,7 @@ execute( TC_ims_call_mo_2nd_mt_rejected() ); execute( TC_ims_call_mt() ); execute( TC_ims_call_mt_noprecondition() ); + execute( TC_ims_call_mt_no_local_uas_registered() ); } } diff --git a/asterisk/expected-results.xml b/asterisk/expected-results.xml index ddc50a5..3be281c 100644 --- a/asterisk/expected-results.xml +++ b/asterisk/expected-results.xml @@ -22,4 +22,5 @@ <testcase classname='Asterisk_Tests' name='TC_ims_call_mo_2nd_mt_rejected' time='MASKED'/> <testcase classname='Asterisk_Tests' name='TC_ims_call_mt' time='MASKED'/> <testcase classname='Asterisk_Tests' name='TC_ims_call_mt_noprecondition' time='MASKED'/> + <testcase classname='Asterisk_Tests' name='TC_ims_call_mt_no_local_uas_registered' time='MASKED'/> </testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37492?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibf7ecfe67f90df060b0ae87f394424566ad0fed4 Gerrit-Change-Number: 37492 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: Introduce test TC_ims_call_mt_local_uas_inacall

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37493?usp=email ) Change subject: asterisk: Introduce test TC_ims_call_mt_local_uas_inacall ...................................................................... asterisk: Introduce test TC_ims_call_mt_local_uas_inacall Change-Id: I8a407993f37d18a0bf4c96f5228c0b5ce696053a --- M asterisk/Asterisk_Tests.ttcn M asterisk/expected-results.xml 2 files changed, 87 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/93/37493/1 diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn index d202c05..a97f2a4 100644 --- a/asterisk/Asterisk_Tests.ttcn +++ b/asterisk/Asterisk_Tests.ttcn @@ -1080,6 +1080,82 @@ f_shutdown(); } +/* Validate incoming IMS MT call is rejected if no UAs are available due to being busy in an internall call. */ +testcase TC_ims_call_mt_local_uas_inacall() runs on test_CT { + var SIPConnHdlrPars sip_pars[2]; + var IMS_ConnHdlrPars ims_pars; + var SIPConnHdlr vc_conn_sip[2]; + var IMS_ConnHdlr vc_conn_ims; + var AMI_Msg ami_msg; + const charstring c_ext_msisdn := "90829"; + + f_init(); + + sip_pars[0] := f_init_ConnHdlrPars(idx := 1); + sip_pars[1] := f_init_ConnHdlrPars(idx := 2); + ims_pars := f_init_IMS_ConnHdlrPars(); + + sip_pars[0].cp.calling := sip_pars[0].registrar_sip_record; + sip_pars[0].cp.called := sip_pars[1].registrar_sip_record; + + sip_pars[1].cp.calling := sip_pars[0].registrar_sip_record; + sip_pars[1].cp.called := sip_pars[1].local_sip_record; + + ims_pars.subscr.cp.calling := valueof(ts_SipAddr(ts_HostPort(ims_pars.realm), + ts_UserInfo(c_ext_msisdn))); + ims_pars.subscr.cp.called := valueof(ts_SipAddr(ts_HostPort(ims_pars.realm), + ts_UserInfo(ims_pars.subscr.msisdn))); + + vc_conn_sip[0] := f_start_handler(refers(f_TC_internal_call_mo), sip_pars[0]); + vc_conn_sip[1] := f_start_handler(refers(f_TC_internal_call_mt), sip_pars[1]); + + vc_conn_ims := f_start_handler_IMS(refers(f_TC_ims_call_mt_IMS_ConnHdlr_603_Decline), ims_pars); + f_AMI_IMS_register(ims_pars); + + interleave { + [] COORD.receive(COORD_CMD_REGISTERED) from vc_conn_sip[0]; + [] COORD.receive(COORD_CMD_REGISTERED) from vc_conn_sip[1]; + [] IMS_COORD.receive(IMS_COORD_CMD_REGISTERED) from vc_conn_ims; + } + + COORD.send(COORD_CMD_START) to vc_conn_sip[0]; + + interleave { + [] COORD.receive(COORD_CMD_CALL_ESTABLISHED) from vc_conn_sip[0]; + [] COORD.receive(COORD_CMD_CALL_ESTABLISHED) from vc_conn_sip[1]; + } + + /* Call on-going, now IMS MT call is attempted: */ + f_sleep(1.0); + IMS_COORD.send(IMS_COORD_CMD_START) to vc_conn_ims; + ami_msg := f_ami_wait_rx_msg(AMI_CLIENT, + tr_AMI_Event_Newchannel(mp_volte_ims_outbound_registration), + fail_others := false); + g_asterisk_chan_name := valueof(f_ami_msg_get_value(ami_msg, AMI_FIELD_CHANNEL)); + f_ami_action_DedicatedBearerStatus(AMI_CLIENT, + g_asterisk_chan_name, + "Up", fail_others := false); + IMS_COORD.receive(IMS_COORD_CMD_CALL_REJECTED) from vc_conn_ims; + AMI_CLIENT.clear; + f_ami_action_DedicatedBearerStatus(AMI_CLIENT, + g_asterisk_chan_name, + "Down", fail_others := false); + + + COORD.send(COORD_CMD_HANGUP) to vc_conn_sip[0]; + COORD.receive(COORD_CMD_CALL_FINISHED) from vc_conn_sip[1]; + + COORD.send(COORD_CMD_UNREGISTER) to vc_conn_sip[0]; + COORD.send(COORD_CMD_UNREGISTER) to vc_conn_sip[1]; + AMI_CLIENT.clear; + f_AMI_IMS_unregister(ims_pars); + + vc_conn_sip[0].done; + vc_conn_sip[1].done; + vc_conn_ims.done; + f_shutdown(); +} + control { execute( TC_internal_registration() ); execute( TC_internal_call_momt() ); @@ -1104,6 +1180,7 @@ execute( TC_ims_call_mt() ); execute( TC_ims_call_mt_noprecondition() ); execute( TC_ims_call_mt_no_local_uas_registered() ); + execute( TC_ims_call_mt_local_uas_inacall() ); } } diff --git a/asterisk/expected-results.xml b/asterisk/expected-results.xml index 3be281c..dd665e4 100644 --- a/asterisk/expected-results.xml +++ b/asterisk/expected-results.xml @@ -23,4 +23,5 @@ <testcase classname='Asterisk_Tests' name='TC_ims_call_mt' time='MASKED'/> <testcase classname='Asterisk_Tests' name='TC_ims_call_mt_noprecondition' time='MASKED'/> <testcase classname='Asterisk_Tests' name='TC_ims_call_mt_no_local_uas_registered' time='MASKED'/> + <testcase classname='Asterisk_Tests' name='TC_ims_call_mt_local_uas_inacall' time='MASKED'/> </testsuite> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37493?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8a407993f37d18a0bf4c96f5228c0b5ce696053a Gerrit-Change-Number: 37493 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: ttcn3-asterisk: Introduce test TC_ims_call_mo_2nd_mt_rejected

by pespin

Attention is currently required from: jolly, laforge, pespin. Hello Jenkins Builder, jolly, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37481?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by jolly, Verified+1 by Jenkins Builder Change subject: ttcn3-asterisk: Introduce test TC_ims_call_mo_2nd_mt_rejected ...................................................................... ttcn3-asterisk: Introduce test TC_ims_call_mo_2nd_mt_rejected Change-Id: Id6577d0e9137c86855469904d347e95b5bcfa4a7 --- M asterisk/Asterisk_Tests.ttcn M asterisk/IMS_ConnectionHandler.ttcn M asterisk/expected-results.xml 3 files changed, 101 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/81/37481/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37481?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id6577d0e9137c86855469904d347e95b5bcfa4a7 Gerrit-Change-Number: 37481 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

11 months, 2 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: asterisk: MO internal call: Expect direct rtp re-INVITE

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37489?usp=email ) Change subject: asterisk: MO internal call: Expect direct rtp re-INVITE ...................................................................... asterisk: MO internal call: Expect direct rtp re-INVITE Change-Id: I4ac602865cf0c18036b411acff4562322b32933b --- M asterisk/Asterisk_Tests.ttcn M asterisk/SIP_ConnectionHandler.ttcn 2 files changed, 70 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/89/37489/1 diff --git a/asterisk/Asterisk_Tests.ttcn b/asterisk/Asterisk_Tests.ttcn index 9b5bb11..71d3576 100644 --- a/asterisk/Asterisk_Tests.ttcn +++ b/asterisk/Asterisk_Tests.ttcn @@ -213,7 +213,7 @@ COORD.send(COORD_CMD_REGISTERED); COORD.receive(COORD_CMD_START); - f_SIP_mo_call_setup(); + f_SIP_mo_call_setup(exp_update_to_direct_rtp := g_pars.cp.exp_update_to_direct_rtp); COORD.send(COORD_CMD_CALL_ESTABLISHED); } private function f_TC_internal_hangup_call_mo_unregister() runs on SIPConnHdlr { @@ -271,7 +271,7 @@ if (g_pars.cp.exp_update_to_direct_rtp) { /* Once MO hangs up, Asterisk updates us to point RTP to it: */ - as_SIP_exp_call_update(g_pars.cp.sip_seq_nr + 1); + as_SIP_exp_mt_call_update(g_pars.cp.sip_seq_nr + 1); } as_SIP_exp_call_hangup(g_pars.cp.sip_seq_nr + 1); @@ -716,6 +716,7 @@ private function f_ims_call_mo_configure(inout SIPConnHdlrPars sip_pars, inout IMS_ConnHdlrPars ims_pars, charstring tgt_ext_msisdn := "90829") runs on test_CT { + sip_pars.cp.exp_update_to_direct_rtp := false; sip_pars.cp.calling := sip_pars.registrar_sip_record; sip_pars.cp.called := valueof(ts_SipAddr(ts_HostPort(sip_pars.remote_sip_host), ts_UserInfo(tgt_ext_msisdn))); diff --git a/asterisk/SIP_ConnectionHandler.ttcn b/asterisk/SIP_ConnectionHandler.ttcn index 49fa04c..c3d955a 100644 --- a/asterisk/SIP_ConnectionHandler.ttcn +++ b/asterisk/SIP_ConnectionHandler.ttcn @@ -467,7 +467,8 @@ } function f_SIP_mo_call_setup(template (present) integer exp_status_code := 200, - template (present) charstring exp_reason := "OK") runs on SIPConnHdlr + template (present) charstring exp_reason := "OK", + boolean exp_update_to_direct_rtp := false) runs on SIPConnHdlr { var template (value) PDU_SIP_Request req; var template (present) PDU_SIP_Response exp; @@ -545,9 +546,62 @@ g_pars.cp.sip_seq_nr, omit); SIP.send(req); + + if (exp_update_to_direct_rtp) { + /* Asterisk will now update the session to connect us to MT directly: */ + /* Via is not kept since anyway "branch" will change upon following INVITE. */ + as_SIP_exp_mo_call_update(?); + } + g_pars.cp.sip_seq_nr := g_pars.cp.sip_seq_nr + 1; } +/* New (re-)INVITE arrives after MO call is established. Accept it: */ +altstep as_SIP_exp_mo_call_update(template (present) integer exp_seq_nr := ?, boolean fail_others := true) runs on SIPConnHdlr +{ + var template (present) PDU_SIP_Request exp_req := + tr_SIP_INVITE(f_tr_SipUrl_opt_defport(g_pars.local_sip_url_ext), + ?, + tr_From(tr_Addr_Union_from_val(g_pars.cp.called.addr), *), + tr_To(tr_Addr_Union_from_val(g_pars.cp.calling.addr), *), + tr_Via_from(f_tr_HostPort(g_pars.remote_sip_host, g_pars.remote_sip_port)), + exp_seq_nr, + body := ?); + var charstring sip_expect_str := log2str(exp_req); + + [] SIP.receive(exp_req) -> value g_rx_sip_req { + var template (value) PDU_SIP_Response tx_resp; + var charstring tx_sdp; + + f_SDP_decodeMessage(g_rx_sip_req.messageBody, g_pars.cp.peer_sdp); + log("Rx Update MO INVITE decoded SDP: ", g_pars.cp.peer_sdp); + + /* Tx 200 OK */ + tx_sdp := f_gen_sdp(); + tx_resp := ts_SIP_Response(g_rx_sip_req.msgHeader.callId.callid, + g_rx_sip_req.msgHeader.fromField, + g_rx_sip_req.msgHeader.toField, + "INVITE", 200, + g_rx_sip_req.msgHeader.cSeq.seqNumber, + "OK", + g_rx_sip_req.msgHeader.via, + body := tx_sdp); + SIP.send(tx_resp); + + /* Wait for ACK */ + exp_req := tr_SIP_ACK(f_tr_SipUrl_opt_defport(g_pars.local_sip_url_ext), + g_rx_sip_req.msgHeader.callId.callid, + g_rx_sip_req.msgHeader.fromField, + g_rx_sip_req.msgHeader.toField, + f_tr_Via_response(g_rx_sip_req.msgHeader.via), + g_rx_sip_req.msgHeader.cSeq.seqNumber, + *); + as_SIP_expect_req(exp_req); + } + [fail_others] as_SIP_fail_resp(sip_expect_str); + [fail_others] as_SIP_fail_req(sip_expect_str); +} + private function f_ConnHdlr_parse_initial_SIP_INVITE(PDU_SIP_Request rx_sip_req) runs on SIPConnHdlr { f_SDP_decodeMessage(rx_sip_req.messageBody, g_pars.cp.peer_sdp); @@ -621,7 +675,7 @@ if (exp_update_to_direct_rtp) { /* Asterisk will now update the session to connect us to MO directly: */ /* Via is not kept since anyway "branch" will change upon following INVITE. */ - as_SIP_exp_call_update(g_pars.cp.sip_seq_nr + 1); + as_SIP_exp_mt_call_update(g_pars.cp.sip_seq_nr + 1); } } [fail_others] as_SIP_fail_resp(sip_expect_str); @@ -694,7 +748,7 @@ } /* New INVITE arrives after MT call is established. Accept it: */ -altstep as_SIP_exp_call_update(template (present) integer exp_seq_nr := ?, boolean fail_others := true) runs on SIPConnHdlr +altstep as_SIP_exp_mt_call_update(template (present) integer exp_seq_nr := ?, boolean fail_others := true) runs on SIPConnHdlr { var template (present) PDU_SIP_Request exp_req := tr_SIP_INVITE(f_tr_SipUrl_opt_defport(g_pars.local_sip_url_ext), @@ -760,7 +814,7 @@ via := g_pars.local_via; via.viaBody[0].viaParams := f_sip_param_set(via.viaBody[0].viaParams, "branch", branch_value); - /* Transmit ACK */ + /* Transmit BYE */ req := ts_SIP_BYE(g_pars.cp.sip_call_id, g_pars.cp.from_addr, g_pars.cp.to_addr, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37489?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4ac602865cf0c18036b411acff4562322b32933b Gerrit-Change-Number: 37489 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: sip: Fail rx unexpected msg during unregister

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37490?usp=email ) Change subject: asterisk: sip: Fail rx unexpected msg during unregister ...................................................................... asterisk: sip: Fail rx unexpected msg during unregister Change-Id: Ibcf65b22925e990e4d13661204eaba1b471b6a5d --- M asterisk/SIP_ConnectionHandler.ttcn 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/90/37490/1 diff --git a/asterisk/SIP_ConnectionHandler.ttcn b/asterisk/SIP_ConnectionHandler.ttcn index c3d955a..5f76ad2 100644 --- a/asterisk/SIP_ConnectionHandler.ttcn +++ b/asterisk/SIP_ConnectionHandler.ttcn @@ -350,6 +350,7 @@ via.viaBody[0].viaParams := f_sip_param_set(via.viaBody[0].viaParams, "branch", branch_value); from_addr.fromParams := f_sip_param_set(from_addr.fromParams, "tag", f_sip_rand_tag()); + SIP.clear; SIP.send(ts_SIP_REGISTER(g_pars.registrar_sip_req_uri, g_pars.registrar_sip_call_id, from_addr, @@ -416,6 +417,8 @@ g_pars.registrar_sip_seq_nr, "OK"); as_SIP_expect_resp(exp); } + [] as_SIP_fail_resp("(un)REGISTER 200 OK"); + [] as_SIP_fail_req("(un)REGISTER 200 OK"); } /* Prepare for next use: */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37490?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibcf65b22925e990e4d13661204eaba1b471b6a5d Gerrit-Change-Number: 37490 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: pySim.cat: More spec references + explanations in comments

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/37488?usp=email ) Change subject: pySim.cat: More spec references + explanations in comments ...................................................................... pySim.cat: More spec references + explanations in comments Change-Id: I4a89156075ae225594740451b33c3dec8983cf04 --- M pySim/cat.py 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/88/37488/1 diff --git a/pySim/cat.py b/pySim/cat.py index d2f39f7..d2a3a66 100644 --- a/pySim/cat.py +++ b/pySim/cat.py @@ -499,9 +499,10 @@ class BufferSize(COMPR_TLV_IE, tag = 0xB9): _construct = Int16ub -# TS 31.111 Section 8.56 +# TS 102 223 Section 8.56 + TS 31.111 Section 8.56 class ChannelStatus(COMPR_TLV_IE, tag = 0xB8): # complex decoding, depends on out-of-band context/knowledge :( + # for default / TCP Client mode: bit 8 of first byte indicates connected, 3 LSB indicate channel nr _construct = HexAdapter(GreedyBytes) # TS 102 223 Section 8.58 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4a89156075ae225594740451b33c3dec8983cf04 Gerrit-Change-Number: 37488 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

11 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2024