July 2024 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-s1gw[master]: sctp_server: do not let sctp_proxy:shutdown() crash the server

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37461?usp=email ) Change subject: sctp_server: do not let sctp_proxy:shutdown() crash the server ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37461?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iaeedbc66cab21ec7274f864c8daf86c87f21e633 Gerrit-Change-Number: 37461 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 14 Jul 2024 10:57:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in ...osmo-s1gw[master]: sctp_proxy: handle_pdu/2: print stacktrace on exception

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37460?usp=email ) Change subject: sctp_proxy: handle_pdu/2: print stacktrace on exception ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/sctp_proxy.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37460/comment/e4be5703_931b… PS1, Line 208: ?LOG_ERROR("An exception occurred: ~p, ~p, ~p", [Exception, Reason, StackTrace]), > I think it may make sense to print Data too in here. It's already being printed by the calling functions (e.g. in `src/sctp_proxy.erl:164`), so I am not sure if it makes sense to print it again here. Can be done in a separate patch when I am convinced. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37460?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I7fef18d4462af4b629318922e59cb5aa161fed93 Gerrit-Change-Number: 37460 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 14 Jul 2024 10:57:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[L] Change in pysim[master]: pySim-smpp2sim.py: Simulate SMSC+CN+RAN+UE for OTA testing

by fixeria

Attention is currently required from: dexter, laforge, osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37456?usp=email ) Change subject: pySim-smpp2sim.py: Simulate SMSC+CN+RAN+UE for OTA testing ...................................................................... Patch Set 4: (2 comments) File pySim-smpp2sim.py: https://gerrit.osmocom.org/c/pysim/+/37456/comment/d980a673_aa3de1de PS3, Line 41: from zope.interface import implementer > I believe it's an upstraeam dependency of twisted. https://docs.twisted.org/en/twisted-17.5. […] Not sure if it's a good idea to import packages from indirect dependencies, as we have no control over it. In theory, it can happen that `twisted` removes this dependency, so we end up in a broken state. Not blocking, just raising a concern. https://gerrit.osmocom.org/c/pysim/+/37456/comment/54931dde_55364070 PS3, Line 95: submit > unused? Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37456?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie5bae9d823bca6f6c658bd455303f63bace2258c Gerrit-Change-Number: 37456 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 14 Jul 2024 07:45:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: pySim.commands: Check return value of TERMINAL PROFILE command

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37485?usp=email ) Change subject: pySim.commands: Check return value of TERMINAL PROFILE command ...................................................................... pySim.commands: Check return value of TERMINAL PROFILE command Change-Id: Iaede74caf22970869c2c85b42d1e6f70d52c65cb --- M pySim/commands.py 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/commands.py b/pySim/commands.py index c0ac1d7..40b0980 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -759,7 +759,7 @@ payload : payload as hex string """ data_length = len(payload) // 2 - data, sw = self.send_apdu(('80100000%02x' % data_length) + payload) + data, sw = self.send_apdu_checksw(('80100000%02x' % data_length) + payload) return (data, sw) # ETSI TS 102 221 11.1.22 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37485?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iaede74caf22970869c2c85b42d1e6f70d52c65cb Gerrit-Change-Number: 37485 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: pySim.transport: Fix proactive_handler from_dict() calls

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37482?usp=email ) Change subject: pySim.transport: Fix proactive_handler from_dict() calls ...................................................................... pySim.transport: Fix proactive_handler from_dict() calls Change-Id: I2aa19ef6a19085d77c1b4f2d434a01ee241bd9a8 --- M pySim/transport/__init__.py 1 file changed, 15 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/transport/__init__.py b/pySim/transport/__init__.py index dd06af8..5ae9428 100644 --- a/pySim/transport/__init__.py +++ b/pySim/transport/__init__.py @@ -187,9 +187,11 @@ # they could be appended after the Result; if the first is a # Result, that cuold replace the one built here. self.proactive_handler.receive_fetch_raw(pcmd, parsed) - result.from_dict({'general_result': 'performed_successfully', 'additional_information': ''}) + result.from_dict({'result': {'general_result': 'performed_successfully', + 'additional_information': ''}}) else: - result.from_dict({'general_result': 'command_beyond_terminal_capability', 'additional_information': ''}) + result.from_dict({'result': {'general_result': 'command_beyond_terminal_capability', + 'additional_information': ''}}) # Send response immediately, thus also flushing out any further # proactive commands that the card already wants to send @@ -200,7 +202,8 @@ (command_details,) = [c for c in pcmd.decoded.children if isinstance(c, CommandDetails)] # The Device Identities are fixed. (TS 102 223 V4.0.0 Section 6.8.2) device_identities = DeviceIdentities() - device_identities.from_dict({'source_dev_id': 'terminal', 'dest_dev_id': 'uicc'}) + device_identities.from_dict({'device_identities': {'source_dev_id': 'terminal', 'dest_dev_id': + 'uicc'}}) # Testing hint: The value of tail does not influence the behavior # of an SJA2 that sent ans SMS, so this is implemented only -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37482?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2aa19ef6a19085d77c1b4f2d434a01ee241bd9a8 Gerrit-Change-Number: 37482 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: pySim.ota: Raise exception if encoded length would exceed 140 bytes

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37484?usp=email ) Change subject: pySim.ota: Raise exception if encoded length would exceed 140 bytes ...................................................................... pySim.ota: Raise exception if encoded length would exceed 140 bytes SMS cannot exceed 140 bytes, and TS 31.115 explicitly states that larger messages must use multi-part SMS, which we don't yet implement here. Change-Id: I8a1543838be2add1c3cfdf7155676cf2b9827e6e --- M pySim/ota.py 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/ota.py b/pySim/ota.py index 00a4b6b..751461a 100644 --- a/pySim/ota.py +++ b/pySim/ota.py @@ -386,6 +386,9 @@ #print("envelope_data: %s" % b2h(envelope_data)) + if len(envelope_data) > 140: + raise ValueError('Cannot encode command in a single SMS; Fragmentation not implemented') + return envelope_data def decode_cmd(self, otak: OtaKeyset, encoded: bytes) -> Tuple[bytes, dict, bytes]: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37484?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8a1543838be2add1c3cfdf7155676cf2b9827e6e Gerrit-Change-Number: 37484 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: pySim.ota: Handle cases where 'secured_data' is empty

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37483?usp=email ) Change subject: pySim.ota: Handle cases where 'secured_data' is empty ...................................................................... pySim.ota: Handle cases where 'secured_data' is empty while it's true that in situations where response_status == 'por_ok' we are guaranteed to have a 'secured_data' key in the dict, its value could well be b'', which in turn causes us to run into an exception, calling a decoder on an empty byte value; let's avoid that. Change-Id: I7c919f9987585d3b42347c54bd3082a54b8c2a0a --- M pySim/ota.py 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/ota.py b/pySim/ota.py index c3a7512..00a4b6b 100644 --- a/pySim/ota.py +++ b/pySim/ota.py @@ -478,7 +478,7 @@ raise OtaCheckError('Unknown por_rc_cc_ds: %s' % spi['por_rc_cc_ds']) # TODO: ExpandedRemoteResponse according to TS 102 226 5.2.2 - if res.response_status == 'por_ok': + if res.response_status == 'por_ok' and len(res['secured_data']): dec = CompactRemoteResp.parse(res['secured_data']) else: dec = None -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37483?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7c919f9987585d3b42347c54bd3082a54b8c2a0a Gerrit-Change-Number: 37483 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

11 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: pySim.commands: Check return value of TERMINAL PROFILE command

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37485?usp=email ) Change subject: pySim.commands: Check return value of TERMINAL PROFILE command ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37485?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iaede74caf22970869c2c85b42d1e6f70d52c65cb Gerrit-Change-Number: 37485 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 13 Jul 2024 21:24:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: pySim.ota: Raise exception if encoded length would exceed 140 bytes

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37484?usp=email ) Change subject: pySim.ota: Raise exception if encoded length would exceed 140 bytes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37484?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8a1543838be2add1c3cfdf7155676cf2b9827e6e Gerrit-Change-Number: 37484 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sat, 13 Jul 2024 21:24:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

[S] Change in pysim[master]: pySim.ota: Handle cases where 'secured_data' is empty

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37483?usp=email ) Change subject: pySim.ota: Handle cases where 'secured_data' is empty ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37483?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7c919f9987585d3b42347c54bd3082a54b8c2a0a Gerrit-Change-Number: 37483 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 13 Jul 2024 21:24:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

11 months, 2 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2024