July 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: library/GTPv1U_Templates: Mark parameters as templates

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37645?usp=email ) Change subject: library/GTPv1U_Templates: Mark parameters as templates ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37645?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I278f7dbc64704c1ba2b8a75d6f540ac52b067598 Gerrit-Change-Number: 37645 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 Jul 2024 15:08:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 3 weeks

1
0
0 0

[S] Change in osmo-ci[master]: OBS: latest: handle "version is None"

by laforge

Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37668?usp=email ) Change subject: OBS: latest: handle "version is None" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37668?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I69cb884d499d1f6a8cae4b4585d31b5bc095fd6e Gerrit-Change-Number: 37668 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 Jul 2024 15:08:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 3 weeks

1
0
0 0

[S] Change in osmo-pcu[master]: tbf_ul_ass_fsm: Clarify use of X2000 timer

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/37669?usp=email ) Change subject: tbf_ul_ass_fsm: Clarify use of X2000 timer ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/37669?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Iee27d1b2a8ddac53e14efd20a8c8aec35de58174 Gerrit-Change-Number: 37669 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 Jul 2024 15:07:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 3 weeks

1
0
0 0

[M] Change in osmo-sgsn[master]: Handle rx UpdatePDPCtxReq with Tunnel Direct Flags EI=1

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37667?usp=email ) Change subject: Handle rx UpdatePDPCtxReq with Tunnel Direct Flags EI=1 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37667?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I76d4c387730fdbfb9e7e0dd23a5afb9e762228b1 Gerrit-Change-Number: 37667 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 Jul 2024 15:03:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 3 weeks

1
0
0 0

[S] Change in osmo-sgsn[master]: Announce SGSN own TEID during UpdatePDPCtxReq after UE goes PMM-IDLE

by laforge

Attention is currently required from: daniel, fixeria, lynxis lazus, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37644?usp=email ) Change subject: Announce SGSN own TEID during UpdatePDPCtxReq after UE goes PMM-IDLE ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37644?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I782aa43c71569922a945bd44544bb1388bf8c878 Gerrit-Change-Number: 37644 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 31 Jul 2024 15:03:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 3 weeks

1
0
0 0

[S] Change in osmo-bsc[master]: osmo_bsc_sigtran: Don't try to decode ipaccess_head a second time

by daniel

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/37662?usp=email ) Change subject: osmo_bsc_sigtran: Don't try to decode ipaccess_head a second time ...................................................................... osmo_bsc_sigtran: Don't try to decode ipaccess_head a second time osmo_io segmentation will already parse the ipaccess_header and set msg->data to the payload of the control command. Depends: Id91cddf9948ca49abf092850fae3a8f17e445b45 (libosmo-netif.git) Related: OS#6422 Change-Id: I300bbab3c0215d52bc5f6232ace5c37a6613feb7 --- M src/osmo-bsc/osmo_bsc_sigtran.c 1 file changed, 16 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c index 224e2c6..cdc5785 100644 --- a/src/osmo-bsc/osmo_bsc_sigtran.c +++ b/src/osmo-bsc/osmo_bsc_sigtran.c @@ -38,6 +38,7 @@ #include <osmocom/bsc/paging.h> #include <osmocom/bsc/bssmap_reset.h> #include <osmocom/mgcp_client/mgcp_common.h> +#include <osmocom/netif/ipa.h> /* A pointer to a list with all involved MSCs * (a copy of the pointer location submitted with osmo_bsc_sigtran_init() */ @@ -733,9 +734,6 @@ * libosmo-sigtran doesn't know about, such as piggy-backed CTRL and/or MGCP */ static int asp_rx_unknown(struct osmo_ss7_asp *asp, int ppid_mux, struct msgb *msg) { - struct ipaccess_head *iph; - struct ipaccess_head_ext *iph_ext; - if (osmo_ss7_asp_get_proto(asp) != OSMO_SS7_ASP_PROT_IPA) { msgb_free(msg); return 0; @@ -743,15 +741,7 @@ switch (ppid_mux) { case IPAC_PROTO_OSMO: - if (msg->len < sizeof(*iph) + sizeof(*iph_ext)) { - LOGP(DMSC, LOGL_ERROR, "The message is too short.\n"); - msgb_free(msg); - return -EINVAL; - } - iph = (struct ipaccess_head *) msg->data; - iph_ext = (struct ipaccess_head_ext *) iph->data; - msg->l2h = iph_ext->data; - switch (iph_ext->proto) { + switch (osmo_ipa_msgb_cb_proto_ext(msg)) { case IPAC_PROTO_EXT_CTRL: return bsc_sccplite_rx_ctrl(asp, msg); case IPAC_PROTO_EXT_MGCP: -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/37662?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I300bbab3c0215d52bc5f6232ace5c37a6613feb7 Gerrit-Change-Number: 37662 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

10 months, 3 weeks

1
0
0 0

[S] Change in osmo-sgsn[master]: gtp: Set Direct Tunnel Flags DTI during UpdatePDPCtx

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37596?usp=email ) Change subject: gtp: Set Direct Tunnel Flags DTI during UpdatePDPCtx ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37596?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iefe73eeea41df0c55db673194c9e9547504cbf0d Gerrit-Change-Number: 37596 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 Jul 2024 15:03:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 3 weeks

1
0
0 0

[M] Change in osmo-ggsn[master]: gtp: Allow setting callback to receive update_context_ind

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/37597?usp=email ) Change subject: gtp: Allow setting callback to receive update_context_ind ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ic80a9a928c55b6ff85be96014920bb42793cb943 Gerrit-Change-Number: 37597 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 Jul 2024 15:02:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 3 weeks

1
0
0 0

[M] Change in osmo-ggsn[master]: gtp: Allow setting callback to receive update_context_ind

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/37597?usp=email ) Change subject: gtp: Allow setting callback to receive update_context_ind ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: likewise, TODO-RELEASE for ABI change? -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/37597?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: Ic80a9a928c55b6ff85be96014920bb42793cb943 Gerrit-Change-Number: 37597 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 31 Jul 2024 15:02:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

10 months, 3 weeks

1
0
0 0

[S] Change in libosmo-netif[master]: ipa: Ensure osmo_ipa_segmentation_cb sets msg->l2h to the payload data

by daniel

daniel has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/37661?usp=email ) Change subject: ipa: Ensure osmo_ipa_segmentation_cb sets msg->l2h to the payload data ...................................................................... ipa: Ensure osmo_ipa_segmentation_cb sets msg->l2h to the payload data Previously if ih->proto was IPAC_PROTO_OSMO msg->l2h would still point to the extension header byte which breaks assumptions in e.g. osmo-bsc. Change-Id: Id91cddf9948ca49abf092850fae3a8f17e445b45 Related: OS#6422 --- M src/ipa.c 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/ipa.c b/src/ipa.c index 8720427..d43df00 100644 --- a/src/ipa.c +++ b/src/ipa.c @@ -375,7 +375,8 @@ #define MSG_CB_IPA_INFO_OFFSET 0 /* Check and remove headers (in case of p == IPAC_PROTO_OSMO, also the IPA extension header). - * Returns a negative number on error, otherwise the number of octets removed */ + * Returns a negative number on error, otherwise the number of octets removed. + * Both msg->data and msg->l2h point to the user data after the (extended) IPA header if this function is successful. */ static inline int ipa_check_pull_headers(struct msgb *msg) { int ret; @@ -397,6 +398,7 @@ osmo_ipa_msgb_cb_proto_ext(msg) = msg->data[0]; msgb_pull(msg, sizeof(struct ipa_head_ext)); octets_removed += sizeof(struct ipa_head_ext); + msg->l2h = msg->data; return octets_removed; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/37661?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Id91cddf9948ca49abf092850fae3a8f17e445b45 Gerrit-Change-Number: 37661 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

10 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2024