July 2024 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: pySim.runtime: Be more verbose if incompatible method is called

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37621?usp=email ) Change subject: pySim.runtime: Be more verbose if incompatible method is called ...................................................................... pySim.runtime: Be more verbose if incompatible method is called Change-Id: I57190d50a63e0c22a8c5921e1348fae31b23e3d4 --- M pySim/runtime.py 1 file changed, 21 insertions(+), 6 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/runtime.py b/pySim/runtime.py index 2d1f12b..a90128d 100644 --- a/pySim/runtime.py +++ b/pySim/runtime.py @@ -451,7 +451,8 @@ binary data read from the file """ if not isinstance(self.selected_file, TransparentEF): - raise TypeError("Only works with TransparentEF") + raise TypeError("Only works with TransparentEF, but %s is %s" % (self.selected_file, + self.selected_file.__class__.__mro__)) return self.scc.read_binary(self.selected_file.fid, length, offset) def read_binary_dec(self) -> Tuple[dict, str]: @@ -475,7 +476,8 @@ offset : Offset into the file from which to write 'data_hex' """ if not isinstance(self.selected_file, TransparentEF): - raise TypeError("Only works with TransparentEF") + raise TypeError("Only works with TransparentEF, but %s is %s" % (self.selected_file, + self.selected_file.__class__.__mro__)) return self.scc.update_binary(self.selected_file.fid, data_hex, offset, conserve=self.rs.conserve_write) def update_binary_dec(self, data: dict): @@ -497,7 +499,8 @@ hex string of binary data contained in record """ if not isinstance(self.selected_file, LinFixedEF): - raise TypeError("Only works with Linear Fixed EF") + raise TypeError("Only works with Linear Fixed EF, but %s is %s" % (self.selected_file, + self.selected_file.__class__.__mro__)) # returns a string of hex nibbles return self.scc.read_record(self.selected_file.fid, rec_nr) @@ -520,7 +523,8 @@ data_hex : Hex string binary data to be written """ if not isinstance(self.selected_file, LinFixedEF): - raise TypeError("Only works with Linear Fixed EF") + raise TypeError("Only works with Linear Fixed EF, but %s is %s" % (self.selected_file, + self.selected_file.__class__.__mro__)) return self.scc.update_record(self.selected_file.fid, rec_nr, data_hex, conserve=self.rs.conserve_write, leftpad=self.selected_file.leftpad) @@ -556,7 +560,8 @@ list of integer tags contained in EF """ if not isinstance(self.selected_file, BerTlvEF): - raise TypeError("Only works with BER-TLV EF") + raise TypeError("Only works with BER-TLV EF, but %s is %s" % (self.selected_file, + self.selected_file.__class__.__mro__)) data, _sw = self.scc.retrieve_data(self.selected_file.fid, 0x5c) _tag, _length, value, _remainder = bertlv_parse_one(h2b(data)) return list(value) @@ -569,7 +574,8 @@ data_hex : Hex string binary data to be written (value portion) """ if not isinstance(self.selected_file, BerTlvEF): - raise TypeError("Only works with BER-TLV EF") + raise TypeError("Only works with BER-TLV EF, but %s is %s" % (self.selected_file, + self.selected_file.__class__.__mro__)) return self.scc.set_data(self.selected_file.fid, tag, data_hex, conserve=self.rs.conserve_write) def register_cmds(self, cmd_app=None): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37621?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I57190d50a63e0c22a8c5921e1348fae31b23e3d4 Gerrit-Change-Number: 37621 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

10 months, 4 weeks

1
0
0 0

[S] Change in pysim[master]: pySim.commands: Don't convert SwMatchError to ValueError

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37622?usp=email ) Change subject: pySim.commands: Don't convert SwMatchError to ValueError ...................................................................... pySim.commands: Don't convert SwMatchError to ValueError In the read and write command implementations, we used to catch lower-layer exceptions (usually SwMatchError) and "translate" that into a value error, only to add more information to the exception. This meant that higher-layer code could no longer detect this was actually a SwMatchError exception type. Let's instead use the add_note() method to amend the existing exception, rather than raising a new one of different type. Change-Id: Ic94d0fe60a8a5e15aade56ec418192ecf31ac5e7 --- M pySim/commands.py 1 file changed, 22 insertions(+), 4 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/commands.py b/pySim/commands.py index 40b0980..3f659eb 100644 --- a/pySim/commands.py +++ b/pySim/commands.py @@ -334,8 +334,8 @@ try: data, sw = self.send_apdu_checksw(pdu) except Exception as e: - raise ValueError('%s, failed to read (offset %d)' % - (str_sanitize(str(e)), offset)) from e + e.add_note('failed to read (offset %d)' % offset) + raise e total_data += data chunk_offset += chunk_len return total_data, sw @@ -394,8 +394,8 @@ try: chunk_data, chunk_sw = self.send_apdu_checksw(pdu) except Exception as e: - raise ValueError('%s, failed to write chunk (chunk_offset %d, chunk_len %d)' % - (str_sanitize(str(e)), chunk_offset, chunk_len)) from e + e.add_note('failed to write chunk (chunk_offset %d, chunk_len %d)' % (chunk_offset, chunk_len)) + raise e total_data += data chunk_offset += chunk_len if verify: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37622?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic94d0fe60a8a5e15aade56ec418192ecf31ac5e7 Gerrit-Change-Number: 37622 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

10 months, 4 weeks

1
0
0 0

[M] Change in pysim[master]: pySim.tlv: Separate {to,from}_val_dict() from {to,from}_dict()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37623?usp=email ) Change subject: pySim.tlv: Separate {to,from}_val_dict() from {to,from}_dict() ...................................................................... pySim.tlv: Separate {to,from}_val_dict() from {to,from}_dict() There are some situations where we want to work with a type-name-wrapped dict that includes the type information, and others where we don't want that. The main reason is that nested IEs can only be reconstructed if we can determine the type/class of the nested IE from the dict data. Let's explicitly offer {to,from}_val_dict() methods that work with the value-part only Related: OS#6453 Change-Id: I81654ea54aed9e598943f41a26a57dcc3a7f10c2 --- M pySim/tlv.py 1 file changed, 47 insertions(+), 11 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/tlv.py b/pySim/tlv.py index ed3be5d..8180fd1 100644 --- a/pySim/tlv.py +++ b/pySim/tlv.py @@ -142,25 +142,43 @@ else: return '%s(%s)' % (type(self).__name__, self.decoded) - def to_dict(self): - """Return a JSON-serializable dict representing the [nested] IE data.""" + def to_val_dict(self): + """Return a JSON-serializable dict representing just the [nested] value portion of the IE + data. This does not include any indication of the type of 'self', so the resulting dict alone + will be insufficient ot recreate an object from it without additional type information.""" if len(self.children): - v = [x.to_dict() for x in self.children] + return [x.to_dict() for x in self.children] else: - v = self.decoded - return {camel_to_snake(type(self).__name__): v} + return self.decoded + + def from_val_dict(self, decoded): + """Set the IE internal decoded representation to data from the argument. + If this is a nested IE, the child IE instance list is re-created. + + This method is symmetrical to to_val_dict() aboe, i.e. there is no outer dict + containig the snake-reformatted type name of 'self'.""" + if self.nested_collection: + self.children = self.nested_collection.from_dict(decoded) + else: + self.children = [] + self.decoded = decoded + + def to_dict(self): + """Return a JSON-serializable dict representing the [nested] IE data. The returned + data contains an outer dict with the snake-reformatted type of 'self' and is hence + sufficient to re-create an object from it.""" + return {camel_to_snake(type(self).__name__): self.to_val_dict()} def from_dict(self, decoded: dict): """Set the IE internal decoded representation to data from the argument. - If this is a nested IE, the child IE instance list is re-created.""" + If this is a nested IE, the child IE instance list is re-created. + + This method is symmetrical to to_dict() above, i.e. the outer dict must contain just a single + key-value pair, where the key is the snake-reformatted type name of 'self'""" expected_key_name = camel_to_snake(type(self).__name__) if not expected_key_name in decoded: raise ValueError("Dict %s doesn't contain expected key %s" % (decoded, expected_key_name)) - if self.nested_collection: - self.children = self.nested_collection.from_dict(decoded[expected_key_name]) - else: - self.children = [] - self.decoded = decoded[expected_key_name] + self.from_val_dict(decoded[expected_key_name]) def is_constructed(self): """Is this IE constructed by further nested IEs?""" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37623?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I81654ea54aed9e598943f41a26a57dcc3a7f10c2 Gerrit-Change-Number: 37623 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: merged

10 months, 4 weeks

1
0
0 0

[M] Change in pysim[master]: pySim.esim.saip: Decode each 'File' element in ProfileElement

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37619?usp=email ) Change subject: pySim.esim.saip: Decode each 'File' element in ProfileElement ...................................................................... pySim.esim.saip: Decode each 'File' element in ProfileElement When loading a ProfileElement from its DER-ecoded format, populate a dict with a pySim.esim.saip.File object for each file. Change-Id: Ie2791c10289eb28daed2904467b0c5e5b11c94c2 --- M pySim/esim/saip/__init__.py 1 file changed, 59 insertions(+), 16 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index abaa679..c76cb5c 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -147,9 +147,10 @@ if k == 'fileDescriptor': return v fd = get_fileDescriptor(l) - if not fd: - raise ValueError("No fileDescriptor found") - self.fileDescriptor.update(dict(fd)) + if not fd and not self.fileDescriptor: + raise ValueError("No fileDescriptor found in tuple, and none set by template before") + if fd: + self.fileDescriptor.update(dict(fd)) self.stream = self.linearize_file_content(l) def to_tuples(self) -> List[Tuple]: @@ -262,13 +263,6 @@ """Return the decoded templateID used by this profile element (if any).""" return self.decoded.get('templateID', None) - @property - def files(self): - """Return dict of decoded 'File' ASN.1 items.""" - if not self.type in self.FILE_BEARING: - return {} - return {k:v for (k,v) in self.decoded.items() if k not in ['templateID', self.header_name]} - @classmethod def from_der(cls, der: bytes) -> 'ProfileElement': class4petype = { @@ -311,7 +305,44 @@ def __str__(self) -> str: return self.type -class ProfileElementMF(ProfileElement): +class FsProfileElement(ProfileElement): + """A file-system bearing profile element, like MF, USIM, ....""" + + def __init__(self, decoded = None, mandated: bool = True): + super().__init__(decoded, mandated) + # indexed by PE-Name + self.files = {} + self.tdef = asn1.types['ProfileElement'].type.name_to_member[self.type] + + def add_file(self, file: File): + """Add a File to the ProfileElement.""" + if file.pe_name in self.files: + raise KeyError('Cannot add file: %s already exists' % file.pename) + self.files[file.pe_name] = file + + def files2pe(self): + """Update the "decoded" member with the contents of the files member.""" + for f in self.files: + self.decoded[f.pename] = f.to_tuples() + + def pe2files(self): + """Update the "files" member with the contents of the "decoded" member.""" + tdict = {x.name: x for x in self.tdef.root_members} + template = templates.ProfileTemplateRegistry.get_by_oid(self.templateID) + for k, v in self.decoded.items(): + if tdict[k].type_name == 'File': + self.add_file(File(k, v, template.files_by_pename.get(k, None))) + + def _post_decode(self): + # not entirely sure about this automatism + self.pe2files() + + def _pre_encode(self): + # should we do self.pe2files()? I don't think so + #self.files2pe() + pass + +class ProfileElementMF(FsProfileElement): type = 'mf' def __init__(self, decoded: Optional[dict] = None): @@ -390,7 +421,7 @@ self.decoded['pinCodes'][1].append(pin) -class ProfileElementTelecom(ProfileElement): +class ProfileElementTelecom(FsProfileElement): type = 'telecom' def __init__(self, decoded: Optional[dict] = None): @@ -576,7 +607,7 @@ 'adfAdminAccessDomain': ADM1_ACCESS, } -class ProfileElementUSIM(ProfileElement): +class ProfileElementUSIM(FsProfileElement): type = 'usim' def __init__(self, decoded: Optional[dict] = None): @@ -597,7 +628,7 @@ f = File('ef-imsi', self.decoded['ef-imsi']) return dec_imsi(b2h(f.stream.getvalue())) -class ProfileElementOptUSIM(ProfileElement): +class ProfileElementOptUSIM(FsProfileElement): type = 'opt-usim' def __init__(self, decoded: Optional[dict] = None): @@ -607,7 +638,7 @@ # provide some reasonable defaults for a MNO-SD self.decoded['templateID'] = str(oid.ADF_USIMopt_not_by_default_v2) -class ProfileElementISIM(ProfileElement): +class ProfileElementISIM(FsProfileElement): type = 'isim' def __init__(self, decoded: Optional[dict] = None): @@ -623,7 +654,7 @@ def adf_name(self) -> str: return b2h(self.decoded['adf-isim'][0][1]['dfName']) -class ProfileElementOptISIM(ProfileElement): +class ProfileElementOptISIM(FsProfileElement): type = 'opt-isim' def __init__(self, decoded: Optional[dict] = None): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie2791c10289eb28daed2904467b0c5e5b11c94c2 Gerrit-Change-Number: 37619 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

10 months, 4 weeks

1
0
0 0

[M] Change in pysim[master]: pySim.esim.saip: Add OID comparison functions

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37618?usp=email ) Change subject: pySim.esim.saip: Add OID comparison functions ...................................................................... pySim.esim.saip: Add OID comparison functions Change-Id: Iab642e0cc6597f667ea126827ea888652f0f2689 --- M pySim/esim/saip/oid.py M tests/test_esim_saip.py 2 files changed, 54 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/esim/saip/oid.py b/pySim/esim/saip/oid.py index 91a48c1..6828e81 100644 --- a/pySim/esim/saip/oid.py +++ b/pySim/esim/saip/oid.py @@ -15,8 +15,10 @@ # You should have received a copy of the GNU Affero General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. +from functools import total_ordering from typing import List, Union +@total_ordering class OID: @staticmethod def intlist_from_str(instr: str) -> List[int]: @@ -26,6 +28,10 @@ def str_from_intlist(intlist: List[int]) -> str: return '.'.join([str(x) for x in intlist]) + @staticmethod + def highest_oid(oids: List['OID']) -> 'OID': + return sorted(oids)[-1] + def __init__(self, initializer: Union[List[int], str]): if isinstance(initializer, str): self.intlist = self.intlist_from_str(initializer) @@ -38,6 +44,39 @@ def __repr__(self) -> str: return 'OID(%s)' % (str(self)) + def __eq__(self, other: 'OID'): + return (self.intlist == other.intlist) + + def __ne__(self, other: 'OID'): + # implement based on __eq__ + return not (self == other) + + def cmp(self, other: 'OID'): + self_len = len(self.intlist) + other_len = len(other.intlist) + common_len = min(self_len, other_len) + max_len = max(self_len, other_len) + + for i in range(0, max_len+1): + if i >= self_len: + # other list is longer + return -1 + if i >= other_len: + # our list is longer + return 1 + if self.intlist[i] > other.intlist[i]: + # our version is higher + return 1 + if self.intlist[i] < other.intlist[i]: + # other version is higher + return -1 + # continue to next digit + return 0 + + def __gt__(self, other: 'OID'): + if self.cmp(other) > 0: + return True + def prefix_match(self, oid_str): """determine if oid_str is equal or below our OID.""" return oid_str.startswith(str(self)) diff --git a/tests/test_esim_saip.py b/tests/test_esim_saip.py index 82ed692..dcde1b4 100755 --- a/tests/test_esim_saip.py +++ b/tests/test_esim_saip.py @@ -83,6 +83,12 @@ pes.append(inst) pes.to_der() +class OidTest(unittest.TestCase): + def test_cmp(self): + self.assertTrue(oid.OID('1.0') > oid.OID('0.9')) + self.assertTrue(oid.OID('1.0') == oid.OID('1.0')) + self.assertTrue(oid.OID('1.0.1') > oid.OID('1.0')) + self.assertTrue(oid.OID('1.0.2') > oid.OID('1.0.1')) if __name__ == "__main__": unittest.main() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37618?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iab642e0cc6597f667ea126827ea888652f0f2689 Gerrit-Change-Number: 37618 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

10 months, 4 weeks

1
0
0 0

[S] Change in pysim[master]: pySim.tlv: Add convenience methods to IE class

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/37620?usp=email ) Change subject: pySim.tlv: Add convenience methods to IE class ...................................................................... pySim.tlv: Add convenience methods to IE class The new methods allow programmatic resolution of nested IEs from a parent, assuming there's only one child of a given type (which is often but not always the case). Change-Id: Ic95b74437647ae8d4bf3cdc481832afb622e3cf0 --- M pySim/tlv.py 1 file changed, 32 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/tlv.py b/pySim/tlv.py index 6dc5301..ed3be5d 100644 --- a/pySim/tlv.py +++ b/pySim/tlv.py @@ -19,7 +19,7 @@ import inspect import abc import re -from typing import List, Tuple +from typing import List, Tuple, Optional from pySim.utils import bertlv_encode_len, bertlv_parse_len, bertlv_encode_tag, bertlv_parse_tag from pySim.utils import comprehensiontlv_encode_tag, comprehensiontlv_parse_tag @@ -189,6 +189,24 @@ self.children = [] return super().from_bytes(do, context=context) + def child_by_name(self, name: str) -> Optional['IE']: + """Return a child IE instance of given snake-case/json type name. This only works in case + there is no more than one child IE of the given type.""" + children = list(filter(lambda c: camel_to_snake(type(c).__name__) == name, self.children)) + if len(children) > 1: + raise KeyError('There are multiple children of class %s' % name) + elif len(children) == 1: + return children[0] + + def child_by_type(self, cls) -> Optional['IE']: + """Return a child IE instance of given type (class). This only works in case + there is no more than one child IE of the given type.""" + children = list(filter(lambda c: isinstance(c, cls), self.children)) + if len(children) > 1: + raise KeyError('There are multiple children of class %s' % cls) + elif len(children) == 1: + return children[0] + class TLV_IE(IE): """Abstract base class for various TLV type Information Elements.""" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37620?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic95b74437647ae8d4bf3cdc481832afb622e3cf0 Gerrit-Change-Number: 37620 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

10 months, 4 weeks

1
0
0 0

[M] Change in pysim[master]: pySim.tlv: Separate {to,from}_val_dict() from {to,from}_dict()

by laforge

Attention is currently required from: dexter, lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37623?usp=email ) Change subject: pySim.tlv: Separate {to,from}_val_dict() from {to,from}_dict() ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37623?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I81654ea54aed9e598943f41a26a57dcc3a7f10c2 Gerrit-Change-Number: 37623 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jul 2024 10:48:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 4 weeks

1
0
0 0

[S] Change in pysim[master]: pySim.commands: Don't convert SwMatchError to ValueError

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37622?usp=email ) Change subject: pySim.commands: Don't convert SwMatchError to ValueError ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37622?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic94d0fe60a8a5e15aade56ec418192ecf31ac5e7 Gerrit-Change-Number: 37622 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jul 2024 10:48:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 4 weeks

1
0
0 0

[S] Change in pysim[master]: pySim.tlv: Add convenience methods to IE class

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37620?usp=email ) Change subject: pySim.tlv: Add convenience methods to IE class ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37620?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic95b74437647ae8d4bf3cdc481832afb622e3cf0 Gerrit-Change-Number: 37620 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jul 2024 10:48:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 4 weeks

1
0
0 0

[M] Change in pysim[master]: pySim.esim.saip: Decode each 'File' element in ProfileElement

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37619?usp=email ) Change subject: pySim.esim.saip: Decode each 'File' element in ProfileElement ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie2791c10289eb28daed2904467b0c5e5b11c94c2 Gerrit-Change-Number: 37619 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jul 2024 10:47:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

10 months, 4 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2024