June 2024 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: ansible: jenkins: lx2: configure tmpfs

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37108?usp=email ) Change subject: ansible: jenkins: lx2: configure tmpfs ...................................................................... ansible: jenkins: lx2: configure tmpfs Add ansible rules to put jenkins workspace and ccache dirs into a tmpfs. Related: OS#5873 Change-Id: I81e03f8d2013dda93395d0017b45f757a15c4ec2 --- M ansible/hosts M ansible/roles/osmocom-jenkins-slave/README.md M ansible/roles/osmocom-jenkins-slave/defaults/main.yml M ansible/roles/osmocom-jenkins-slave/tasks/main.yml 4 files changed, 37 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/ansible/hosts b/ansible/hosts index 51e26b9..a0a4578 100644 --- a/ansible/hosts +++ b/ansible/hosts @@ -16,7 +16,7 @@ rpi4-raspbian11build-ansible-1 ansible_host=10.9.25.50 docker_max_image_space="20 GB" rpi4-raspbian11build-ansible-2 ansible_host=10.9.25.60 docker_max_image_space="20 GB" rpi4-raspbian11build-ansible-3 ansible_host=10.9.25.70 docker_max_image_space="20 GB" -lx2-raspbian11build-ansible ansible_host=10.34.2.153 docker_max_image_space="20 GB" +lx2-raspbian11build-ansible ansible_host=10.34.2.153 docker_max_image_space="20 GB" jenkins_tmpfs=True [simtester] simtest ansible_host=10.9.25.80 diff --git a/ansible/roles/osmocom-jenkins-slave/README.md b/ansible/roles/osmocom-jenkins-slave/README.md index 81f68b3..fc62472 100644 --- a/ansible/roles/osmocom-jenkins-slave/README.md +++ b/ansible/roles/osmocom-jenkins-slave/README.md @@ -6,3 +6,4 @@ * `generic_slave`: (true) contains tasks used by the most osmocom jenkins slaves * `osmocom_jenkins_slave_fstrim`: (false) calls fstrim periodical * `ttcn3_slave`: (true) install titan ttcn3 compiler and prepares the docker-playground +* `jenkins_tmpfs`: (false) put jenkins workspaces and ccache dirs into tmpfs diff --git a/ansible/roles/osmocom-jenkins-slave/defaults/main.yml b/ansible/roles/osmocom-jenkins-slave/defaults/main.yml index a4ce8ac..fc6f9fa 100644 --- a/ansible/roles/osmocom-jenkins-slave/defaults/main.yml +++ b/ansible/roles/osmocom-jenkins-slave/defaults/main.yml @@ -15,3 +15,6 @@ # call fstrim peridically osmocom_jenkins_slave_fstrim: false + +# put jenkins workspaces and ccache dirs into tmpfs +jenkins_tmpfs: false diff --git a/ansible/roles/osmocom-jenkins-slave/tasks/main.yml b/ansible/roles/osmocom-jenkins-slave/tasks/main.yml index 1868d97..46da076 100644 --- a/ansible/roles/osmocom-jenkins-slave/tasks/main.yml +++ b/ansible/roles/osmocom-jenkins-slave/tasks/main.yml @@ -58,3 +58,23 @@ minute: 0 job: "fstrim / >/dev/null 2>/dev/null || true" when: osmocom_jenkins_slave_fstrim + +- name: add tmpfs for /home/osmocom-build/jenkins + when: jenkins_tmpfs + ansible.posix.mount: + boot: true + path: /home/osmocom-build/jenkins + src: tmpfs + fstype: tmpfs + state: mounted + opts: "uid=1000,gid=1000" + +- name: add tmpfs for /home/osmocom-build/ccache + when: jenkins_tmpfs + ansible.posix.mount: + boot: true + path: /home/osmocom-build/ccache + src: tmpfs + fstype: tmpfs + state: mounted + opts: "uid=1000,gid=1000" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37108?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I81e03f8d2013dda93395d0017b45f757a15c4ec2 Gerrit-Change-Number: 37108 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year

1
0
0 0

[S] Change in osmo-ci[master]: ansible: jenkins: lx2: configure tmpfs

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/37108?usp=email ) Change subject: ansible: jenkins: lx2: configure tmpfs ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/37108?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I81e03f8d2013dda93395d0017b45f757a15c4ec2 Gerrit-Change-Number: 37108 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 07 Jun 2024 09:05:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in ...osmo-s1gw[master]: sctp_proxy: add a safe wrapper for s1ap_proxy:handle_pdu/1

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37122?usp=email ) Change subject: sctp_proxy: add a safe wrapper for s1ap_proxy:handle_pdu/1 ...................................................................... Patch Set 2: (1 comment) File src/sctp_proxy.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37122/comment/fbeb47ef_d7f1… PS2, Line 197: handle_pdu(Data) when is_binary(Data) -> > isn't the when_is_binary() and the spec declaring the param to be binary() actually the same? I thin […] The spec is for Dialyzer, it does not affect the program logic IIUC. The `is_binary()` guard ensures that this function variant is only executed when the given argument is of a binary type. The idea is to ensure that we never pass `s1ap_proxy:handle_pdu/1` anything else than a binary, and thus never blame it a bug that is actually ours (this module's own). -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37122?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ie6a7c9ff40789695e37be11344f5ea97fbcb8cfa Gerrit-Change-Number: 37122 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Jun 2024 21:00:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year

1
0
0 0

[M] Change in osmo-hnbgw[master]: hnb_persistent: introduce disconnected timeout

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36894?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: hnb_persistent: introduce disconnected timeout ...................................................................... Patch Set 3: Code-Review-2 (1 comment) Patchset: PS3: let's delay this a bit until https://osmocom.org/issues/6484 is clarified -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36894?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic819d7cbc03fb39e98c204b70d016c5170dc6307 Gerrit-Change-Number: 36894 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Jun 2024 20:59:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in ...osmo-s1gw[master]: sctp_proxy: add a safe wrapper for s1ap_proxy:handle_pdu/1

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37122?usp=email ) Change subject: sctp_proxy: add a safe wrapper for s1ap_proxy:handle_pdu/1 ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/sctp_proxy.erl: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37122/comment/b1436aae_5930… PS2, Line 197: handle_pdu(Data) when is_binary(Data) -> isn't the when_is_binary() and the spec declaring the param to be binary() actually the same? I think "when_is_binary()" can be dropped. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37122?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ie6a7c9ff40789695e37be11344f5ea97fbcb8cfa Gerrit-Change-Number: 37122 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Jun 2024 20:54:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in ...osmo-s1gw[master]: sctp_proxy: add a safe wrapper for s1ap_proxy:handle_pdu/1

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37122?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: sctp_proxy: add a safe wrapper for s1ap_proxy:handle_pdu/1 ...................................................................... sctp_proxy: add a safe wrapper for s1ap_proxy:handle_pdu/1 We want to keep the SCTP connection alive even if we hit a bug in s1ap_proxy:handle_pdu/1. Otherwise, all the PDN contexts of all the subscribers served by the respective eNB will be killed. Change-Id: Ie6a7c9ff40789695e37be11344f5ea97fbcb8cfa --- M src/sctp_proxy.erl 1 file changed, 27 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/22/37122/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37122?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ie6a7c9ff40789695e37be11344f5ea97fbcb8cfa Gerrit-Change-Number: 37122 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year

1
0
0 0

[S] Change in ...osmo-s1gw[master]: sctp_proxy: add a safe wrapper for s1ap_proxy:handle_pdu/1

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37122?usp=email ) Change subject: sctp_proxy: add a safe wrapper for s1ap_proxy:handle_pdu/1 ...................................................................... Patch Set 1: (1 comment) File src/sctp_proxy.erl: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16569): https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37122/comment/f004c5d9_c801… PS1, Line 202: logger:error("An exception occured: ~p, ~p", [Exception, Reason]), 'occured' may be misspelled - perhaps 'occurred'? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37122?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ie6a7c9ff40789695e37be11344f5ea97fbcb8cfa Gerrit-Change-Number: 37122 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 06 Jun 2024 20:48:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in ...osmo-s1gw[master]: sctp_proxy: add a safe wrapper for s1ap_proxy:handle_pdu/1

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37122?usp=email ) Change subject: sctp_proxy: add a safe wrapper for s1ap_proxy:handle_pdu/1 ...................................................................... sctp_proxy: add a safe wrapper for s1ap_proxy:handle_pdu/1 We want to keep the SCTP connection alive even if we hit a bug in s1ap_proxy:handle_pdu/1. Otherwise, all the PDN contexts of all the subscribers served by the respective eNB will be killed. Change-Id: Ie6a7c9ff40789695e37be11344f5ea97fbcb8cfa --- M src/sctp_proxy.erl 1 file changed, 27 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/22/37122/1 diff --git a/src/sctp_proxy.erl b/src/sctp_proxy.erl index 9f9072b..39bc4d7 100644 --- a/src/sctp_proxy.erl +++ b/src/sctp_proxy.erl @@ -155,8 +155,7 @@ {[#sctp_sndrcvinfo{assoc_id = Aid}], Data}}, S) -> logger:debug("MME connection (id=~p, ~p:~p) -> eNB: ~p", [Aid, MmeAddr, MmePort, Data]), - sctp_server:send_data(maps:get(enb_aid, S), - s1ap_proxy:handle_pdu(Data)), + sctp_server:send_data(maps:get(enb_aid, S), handle_pdu(Data)), {keep_state, S}; %% Catch-all for other kinds of SCTP events @@ -193,10 +192,21 @@ %% private API %% ------------------------------------------------------------------ +%% A safe wrapper for s1ap_proxy:handle_pdu/1 +-spec handle_pdu(binary()) -> binary(). +handle_pdu(Data) when is_binary(Data) -> + try s1ap_proxy:handle_pdu(Data) of + NewData -> NewData + catch + Exception:Reason -> + logger:error("An exception occured: ~p, ~p", [Exception, Reason]), + Data %% proxy as-is + end. + + %% Send a single message to the MME sctp_send(#{sock := Sock, mme_aid := Aid}, Data) -> - sctp_client:send_data({Sock, Aid}, - s1ap_proxy:handle_pdu(Data)). + sctp_client:send_data({Sock, Aid}, handle_pdu(Data)). %% Send pending messages to the MME -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37122?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ie6a7c9ff40789695e37be11344f5ea97fbcb8cfa Gerrit-Change-Number: 37122 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: Validate Expires=600000 in REGISTER as per specs

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37121?usp=email ) Change subject: asterisk: IMS: Validate Expires=600000 in REGISTER as per specs ...................................................................... asterisk: IMS: Validate Expires=600000 in REGISTER as per specs Change-Id: Ibf2e3ff36d0c7cc84d25328ffdf87a6cedc8a37b --- M asterisk/IMS_ConnectionHandler.ttcn 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/37121/1 diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index f10e2aa..3793f7d 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -34,6 +34,7 @@ charstring mp_ipsec_setup_script_path := "./IMS_ipsec_setup.sh"; } +const integer c_def_expires := 600000; /* 3GPP TS 24.229 5.1.1.2.1 e) */ const char c_sip_server_name := "osmo-ttcn3-hacks/0.23"; @@ -476,6 +477,7 @@ tr_From(), tr_To(), tr_Via_from(?), + expires := tr_Expires(int2str(c_def_expires)), require := tr_Require(superset("sec-agree")), security_client := tr_Security_client(superset(tr_Security_mechanism("ipsec-3gpp", superset(tr_Param("alg","hmac-sha-1-96"))))), @@ -519,8 +521,6 @@ */ f_ims_validate_register_P_Access_Network_info(g_rx_sip_req, exp_present := false); - /* TODO: Validate "Expires" is 600000 */ - /* Tx 100 Tyring */ tx_resp := ts_SIP_Response_Trying(sip_call_id, from_addr, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37121?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibf2e3ff36d0c7cc84d25328ffdf87a6cedc8a37b Gerrit-Change-Number: 37121 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: Validate Via port matches the ipsec port-c one

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37117?usp=email ) Change subject: asterisk: IMS: Validate Via port matches the ipsec port-c one ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37117?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3f8b2112d40dd5f018abb8bc00b9e1be16586a9b Gerrit-Change-Number: 37117 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 06 Jun 2024 17:54:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2024