Attention is currently required from: laforge.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37011?usp=email )
Change subject: add contrib/saip-tool.py
......................................................................
Patch Set 3:
(2 comments)
File contrib/saip-tool.py:
https://gerrit.osmocom.org/c/pysim/+/37011/comment/431c9bba_bbf3fc4d
PS3, Line 37: subparsers = parser.add_subparsers(dest='command', help="The command to perform", required=True)
> subparsers. […]
ah nvm, there is already required=True
https://gerrit.osmocom.org/c/pysim/+/37011/comment/80e808b0_054e9070
PS3, Line 161: else:
: parser.print_help(sys.stderr)
: sys.exit(2)
this can be removed since opts.command is required
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37011?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I396bcd594e0628dfc26bd90233317a77e2f91b20
Gerrit-Change-Number: 37011
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 07 Jun 2024 10:26:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37010?usp=email )
Change subject: esim.saip: Add ProfileElementSequence.remove_naas_of_type
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File pySim/esim/saip/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/37010/comment/7826be67_db733953
PS3, Line 562: def remove_naas_of_type(self, naa: Naa) -> None:
maybe it would be useful if this function printed which instances of NAAs it removed?
https://gerrit.osmocom.org/c/pysim/+/37010/comment/d4e9f6cd_497a73b9
PS3, Line 573: if template in hdr.decoded['eUICC-Mandatory-GFSTEList']:
: hdr.decoded['eUICC-Mandatory-GFSTEList'] = [x for x in hdr.decoded['eUICC-Mandatory-GFSTEList'] if not template.prefix_match(x)]
just to be sure: it cannot be that `template.prefix_match() is True` for any element of `hdr.decoded['eUICC-Mandatory-GFSTEList']`, but at the same time `template not in hdr.decoded['eUICC-Mandatory-GFSTEList']`, right?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37010?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I64438bf0be58bad7a561c3744b7e9b1338a7857c
Gerrit-Change-Number: 37010
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 07 Jun 2024 10:17:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
