June 2024 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-abis[master]: TRAU->RTP: add support for TW-TS-001 & TW-TS-002

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37156?usp=email ) Change subject: TRAU->RTP: add support for TW-TS-001 & TW-TS-002 ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/trau/trau_rtp_conv.c: https://gerrit.osmocom.org/c/libosmo-abis/+/37156/comment/c084e919_8b00e111 PS3, Line 120: twts001_hdr = out++; this variable is only used in this scope, so it can be declared here. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7a6d13d406484c01210594bb6d2f0aff7c1341ab Gerrit-Change-Number: 37156 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 10 Jun 2024 18:29:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in libosmo-abis[master]: rtp2trau_hr16: set CRC bits correctly

by pespin

Attention is currently required from: dexter, falconia, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37180?usp=email ) Change subject: rtp2trau_hr16: set CRC bits correctly ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37180?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I5c8aa5891e3862f978f14093bff46bd00b6702a5 Gerrit-Change-Number: 37180 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Jun 2024 18:25:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: asterisk: IMS: Fix warning regarding deprecated type char

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37182?usp=email ) Change subject: asterisk: IMS: Fix warning regarding deprecated type char ...................................................................... asterisk: IMS: Fix warning regarding deprecated type char Change-Id: I4d283251684738e85973a2dfc57e4480a44cbc6b --- M asterisk/IMS_ConnectionHandler.ttcn 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/37182/1 diff --git a/asterisk/IMS_ConnectionHandler.ttcn b/asterisk/IMS_ConnectionHandler.ttcn index 3c3a51b..9f7d0f1 100644 --- a/asterisk/IMS_ConnectionHandler.ttcn +++ b/asterisk/IMS_ConnectionHandler.ttcn @@ -35,7 +35,7 @@ } const integer c_def_expires := 600000; /* 3GPP TS 24.229 5.1.1.2.1 e) */ -const char c_sip_server_name := "osmo-ttcn3-hacks/0.23"; +const charstring c_sip_server_name := "osmo-ttcn3-hacks/0.23"; type port IMSCoord_PT message -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37182?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4d283251684738e85973a2dfc57e4480a44cbc6b Gerrit-Change-Number: 37182 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year

1
0
0 0

[S] Change in libosmo-abis[master]: trau2rtp_hr16: check CRC bits in the TRAU frame

by falconia

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37181?usp=email ) Change subject: trau2rtp_hr16: check CRC bits in the TRAU frame ...................................................................... trau2rtp_hr16: check CRC bits in the TRAU frame If CRC bits in the received TRAU frame are bad, the implication is that this frame must have got corrupted in E1 transport. In this case all other bits cannot be trusted, and we should deliver BFI-no-data to RTP. Change-Id: I4f97b67884ff7540be631298e5252d28f765fce9 --- M src/trau/trau_rtp_conv.c 1 file changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/81/37181/1 diff --git a/src/trau/trau_rtp_conv.c b/src/trau/trau_rtp_conv.c index 8681ead..a1fea32 100644 --- a/src/trau/trau_rtp_conv.c +++ b/src/trau/trau_rtp_conv.c @@ -186,6 +186,7 @@ static int trau2rtp_hr16(uint8_t *out, size_t out_len, const struct osmo_trau_frame *tf, bool emit_twts002) { enum osmo_gsm631_sid_class sidc; + int rc; if (tf->type != OSMO_TRAU16_FT_HR) return -EINVAL; @@ -195,6 +196,12 @@ /* HR Data Bits according to TS 48.061 Section 5.1.4.1.1 */ + /* bad CRC means bad frame, no matter what else is going on */ + rc = osmo_crc8gen_check_bits(&gsm0860_efr_crc3, tf->d_bits, 44, + tf->crc_bits); + if (rc) + goto bad_frame; + sidc = (tf->c_bits[12] << 1) | tf->c_bits[13]; /* both C13 and C14 being set is invalid combination */ if (sidc > OSMO_GSM631_SID_CLASS_VALID) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37181?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I4f97b67884ff7540be631298e5252d28f765fce9 Gerrit-Change-Number: 37181 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

1 year

1
0
0 0

[M] Change in libosmo-abis[master]: TRAU->RTP: add support for TW-TS-001 & TW-TS-002

by falconia

Attention is currently required from: pespin. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37156?usp=email ) Change subject: TRAU->RTP: add support for TW-TS-001 & TW-TS-002 ...................................................................... Patch Set 3: (1 comment) File src/trau/trau_rtp_conv.c: https://gerrit.osmocom.org/c/libosmo-abis/+/37156/comment/2c4c183a_c8519785 PS2, Line 324: out--; > Point taken - will do in the next iteration. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7a6d13d406484c01210594bb6d2f0aff7c1341ab Gerrit-Change-Number: 37156 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Jun 2024 18:07:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year

1
0
0 0

[S] Change in docker-playground[master]: asterisk: extensions.conf: Route non-local extensions towards IMS side

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/37014?usp=email ) Change subject: asterisk: extensions.conf: Route non-local extensions towards IMS side ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'll merge this tomorrow or so if there's no more reviews coming. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/37014?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Icce5e55ab75c0c9fdacc4d8504e6714b99d385b4 Gerrit-Change-Number: 37014 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 10 Jun 2024 18:05:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year

1
0
0 0

[M] Change in libosmo-abis[master]: TRAU->RTP: add support for TW-TS-001 & TW-TS-002

by falconia

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/37156?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: TRAU->RTP: add support for TW-TS-001 & TW-TS-002 ...................................................................... TRAU->RTP: add support for TW-TS-001 & TW-TS-002 The industry standard RTP payload formats of RFC 3551 and RFC 5993 drop valuable metadata from TRAU-UL frames of GSM 08.60 & 08.61, and disallow transport of marked-bad frames. Enhanced RTP transport formats of TW-TS-001 (FR & EFR) and TW-TS-002 (HR) restore these capabilities - however, because these formats are non-standard outside of Osmocom+Themyscira GSM networks, their use can only be optional. Add rtp_extensions member to struct osmo_trau2rtp_state, specifying the mask of RTP extensions to be used, just like we defined for AoIP BSSMAP and Abis-IP RSL, and extend osmo_trau2rtp() to emit these enhanced RTP formats when they are enabled. Related: OS#6448 Depends: I0eccfe5ddcf44f8f20440acb01e2d4870ec0cd91 (libosmocore) Change-Id: I7a6d13d406484c01210594bb6d2f0aff7c1341ab --- M TODO-RELEASE M include/osmocom/trau/trau_rtp.h M src/trau/trau_rtp_conv.c 3 files changed, 135 insertions(+), 29 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/56/37156/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7a6d13d406484c01210594bb6d2f0aff7c1341ab Gerrit-Change-Number: 37156 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year

1
0
0 0

[S] Change in libosmo-abis[master]: rtp2trau_hr16: set CRC bits correctly

by falconia

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37180?usp=email ) Change subject: rtp2trau_hr16: set CRC bits correctly ...................................................................... rtp2trau_hr16: set CRC bits correctly The code previously failed to set the CRC bits in the TRAU frame output, containing a misleading comment that this operation is done by the TRAU frame encoding function (it isn't). Set these bits correctly in the rtp2trau step, like we do for EFR. Change-Id: I5c8aa5891e3862f978f14093bff46bd00b6702a5 --- M src/trau/trau_rtp_conv.c 1 file changed, 17 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/80/37180/1 diff --git a/src/trau/trau_rtp_conv.c b/src/trau/trau_rtp_conv.c index e4aa885..d7b19e2 100644 --- a/src/trau/trau_rtp_conv.c +++ b/src/trau/trau_rtp_conv.c @@ -47,7 +47,7 @@ /* - * EFR TRAU parity + * EFR TRAU parity (also used for HR) * * g(x) = x^3 + x^1 + 1 */ @@ -461,11 +461,12 @@ tf->ufi = 0; else tf->ufi = 1; - /* CRC is computed by TRAU frame encoder */ if (data_len) osmo_pbit2ubit(tf->d_bits, data, 112); else memset(tf->d_bits, 0, 112); + /* CRC is *not* computed by TRAU frame encoder - we have to do it */ + osmo_crc8gen_set_bits(&gsm0860_efr_crc3, tf->d_bits, 44, tf->crc_bits); return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37180?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I5c8aa5891e3862f978f14093bff46bd00b6702a5 Gerrit-Change-Number: 37180 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-MessageType: newchange

1 year

1
0
0 0

[M] Change in libosmo-abis[master]: TRAU->RTP: add support for TW-TS-001 & TW-TS-002

by falconia

Attention is currently required from: pespin. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37156?usp=email ) Change subject: TRAU->RTP: add support for TW-TS-001 & TW-TS-002 ...................................................................... Patch Set 2: (1 comment) File src/trau/trau_rtp_conv.c: https://gerrit.osmocom.org/c/libosmo-abis/+/37156/comment/66ef46b6_151a18cc PS2, Line 324: out--; > I'm not really liking this, it's calling for wrong access at some point in the future. […] Point taken - will do in the next iteration. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7a6d13d406484c01210594bb6d2f0aff7c1341ab Gerrit-Change-Number: 37156 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Jun 2024 17:57:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year

1
0
0 0

[M] Change in libosmo-abis[master]: TRAU->RTP: add support for TW-TS-001 & TW-TS-002

by pespin

Attention is currently required from: falconia. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37156?usp=email ) Change subject: TRAU->RTP: add support for TW-TS-001 & TW-TS-002 ...................................................................... Patch Set 2: (1 comment) File src/trau/trau_rtp_conv.c: https://gerrit.osmocom.org/c/libosmo-abis/+/37156/comment/d9eb586b_f22f6e29 PS2, Line 324: out--; I'm not really liking this, it's calling for wrong access at some point in the future. I'd say let's keep the original start of the buffer in a variable and use it here. because iiuc that's what you want to do here right? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/37156?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I7a6d13d406484c01210594bb6d2f0aff7c1341ab Gerrit-Change-Number: 37156 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Mon, 10 Jun 2024 17:40:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2024